Re: [Python-Dev] hg.python.org Mercurial upgrade

2013-01-24 Thread Antoine Pitrou
Le Wed, 23 Jan 2013 17:37:53 -0500,
David Bolen  a écrit :
> Antoine Pitrou  writes:
> 
> > I've upgraded the Mercurial version on hg.python.org. If there any
> > problems, don't hesitate to post here.
> > (apart from the connectivity problems we seem to have from time to
> > time and which shouldn't be related)
> 
> I'm not sure if this is related to the upgrade specifically (or just
> some other hg issue0, but yesterday my Windows 7 buildbot failed an hg
> pull operation on the 3.x branch and automatically removed it's local
> repository.  Ever since then an attempt to start fresh (with an hg
> clone) is dying during the clone operation.
> 
> I'm running the clone operation manually now, and after sitting there
> for 10 minutes or so at the "adding changesets" stage, it died just
> like in the buildbot logs ("transaction abort!" followed by "rollback
> completed").  Nothing was happening on the buildbot during the adding
> changesets delay so I'm assuming that was all server-side.

Given the delay (10 minutes), I'm assuming this has more to do with the
connectivity problem Noah is trying to investigate:
http://mail.python.org/pipermail/catalog-sig/2013-January/004736.html

Regards

Antoine.


___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] Implementation of the PEP 433

2013-01-24 Thread Victor Stinner
Hi,

I implemented the PEP 433 in the following repository:
http://hg.python.org/features/pep-433

You can use it if you would like to experiment/test the PEP 433.

PEP 433: "Easier suppression of file descriptor inheritance"
http://www.python.org/dev/peps/pep-0433/

I added a PYTHONCLOEXEC environment variable, an "-e" option and
sys.setdefaultcloexec() function. At startup, the default value of
cloexec parameter is False.

I tested my implementation on Linux, Windows, Mac OS X, FreeBSD,
OpenBSD and OpenIndiana.

Victor
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com


[Python-Dev] PEP 433: Choose the default value of the new cloexec parameter

2013-01-24 Thread Victor Stinner
Hi,

The PEP 433 proposes different options to add a new cloexec parameter:

 a) cloexec=False by default
 b) cloexec=True by default
 c) configurable default value

I tried to list in the PEP 433 advantages and drawbacks of each option.

If I recorded correctly opinions, the different options have the
following supporters:

 a) cloexec=False by default
 b) cloexec=True by default: Charles-François Natali
 c) configurable default value: Antoine Pitrou, Nick Coghlan, Guido van Rossum

I don't know if it's enough to say that (c) is the chosen option.

--

For the name of the new parameter, I still prefer "cloexec" for the
reason given by Antoine: on UNIX, the flag has only an effect on
exec(), not on fork(). So inherited=False can be misleading on UNIX.

I updated the rationale of the PEP to describe the close-on-exec flag:
http://www.python.org/dev/peps/pep-0433/#rationale

--

FYI on Windows, cloexec=False (inherited=True) doesn't mean that the
file descriptor will be inherited. It also depends on the
bInheritHandles parameter of the CreateProcess() function. Extract of
the PEP:

"On Windows, the file descriptor is not inherited if the close-on-exec
flag is set, the file descriptor is inherited by child processes if
the flag is cleared and if CreateProcess() is called with the
bInheritHandles parameter set to TRUE (when subprocess.Popen is
created with close_fds=False for example)."

Victor
___
Python-Dev mailing list
Python-Dev@python.org
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe: 
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com