[Python-Dev] fileinput module tests
Hi all, I have a patch for the fileinput.FileInput class, adding a parameter to the __init__ method called write_mode in order to specify the write mode when using the class with the inplace parameter set to True. Before I submit the patch, I've added a test to the test module, and noticed that the module is pretty messy, with half of the tests being run in the module body, and the rest in a large function body. I propose to refactor the module, moving the tests into a unittest.TestCase subclass (essentially unchanged, bar changing verify calls to self.assert_ calls, raise TestFailed(...) to self.fail(...) etc). I think this will add clarity and modularity to the tests, and bring them into line with the unittest based test suite used by the test_file module amongst others (which I'm guessing are substantially more up to date than test_fileinput). Any thought? Cheers, -- Ant... ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Windows SDK
Hello all (A quick google of the python-dev archive didn't turn up any discussions on this topic. If this has already been discussed, please accept my humble apologies.) As part of the Windows Vista release, Microsoft have created the "Windows SDK" that looks like Platform SDK on steroids. It includes 32-bit and 64-bit libraries and compilers, debugging tools, etc. and supports Windows XP, Windows Server 2003 and Windows Vista. Check the Microsoft Windows SDK Blog for more info: http://blogs.msdn.com/windowssdk/ Go here for links to ISO and web install: http://blogs.msdn.com/windowssdk/archive/2006/11/08/windows-sdk-for-windows-vista-is-live.aspx I'm only guessing here, but I think the Windows SDK is probably going to become the de facto standard for building software on Windows in the absence of Visual Studio. Has anybody else looked at the Windows SDK yet? Any thoughts on what needs to be done with distutils so that the Windows SDK can be supported in Python 2.6? Cheers, Albert Strasheim ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] fileinput module tests
On 12/8/06, Anthony Roy <[EMAIL PROTECTED]> wrote: Hi all, I have a patch for the fileinput.FileInput class, adding a parameter to the __init__ method called write_mode in order to specify the write mode when using the class with the inplace parameter set to True. Before I submit the patch, I've added a test to the test module, and noticed that the module is pretty messy, with half of the tests being run in the module body, and the rest in a large function body. I propose to refactor the module, moving the tests into a unittest.TestCase subclass (essentially unchanged, bar changing verify calls to self.assert_ calls, raise TestFailed(...) to self.fail(...) etc). I think this will add clarity and modularity to the tests, and bring them into line with the unittest based test suite used by the test_file module amongst others (which I'm guessing are substantially more up to date than test_fileinput). Any thought? Please do! It's always nice to have once less test not using unittest or doctest. -Brett ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Windows SDK
"Albert Strasheim" <[EMAIL PROTECTED]> wrote: > As part of the Windows Vista release, Microsoft have created the "Windows > SDK" that looks like Platform SDK on steroids. It includes 32-bit and 64-bit > libraries and compilers, debugging tools, etc. and supports Windows XP, > Windows Server 2003 and Windows Vista. Possibly not being able to run the compiler on Windows 2000 (or ME/98/95) in a "supported" mode may be a deal killer for people to not switch (and stick with the Platform SDK or Visual Studio 2003). I also wonder if the results of the compilations are usable on Windows 2000 (or ME/98/95). > I'm only guessing here, but I think the Windows SDK is probably going to > become the de facto standard for building software on Windows in the absence > of Visual Studio. Has anybody else looked at the Windows SDK yet? Any > thoughts on what needs to be done with distutils so that the Windows SDK can > be supported in Python 2.6? Someone will have to add/update a visual studio project file equivalent in the PCBuild directory. I think it would be nice if the person who updates the PCBuild stuff also tried to find someone with other Windows platforms (64 bit, win2k, possibly the 95/98/ME family). - Josiah ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Windows SDK
Albert Strasheim schrieb: > I'm only guessing here, but I think the Windows SDK is probably going to > become the de facto standard for building software on Windows in the absence > of Visual Studio. Has anybody else looked at the Windows SDK yet? Any > thoughts on what needs to be done with distutils so that the Windows SDK can > be supported in Python 2.6? As always, the question is what msvcrt version the compiler links with. For Itanium and AMD64, the SDK (compiler) links with mscvrt.dll, which is the CRT version distributed with the system. Python 2.5 is already build with the SDK compiler on these targets, so you can use the SDK to build extensions. To use the SDK compiler, open an SDK build environment, and set the environment variable DISTUTILS_USE_SDK. For x86, the situation is more difficult. I'm uncertain what CRT the x86 SDK compiler links with. Mixing CRTs may or may not work, depending on what precisely the extension module does. For 2.6, I hope we will switch to VS 2007 (assuming that's released at that point). Then, the question is whether the Windows SDK will support VS 2007. Regards, Martin ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] fileinput module tests
Anthony Roy schrieb: > Any thought? In addition to what Brett said: please make functionality changes and refactoring separate patches (specify the order of application if one depends on the other). When reading commit message, or performing "svn blame", it's important to know whether a change is just a structural one, or a substantial one. Regards, Martin ___ Python-Dev mailing list Python-Dev@python.org http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
