[Python-Dev] Re: [Python-checkins] python/dist/src/Python marshal.c, 1.79, 1.80
Hi!
A single-character diff...
On Mon, Dec 20, 2004 at 04:25:59AM -0800, [EMAIL PROTECTED] wrote:
> --- marshal.c 27 Jun 2004 16:51:46 - 1.79
> +++ marshal.c 20 Dec 2004 12:25:57 - 1.80
> @@ -893,7 +893,7 @@
> {
> PyObject *x;
> int version = Py_MARSHAL_VERSION;
> - if (!PyArg_ParseTuple(args, "O|i:dumps", &x, version))
> + if (!PyArg_ParseTuple(args, "O|i:dumps", &x, &version))
> return NULL;
> return PyMarshal_WriteObjectToString(x, version);
> }
Crash. Which means that there is no way in 2.4.0 to marshal an object in the
old version format as a string -- you'd have to work around by writing a real
file and reading it back :-(
Armin
___
Python-Dev mailing list
[EMAIL PROTECTED]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Python marshal.c, 1.79, 1.80
On Mon, Dec 20, 2004, Armin Rigo wrote:
>
> Hi!
>
> A single-character diff...
>
> On Mon, Dec 20, 2004 at 04:25:59AM -0800, [EMAIL PROTECTED] wrote:
>> --- marshal.c27 Jun 2004 16:51:46 - 1.79
>> +++ marshal.c20 Dec 2004 12:25:57 - 1.80
>> @@ -893,7 +893,7 @@
>> {
>> PyObject *x;
>> int version = Py_MARSHAL_VERSION;
>> -if (!PyArg_ParseTuple(args, "O|i:dumps", &x, version))
>> +if (!PyArg_ParseTuple(args, "O|i:dumps", &x, &version))
>> return NULL;
>> return PyMarshal_WriteObjectToString(x, version);
>> }
>
> Crash. Which means that there is no way in 2.4.0 to marshal an object in the
> old version format as a string -- you'd have to work around by writing a real
> file and reading it back :-(
Brown bag time?
--
Aahz ([EMAIL PROTECTED]) <*> http://www.pythoncraft.com/
"19. A language that doesn't affect the way you think about programming,
is not worth knowing." --Alan Perlis
___
Python-Dev mailing list
[EMAIL PROTECTED]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
[Armin] > Crash. Which means that there is no way in 2.4.0 to marshal an object in the > > old version format as a string -- you'd have to work around by writing a real > > file and reading it back :-( [Aahz] > Brown bag time? Perhaps a rather quick Py2.4.1 would be in order. Ideally, it should include other important fixes: * Tim's critical thread bug http://www.python.org/sf/1069160 * Compile of _socket fails on 2.4 (SGI Orion only) http://www.python.org/sf/1086642 (waiting for a developer who has this set-up) * sys.stdin segfaults on invalid stdin http://www.python.org/sf/1084766 (Jeff Epler has already isolated the problem) * truncated gzip file triggers zlibmodule segfault http://www.python.org/sf/1083110 (assigned to Andrew) * various installer issues (all currently assigned to Martin) * bad arg type to isspace in struct module http://www.python.org/sf/1072182 (assigned to me) * fix bug in StringIO.truncate - length not changed http://www.python.org/sf/951915 (assigned to me) * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Raymond ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > Perhaps a rather quick Py2.4.1 would be in order. +1 -Barry signature.asc Description: This is a digitally signed message part ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Re: Re: [Python-checkins]python/dist/src/Pythonmarshal.c, 1.79, 1.80
Raymond Hettinger wrote: > Perhaps a rather quick Py2.4.1 would be in order. sounds like a good idea. +1 from here. ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: > On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > > > Perhaps a rather quick Py2.4.1 would be in order. > > +1 Nothing wrong with an incremental release, but none of these sound like critical bugs to me. Jeremy ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
[Python-Dev] Latex problem when trying to build documentation
I wanted to create a doc patch belonging to my patch #1062060,
but got this error when trying to build the documentation from CVS:
(/opt/PythonBugDay/python/dist/src/Doc/commontex/reportingbugs.tex
Underfull \hbox (badness 1) in paragraph at lines 13--17
[]\OT1/ptm/m/n/10 All bug re-ports should be sub-mit-ted via the Python Bug Tra
cker on Source-Forge
) [783] [784]
Appendix C.
(/opt/PythonBugDay/python/dist/src/Doc/commontex/license.tex [785] [786]
[787]
Underfull \hbox (badness 1) in paragraph at lines 294--297
\OT1/ptm/m/n/10 The []\OT1/pcr/m/n/10 random \OT1/ptm/m/n/10 mod-ule in-cludes
code based on a down-load from
Overfull \hbox (4.8973pt too wide) in paragraph at lines 339--339
[]\OT1/pcr/m/n/9 A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE CO
PYRIGHT OWNER OR[]
[788]
Overfull \hbox (4.8973pt too wide) in paragraph at lines 376--376
[]\OT1/pcr/m/n/9 FOR GAI_ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
OR CONSEQUENTIAL[]
Overfull \hbox (4.8973pt too wide) in paragraph at lines 376--376
[]\OT1/pcr/m/n/9 HOWEVER CAUSED AND ON GAI_ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT[]
[789] [790] [791] [792] [793] [794])
Underfull \hbox (badness 1) in paragraph at lines 616--363
(./modlib.ind [795] [796] [797]) (./lib.ind [798] [799])
Package longtable Warning: Table widths have changed. Rerun LaTeX.
! LaTeX Error: \begin{description} on input line 59 ended by \end{document}.
See the LaTeX manual or LaTeX Companion for explanation.
Type H for immediate help.
...
l.380 \end{document}
?
! Emergency stop.
...
l.380 \end{document}
Output written on lib.dvi (805 pages, 2885748 bytes).
Transcript written on lib.log.
*** Session transcript and error messages are in
/opt/PythonBugDay/python/dist/src/Doc/html/lib/lib.how.
*** Exited with status 1.
make: *** [html/lib/lib.html] Error 1
I dont really understand that latex stuff (used to, but that
was a long time ago). What's the problem?
I'm running this on Mandrake Linux 10.0 with Tetex 2.0.2.
Regards,
Irmen de Jong.
___
Python-Dev mailing list
[EMAIL PROTECTED]
http://mail.python.org/mailman/listinfo/python-dev
Unsubscribe:
http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
Raymond Hettinger wrote: Perhaps a rather quick Py2.4.1 would be in order. Ideally, it should include other important fixes: [...] * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Is http://www.python.org/sf/1062060 perhaps of similar importance? (fix for urllib.urlretrieve silently truncating download) --Irmen ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
RE: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
> Raymond Hettinger wrote: > > Perhaps a rather quick Py2.4.1 would be in order. > > > > Ideally, it should include other important fixes: > [...] > > * Fix for off-by-one bug in urllib.URLopener.retrieve > >http://www.python.org/sf/810023 > >(assigned to me) > > Is http://www.python.org/sf/1062060 perhaps of similar importance? > (fix for urllib.urlretrieve silently truncating download) That seems reasonable to me. There is no point in having the error pass silently. Raymond ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
Raymond Hettinger wrote: * Fix for off-by-one bug in urllib.URLopener.retrieve http://www.python.org/sf/810023 (assigned to me) Is http://www.python.org/sf/1062060 perhaps of similar importance? (fix for urllib.urlretrieve silently truncating download) That seems reasonable to me. There is no point in having the error pass silently. Well, I wanted to make the patches that Johannes suggested, but ran into trouble when building the Python docs from CVS source (see my other message about this). Also, I'm not sure how a test-case should be constructed for this patch? Can the Python regression test download stuff as part of a test? Or is there some other way to make a testcase for this. --Irmen ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re:[Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
Irmen de Jong wrote: Also, I'm not sure how a test-case should be constructed for this patch? Can the Python regression test download stuff as part of a test? Or is there some other way to make a testcase for this. Hmm - perhaps start a server on the local machine at the start of the test, and tear it down at the end? you've then got full control of that server and can make it do whatever you want. Or replace the socket objects with mock objects? Tim Delaney ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
On Mon, Dec 20, 2004, Jeremy Hylton wrote: > On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: >> On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: >>> >>> Perhaps a rather quick Py2.4.1 would be in order. >> >> +1 > > Nothing wrong with an incremental release, but none of these sound > like critical bugs to me. You don't think a blowup in marshal is critical? Mind expanding on that? -- Aahz ([EMAIL PROTECTED]) <*> http://www.pythoncraft.com/ "19. A language that doesn't affect the way you think about programming, is not worth knowing." --Alan Perlis ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
On Mon, 20 Dec 2004 18:25:39 -0500, Aahz <[EMAIL PROTECTED]> wrote: > On Mon, Dec 20, 2004, Jeremy Hylton wrote: > > On Mon, 20 Dec 2004 15:03:13 -0500, Barry Warsaw <[EMAIL PROTECTED]> wrote: > >> On Mon, 2004-12-20 at 12:48, Raymond Hettinger wrote: > >>> > >>> Perhaps a rather quick Py2.4.1 would be in order. > >> > >> +1 > > > > Nothing wrong with an incremental release, but none of these sound > > like critical bugs to me. > > You don't think a blowup in marshal is critical? Mind expanding on > that? An undocumented extension to marshal causes a segfault. It's certainly a bug worth fixing. It doesn't sound like a critical bug to me. Jeremy ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
Re: [Python-Dev] Re: [Python-checkins] python/dist/src/Pythonmarshal.c, 1.79, 1.80
[Jeremy Hylton on a quick 2.4.1] >>> Nothing wrong with an incremental release, but none of these sound >>> like critical bugs to me. [Aahz] >> You don't think a blowup in marshal is critical? Mind expanding on >> that? [Jeremy] > An undocumented extension to marshal causes a segfault. It's > certainly a bug worth fixing. It doesn't sound like a critical bug to > me. The new optional ``version`` argument to marshal.dumps() is documented. The easiest way to see that is to look at 2.4's marshal.dumps() docs . Unfortunately, it was wholly untested. Still, it's a new-in-2.4 gimmick, and no pre-2.4 code could be using it. I suppose Armin found a use for it in 2.4, but I'm still scratching my head. If ZODB doesn't already depend on it, how useful can it be? QED WRT "my" critical thread bug, I asked that everyone pretend I hadn't submitted it until a month after 2.4 was released. That hasn't happened yet, so I refuse to admit it exists. FWIW, I'd press on with 2.3.5 first, while it can still attract some volunteer effort. ___ Python-Dev mailing list [EMAIL PROTECTED] http://mail.python.org/mailman/listinfo/python-dev Unsubscribe: http://mail.python.org/mailman/options/python-dev/archive%40mail-archive.com
