[python-committers] [RELEASE] Python 3.7.0rc1 and 3.6.6rc1 are now available

2018-06-13 Thread Ned Deily 
Python 3.7.0rc1 and 3.6.6rc1 are now available. 3.7.0rc1 is the final
planned release preview of Python 3.7, the next feature release of
Python. 3.6.6rc1 is the the release preview of the next maintenance
release of Python 3.6, the current release of Python. Assuming no
critical problems are found prior to *2018-06-27*, the scheduled
release dates for 3.7.0 and 3.6.6, no code changes are planned
between these release candidates and the final releases. These
release candidates are intended to give you the opportunity to test
the new features and bug fixes in 3.7.0 and 3.6.6 and to prepare your
projects to support them. We strongly encourage you to test your
projects and report issues found to bugs.python.org as soon as
possible. Please keep in mind that these are preview releases and,
thus, their use is not recommended for production environments.
Attention macOS users: there is now a new installer variant for macOS
10.9+ that includes a built-in version of Tcl/Tk 8.6. This variant
will become the default version when 3.7.0 releases. Check it out!

You can find these releases and more information here:
https://www.python.org/downloads/release/python-370rc1/
https://www.python.org/downloads/release/python-366rc1/

--
  Ned Deily
  [email protected] -- []

___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

[python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Victor Stinner 
Hi,

I propose to promote Pablo Salingo Salgado as a core developer and so
open a vote during one week. If there is no strong opposition, I will
promote him but also continue to mentor him for a least one month.

Pablo is contributing frequently to Python since almost one year. He
added os.preadv()/pwritev() to Python 3.7 and os.posix_spawn() to
Python 3.8. I am now waiting for his os.copy_file_range() function!
(Others are working on it.)
https://bugs.python.org/issue26826

I am mentoring Pablo Salingo Salgado since January. I am watching his
hard work since last September. He made many non trivial and useful
contributions to Python.

I think that he understands well how Python is developed, is
respectful, try to find answers alone before asking, and is eager to
learn. In case of doubt, he ask others before doing something, like
closing an issue. I trust that Pablo will respect opinions of others,
like not merging a PR if someone disagree.

Pablo's merged PR:
https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Aclosed+is%3Apr+author%3Apablogsal+

He got 22 commits merged into master between September 2017 and June 2018.

If Pablo is promoted as a core developer, I propose to continue to be
his mentor for at least one month, and ask him before merging any PR.

Note: Pablo already has the bug triage permission for 5 months:
https://mail.python.org/pipermail/python-committers/2018-January/005133.html

Victor
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Terry Reedy 

On 6/13/2018 12:16 PM, Victor Stinner wrote:

Hi,

I propose to promote Pablo Salingo Salgado as a core developer and so
open a vote during one week. If there is no strong opposition, I will
promote him but also continue to mentor him for a least one month.

Pablo is contributing frequently to Python since almost one year. He
added os.preadv()/pwritev() to Python 3.7 and os.posix_spawn() to
Python 3.8. I am now waiting for his os.copy_file_range() function!
(Others are working on it.)
https://bugs.python.org/issue26826

I am mentoring Pablo Salingo Salgado since January. I am watching his
hard work since last September. He made many non trivial and useful
contributions to Python.

I think that he understands well how Python is developed, is
respectful, try to find answers alone before asking, and is eager to
learn. In case of doubt, he ask others before doing something, like
closing an issue. I trust that Pablo will respect opinions of others,
like not merging a PR if someone disagree.

Pablo's merged PR:
https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Aclosed+is%3Apr+author%3Apablogsal+


This includes closed without merging.


He got 22 commits merged into master between September 2017 and June 2018.


https://github.com/python/cpython/pulls?page=2&q=is%3Amerged+is%3Apr+author%3Apablogsal&utf8=%E2%9C%93

shows 27 merged, 1 a backport.  Merges were by several different people.
+1


If Pablo is promoted as a core developer, I propose to continue to be
his mentor for at least one month, and ask him before merging any PR
Note: Pablo already has the bug triage permission for 5 months:
https://mail.python.org/pipermail/python-committers/2018-January/005133.html


___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Serhiy Storchaka 

13.06.18 19:43, Terry Reedy пише:

On 6/13/2018 12:16 PM, Victor Stinner wrote:

I propose to promote Pablo Salingo Salgado as a core developer and so
open a vote during one week. If there is no strong opposition, I will
promote him but also continue to mentor him for a least one month.

Pablo is contributing frequently to Python since almost one year. He
added os.preadv()/pwritev() to Python 3.7 and os.posix_spawn() to
Python 3.8. I am now waiting for his os.copy_file_range() function! x
(Others are working on it.)
https://bugs.python.org/issue26826

I am mentoring Pablo Salingo Salgado since January. I am watching his
hard work since last September. He made many non trivial and useful
contributions to Python.

I think that he understands well how Python is developed, is
respectful, try to find answers alone before asking, and is eager to
learn. In case of doubt, he ask others before doing something, like
closing an issue. I trust that Pablo will respect opinions of others,
like not merging a PR if someone disagree.

Pablo's merged PR:
https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Aclosed+is%3Apr+author%3Apablogsal+ 



This includes closed without merging.


And reverted PRs. Adding ensure_disabled() (bpo-31356) was reverted 
because the implementation caused crash and core developers have doubts 
about usefulness of this feature at all. Adding posix_spawn() 
(bpo-20104) was reverted in 3.7 because it was incomplete and had many 
bugs. It was left in 3.8, and the work of completing and fixing it in 
process. PR 4003 has long review history, the final merged version is 
very different from the initial one. Many of other PRs are documentation 
fixes.


I think Pablo will be good core developer and agree with the description 
given by Victor. But it seems that he still needs to learn something 
about what changes are good for Python.


___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Victor Stinner 
2018-06-13 18:43 GMT+02:00 Terry Reedy :
>> Pablo's merged PR:
>>
>> https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Aclosed+is%3Apr+author%3Apablogsal+
>
> This includes closed without merging.
>
>> He got 22 commits merged into master between September 2017 and June 2018.
>
> https://github.com/python/cpython/pulls?page=2&q=is%3Amerged+is%3Apr+author%3Apablogsal&utf8=%E2%9C%93
>
> shows 27 merged, 1 a backport.  Merges were by several different people.
> +1

I computed the number of patches merged into master using:

$ git log master [email protected]|grep ^commit -c
22

Oh sorry, I posted the wrong link. I wanted to post this link:
https://github.com/python/cpython/commits?author=pablogsal

I counted manually and I see again 22 changes.

Victor
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Victor Stinner 
2018-06-13 21:38 GMT+02:00 Serhiy Storchaka :
>> Pablo's merged PR:
>> https://github.com/python/cpython/pulls?utf8=%E2%9C%93&q=is%3Aclosed+is%3Apr+author%3Apablogsal+
>
> This includes closed without merging.

(sorry again, bad link.)


> And reverted PRs. Adding ensure_disabled() (bpo-31356) was reverted because
> the implementation caused crash and core developers have doubts about
> usefulness of this feature at all.

Hum, let me see:
https://bugs.python.org/issue31356#msg301407

The feature has been proposed by Raymond Hettinger and approved ("+1")
by Nick Coghlan. Pablo's PR has been merged by Raymond.

It's not like Pablo proposed the idea himself and force to get this
feature merged. Pablo just implemented an idea proposed by two other
core developers.

It happens that core developers disagree each others ;-) The feature
has been quickly removed, it's not a big deal.


> Adding posix_spawn() (bpo-20104) was
> reverted in 3.7 because it was incomplete and had many bugs. It was left in
> 3.8, and the work of completing and fixing it in process.

(a) Two days after Pablo proposed his PR, he wrote an email to
python-dev to get the widest audience to design posix_spawn() API:
https://mail.python.org/pipermail/python-dev/2018-January/151661.html

Gregory P. Smith merged Pablo's PR, after one month of review.

IMHO Pablo did the best to get the correct API and a good implementation.


(b) After the PR has been approved and merged, Serhiy noticed that the
Python function doesn't expose one posix_spawn() feature.

During Pycon US, we discussed what do to with posix_spawn() before the
Python 3.7 release: urge to push a change, or revert. I proposed to
Pablo to remove the feature from 3.7, get more time to stabilize the
API and the implementation in master. He was fine with that.

He could complain and ask to keep the feature (to get it released as
soon as possible), but he didn't.

I don't see anything wrong here. It's not uncommon that a newly merged
feature is still discussed, and I don't see anything wrong with
Pablo's behaviour here. I don't see how we could prevent such further
discussions on posix_spawn(). At least, I don't see how Pablo could
prevent these issues.


> PR 4003 has long  review history, the final merged version is very different 
> from the initial
> one.

"bpo-31786: Make select.poll.poll block if ms < 0 for every value of ms"
https://github.com/python/cpython/pull/4003

Oh, I recall that one, I recall that *I* was super pedantic :-)

You (Serhiy) asked to fix select.poll.poll() for negative timeout.
This is exactly what Pablo did. His PR was fine on that aspect.

Then I started to complain and ask to use my private _PyTime API. I
also asked to implement a new rounding mode for _PyTime: a complex
task, because it requires to modify a lot of files, write new tests,
etc. This C code is not well documented.

Then I asked to not only modify select.poll, but many other functions.

The final PR is very different because I requested to modify much more
files and fix many more functions.

At the end, I really like the final commit:
https://github.com/python/cpython/commit/2c15b29aea5d6b9c61aa42d2c24a07ff1edb4b46

It adds a new rounding mode (_PyTime_ROUND_UP), write a non-trivial
function test for negative timeout, has a good NEWS entry, etc.

Pablo showed that he is able to implement large change and fix all
cases, not a single case. IMHO it's a good example, rather than a bad
example :-)


> Many of other PRs are documentation fixes.

Is it an issue?


> I think Pablo will be good core developer and agree with the description
> given by Victor. But it seems that he still needs to learn something about
> what changes are good for Python.

Ok, I account your -1 vote.


But I disagree you with :-) Pablo worked on complex changes, so I'm
not surprised that his changes required a lot of discussion, and that
there are some hiccups like posix_spawn() issues. By the way,
posix_spawn() is one of the most complex C function that I know...
Compare its API to dup() API: well, dup() is simpler :-) But
posix_spawn() seems efficient and very useful.

Again, I don't see anything wrong with Pablo's behaviour or the
quality of his work. I understand that you want more reviewers on
posixmodule.c changes, and there is where I expect that Pablo will
help :-) In private, I told Pablo that I consider that the main
difference between a core developer and a contributor is that core
developers are expected to spend more time on reviews and mentoring.

Pablo proved its steady involvment in Python for almost one year with
multiple significant contributions (new os functions). IMHO you are
pushing the bar too high.

Victor
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Berker Peksağ 
On Wed, Jun 13, 2018 at 10:38 PM, Serhiy Storchaka  wrote:
> I think Pablo will be good core developer and agree with the description
> given by Victor. But it seems that he still needs to learn something about
> what changes are good for Python.

I agree with Serhiy. Count me -1 for now.

I don't care about total number of commits to be honest. It's not so
hard to get 50 PRs merged into master in a month or so. Writing high
quality code is not the only requirement to become a core developer.
IMO, being active on bugs.p.o [1] and reviewing pull requests on
GitHub [2] are more important than writing code or documentation.

--Berker

[1] According to bpo, Pablo has been active in 38 issues:
https://bugs.python.org/issue?%40search_text=&ignore=file%3Acontent&title=&%40columns=title&id=&%40columns=id&stage=&creation=&creator=&activity=&%40columns=activity&%40sort=activity&actor=&nosy=pablogsal&type=&components=&versions=&dependencies=&assignee=&keywords=&priority=&status=&%40columns=status&resolution=&nosy_count=&message_count=&%40group=&%40pagesize=50&%40startwith=0&%40sortdir=on&%40queryname=&%40old-queryname=&%40action=search

[2] Looking at Pablo's GitHub profile (from October 2017 to June 2018)
most of Pablo's review comments seems to be made in their own PRs.
I've found two non-core developer PRs reviewed by Pablo:
https://github.com/python/cpython/pull/6984 and
https://github.com/python/cpython/pull/6481
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Carol Willing 
+1 With Victor's mentoring (1 or 2 months), I believe that it is reasonable to 
promote Pablo to a core developer either now or after 3 months of coaching.

I would also like to see Cheryl Sabella who has been very active on the bug 
tracker to also be promoted to a core developer as well as Emily Morehouse who 
has been at the Language Summit for several years.

I'm happy to trust Victor's perspective as well as Pablo being respectful of 
the merge process.

FWIW, I also believe that triaging issues, writing documentation, and 
contributing code are all valuable to the success of CPython. Without issue 
triage and quality documentation being valued, the users and contributors 
suffer a lack of information and efficiency as well as demotivating potential 
developers.


> On Jun 13, 2018, at 1:46 PM, Victor Stinner  > wrote:
> 
> Pablo proved its steady involvment in Python for almost one year with
> multiple significant contributions (new os functions). IMHO you are
> pushing the bar too high.

> I think Pablo will be good core developer and agree with the description 
> given by Victor.But it seems that he still needs to learn something about 
> what changes are good for Python___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Terry Reedy 

On 6/13/2018 7:03 PM, Carol Willing wrote:
+1 With Victor's mentoring (1 or 2 months), I believe that it is 
reasonable to promote Pablo to a core developer either now or after 3 
months of coaching.


I would also like to see Cheryl Sabella who has been very active on the 
bug tracker to also be promoted to a core developer.


A bit off topic, but I would too, as she has been extremely helpful with 
IDLE.  We have discussed it privately and I offered to sponsor her here 
whenever she wants me to.  At the moment, she is happy doing what she 
does with the time she has.


Terry Jan Reedy

___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] Vote to promote Pablo Salingo Salgado as core developer

2018-06-13 Thread Carol Willing 



> On Jun 13, 2018, at 7:30 PM, Terry Reedy  wrote:
> 
> On 6/13/2018 7:03 PM, Carol Willing wrote:
>> +1 With Victor's mentoring (1 or 2 months), I believe that it is reasonable 
>> to promote Pablo to a core developer either now or after 3 months of 
>> coaching.
>> I would also like to see Cheryl Sabella who has been very active on the bug 
>> tracker to also be promoted to a core developer.
> 
> A bit off topic, but I would too, as she has been extremely helpful with 
> IDLE.  We have discussed it privately and I offered to sponsor her here 
> whenever she wants me to.  At the moment, she is happy doing what she does 
> with the time she has.
> 
> Terry Jan Reedy
> 

Thanks Terry for discussing with her and mentoring her on IDLE :-)


> ___
> python-committers mailing list
> [email protected]
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/

___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/