Re: [python-committers] Visual Studio Team Services checks on pullrequests
On Thu, 17 May 2018 at 01:47 Benjamin Peterson wrote: > > > On Wed, May 16, 2018, at 15:27, Steve Dower wrote: > > Thanks Microsoft for the 20 concurrent builds on Windows, macOS and > Linux :) > > That is quite generous! Will it be ongoing? > Yes, this is not just for the sprints. This is a continual contribution so this level of performance will be year-round. :) ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Visual Studio Team Services checks on pullrequests
Okay, now that it's morning and I have coffee, here's a full update on what I've been doing (those at the language summit have heard some of this already). Visual Studio Team Services is Microsoft's integrated code/build/release infrastructure service. The official marketing page is https://www.visualstudio.com/team-services/ but you can think of it as github code+github issues+Travis but engineered for huge teams (i.e. Microsoft keeps all of Windows in git, all the millions of issues they have, and all the builds they do, are in VSTS and it scales to thousands of developers just fine). I've been working with the team to improve their Python support and generally raise awareness of the new service, and one of the things they agreed to is to provide a free set of build machines for CPython. These allow us to run up to 20 simultaneous Windows, macOS and Linux builds with no other limits. My main project at the PyCon US sprints has been setting these builds up. As of about 16 hours ago the PR builds are now hooked up to github (for an example, see https://github.com/python/cpython/pull/6933). They are not required to merge, so don't feel the need to block PRs if everything else passes, but we'd like to fix up the issues they are hitting. As far as I can tell, most of the problems are transient test failures that ought to be fixed anyway. Brief interruption for some links: * https://python.visualstudio.com/cpython/_build/index?_a=queued (queued and recently completed builds) * https://github.com/python/cpython/tree/master/.vsts (build definitions) * https://github.com/python/cpython/pull/6933 (sample PR with build status) Authentication for python.visualstudio.com is currently manually managed, but everything relevant under https://python.visualstudio.com/cpython is visible without authentication (this is a new VSTS feature that we got enabled early). Right now I don't want to add lots of people manually, and we'll be looking at how to make this simpler in the future. There isn't much you can do while logged in anyway :) There are some missing features. I'm still in contact with the team and I'll be passing along requests, so feel free to let me know if you need anything. Currently I'm aware of: * no way to requeue a PR build (whether logged in or not) * no link from a build to the github PR page * templated build steps aren't enabled yet (see linux-deps.yml if you're interested) We don't yet have a specific timeline for making VSTS builds required and reducing Travis/AppVeyor usage. I also haven't set up VSTS for Python 2.7, and honestly I'm fine with keeping the existing systems there. As a slight aside, we're also working with some other projects to provide similar setups (specifically Twisted and some PyPA-associated projects), so if you think you'd benefit from this on one of your other projects let me know and we can see what's available. Also, if you start evaluating/using VSTS for other projects because of this, *please* let me know. New users is what the VSTS team is trying to achieve, so every time I can send back positive reports it helps convince them to keep donating build time. Feel free to email me with any questions or feedback, either on or off-list. Cheers, Steve ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Visual Studio Team Services checks on pullrequests
Le 17/05/2018 à 16:07, Steve Dower a écrit : > Okay, now that it's morning and I have coffee, here's a full update on > what I've been doing (those at the language summit have heard some of > this already). > > Visual Studio Team Services is Microsoft's integrated code/build/release > infrastructure service. The official marketing page is > https://www.visualstudio.com/team-services/ but you can think of it as > github code+github issues+Travis but engineered for huge teams (i.e. > Microsoft keeps all of Windows in git, all the millions of issues they > have, and all the builds they do, are in VSTS and it scales to thousands > of developers just fine). > > I've been working with the team to improve their Python support and > generally raise awareness of the new service, and one of the things they > agreed to is to provide a free set of build machines for CPython. These > allow us to run up to 20 simultaneous Windows, macOS and Linux builds > with no other limits. That sounds cool. Which builds are you looking to migrate to VSTS? macOS sounds like a no-brainer as the Travis-CI macOS infrastructure is known to be very lacking (though it has been a bit better lately). Windows may be reasonable since AppVeyor doesn't provide any parallelism AFAIK. As for Linux, I think it may be better to keep some of our CI on Travis (if only not to depend entirely on a donated service). Also a concern: currently the Travis-CI and AppVeyor configurations also work, transparently, on user's forks as long as they activated those (free) services on their fork. What about VSTS, though? If CPython were to migrate all of its CI to VSTS, would I still get CI on my CPython fork? Regards Antoine. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Visual Studio Team Services checks on pullrequests
On 17May2018 1014, Antoine Pitrou wrote: > That sounds cool. Which builds are you looking to migrate to VSTS? > macOS sounds like a no-brainer as the Travis-CI macOS infrastructure is > known to be very lacking (though it has been a bit better lately). > Windows may be reasonable since AppVeyor doesn't provide any parallelism > AFAIK. As for Linux, I think it may be better to keep some of our CI on > Travis (if only not to depend entirely on a donated service). That sounds fine. It'll be decided on core-workflow, but I tried to enable everything (except the 2.7 branch :) ) > Also a concern: currently the Travis-CI and AppVeyor configurations also > work, transparently, on user's forks as long as they activated those > (free) services on their fork. What about VSTS, though? If CPython > were to migrate all of its CI to VSTS, would I still get CI on my > CPython fork? I've enabled as much as I have options for (including clicking through the security warnings), so if it's still lacking in certain areas then I'll pass that feedback along. It definitely runs against PRs sent from forks, but I don't think it'll run against pushes to your own fork unless you sign up for your own (free) instance. The YAML files should work fine though, but they won't automatically create themselves. Cheers, Steve ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Visual Studio Team Services checks on pullrequests
On 5/17/2018 10:07 AM, Steve Dower wrote: Feel free to email me with any questions or feedback, either on or off-list. When a test fails and verbose test by test output is displayed, it would be really nice if error lines, or at least 'ERROR' were highlighted more somehow. Either in red (hard with plain text, I guess) or ***ERROR***, for instance. In the example, test_asyncio failed (this is a know intermittent problem) and includes lines like test_sock_sendfile_fallback (test.test_asyncio.test_base_events.BaseLoopSockSendfileTests) ... ERROR with no traceback. It is hard to be sure that one has seen all such lines. tjr ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
15.05.18 14:51, Ned Deily пише: This is it! We are down to THE FINAL WEEK for 3.7.0! Please get your feature fixes, bug fixes, and documentation updates in before 2018-05-21 ~23:59 Anywhere on Earth (UTC-12:00). That's about 7 days from now. We will then tag and produce the 3.7.0 release candidate. Our goal continues been to be to have no changes between the release candidate and final; AFTER NEXT WEEK'S RC1, CHANGES APPLIED TO THE 3.7 BRANCH WILL BE RELEASED IN 3.7.1. Please double-check that there are no critical problems outstanding and that documentation for new features in 3.7 is complete (including NEWS and What's New items), and that 3.7 is getting exposure and tested with our various platorms and third-party distributions and applications. Those of us who are participating in the development sprints at PyCon US 2018 here in Cleveland can feel the excitement building as we work through the remaining issues, including completing the "What's New in 3.7" document and final feature documentation. (We wish you could all be here.) The "What's New in 3.7" document is still not complete. Actually it is far completing. In the previous releases somebody made a thoughtful review of the NEWS file and added all significant changes in What's New, and also removed insignificant entries, reorganized entries, fixed errors, improved wording and formatting. Many thanks to Martin Panter, Elvis Pranskevichus, Yury Selivanov, R. David Murray, Nick Coghlan, Antoine Pitrou, Victor Stinner and others for their great work! But seems in 3.7 this documents doesn't have an editor. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
Elvis has been working on the What’s New doc at the sprints this week. He should be checking in his edits soon. Stay tuned! -- Ned Deily [email protected] -- [] > On May 17, 2018, at 14:31, Serhiy Storchaka wrote: > > 15.05.18 14:51, Ned Deily пише: >> This is it! We are down to THE FINAL WEEK for 3.7.0! Please get your >> feature fixes, bug fixes, and documentation updates in before >> 2018-05-21 ~23:59 Anywhere on Earth (UTC-12:00). That's about 7 days >> from now. We will then tag and produce the 3.7.0 release candidate. >> Our goal continues been to be to have no changes between the release >> candidate and final; AFTER NEXT WEEK'S RC1, CHANGES APPLIED TO THE 3.7 >> BRANCH WILL BE RELEASED IN 3.7.1. Please double-check that there are >> no critical problems outstanding and that documentation for new >> features in 3.7 is complete (including NEWS and What's New items), and >> that 3.7 is getting exposure and tested with our various platorms and >> third-party distributions and applications. Those of us who are >> participating in the development sprints at PyCon US 2018 here in >> Cleveland can feel the excitement building as we work through the >> remaining issues, including completing the "What's New in 3.7" >> document and final feature documentation. (We wish you could all be >> here.) > > The "What's New in 3.7" document is still not complete. Actually it is far > completing. In the previous releases somebody made a thoughtful review of the > NEWS file and added all significant changes in What's New, and also removed > insignificant entries, reorganized entries, fixed errors, improved wording > and formatting. Many thanks to Martin Panter, Elvis Pranskevichus, Yury > Selivanov, R. David Murray, Nick Coghlan, Antoine Pitrou, Victor Stinner and > others for their great work! But seems in 3.7 this documents doesn't have an > editor. > ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] [Python-Dev] FINAL WEEK FOR 3.7.0 CHANGES!
17.05.18 21:43, Elvis Pranskevichus пише: I'm working on the What's New document. Will start putting PRs in the next few days. Great! ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] FINAL WEEK FOR 3.7.0 CHANGES!
On Thu, 17 May 2018 at 14:31 Serhiy Storchaka wrote: > 15.05.18 14:51, Ned Deily пише: > > This is it! We are down to THE FINAL WEEK for 3.7.0! Please get your > > feature fixes, bug fixes, and documentation updates in before > > 2018-05-21 ~23:59 Anywhere on Earth (UTC-12:00). That's about 7 days > > from now. We will then tag and produce the 3.7.0 release candidate. > > Our goal continues been to be to have no changes between the release > > candidate and final; AFTER NEXT WEEK'S RC1, CHANGES APPLIED TO THE 3.7 > > BRANCH WILL BE RELEASED IN 3.7.1. Please double-check that there are > > no critical problems outstanding and that documentation for new > > features in 3.7 is complete (including NEWS and What's New items), and > > that 3.7 is getting exposure and tested with our various platorms and > > third-party distributions and applications. Those of us who are > > participating in the development sprints at PyCon US 2018 here in > > Cleveland can feel the excitement building as we work through the > > remaining issues, including completing the "What's New in 3.7" > > document and final feature documentation. (We wish you could all be > > here.) > > The "What's New in 3.7" document is still not complete. Actually it is > far completing. In the previous releases somebody made a thoughtful > review of the NEWS file and added all significant changes in What's New, > and also removed insignificant entries, reorganized entries, fixed > errors, improved wording and formatting. Many thanks to Martin Panter, > Elvis Pranskevichus, Yury Selivanov, R. David Murray, Nick Coghlan, > Antoine Pitrou, Victor Stinner and others for their great work! But > seems in 3.7 this documents doesn't have an editor. > Maybe we should start thinking about flagging PRs or issues as needing a What's New entry to help track when they need one, or always expect it in a PR and ignore that requirement when a 'skip whats new' label is applied. That would at least make it easier to keep track of what needs to be done. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Visual Studio Team Services checks on pullrequests
Can VSTS run GUI tests on any of the systems? Right now, only Appveyor and one or two of the Windows buildbots do so. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Visual Studio Team Services checks on pullrequests
On Thu, May 17, 2018 at 5:27 PM, Terry Reedy wrote: > Can VSTS run GUI tests on any of the systems? Right now, only Appveyor and > one or two of the Windows buildbots do so. It's certainly possible to use Xvfb to run headless GUI tests on Linux (or other Unixes that use X11). Any CI service should be able to handle this, e.g.: https://docs.travis-ci.com/user/gui-and-headless-browsers/#Using-xvfb-to-Run-Tests-That-Require-a-GUI -n -- Nathaniel J. Smith -- https://vorpus.org ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Can I just rerun a test on AppVeyor?
I can restart a test on just Travis when AppVeyor (and now MSTS) all passed. But for the last few hours, test_async has failed 1/4 to 1/3 of the runs. This means that test_async failed twice, so I suspect that it actually fails about half the time. A connection error seems to be the main culprit. I could not find a rebuild button on the AppVeyor page, even after connecting my github account with AppVeyor. I ended up closing and reopening, but this wastes resources on Travis and now MSTS. On the rerun, it failed the first time and then passed on the rerun ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Can I just rerun a test on AppVeyor?
On Thu, May 17, 2018 at 8:09 PM, Terry Reedy wrote: > I can restart a test on just Travis when AppVeyor (and now MSTS) all passed. > But for the last few hours, test_async has failed 1/4 to 1/3 of the runs. > This means that test_async failed twice, so I suspect that it actually fails > about half the time. A connection error seems to be the main culprit. > > I could not find a rebuild button on the AppVeyor page, even after > connecting my github account with AppVeyor. I ended up closing and > reopening, but this wastes resources on Travis and now MSTS. > > On the rerun, it failed the first time and then passed on the rerun It is unfortunately non-obvious that you have to choose "python" rather than your own GitHub username after clicking the "login via GitHub" button, but after logging in that way you should have a "Re-build PR" button at the top of the page of any PR build. I'm not certain that permissions were set correctly before, but they definitely should be now. -- Zach ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Can I just rerun a test on AppVeyor?
On 5/17/2018 10:36 PM, Zachary Ware wrote: On Thu, May 17, 2018 at 8:09 PM, Terry Reedy wrote: I can restart a test on just Travis when AppVeyor (and now MSTS) all passed. But for the last few hours, test_async has failed 1/4 to 1/3 of the runs. This means that test_async failed twice, so I suspect that it actually fails about half the time. A connection error seems to be the main culprit. I could not find a rebuild button on the AppVeyor page, even after connecting my github account with AppVeyor. I ended up closing and reopening, but this wastes resources on Travis and now MSTS. On the rerun, it failed the first time and then passed on the rerun It is unfortunately non-obvious that you have to choose "python" rather than your own GitHub username after clicking the "login via GitHub" button, You're right. I choose my name. 0-(. In retrospect, it makes sense since the job is being done on the python account, not mine. but after logging in that way you should have a "Re-build PR" button at the top of the page of any PR build. I'm not certain that permissions were set correctly before, but they definitely should be now. Thanks. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] Bring back Travis & AppVeyor, make VSTS non-blocking
VSTS is clearly not yet a stable continuous integration platform. It needs to be made non-blocking, and AppVeyor and Travis need to be brought back! Examples: https://github.com/python/cpython/pull/6938#issuecomment-389908094 Windows broke - https://python.visualstudio.com/cpython/_build?buildId=522 https://github.com/python/cpython/pull/6939 Linux broke - https://python.visualstudio.com/cpython/_build?buildId=523 This was on a documentation-only change. We cannot be changing to new PR-merge-blocking continuous integration services at this point during a release cycle. This is preventing changes from making it in. -gps ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
