[python-committers] Adding "Co-authored-by" in commit message.
I learned today that GitHub now supports multiple author info in a commit. https://help.github.com/articles/creating-a-commit-with-multiple-authors/ and https://github.com/blog/2496-commit-together-with-co-authors It can be done by adding: Co-authored-by: name as the footer of the commit message. I tested this in CPython: https://github.com/python/cpython/commit/6ea75b174da0cf824e2acc5db6b53798f5f4e4f9 I suggest we start adding this where it makes sense, to give proper credit to PR authors. What I've seen is that we've only been writing "Original Patch by ". One scenario is when we convert someone else's mercurial patch to GitHub pull request. Or when someone started a patch, and another person finished it. The other scenario is with miss-islington's backport PRs. I will try to find time this week so that miss-islington or cherry_picker will add the "Co-authored-by:" automatically. Mariatta Wijaya ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] [core-workflow] Adding "Co-authored-by" in commit message.
On Mon, Jan 29, 2018 at 4:32 PM, Mariatta Wijaya wrote: > I suggest we start adding this where it makes sense, to give proper credit > to PR authors. +1 Thanks for noticing this. I've bumped into this several times and look forward to (more clearly) giving credit where credit is due. -eric ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] [core-workflow] Adding "Co-authored-by" in commit message.
No prob :) I've also updated cherry_picker and miss-islington, so now `Co-authored-by` is added automatically in backport PRs. Mariatta Wijaya On Mon, Jan 29, 2018 at 5:37 PM, Eric Snow wrote: > On Mon, Jan 29, 2018 at 4:32 PM, Mariatta Wijaya > wrote: > > I suggest we start adding this where it makes sense, to give proper > credit > > to PR authors. > > +1 > > Thanks for noticing this. I've bumped into this several times and > look forward to (more clearly) giving credit where credit is due. > > -eric > ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
