Re: [python-committers] OK to back-fill "awaiting" labels on open issues?

2017-10-10 Thread Brett Cannon 
On Fri, 6 Oct 2017 at 15:50 Terry Reedy  wrote:

> On 10/6/2017 5:29 PM, Brett Cannon wrote:
> > I noticed today that out of about 19 pages of issues, only the first 5
> > have "awaiting" labels. Would people object if I back-filled those open
> > issues lacking an "awaiting" label? For those that have a "changes
> > requested" review a comment that said roughly "we noticed there's a
> > review asking for changes; if you already did that then let us know by
> > saying 'I didn't expect the Spanish Inquisition' and we will update this
> > pull request accordingly" (the other stages don't have potential
> > false-positives).
> >
> > The reason I'm asking before coding this up and running it is there will
> > be some churn in notifications for those issues that get a comment about
> > "awaiting changes".
>
> Could you do, for instance, a page a day, so people are less likely to
> be overwhelmed by (and ignore) a big batch?
>

Yes, the work could be smeared across multiple days.
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/

Re: [python-committers] OK to back-fill "awaiting" labels on open issues?

2017-10-10 Thread Brett Cannon 
On Fri, 6 Oct 2017 at 14:37 Donald Stufft  wrote:

>
> > On Oct 6, 2017, at 5:36 PM, Alex Gaynor  wrote:
> >
> > Can we please use a phrase for re-triggering a review that makes more
> sense like "I've updated the patch, please re-review", rather than magic
> inside baseball language?
> >
>
>
> +1
>

I just added support for the trigger phrase of "I have made the requested
changes; please review again" (which is now what people are asked to say).
The "I didn't expect the Spanish Inquisition" trigger has stayed as an
easter egg (whose response is also part of the easter egg). I also left the
random easter egg on the comment about the required comment.
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/