Re: [python-committers] OK to back-fill "awaiting" labels on open issues?

2017-10-07 Thread Brett Cannon
This off-topic for this thread. If you want to discuss adding support for
another trigger phrase you can bring it up on core-workflow.

On Fri, Oct 6, 2017, 14:36 Alex Gaynor,  wrote:

> Can we please use a phrase for re-triggering a review that makes more
> sense like "I've updated the patch, please re-review", rather than magic
> inside baseball language?
>
> Alex
>
> On Fri, Oct 6, 2017 at 5:29 PM, Brett Cannon  wrote:
>
>> I noticed today that out of about 19 pages of issues, only the first 5
>> have "awaiting" labels. Would people object if I back-filled those open
>> issues lacking an "awaiting" label? For those that have a "changes
>> requested" review a comment that said roughly "we noticed there's a review
>> asking for changes; if you already did that then let us know by saying 'I
>> didn't expect the Spanish Inquisition' and we will update this pull request
>> accordingly" (the other stages don't have potential false-positives).
>>
>> The reason I'm asking before coding this up and running it is there will
>> be some churn in notifications for those issues that get a comment about
>> "awaiting changes".
>>
>> ___
>> python-committers mailing list
>> [email protected]
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>>
>
>
> --
> "I disapprove of what you say, but I will defend to the death your right
> to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
> "The people's good is the highest law." -- Cicero
> GPG Key fingerprint: D1B3 ADC0 E023 8CA6
>
>
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/


Re: [python-committers] OK to back-fill "awaiting" labels on open issues?

2017-10-07 Thread Brett Cannon
And this email was written when heading out the door, so sorry if came off
as me being short.

On Sat, Oct 7, 2017, 14:32 Brett Cannon,  wrote:

> This off-topic for this thread. If you want to discuss adding support for
> another trigger phrase you can bring it up on core-workflow.
>
> On Fri, Oct 6, 2017, 14:36 Alex Gaynor,  wrote:
>
>> Can we please use a phrase for re-triggering a review that makes more
>> sense like "I've updated the patch, please re-review", rather than magic
>> inside baseball language?
>>
>> Alex
>>
>> On Fri, Oct 6, 2017 at 5:29 PM, Brett Cannon  wrote:
>>
>>> I noticed today that out of about 19 pages of issues, only the first 5
>>> have "awaiting" labels. Would people object if I back-filled those open
>>> issues lacking an "awaiting" label? For those that have a "changes
>>> requested" review a comment that said roughly "we noticed there's a review
>>> asking for changes; if you already did that then let us know by saying 'I
>>> didn't expect the Spanish Inquisition' and we will update this pull request
>>> accordingly" (the other stages don't have potential false-positives).
>>>
>>> The reason I'm asking before coding this up and running it is there will
>>> be some churn in notifications for those issues that get a comment about
>>> "awaiting changes".
>>>
>>> ___
>>> python-committers mailing list
>>> [email protected]
>>> https://mail.python.org/mailman/listinfo/python-committers
>>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>>
>>>
>>
>>
>> --
>> "I disapprove of what you say, but I will defend to the death your right
>> to say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
>> "The people's good is the highest law." -- Cicero
>> GPG Key fingerprint: D1B3 ADC0 E023 8CA6
>>
>>
___
python-committers mailing list
[email protected]
https://mail.python.org/mailman/listinfo/python-committers
Code of Conduct: https://www.python.org/psf/codeofconduct/