[python-committers] Requesting reviews
I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed? As I say, it's not a big deal for me, but I'm curious how others think the review teams should be used. Paul ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
On 10/6/2017 8:16 AM, Paul Moore wrote: I'm seeing a lot of review requests from github, asking for reviews from the Windows team. Many of the PRs don't as far as I can see have much Windows-specific about them. It doesn't bother me too much (I just ignore ones I don't have anything to say on) but I thought the idea of having the teams was to ask for specific experts to take a look when needed? Perhaps people are asking for Windows-specific input in addition to input from themselves or other *nix experts, in case there is something they do not know about. If so, and you look and see nothing, it might be helpful to say so. Of course, it might help if the requesting person explains such requests. tjr ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore wrote: > I'm seeing a lot of review requests from github, asking for reviews > from the Windows team. Many of the PRs don't as far as I can see have > much Windows-specific about them. It doesn't bother me too much (I > just ignore ones I don't have anything to say on) but I thought the > idea of having the teams was to ask for specific experts to take a > look when needed? > > As I say, it's not a big deal for me, but I'm curious how others think > the review teams should be used. Do you have some examples of superfluous requests? I don't think I've seen any, other than a rash of bad drive-by PRs that merge a maintenance branch into master, which GitHub should be working on preventing. See https://github.com/python/core-workflow/issues/168 for more on that. -- Zach ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
Hmm, as an example, #2858, which seems to be about the AST (which I'm not familiar with). I don't particularly want to single this out as a problem, but it's an example of the sort of request that confuses me - I simply don't know what help I can offer. Maybe there is some suspicion that there might be a Windows element - but without some guidance, I'm not sure where to look. Paul On 6 October 2017 at 16:38, Zachary Ware wrote: > On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore wrote: >> I'm seeing a lot of review requests from github, asking for reviews >> from the Windows team. Many of the PRs don't as far as I can see have >> much Windows-specific about them. It doesn't bother me too much (I >> just ignore ones I don't have anything to say on) but I thought the >> idea of having the teams was to ask for specific experts to take a >> look when needed? >> >> As I say, it's not a big deal for me, but I'm curious how others think >> the review teams should be used. > > Do you have some examples of superfluous requests? I don't think I've > seen any, other than a rash of bad drive-by PRs that merge a > maintenance branch into master, which GitHub should be working on > preventing. See https://github.com/python/core-workflow/issues/168 > for more on that. > > -- > Zach > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
The windows team is notified because the PR includes changes to PCBuild/* Mariatta Wijaya On Fri, Oct 6, 2017 at 8:51 AM, Paul Moore wrote: > Hmm, as an example, #2858, which seems to be about the AST (which I'm > not familiar with). I don't particularly want to single this out as a > problem, but it's an example of the sort of request that confuses me - > I simply don't know what help I can offer. Maybe there is some > suspicion that there might be a Windows element - but without some > guidance, I'm not sure where to look. > > Paul > > On 6 October 2017 at 16:38, Zachary Ware > wrote: > > On Fri, Oct 6, 2017 at 7:16 AM, Paul Moore wrote: > >> I'm seeing a lot of review requests from github, asking for reviews > >> from the Windows team. Many of the PRs don't as far as I can see have > >> much Windows-specific about them. It doesn't bother me too much (I > >> just ignore ones I don't have anything to say on) but I thought the > >> idea of having the teams was to ask for specific experts to take a > >> look when needed? > >> > >> As I say, it's not a big deal for me, but I'm curious how others think > >> the review teams should be used. > > > > Do you have some examples of superfluous requests? I don't think I've > > seen any, other than a rash of bad drive-by PRs that merge a > > maintenance branch into master, which GitHub should be working on > > preventing. See https://github.com/python/core-workflow/issues/168 > > for more on that. > > > > -- > > Zach > > ___ > > python-committers mailing list > > [email protected] > > https://mail.python.org/mailman/listinfo/python-committers > > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
On 6 October 2017 at 17:09, Mariatta Wijaya wrote: > The windows team is notified because the PR includes changes to PCBuild/* Ah cool. That explains it then - I hadn't spotted that (and didn't think of it). Thanks Mariatta Paul ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
On Fri, 06 Oct 2017 09:09:01 -0700, Mariatta Wijaya wrote: > The windows team is notified because the PR includes changes to PCBuild/* If you get a review request that says your review was requested "as a code owner", then it was an auto-request, it wasn't actually requested by the person named in the message (which I agree is confusing). You can look through the diff to check for changes to PC, PCBuild, msi, or nuget to see if there are windows changes you do want to review. The config for the auto-review-requests is in .github/CODEOWNERS; the current windows team entries are: # Windows /PC/ @python/windows-team /PCBuild/ @python/windows-team # Windows installer packages /Tools/msi/ @python/windows-team /Tools/nuget/ @python/windows-team ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Requesting reviews
On 6 October 2017 at 17:58, R. David Murray wrote: > On Fri, 06 Oct 2017 09:09:01 -0700, Mariatta Wijaya > wrote: >> The windows team is notified because the PR includes changes to PCBuild/* > > If you get a review request that says your review was requested "as a > code owner", then it was an auto-request, it wasn't actually requested > by the person named in the message (which I agree is confusing). Ah, right. Yes I had missed that nuance. Thanks, I'm now much clearer on what's going on here. Thanks all for the explanations :-) Paul ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
[python-committers] OK to back-fill "awaiting" labels on open issues?
I noticed today that out of about 19 pages of issues, only the first 5 have "awaiting" labels. Would people object if I back-filled those open issues lacking an "awaiting" label? For those that have a "changes requested" review a comment that said roughly "we noticed there's a review asking for changes; if you already did that then let us know by saying 'I didn't expect the Spanish Inquisition' and we will update this pull request accordingly" (the other stages don't have potential false-positives). The reason I'm asking before coding this up and running it is there will be some churn in notifications for those issues that get a comment about "awaiting changes". ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] OK to back-fill "awaiting" labels on open issues?
Can we please use a phrase for re-triggering a review that makes more sense like "I've updated the patch, please re-review", rather than magic inside baseball language? Alex On Fri, Oct 6, 2017 at 5:29 PM, Brett Cannon wrote: > I noticed today that out of about 19 pages of issues, only the first 5 > have "awaiting" labels. Would people object if I back-filled those open > issues lacking an "awaiting" label? For those that have a "changes > requested" review a comment that said roughly "we noticed there's a review > asking for changes; if you already did that then let us know by saying 'I > didn't expect the Spanish Inquisition' and we will update this pull request > accordingly" (the other stages don't have potential false-positives). > > The reason I'm asking before coding this up and running it is there will > be some churn in notifications for those issues that get a comment about > "awaiting changes". > > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > > -- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero GPG Key fingerprint: D1B3 ADC0 E023 8CA6 ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] OK to back-fill "awaiting" labels on open issues?
> On Oct 6, 2017, at 5:36 PM, Alex Gaynor wrote: > > Can we please use a phrase for re-triggering a review that makes more sense > like "I've updated the patch, please re-review", rather than magic inside > baseball language? > +1 ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] OK to back-fill "awaiting" labels on open issues?
On 10/6/2017 5:29 PM, Brett Cannon wrote: I noticed today that out of about 19 pages of issues, only the first 5 have "awaiting" labels. Would people object if I back-filled those open issues lacking an "awaiting" label? For those that have a "changes requested" review a comment that said roughly "we noticed there's a review asking for changes; if you already did that then let us know by saying 'I didn't expect the Spanish Inquisition' and we will update this pull request accordingly" (the other stages don't have potential false-positives). The reason I'm asking before coding this up and running it is there will be some churn in notifications for those issues that get a comment about "awaiting changes". Could you do, for instance, a page a day, so people are less likely to be overwhelmed by (and ignore) a big batch? ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
