Re: [python-committers] Revert changes which break too many buildbots
Ok, since I spent weeks on fixing buildbots, I'm now more confident that our buildbots are super stable. Since a test_datetime change introduced a *regression* (ARMv7 started to fail), I reverted the first commit: https://github.com/python/cpython/pull/2588 Again, it's not to reject the change, just to repair the buildbot to get more time to design and test the proper fix. Because of a bug, test_datetime only tested the C implementation of datetime. The change enables tests on Lib/datetime.py, the Python implementation. Suddenly, test_datetime started to take up to 20 minutes to run! The slowest time on some buildbots. I don't know much more at this point. Please join http://bugs.python.org/issue30822 if you want to help fixing this issue ;-) Victor 2017-06-14 16:40 GMT+02:00 Victor Stinner : > Hi, > > The CPython workflow was enhanced to get pre-commit CI checks. That's > a huge win, thank you for that... But, sometimes, a change can still > break many buildbots, bugs which weren't catched by pre-commit checks > (Travis CI/Linux and AppVeyor/Windows). Buildbots cover much more > different architectures and platforms. > > I spend a significant amount of time to maintain the sanity of our > buildbots. Sometimes, it can take me up to 3 days on a week (of 5 > working days). It's annoying to see new regressions while I'm trying > hard to fix old ones :-( > > So I would like to set a new rule: if I'm unable to fix buildbots > failures caused by a recent change quickly (say, in less than 2 > hours), I propose to revert the change. > > It doesn't mean that the commit is bad and must not be merged ever. > No. It would just mean that we need time to work on fixing the issue, > and it shouldn't impact other pending changes, to keep a sane master > branch. > > What do you think? Would you be ok with such rule? > > A recent example is Nick Coghlan's implementation of the PEP 538: > basically, it broke all buildbots... except of Linux and Windows :-) > And it will take a few more days to fix all failures. Well, we are > working on fixing these issues, so I don't want to revert this change. > It's just an example of a single change which broke many buildbots. > The PEP 538 depends a lot on the platform, so I'm not surprised to see > different failures per platforms ;-) > > By "buildbot failure", I mean a red buildbot failing because of > compilation error or failed test suite. But I would prefer to ignore > failures of the Refleak buildbots since these ones are not stable > (even if there are less and less ref leaks in master, and these > buildbots already catched recent regressions!). > > If the rule is approved, I plan to announce it on python-dev to be > transparent. > > Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Revert changes which break too many buildbots
2017-07-05 15:51 GMT+02:00 Victor Stinner : > Ok, since I spent weeks on fixing buildbots, I'm now more confident > that our buildbots are super stable. Since a test_datetime change > introduced a *regression* (ARMv7 started to fail), I reverted the > first commit: > https://github.com/python/cpython/pull/2588 Crap. I created this PR using the [Revert] button. While the changes are fine, I didn't notice the giant commit message which is wrong and spamed me with notifications on unrelated issues :-/ Sorry for the spam... commit 8207c17486baece8ed0ac42d9f8d69ecec4ba7e4 Author: Victor Stinner Date: Wed Jul 5 15:44:52 2017 +0200 Revert "bpo-30822: Fix testing of datetime module." (#2588) * Revert "bpo-30854: Fix compile error when --without-threads (#2581)" This reverts commit 0c3116309307ad2c7f8e2d2096612f4ab33cbb62. * Revert "NEWS for 30777 (#2576)" This reverts commit aaa917ff38f9869eeebe3bc9469bfee64089d826. * Revert "bpo-21624: IDLE -- minor htest fixes (#2575)" This reverts commit 2000150c569941584994ec4ec59171961209bec3. * Revert "bpo-30777: IDLE: configdialog - add docstrings and improve comments (#2440)" This reverts commit 7eb5883ac59833bf63f0e1f7fb95671a1ac1ee08. * Revert "bpo-30319: socket.close() now ignores ECONNRESET (#2565)" This reverts commit 67e1478dba6efe60b8e1890192014b8b06dd6bd9. * Revert "bpo-30789: Use a single memory block for co_extra. (#2555)" This reverts commit 378ebb6578b9d709f38b888d23874c0b18125249. * Revert "bpo-30845: Enhance test_concurrent_futures cleanup (#2564)" This reverts commit 3df9dec425b0254df1cdf41922fd8d6b08bf47e4. * Revert "bpo-29293: multiprocessing.Condition.notify() lacks parameter `n` (#2480)" This reverts commit 48350412b70c76fa51f488cfc736c80d59b5e8eb. * Revert "Remove outdated FOX from GUI FAQ (GH-2538)" This reverts commit d3ed2877a798d07df75422afe136b4727e500c99. * Revert "bpo-6691: Pyclbr now reports nested classes and functions. (#2503)" This reverts commit 246ff3bd00f97658e567a7087645a6b76e056491. * Revert "bpo-29464: Rename METH_FASTCALL to METH_FASTCALL|METH_KEYWORDS and make (#1955)" This reverts commit 6969eaf4682beb01bc95eeb14f5ce6c01312e297. * Revert "bpo-30832: Remove own implementation for thread-local storage (#2537)" This reverts commit aa0aa0492c5fffe750a26d2ab13737a1a6d7d63c. * Revert "bpo-30764: Fix regrtest --fail-env-changed --forever (#2536)" This reverts commit 5e87592fd12e0b7c41edc11d4885ed7298d5063b. * Revert "bpo-30822: Deduplicate ZoneInfoTest classes in test_datetime. (#2534)" This reverts commit 34b54873b51a1ebee2a3c57b7205537b4f33128d. * Revert "bpo-30822: Fix testing of datetime module. (#2530)" This reverts commit 98b6bc3bf72532b784a1c1fa76eaa6026a663e44. Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Revert changes which break too many buildbots
On 7/5/2017 10:03 AM, Victor Stinner wrote: 2017-07-05 15:51 GMT+02:00 Victor Stinner : Ok, since I spent weeks on fixing buildbots, I'm now more confident that our buildbots are super stable. Since a test_datetime change introduced a *regression* (ARMv7 started to fail), I reverted the first commit: https://github.com/python/cpython/pull/2588 Crap. I created this PR using the [Revert] button. While the changes are fine, I didn't notice the giant commit message which is wrong and spamed me with notifications on unrelated issues :-/ Committers should always review checkin messages. Unless a PR is made with a single commit, the message usually needs editing. Sorry for the spam... Each tracker issue mentioned below got a bogus reversion message. But better the spam than an actual reversion ;-). I unlinked the ones for IDLE. You should go through the rest. Terry ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
