Re: [python-committers] Promote Xiang Zhang as a core developer
2016-11-15 16:46 GMT+01:00 Senthil Kumaran : >> Maybe Xiang needs a longer mentoring period than 1 month, but I want >> to keep him motivated. Active contributors (even inside core >> developers) are rare, so we always need fresh blood :-) > > I agree with this statement. I did a review of his contributions and many > seem worthy. > I am +1 to support commit privileges for Xiang. Ok, I will wait until Sunday evening to make sure that everybody has the opportonity to vote. Even if Berker and Serhiy have legit concerns, I'm still in favor of giving the commit bit to Xiang right now. Berker, Serhiy: Do you prefer that I mentor Xiang first during one month, then give him the commit bit, but continue to mentor him? Or are you ok to give him the commit bit right now, and as I wrote, request him to ask me before pushing anything? Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
2016-11-15 19:32 GMT+01:00 : > Since the first commit 8 months ago I counted about 50 Xiang's committed > patches, and most of them were committed by me (other 10 core developers > committed form 1 to 4 Xiang's patches). He helped with reviewing patches and > discussing issues. His C skills was good 8 months ago, and now he is known > with CPython style and workflow. He sees beneath the surface and understands > that he need to consider edge cases and side effects. Cool :-) > From technical point there is no need to grant him commit rights, because I > and other core developers commit his patches. Almost all his patches are > commited (there are few issues in progress and there are few documentation > issues). But for motivating purpose I support this proposition. For me, the main reason to give the commit bit is to motivate contributors :-) I know that many people are proud to be core developers (but don't say it loudly ;-)) and it keeps them motivated. > Unfortunately there is truth in Berker's words. Yes, Xiang tends to fix things > that don't look obviously broken (for example see issue28398 [1] and > issue28531 [2]). This may have been partially my fault, because I committed > his patches that would not dare to offer himself. He is inclined not to accept > comments obediently, but start a discussion. Not sure this is certainly bad. I look at these two patches and the patch looks good to me, but it's also right that they don't fix any bug. I will make sure that Xiang understands well that changes in CPython must be carefully reviewed by others, and that sometimes it's just fine to abandon patches. Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
2016-11-18 18:16 GMT+02:00 Victor Stinner : > Berker, Serhiy: Do you prefer that I mentor Xiang first during one > month, then give him the commit bit, but continue to mentor him? Or > are you ok to give him the commit bit right now, and as I wrote, > request him to ask me before pushing anything? I'm for giving him the commit bit right now. ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
On Tue, Nov 15, 2016 at 11:17 AM, Victor Stinner wrote: > Hi, > > 2016-11-15 1:10 GMT+01:00 Berker Peksağ : >> Xiang tends to fix things that are not broken, > > This sentence sounds strange. What do you mean? :-) > >> (...) and when you point out that the thing they are >> trying to fix is not broken, they try to start an endless discussion. >> I also saw a couple of instances where they refused to address code >> review comments from experienced core developers (which is a red flag >> for me) > > I guess that "they" means "he", so Xiang, right? Correct, sorry for being unclear. https://en.wikipedia.org/wiki/Singular_they can probably do a better job on explaining my usage of it :) > Do you have some examples of such discussions? I'm not aware of such issue. * http://bugs.python.org/review/27861/ (you can start reading from my first comment) * http://bugs.python.org/issue27740 * http://bugs.python.org/issue27414 There are more examples where Xiang refused to address reviews comments by saying "do what you want", but I don't really have time to dig bugs.p.o mails now (one of them was in response to Serhiy's comments) Committing a patch takes a lot of time and I think respecting a core developer's time is a good trait to look for (of course I'm not saying that all review comments are correct and should be addressed without any discussion) I agree that we should look for people who wrote high quality patches, but I think we also should look for people who help other members of the community by doing *boring* tasks (e.g. review patches submitted by other contributors, triage old issues on the tracker, update an outdated patch by addressing review comments) --Berker ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
On 19 November 2016 at 13:07, Berker Peksağ wrote: > I agree that we should look for people who wrote high quality patches, > but I think we also should look for people who help other members of > the community by doing *boring* tasks (e.g. review patches submitted > by other contributors, triage old issues on the tracker, update an > outdated patch by addressing review comments) While I agree with this, I don't think it's an either/or situation - I know when I've recommended folks for commit rights in the past, it's been because the situation changed from "discussing their patches with me before I commit them is leading to important changes prior to merging" to "I'm mostly just rubberstamping their patches, and I trust them to ask me or another core dev for our perspective when they're unsure, and to take it with good grace if someone asks for a change they made to be reverted for further discussion". One of the luxuries of version control is that only released changes are hard to undo :) One specific technique that has worked well in some cases is to explicitly scope a new committer's responsibilities (i.e. the "to work on X, Y, Z" comments in the developer log), rather than saying "feel free to approve changes anywhere in the code base". Branching out from that initial base (if they choose to do so) can then happen over time as they gain familiarity and confidence in more areas. Cheers, Nick. -- Nick Coghlan | [email protected] | Brisbane, Australia ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
