[python-committers] Promote Xiang Zhang as a core developer
Hi, Last months, I noticed that Xiang Zhang is very active on the bug tracker and propose many enhancements and bug fixes. He contributes to Python code, but also to the C code (a rare skill nowadays). Slowly, he understood how to produce "good" patches, the CPython workflow, etc. I think that his contributions are now good enough to give him the commit bit. As I did previously (for Xavier), I also propose to be his mentor the first month: request him to ask me before pushing anything, help him with Mercurial, branches, etc. So I can help to avoid simple mistakes and to not break the buildbot too often :-) Maybe Serhiy Storchaka and/or Yury Selivanov may want to co-mentor Xiang? Serhiy reviewed many of Xiang's patches recently. Victor ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
+1, if I can vote. He helped me a lot by reviewing my patch, and fixing issues relating to dict. Regards, -- INADA Naoki ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
On 14 November 2016 at 22:09, Victor Stinner wrote: > Hi, > > Last months, I noticed that Xiang Zhang is very active on the bug > tracker and propose many enhancements and bug fixes. He contributes to > Python code, but also to the C code (a rare skill nowadays). Slowly, > he understood how to produce "good" patches, the CPython workflow, > etc. I think that his contributions are now good enough to give him > the commit bit. I haven't been doing a lot of general patch triage lately, but Xiang's issue report where he found and fixed an obscure problem in the new multi-phase extension module import system [1] was a genuinely enjoyable experience for me as a patch reviewer (and the patch itself was complete and correct, so the only thing I needed to add was a NEWS entry). Cheers, Nick. [1] http://bugs.python.org/issue27782 -- Nick Coghlan | [email protected] | Brisbane, Australia ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
I thought someone asked Xiang if he wanted to be a core dev during the core sprints in September and he turned down the offer? On Mon, 14 Nov 2016 at 04:10 Victor Stinner wrote: > Hi, > > Last months, I noticed that Xiang Zhang is very active on the bug > tracker and propose many enhancements and bug fixes. He contributes to > Python code, but also to the C code (a rare skill nowadays). Slowly, > he understood how to produce "good" patches, the CPython workflow, > etc. I think that his contributions are now good enough to give him > the commit bit. > > As I did previously (for Xavier), I also propose to be his mentor the > first month: request him to ask me before pushing anything, help him > with Mercurial, branches, etc. So I can help to avoid simple mistakes > and to not break the buildbot too often :-) > > Maybe Serhiy Storchaka and/or Yury Selivanov may want to co-mentor > Xiang? Serhiy reviewed many of Xiang's patches recently. > > Victor > ___ > python-committers mailing list > [email protected] > https://mail.python.org/mailman/listinfo/python-committers > Code of Conduct: https://www.python.org/psf/codeofconduct/ > ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
Re: [python-committers] Promote Xiang Zhang as a core developer
On Mon, Nov 14, 2016 at 3:09 PM, Victor Stinner wrote: > Hi, > > Last months, I noticed that Xiang Zhang is very active on the bug > tracker and propose many enhancements and bug fixes. He contributes to > Python code, but also to the C code (a rare skill nowadays). Slowly, > he understood how to produce "good" patches, the CPython workflow, > etc. I think that his contributions are now good enough to give him > the commit bit. > > As I did previously (for Xavier), I also propose to be his mentor the > first month: request him to ask me before pushing anything, help him > with Mercurial, branches, etc. So I can help to avoid simple mistakes > and to not break the buildbot too often :-) > > Maybe Serhiy Storchaka and/or Yury Selivanov may want to co-mentor > Xiang? Serhiy reviewed many of Xiang's patches recently. I also reviewed and pushed Xiang's patches. Xiang tends to fix things that are not broken, and when you point out that the thing they are trying to fix is not broken, they try to start an endless discussion. I also saw a couple of instances where they refused to address code review comments from experienced core developers (which is a red flag for me) --Berker ___ python-committers mailing list [email protected] https://mail.python.org/mailman/listinfo/python-committers Code of Conduct: https://www.python.org/psf/codeofconduct/
