[issue26293] Embedded zipfile fields dependent on absolute position

[spoo]

spoo added the comment:

On 06/03/2016 09:27 PM, Serhiy Storchaka wrote:
> 
> Serhiy Storchaka added the comment:
> 
> spoo, can you confirm that the patch fixes your issue?
> 
> --
> 
> ___
> Python tracker 
> <http://bugs.python.org/issue26293>
> ___
> 

Yes, sorry, and thank you for looking into this!  It may take me a few
days to be able to test it.

--

___
Python tracker 
<http://bugs.python.org/issue26293>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26293] Embedded zipfile fields dependent on absolute position

[spoo]

spoo added the comment:

Thank you for looking into this!  I don't have my tablet to test with at
the moment, but testing locally with zipinfo there used to be a warning
about missing bytes and now there is none.  I will test with the tablet
in a week or two when I get it back.

--

___
Python tracker 
<http://bugs.python.org/issue26293>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26293] Embedded zipfile fields dependent on absolute position

[spoo]

New submission from spoo:

Example:

from zipfile import ZipFile
with open('a.zipp', 'wb') as base:
base.write(b'old\n')
with ZipFile(base, 'a') as myzip:
myzip.write('eggs.txt')

If the embedded zip portion of the file is extracted (first four bytes 
deleted), some fields will be incorrect in the resultant file - commenting out 
line 3 produces a file that can serve as a comparison.  These differences cause 
issues opening with some zip library implementations.

My best guess is that this is related to this line: 
https://github.com/python/cpython/blob/master/Lib/zipfile.py#L1459

--
components: Library (Lib)
messages: 259642
nosy: spoo
priority: normal
severity: normal
status: open
title: Embedded zipfile fields dependent on absolute position
type: behavior
versions: Python 3.6

___
Python tracker 
<http://bugs.python.org/issue26293>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26293] Embedded zipfile fields dependent on absolute position

[spoo]

spoo added the comment:

I'm not familiar with iOS development, but I'd hazard a guess that "some zip 
library implementations" means a (the official?) iOS zip library.

--

___
Python tracker 
<http://bugs.python.org/issue26293>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26293] Embedded zipfile fields dependent on absolute position

[spoo]

spoo added the comment:

I confirmed this fixes the issue loading zips on an iPad.

--

___
Python tracker 
<http://bugs.python.org/issue26293>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com