[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[hudelgado]

hudelgado  added the comment:

Ok, I'm thinking in also replace the os.popen calls with subprocess.Popen to 
keep consistency with existing tests.
Do you think it's a good approach? Or should be better to just add some tests 
around the current implementation?

--

___
Python tracker 
<https://bugs.python.org/issue24955>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

[hudelgado]

hudelgado  added the comment:

I took a look at it and have a some more questions.
The class MacOSX(BaseBrowser) seems to be broken because it uses 'OpenUrl' 
which doesn't work in most recent versions of applescript, also that class 
doesn't seem to be used anywhere, is it ok to remove it, or should left it as 
is?
Although that class isn't used it contained an hack to open local files that 
didn't exist in the class MacOSXOSAScript(BaseBrowser), i've added that hack to 
the MacOSXOSAScript.
Can you validate if everything seems ok with this changes?
I'm happy to adjust things according to what you suggest.

--
Added file: https://bugs.python.org/file49341/24955.diff

___
Python tracker 
<https://bugs.python.org/issue24955>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com