[issue34410] itertools.tee not thread-safe; can segfault interpreter when wrapped iterator releases GIL
Xiang Zhang added the comment: >It may be better to apply it even to the developed version. There is nothing >wrong with creating the tee iterator in one thread and using it the other >thread. Or using the tee iterators with external locking. I afraid that PR >15567 can break a legitimate code. +1 on this. I think it's better to also apply #15625 to master branch. I don't think we should prevent creating the iterator in one thread and using it in others. -- ___ Python tracker <https://bugs.python.org/issue34410> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38168] Refleaks in setint() of mmapmodule.c
Change by Xiang Zhang : -- pull_requests: +15786 pull_request: https://github.com/python/cpython/pull/16176 ___ Python tracker <https://bugs.python.org/issue38168> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38168] Refleaks in setint() of mmapmodule.c
Xiang Zhang added the comment: New changeset 68d8c122972d7a49627b983af4ccbfad9f5ade17 by Xiang Zhang in branch '2.7': [2.7] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16176) https://github.com/python/cpython/commit/68d8c122972d7a49627b983af4ccbfad9f5ade17 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue38168> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38168] Refleaks in setint() of mmapmodule.c
Change by Xiang Zhang : -- components: +Extension Modules -Interpreter Core resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue38168> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38391] Typo in tutorial code (does not compile)
Xiang Zhang added the comment: New changeset 038503e08ac5b10601b95d5adc2c2cab7be10163 by Xiang Zhang (Krishna Oza) in branch 'master': bpo-38391: Fixing a typo for Py_DECREF (GH-16616) https://github.com/python/cpython/commit/038503e08ac5b10601b95d5adc2c2cab7be10163 -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue38391> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38391] Typo in tutorial code (does not compile)
Change by Xiang Zhang : -- assignee: -> docs@python components: +Documentation -Demos and Tools nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue38391> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34953] Implement `mmap.mmap.__repr__`
Change by Xiang Zhang : -- components: +Extension Modules -Interpreter Core resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 -Python 3.8 ___ Python tracker <https://bugs.python.org/issue34953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34953] Implement `mmap.mmap.__repr__`
Xiang Zhang added the comment: New changeset d8ca2354ed30c12b9ce37c4535222b700a727b32 by Xiang Zhang (Taine Zhao) in branch 'master': bpo-34953: Implement `mmap.mmap.__repr__` (GH-9891) https://github.com/python/cpython/commit/d8ca2354ed30c12b9ce37c4535222b700a727b32 -- ___ Python tracker <https://bugs.python.org/issue34953> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32408] Performance regression in urllib.proxy_bypass_environment
Xiang Zhang added the comment:
I think this issue has already been solved by #39507. The time difference is:
before:
time python3 -c 'import urllib.request;
urllib.request.proxy_bypass_environment("1.1.1.1")'
real0m0.912s
user0m0.902s
sys 0m0.010s
after:
time python3 -c 'import urllib.request;
urllib.request.proxy_bypass_environment("1.1.1.1")'
real0m0.105s
user0m0.086s
sys 0m0.019s
--
nosy: +serhiy.storchaka
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue32408>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32408] Performance regression in urllib.proxy_bypass_environment
Xiang Zhang added the comment: Sorry, it's #39057 -- ___ Python tracker <https://bugs.python.org/issue32408> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39279] Don't allow non-Ascii digits in platform.py
Xiang Zhang added the comment: I can't understand the rational for rejecting localized digits though I don't know who will use them in practise. I'd rather fix it until there is a real problem with it. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue39279> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39279] Don't allow non-Ascii digits in platform.py
Xiang Zhang added the comment: @Ezio, at least for my config they are all ASCII digits. But still I don't think there is any rush to change current behaviour. -- ___ Python tracker <https://bugs.python.org/issue39279> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30434] multiprocessing AuthenticationError "digest sent was rejected"
Change by Xiang Zhang : -- resolution: -> out of date stage: test needed -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue30434> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue34763] Treat U+4E17 as a numeric value
Xiang Zhang added the comment: unicode.org doesn't list "丗" as numeric so I think there is nothing we can do. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34763> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37441] Fix a param error in exceptions.rst
Xiang Zhang added the comment: New changeset aeecf380660ea459d85bb5f59d76bb54f757b5be by Xiang Zhang (Hai Shi) in branch 'master': bpo-37441: Fix wrong PyErr_SetImportErrorSubclass signature in doc (GH-14453) https://github.com/python/cpython/commit/aeecf380660ea459d85bb5f59d76bb54f757b5be -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue37441> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37441] Fix a param error in exceptions.rst
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue37441> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
Xiang Zhang added the comment: Should be TypeError. It's changed from ValueError to TypeError in https://bugs.python.org/issue1831. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a type error in ctypes.rst
Xiang Zhang added the comment: New changeset f6cdd3ff687ebbf8209d793a18a042ea495c4aeb by Xiang Zhang (Hai Shi) in branch 'master': bpo-37513: Change ValueError to TypeError in an example in ctypes doc (GH-14615) https://github.com/python/cpython/commit/f6cdd3ff687ebbf8209d793a18a042ea495c4aeb -- ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37513] Fix a wrong exception type in ctypes documentation
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed title: Fix a type error in ctypes.rst -> Fix a wrong exception type in ctypes documentation versions: +Python 2.7, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue37513> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding a unit test of unicode in test_unicode.py
Change by Xiang Zhang : -- type: -> enhancement versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
Xiang Zhang added the comment: In Py3, you should use `python -m test test_dtrace` to run the test suite. -- nosy: +xiang.zhang resolution: -> not a bug stage: patch review -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37606] Improve test_dtrace.py
Change by Xiang Zhang : -- versions: -Python 3.5 ___ Python tracker <https://bugs.python.org/issue37606> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding a unit test of unicode in test_unicode.py
Xiang Zhang added the comment: New changeset 5623ac87bbe5de481957eca5eeae06347612fbeb by Xiang Zhang (Hai Shi) in branch 'master': bpo-37476: Adding tests for asutf8 and asutf8andsize (GH-14531) https://github.com/python/cpython/commit/5623ac87bbe5de481957eca5eeae06347612fbeb -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37476] Adding tests for PyUnicode_AsUTF8 and PyUnicode_AsUTF8AndSize
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed title: Adding a unit test of unicode in test_unicode.py -> Adding tests for PyUnicode_AsUTF8 and PyUnicode_AsUTF8AndSize ___ Python tracker <https://bugs.python.org/issue37476> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37451] Remove redudant test code in _testcapimodule.c
Change by Xiang Zhang : -- components: +Tests resolution: -> rejected stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python.org/issue37451> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30176] curses attribute constants list is incomplete
Changes by Xiang Zhang : -- stage: patch review -> backport needed ___ Python tracker <http://bugs.python.org/issue30176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30176] curses attribute constants list is incomplete
Changes by Xiang Zhang : -- pull_requests: +2326 ___ Python tracker <http://bugs.python.org/issue30176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30176] curses attribute constants list is incomplete
Changes by Xiang Zhang : -- pull_requests: +2327 ___ Python tracker <http://bugs.python.org/issue30176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30176] curses attribute constants list is incomplete
Xiang Zhang added the comment: New changeset 04521c275e47e4df59046ee0297810f06c208350 by Xiang Zhang in branch '3.5': bpo-30176: Add missing curses cell attributes constants (#2277) https://github.com/python/cpython/commit/04521c275e47e4df59046ee0297810f06c208350 -- ___ Python tracker <http://bugs.python.org/issue30176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30176] curses attribute constants list is incomplete
Xiang Zhang added the comment: New changeset b39a7481ee7e6166d6d2b252a7a514b1f6553dfa by Xiang Zhang in branch '2.7': bpo-30176: Add missing curses cell attributes constants (#2278) https://github.com/python/cpython/commit/b39a7481ee7e6166d6d2b252a7a514b1f6553dfa -- ___ Python tracker <http://bugs.python.org/issue30176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30176] curses attribute constants list is incomplete
Xiang Zhang added the comment: Thanks Mariatta and Serhiy! -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue30176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk
Xiang Zhang added the comment: One question about this function: hosts like "*.foo.com" gets an unambiguous intention, but how about hosts like "*foo.com"? Should it match hosts like barfoo.com, or treat it as a typo and not match? Although the link says "asterisks can be used as wildcards" but I am still not quite sure it's intention. -- ___ Python tracker <http://bugs.python.org/issue30462> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Changes by Xiang Zhang : -- components: Extension Modules nosy: xiang.zhang priority: normal severity: normal stage: patch review status: open title: Py_Decref a borrowed reference in _tracemalloc versions: Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Changes by Xiang Zhang : -- pull_requests: +2806 ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
New submission from Xiang Zhang: New changeset 4ed5ad79ec6c6270e6018bd0a55656305ee60907 by Xiang Zhang in branch 'master': bpo-30961: Fix decrementing a borrowed reference in tracemalloc. (#2747) https://github.com/python/cpython/commit/4ed5ad79ec6c6270e6018bd0a55656305ee60907 -- ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Changes by Xiang Zhang : -- pull_requests: +2807 ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Changes by Xiang Zhang : -- pull_requests: +2808 ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Xiang Zhang added the comment: New changeset 241c4a28d9fec7f2beffc9cbd21f15659a9d by Xiang Zhang in branch '3.6': bpo-30961: Fix decrementing a borrowed reference in tracemalloc. (#2747) (#2748) https://github.com/python/cpython/commit/241c4a28d9fec7f2beffc9cbd21f15659a9d -- ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Xiang Zhang added the comment: New changeset cb3f024f3ac91e468d581f0682e63685c977c80d by Xiang Zhang in branch '3.5': bpo-30961: Fix decrementing a borrowed reference in tracemalloc. (#2747) (#2749) https://github.com/python/cpython/commit/cb3f024f3ac91e468d581f0682e63685c977c80d -- ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30961] Py_Decref a borrowed reference in _tracemalloc
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue30961> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30966] multiprocessing.queues.SimpleQueue leaks 2 fds
Xiang Zhang added the comment: Get this solved then we could also solve #23267, which reports pipes leak in pool due to using SimpleQueue. -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue30966> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23267] multiprocessing pool.py doesn't close inqueue and outqueue pipes on termination
Changes by Xiang Zhang : -- dependencies: +multiprocessing.queues.SimpleQueue leaks 2 fds ___ Python tracker <http://bugs.python.org/issue23267> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29456] bugs in unicodedata.normalize: u1176, u11a7 and u11c3
Changes by Xiang Zhang : Removed file: http://bugs.python.org/file47070/800.jpg ___ Python tracker <http://bugs.python.org/issue29456> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29456] bugs in unicodedata.normalize: u1176, u11a7 and u11c3
Xiang Zhang added the comment: Hi Wonsup, sorry for the delay. I get really busy with my work these days. If no one get involved I'd try to find time reviewing your patch this week. -- ___ Python tracker <http://bugs.python.org/issue29456> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31282] C APIs called without GIL in PyOS_Readline
New submission from Xiang Zhang: When debugging our project I find something interesting. In PyOS_Readline it releases the GIL and delegate its job to PyOS_ReadlineFunctionPointer, which could be call_readline or PyOS_StdioReadline(I don't find where vms__StdioReadline is defined). But in the two functions, they use some C APIs like PyMem_Malloc/MALLOC, PyErr_SetString which need guarded by GIL. I don't understand why not doing find-grained lock control in call_readline or PyOS_StdioReadline since the code is ancient. :-( I find this because our project makes test_cmd_line fail with `echo "Timer\n" | python -i -m timeit -n 1`. -- components: Interpreter Core messages: 300862 nosy: xiang.zhang priority: normal severity: normal status: open title: C APIs called without GIL in PyOS_Readline type: behavior versions: Python 2.7 ___ Python tracker <http://bugs.python.org/issue31282> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31282] C APIs called without GIL in PyOS_Readline
Changes by Xiang Zhang : -- stage: -> needs patch versions: +Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issue31282> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31282] C APIs called without GIL in PyOS_Readline
Xiang Zhang added the comment: In pymem.h, it's stated that "The GIL must be held when using these APIs". I think the reason is when PYMALLOC_DEBUG is defined, they finally delegate to PyObject_Malloc. Victor must be familiar with them since once he proposed to remote the restriction: https://mail.python.org/pipermail/python-dev/2013-June/126822.html. -- ___ Python tracker <http://bugs.python.org/issue31282> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31282] C APIs called without GIL in PyOS_Readline
Xiang Zhang added the comment: >>> I fixed Python 3, no? Yes. In Python3 they are replaced by PyMem_RawMalloc. But it's not only PyMem_Malloc, there are also PyErr_SetString, PyErr_NoMemory, even in Python3. BTW, even in Python3, when memory allocators are in debug mode, it finally calls bumpserialno, which IIUC, is not thread safe. But of course it's another issue. >>> For Python 2, in practice you can call PyMem_Malloc() without holding the >>> GIL, it's just malloc() which is thread safe. Hmm, I know it. But it's not stated in the doc they are thread safe, I am not sure assuming this is suitable. An example is https://github.com/psycopg/psycopg2/issues/110. -- ___ Python tracker <http://bugs.python.org/issue31282> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31379] run_profile_task in Makefile should add $(RUNSHARED)
New submission from Xiang Zhang: Build Python 2.7 with --enable-shared and pgo could highly possibly skip test procedure due to dynamic link fails. I suggest adding $(RUNSHARED) to bring convenience. Python 3 already gets it. -- components: Build keywords: easy messages: 301578 nosy: xiang.zhang priority: normal severity: normal stage: needs patch status: open title: run_profile_task in Makefile should add $(RUNSHARED) versions: Python 2.7 ___ Python tracker <http://bugs.python.org/issue31379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31379] run_profile_task in Makefile should add $(RUNSHARED)
Changes by Xiang Zhang : -- pull_requests: +3419 ___ Python tracker <http://bugs.python.org/issue31379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31379] run_profile_task in Makefile should add $(RUNSHARED)
Xiang Zhang added the comment: New changeset 7dcea4c8769e4f12197646922f399a699c3e2a5a by Xiang Zhang in branch '2.7': bpo-31379: Added $(RUNSHARED) to run_profile_task (#3422) https://github.com/python/cpython/commit/7dcea4c8769e4f12197646922f399a699c3e2a5a -- ___ Python tracker <https://bugs.python.org/issue31379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31379] run_profile_task in Makefile should add $(RUNSHARED)
Changes by Xiang Zhang : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue31379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31440] wrong default module search path in help message
New submission from Xiang Zhang: In python --help: PYTHONHOME : alternate directory (or :). The default module search path uses /pythonX.X. I think the default module search path should be /lib/pythonX.X. -- keywords: easy messages: 302032 nosy: xiang.zhang priority: normal severity: normal stage: needs patch status: open title: wrong default module search path in help message versions: Python 2.7, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue31440> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31451] PYTHONHOME is not absolutized
New submission from Xiang Zhang: I find that PYTHONHOME is not absolutized even after VM initialization. So sys.prefix will be "usr" if I execute `PYTHONHOME=usr python`. This could lead to libraries like pip to fail if the current directory is changed, such as by `os.chdir`. I am not sure this is a bug. But I see PYTHONPATH is absolutized in site.py. Maybe PYTHONHOME should be too? Or it's by design. -- messages: 302077 nosy: xiang.zhang priority: normal severity: normal status: open title: PYTHONHOME is not absolutized type: behavior versions: Python 2.7, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue31451> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30246] fix several error messages in struct
Xiang Zhang added the comment: New changeset c3e97d9d984130d1c2aceedc4dfcd603b3162688 by Xiang Zhang in branch 'master': bpo-30246: fix several error messages which only mention bytes in struct (#1421) https://github.com/python/cpython/commit/c3e97d9d984130d1c2aceedc4dfcd603b3162688 -- ___ Python tracker <https://bugs.python.org/issue30246> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30246] fix several error messages in struct
Changes by Xiang Zhang : -- keywords: +patch pull_requests: +3552 ___ Python tracker <https://bugs.python.org/issue30246> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30246] fix several error messages in struct
Xiang Zhang added the comment: New changeset fa82dda1012b406a7091587fc65384ce11528346 by Xiang Zhang in branch '3.6': [3.6] bpo-30246: fix several error messages which only mention bytes in struct (#3561) https://github.com/python/cpython/commit/fa82dda1012b406a7091587fc65384ce11528346 -- ___ Python tracker <https://bugs.python.org/issue30246> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30246] fix several error messages in struct
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker <https://bugs.python.org/issue30246> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19985] Not so correct error message when initializing Struct with ill argument
Changes by Xiang Zhang : -- dependencies: +fix several error messages in struct -Document whether it's safe to use bytes for struct format string resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue19985> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19985] Not so correct error message when initializing Struct with ill argument
Changes by Xiang Zhang : -- versions: +Python 3.6, Python 3.7 -Python 3.3, Python 3.4 ___ Python tracker <https://bugs.python.org/issue19985> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31473] PyMem_Raw* API in debug mode are not thread safe
New submission from Xiang Zhang: PyMem_Raw* APIs should be thread safe. But in debug mode, they are not that simple and increment a global variable *serialno* and the incrementing action is not thread safe. -- components: Interpreter Core messages: 302187 nosy: haypo, xiang.zhang priority: normal severity: normal stage: needs patch status: open title: PyMem_Raw* API in debug mode are not thread safe type: behavior versions: Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue31473> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31440] wrong default module search path in help message
Xiang Zhang added the comment: Not sure about Windows. _get_path() looks to me is used for user site-packages. getsitepackages() doesn't do the same and seems matching the current message, also the OS2 branch in py2. Let's consult Windows guys. -- nosy: +eryksun, gauravbackback, steve.dower, zach.ware ___ Python tracker <https://bugs.python.org/issue31440> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31484] Cache single-character strings outside of the Latin1 range
Xiang Zhang added the comment: I run the patch against a toy NLP application, cutting words from Shui Hu Zhuan provided by Serhiy. The result is not bad, 6% faster. And I also count the hit rate, 90% hit cell 0， 4.5 hit cell 1, 5.5% miss. I also increase the cache size to 1024 * 2. Although the hit rate increases to 95.4%, 2.1%, 2.4%, it's still 6% difference. So IMHO this patch could hardly affect that *much* real-world applications, better or worse. I couldn't recall clearly the implementation of unicode but why can't we reuse the latin1 cache when we use this bmp cache? And then to avoid the chars' low bits conflicting with ASCII chars' low bits we have to introduce the mini-LRU-cache, which is not that easily understandable. -- ___ Python tracker <https://bugs.python.org/issue31484> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33106] Deleting a key in a read-only gdbm results in KeyError, not gdbm.error
Xiang Zhang added the comment: New changeset 4fb0b8bc25c52aae8dcb4353e69c1c88999a9a53 by Xiang Zhang in branch 'master': bpo-33106: change dbm key deletion error for readonly file from KeyError to dbm.error (#6295) https://github.com/python/cpython/commit/4fb0b8bc25c52aae8dcb4353e69c1c88999a9a53 -- ___ Python tracker <https://bugs.python.org/issue33106> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33106] Deleting a key in a read-only gdbm results in KeyError, not gdbm.error
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: behavior -> enhancement ___ Python tracker <https://bugs.python.org/issue33106> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35470] A deadly decref in _PyImport_FindExtensionObjectEx()
Xiang Zhang added the comment: What about version 3.6? -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue35470> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35517] selector.EpollSelector: add new parameter to support EPOLLEXCLUSIVE
Xiang Zhang added the comment: > I don't think to make selector be a public property is a good idea. It will > break the whole system integrity. If exposing a private property is not a good idea, another choice may be construct a selector with a customized I/O multiplexer, adding an optional parameter to the __init__. But actually I'm -1 to this change. `selectors` makes underlying implementations irrelavant to most users since we can simply use `DefaultSelector`(maybe why only read/write events are valid now?). But you are seeking to add implementation specific details back. If you know you want to add EPOLL_EXCLUSIVE, why not just use `select.epoll`? A single selector doesn't do much more than the underlying multiplexer. -- nosy: +xiang.zhang ___ Python tracker <https://bugs.python.org/issue35517> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Change by Xiang Zhang : -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python, xiang.zhang versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Xiang Zhang added the comment: New changeset 92330c0b6d6c253c41a133cc50caea4853c7e311 by Xiang Zhang (Manjusaka) in branch 'master': bpo-35497: add versionadded tag for EPOLLEXCLUSIVE (GH-11162) https://github.com/python/cpython/commit/92330c0b6d6c253c41a133cc50caea4853c7e311 -- ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue35497] Libary select docs enhance
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35497> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24329] __qualname__ and __slots__
Changes by Xiang Zhang : -- pull_requests: +405 ___ Python tracker <http://bugs.python.org/issue24329> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24329] __qualname__ and __slots__
Xiang Zhang added the comment: PR made. :-) -- ___ Python tracker <http://bugs.python.org/issue24329> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29657] os.symlink: FileExistsError shows wrong message
Xiang Zhang added the comment: I agree with Eryk. The error message is misleading. When I see it, I take it as source -> destination. I think we should make the error message clearer, or document it in the OSError documentation. -- ___ Python tracker <http://bugs.python.org/issue29657> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29714] can't interpolate byte string with \x00 before replacement identifier
Xiang Zhang added the comment: The problem is now _PyBytes_FormatEx uses strchr to sniff %. It should use memchr instead. -- assignee: -> xiang.zhang nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29714] can't interpolate byte string with \x00 before replacement identifier
Changes by Xiang Zhang : -- pull_requests: +407 ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc
Changes by Xiang Zhang : -- pull_requests: +411 ___ Python tracker <http://bugs.python.org/issue26915> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29714] can't interpolate byte string with \x00 before replacement identifier
Changes by Xiang Zhang : -- pull_requests: +412 ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29714] can't interpolate byte string with \x00 before replacement identifier
Xiang Zhang added the comment: Thanks for the report, Nick! -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29714] can't interpolate byte string with \x00 before replacement identifier
Xiang Zhang added the comment: I think no. String is not affected now and its code uses related macros so I don't think it could suffer possible regression. -- ___ Python tracker <http://bugs.python.org/issue29714> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29700] readline memory corruption when sys.stdin fd >= FD_SETSIZE for select()
Changes by Xiang Zhang : -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29700> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27577] Make implementation and doc of tuple and list more compliant
Xiang Zhang added the comment: This issue doesn't make any sense once #29695 is applied. So close. -- resolution: -> fixed stage: -> resolved ___ Python tracker <http://bugs.python.org/issue27577> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27577] Make implementation and doc of tuple and list more compliant
Changes by Xiang Zhang : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue27577> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28728] test_host_resolution in test_socket fails
Changes by Xiang Zhang : -- pull_requests: +440 ___ Python tracker <http://bugs.python.org/issue28728> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29739] zipfile raises wrong exception for some incorrect passwords
Changes by Xiang Zhang : -- nosy: +serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29739> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29744] memmap behavior changed
Changes by Xiang Zhang : -- stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29744> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28728] test_host_resolution in test_socket fails
Changes by Xiang Zhang : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue28728> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28856] %b format for bytes does not support objects that follow the buffer protocol
Changes by Xiang Zhang : -- components: +Interpreter Core stage: test needed -> patch review versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issue28856> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28856] %b format for bytes does not support objects that follow the buffer protocol
Changes by Xiang Zhang : -- pull_requests: +449 ___ Python tracker <http://bugs.python.org/issue28856> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28856] %b format for bytes does not support objects that follow the buffer protocol
Xiang Zhang added the comment: Isn't this a discussed behaviour that is explicitly documented in PEP 461? -- ___ Python tracker <http://bugs.python.org/issue28856> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc
Changes by Xiang Zhang : -- pull_requests: +454 ___ Python tracker <http://bugs.python.org/issue26915> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24329] __qualname__ and __slots__
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue24329> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26915] Test identity first in membership operation of ItemsView, ValuesView and Sequence in collections.abc
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue26915> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29568] undefined parsing behavior with the old style string formatting
Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29568> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29619] st_ino (unsigned long long) is casted to long long in posixmodule.c:_pystat_fromstructstat
Xiang Zhang added the comment: Any reason our _Py_stat_struct on Windows uses a signed type to represent st_ino? -- nosy: +eryksun, steve.dower ___ Python tracker <http://bugs.python.org/issue29619> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29758] Previously-working SWIG code fails in Python 3.6
Changes by Xiang Zhang : -- nosy: +haypo, serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue29758> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29756] Improve documentation for list methods that compare items by equality
Xiang Zhang added the comment: +1 for jsoh. Actually the behaviour is documented in https://docs.python.org/3/reference/expressions.html#value-comparisons. So a single 'a is b' or 'a == b' is not complete. I would like to use 'equal to' which implies 'a is b or a == b'. -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29756] Improve documentation for list methods that compare items by equality
Changes by Xiang Zhang : -- pull_requests: +468 ___ Python tracker <http://bugs.python.org/issue29756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29759] Deadlock in multiprocessing.pool.Pool on terminate
Changes by Xiang Zhang : -- nosy: +davin versions: -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issue29759> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29764] PyUnicode_Decode with encoding utf8 crashes
Xiang Zhang added the comment: You need to first call `Py_Initialize()` to initialize the Python interpreter. It is required. -- nosy: +xiang.zhang resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29764> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29767] build python failed on test_socket due to unused_port is actually used.
Xiang Zhang added the comment: Could you show the failure message here? And you could make your patch a PR on GitHub. -- nosy: +xiang.zhang ___ Python tracker <http://bugs.python.org/issue29767> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
