[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid
New submission from William Gianopoulos: So, the arguments to run_process are not escaped when logged such that the logged command is un-parsable. The following call: self.run_process(['notify-send', '--app-name', 'Mozilla Build System', 'Mozilla Build System', msg]) where msg='Build complete' ends up logging the following: /usr/bin/notify-send --app-name Mozilla Build System Mozilla Build System Build complete Where to be a valid command it needs to be: /usr/bin/notify-send --app-name 'Mozilla Build System' 'Mozilla Build System' 'Build complete' So, I think this needs to either not log the command at all or for each parameter replace any occurrence of the character "'" with "\'" and then enclose the entire parameter with "'" to make sure the logged command can actually be properly parsed. -- components: Library (Lib) messages: 284498 nosy: wgianopoulos priority: normal severity: normal status: open title: run_proces logs the command without escaping parmaeters such that the coammns logged are not valid versions: Python 3.7 ___ Python tracker <http://bugs.python.org/issue29135> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid
William Gianopoulos added the comment: well i could be screwed up perhaps it is something provided in the mozilla python environment i was going by the fact that google searches on python run-process returned things, including other reported issues, that made me think it was not. On Mon, Jan 2, 2017 at 4:02 PM, R. David Murray wrote: > > R. David Murray added the comment: > > What is run_process? I'm not getting any hits from grep on the standard > library. > > -- > nosy: +r.david.murray > > ___ > Python tracker > <http://bugs.python.org/issue29135> > ___ > -- ___ Python tracker <http://bugs.python.org/issue29135> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid
William Gianopoulos added the comment: OK i t appears it might be a third party python utility library. I will try to trak this down and report it there and close this issue once i sort it out. On Mon, Jan 2, 2017 at 4:07 PM, William Gianopoulos wrote: > > William Gianopoulos added the comment: > > well i could be screwed up perhaps it is something provided in the mozilla > python environment i was going by the fact that google searches on python > run-process returned things, including other reported issues, that made me > think it was not. > > On Mon, Jan 2, 2017 at 4:02 PM, R. David Murray > wrote: > > > > > R. David Murray added the comment: > > > > What is run_process? I'm not getting any hits from grep on the standard > > library. > > > > -- > > nosy: +r.david.murray > > > > ___ > > Python tracker > > <http://bugs.python.org/issue29135> > > ___ > > > > -- > > ___ > Python tracker > <http://bugs.python.org/issue29135> > ___ > -- ___ Python tracker <http://bugs.python.org/issue29135> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid
William Gianopoulos added the comment: I would like to keep this open until I figure this out so I can provide a pointer to where the real issue is being tracked. I should have time to do that tomorrow. SOunds like this is part of some third-party add-on python library that is normally provided with linux builds. -- ___ Python tracker <http://bugs.python.org/issue29135> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29135] run_proces logs the command without escaping parmaeters such that the coammns logged are not valid
William Gianopoulos added the comment: It seems it is part of the Mozilla build system. I closed this issue. -- resolution: -> not a bug status: open -> closed ___ Python tracker <http://bugs.python.org/issue29135> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
