[issue31739] socket.close recommended but not demonstrated in same-page example code
Change by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <https://bugs.python.org/issue31739> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5124] IDLE - pasting text doesn't delete selection
Todd Rovito added the comment: "What is standard in other linex and mac apps?" -On Mac OS X 10.8.3 TextEdit I get the replacement behavior -On Linux CentOS 6.4 gedit I get the replacement behavior -On IDLE under the latest 3.4 pull I get the replacement behavior with Max OS X 10.8.3 -On IDLE under the latest 3.4 pull I get the eggsspam behavior with Linux CentOS 6.4 as Weeble described in the original bug report So from my perspective Linux is behaving differently than Windows and Mac OS X. -- ___ Python tracker <http://bugs.python.org/issue5124> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Ping!!! I have not heard anything about this patch so I wanted to ping it to get more feedback. Thanks! -- ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17511] Idle find function closes after each find operation
Todd Rovito added the comment: I was wondering does it make sense to commit this patch since it is similar to http://bugs.python.org/issue14146 then put the issue in the pending state as we wait for the TK/TCL fix? It seems more consistent to me since this issue is basically the same highlight problem as 14146. I imagine this is very bothersome for Windows users. -- ___ Python tracker <http://bugs.python.org/issue17511> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5124] IDLE - pasting text doesn't delete selection
Todd Rovito added the comment: I haver verified Roger's patch does indeed fix the problem on Linux CentOS 6.4 with IDLE 3.4. The Linux situation is complex. Basically as I see it over the years pure X11 applications are becoming extinct and most developers either use GTK (for GNOME) or QT (for KDE). I don't blame anybody for moving to one of these toolkits because writing a pure X11 application is painful. In the near future Wayland http://en.wikipedia.org/wiki/Wayland_(display_server_protocol) will take over and I wonder how many X11 applications will actually be ported. I agree with Roger we should try and make IDLE as consistent as possible across operating systems. +1 for applying the patch. -- ___ Python tracker <http://bugs.python.org/issue5124> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15392] Create a unittest framework for IDLE
Todd Rovito added the comment: Patch does indeed apply and I get good results! The patch is well done and provides a nice example on how to write unit tests. +1 for making the commit from me R. David Murray you used the patch command while I used "hg import --no-commit mywork.patch" as specified in the Python Developers Guide. Next time I have an issue I will use patch and see if it works better. -- ___ Python tracker <http://bugs.python.org/issue15392> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2053] IDLE - standardize dialogs
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue2053> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7136] Idle File Menu Option Improvement
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue7136> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7136] Idle File Menu Option Improvement
Todd Rovito added the comment: Roger's patch works but the documentation has changed since he made the patch back in 2011. So I patched the patch and hope this very simple patch will get committed. I will work on a patch for 2.7 next. Today I was teaching a student on how to use Python with IDLE and the student found the existing menu option confusing. I was thrilled a patch already existed and it just needed updated. Thanks! -- versions: +Python 3.4 -Python 3.2 Added file: http://bugs.python.org/file30418/7136FileMenuConfusionV23point4.patch ___ Python tracker <http://bugs.python.org/issue7136> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7136] Idle File Menu Option Improvement
Todd Rovito added the comment: Same patch but for Python 2.7.5. I just updated the documentation from Roger's excellent patch. -- versions: +Python 2.7 Added file: http://bugs.python.org/file30419/7136FileMenuConfusionV22point7.patch ___ Python tracker <http://bugs.python.org/issue7136> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18103] Create a GUI test framework for Idle
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18103> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18104] Idle: make human-mediated GUI tests usable
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18104> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18189] IDLE Improvements: Unit test for Delegator.py
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18189> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18189] IDLE Improvements: Unit test for Delegator.py
Changes by Todd Rovito : -- nosy: +philwebster ___ Python tracker <http://bugs.python.org/issue18189> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18189] IDLE Improvements: Unit test for Delegator.py
Changes by Todd Rovito : -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue18189> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18226] IDLE Unit test for FormatParagrah.py
Changes by Todd Rovito : -- nosy: +JayKrish ___ Python tracker <http://bugs.python.org/issue18226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18226] IDLE Unit test for FormatParagrah.py
New submission from Todd Rovito: Continuing the IDLE unittest framework initiated in http://bugs.python.org/issue15392. A small unit test for IDLE FormatParagraph.py. This patch introduces a test module named test_format_paragraph.py inside Lib/idlelib/idle_test, considering the guidance in README file from idle_test. I should have a patch uploaded by Monday 6/17/2013 night. -- messages: 191242 nosy: Todd.Rovito, philwebster, terry.reedy priority: normal severity: normal status: open title: IDLE Unit test for FormatParagrah.py type: enhancement versions: Python 2.7, Python 3.4 ___ Python tracker <http://bugs.python.org/issue18226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7136] Idle File Menu Option Improvement
Todd Rovito added the comment: PING It has been a month since Roger's last comment on the patch looking good, can somebody please commit or post feedback. Thanks. -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue7136> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13582] IDLE and pythonw.exe stderr problem
Todd Rovito added the comment:
Yes I have a Mac and I am glad to help, so I gave it a test run tonight. The
first thing I did was apply the patch then I ran idle from the console like so:
./python.exe Lib/idlelib/idle.py
For testing I used a simple print command to print to stderr:
sys.stderr.write("spam/n")
which I got the output of
spam/n6
I also tried to use the newer print function:
print("fatal error", file=sys.stderr)
Python 3.4 on the Mac behaved exactly the same way with or without the patch.
I got the stderr output in the Python shell and nothing appeared in the
console. With the patch applied I saw no dialog box to capture the stderr
output. Maybe I didn't perform the test correctly?
Another thing to consider is for Mac IDLE runs in a special mode via
macosxSupport.py which I turn on by forcing runningAsOSXApp() to always return
True. Even after setting runningAsOSXApp() to true a dialog box does not
appear when writing to stderr.
Maybe I am not testing this patch correctly? Let me know if I can do anything
else to help, thanks.
--
___
Python tracker
<http://bugs.python.org/issue13582>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18226] IDLE Unit test for FormatParagrah.py
Todd Rovito added the comment: Here is a uncompleted patch but works for the most part. I thought I would post just in case somebody wanted to provide me comments on the general direction of the patch. The naming might have to change but this follows Terry Reedy's model of monkey patching. -- keywords: +patch Added file: http://bugs.python.org/file30743/18226IDLEUnitTestFormatParagraph.patch ___ Python tracker <http://bugs.python.org/issue18226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18292] IDLE Improvements: Unit test for AutoExpand.py
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18292> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7136] Idle File Menu Option Improvement
Todd Rovito added the comment: Terry I am sorry the push didn't go smooth. I thought I had checked the patch with 2.7 and 3.4 and it applied for me but maybe I missed something? For sure I didn't check 3.3 but from here on out I will. Awhile ago I worked on a issue to synchronize the documentation here: http://bugs.python.org/issue5066 Mr. Andrew Svetlov was kind enough to push the patch but he only pushed it for 3.4 which I am not sure why? Then Zachary Ware had the excellent suggestion of making the help.txt generate from the rst file http://bugs.python.org/issue16893. So with all that being said I am confused about the direction of IDLE documentation. Maybe we should reopen issue 5066 or create a new issue to sync help.txt and idle.rst across all version from 2.7 - 3.4? Then apply Zachary's patch to automate the creation of help.txt. -- ___ Python tracker <http://bugs.python.org/issue7136> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18226] IDLE Unit test for FormatParagrah.py
Todd Rovito added the comment: Terry, Thank you for the feedback this helps me alot! I will work with Phil Webster and will use his Text Widget and EditorWindow classes. Hopefully this will help us converge on a strong unit test for FormatParagraph.py. Thanks for the reminder about triple quoted strings I think your idea to make sure those strings are in place now is excellent. -- ___ Python tracker <http://bugs.python.org/issue18226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15661] OS X installer packages should be signed for OS X 10.8 Gatekeeper feature
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue15661> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13582] IDLE and pythonw.exe stderr problem
Todd Rovito added the comment:
Terry,
Bottom line I can't seem to get this patch to do anything for me. Before
the patch is applied IDLE seems to be handling warnings and exceptions just
fine in PyShell on the Mac. I get no crash and the output matches the normal
console. Here is a small test program I wrote:
import warnings
def fxn():
# user warnings are not ignored by default and will cause a dump of
information
# to standard error.
warnings.warn("User warning: Warn on purpose for IDLE", UserWarning)
if __name__ == "__main__":
fxn()
print("the program should not terminate with the warning, but keep on
running")
a = 10 * 1000
print(a)
# exception testing each of these will stop the program
# divide by zero
b = 10 * (1/0)
print(b)
# variable not defined
c = 4 + spam*3
print(c)
# can't convert 'int' object o str implicitly
d = '2' + 2
print(d)
Then I wanted to make sure I was executing the patched code so I made sure I
called idle.pyw (normally I wouldn't do that I would use idle.py). After I
called the correct script I changed the code to force std error to ErrorNotify
class around line 101:
import sys
##if 0: # For testing
##sys.__stderr__ = None
##sys.stderr = None
if sys.__stderr__ is None:
sys.__stderr__ = ErrorNotify()
if sys.stderr is None:
sys.stderr = ErrorNotify()
if sys.__stdout__ is None:
sys.__stdout__ = ErrorNotify(devnull=True)
if sys.stdout is None:
sys.stdout = ErrorNotify(devnull=True)
sys.__stderr__ = ErrorNotify()
sys.stderr = ErrorNotify()
I would expect after this code runs any message sent to stderr would go through
the ErrorNotify class and a widget should appear with the stderr output. Even
after this change I can't get the error widget to appear. I have not given up
yet but I wanted to provide a status update.
--
___
Python tracker
<http://bugs.python.org/issue13582>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18425] IDLE Unit test for IdleHistory.py
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18425> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18429] IDLE: Format Paragraph doesn't function with comment blocks
New submission from Todd Rovito: While working on a test case for Format Paragraph (http://bugs.python.org/issue18226) I noted that format paragraph doesn't work with comment blocks when a comment block is selected. The fix is very simple by changing one line: if first and last: data = text.get(first, last) comment_header = get_comment_header(data) else: The comment_header line was changed from comment_header = ''. This forces the format paragraph extension to always do "just a normal text format". Attached is a patch but I would like to explore the bug in more detail and make sure all cases are covered. -- messages: 192883 nosy: Todd.Rovito priority: normal severity: normal status: open title: IDLE: Format Paragraph doesn't function with comment blocks type: behavior versions: Python 3.4 ___ Python tracker <http://bugs.python.org/issue18429> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18429] IDLE: Format Paragraph doesn't function with comment blocks
Changes by Todd Rovito : -- keywords: +patch nosy: +JayKrish, philwebster, roger.serwy, terry.reedy Added file: http://bugs.python.org/file30891/18429FormatParagraphFor3.4.patch ___ Python tracker <http://bugs.python.org/issue18429> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18429] IDLE: Format Paragraph doesn't function with comment blocks
Todd Rovito added the comment: Terry, I was suffering from the classic chicken and egg problem so I was not sure if the test case in http://bugs.python.org/issue18226 should include the small code change. I will work with Phil Webster to get this small change added to issue 18226 along with test cases. Thanks! -- resolution: -> duplicate status: open -> closed ___ Python tracker <http://bugs.python.org/issue18429> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18279] IDLE Unit test for RstripExtension.py
Todd Rovito added the comment: As a suggestion I always use the command "make patchcheck" (before making the patch) which catches the white space and tab problem plus it fixes other things. Here is more information on patch check in the developer's guide. http://docs.python.org/devguide/committing.html#patch-checklist -- ___ Python tracker <http://bugs.python.org/issue18279> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17721] Help button on preference window doesn't work
Todd Rovito added the comment: This patch LGTM as well. I think it should be committed ASAP because the button clearly doesn't work as it is programmed now. -- ___ Python tracker <http://bugs.python.org/issue17721> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18444] IDLE: Mac OS X pressing ctrl-A in Python shell moved cursor before the prompt, which then makes the keyboard unresponsive.
New submission from Todd Rovito: covers point 1.1) "Pressing the Home key moves the cursor before the >>> prompt, which then makes the keyboard unresponsive." This issues was fixed on Windows XP and Linux here http://bugs.python.org/issue3851 On Mac OS X the "home" key is control-A or function left arrow both have the same effect of moving the cursor left of prompt, which them makes the keyboard unresponsive. I tested this with Python 3.4 and Python 2.7 on Mac OS X 10.8.4. -- components: IDLE messages: 193025 nosy: Todd.Rovito, roger.serwy, terry.reedy priority: normal severity: normal status: open title: IDLE: Mac OS X pressing ctrl-A in Python shell moved cursor before the prompt, which then makes the keyboard unresponsive. versions: Python 2.7, Python 3.4 ___ Python tracker <http://bugs.python.org/issue18444> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13504] Meta-issue for "Invent with Python" IDLE feedback
Todd Rovito added the comment: 1.1) "Pressing the Home key moves the cursor before the >>> prompt, which then makes the keyboard unresponsive." This issue is still broken on Mac OS X. http://bugs.python.org/issue18444 -- ___ Python tracker <http://bugs.python.org/issue13504> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18444] IDLE: Mac OS X pressing ctrl-A in Python shell moved cursor before the prompt, which then makes the keyboard unresponsive.
Todd Rovito added the comment: Ned, Thanks for such a thorough comment this saved me lots of time now I don't have to dig so deeply into the problem. "After spending some time trying to understand how this all works or doesn't across the various Tk's, I am coming to the conclusion that we need to define a new set of default key bindings for OS X, one that generally avoids as much as possible the use of Command key and Option key accelerators, as these tend to be especially problematic either in Tk or with system conflicts, and, instead, use Fn keys for non-trivial accelerators." I like your purposed solution so I will look into trying to creat a new key binding for OS X. -- ___ Python tracker <http://bugs.python.org/issue18444> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18441> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Todd Rovito : -- nosy: +JayKrish ___ Python tracker <http://bugs.python.org/issue18441> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18441] Idle: Make test.support.requires('gui') skip when it should.
Changes by Todd Rovito : -- nosy: +philwebster ___ Python tracker <http://bugs.python.org/issue18441> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18583] Idle: enhance FormatParagraph
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue18583> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18704] IDLE: PEP8 Style Check Integration
Todd Rovito added the comment: Ezio, I think modern editors are expected to have this sort of functionality built into them [1]. XCode is simply amazing where it will pop up errors and quote the C99 standard [2]. We don't expect IDLE to have all that functionality but it seemed to us like it would be great to add pep8 or PyFlakes to IDLE. It is possible we could create an extension but that would void Python's motto "batteries included". In addition tools like pep8 and PyFlakes could be useful for other purposes as well. JayKrish is checking with the authors of pep8 about license issues. As always we will defer to the judgement of Core Developers and could pursue either option. [1] Wikipeida Microsoft Visual Studio, http://en.wikipedia.org/wiki/Microsoft_Visual_Studio#Code_editor [2] XCode, http://en.wikipedia.org/wiki/XCode -- status: pending -> open ___ Python tracker <http://bugs.python.org/issue18704> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18704] IDLE: PEP8 Style Check Integration
Todd Rovito added the comment: Raymond, Would you prefer PyFlakes instead? Try to consider IDLE being for beginners so they need all the help they can get. Advanced users can always turn the extension off. Thanks for your input. -- ___ Python tracker <http://bugs.python.org/issue18704> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18704] IDLE: PEP8 Style Check Integration
Changes by Todd Rovito : -- nosy: +terry.reedy ___ Python tracker <http://bugs.python.org/issue18704> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9583] Document startup option/environment interaction
Todd Rovito added the comment: Applies to Python 3.4 in development and Python 2.7. I recently ran into a similar conflict where I was overriding a environment variable with a command line option and didn't realize it. I first checked the documentation and noticed that it was not clear. Then I found this bug report and made a patch which is attached. The patch iterates what Terry Reedy suggested which I thought made the documentation clearer. This is my first patch to Python I hope it is helpful as Python has served me well over the years. -- keywords: +patch nosy: +Todd.Rovito versions: +Python 3.4 -Python 3.1, Python 3.2 Added file: http://bugs.python.org/file27588/EnvironmentVariables.patch ___ Python tracker <http://bugs.python.org/issue9583> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Todd Rovito added the comment: For Python 3.4 attached is a patch as suggested by Raymond Hettinger. My suggestion is to put the patch in Doc/reference/datamodel.rst because if a user searches google.com for __len__ this is the first link in the list. I think this extra information is a valuable addition to the documentation. -- keywords: +patch nosy: +Todd.Rovito versions: +Python 3.4 Added file: http://bugs.python.org/file27589/DataModel__len__.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9583] Document startup option/environment interaction
Todd Rovito added the comment: After another review I decided to submit a newer patch that uses a comma so I think the documentation flows better. -- type: -> enhancement Added file: http://bugs.python.org/file27590/EnvironmentVariables.patch ___ Python tracker <http://bugs.python.org/issue9583> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12913] Add a debugging howto
Todd Rovito added the comment: I think this is an excellent idea. How about putting in some advanced debugging with IDLE? For example I have read somewhere that IDLE lets you set break points but the documentation for IDLE OS not that clear on debugging. -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue12913> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27589/DataModel__len__.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Todd Rovito added the comment: New patch with a better reference to the source for the test case. This was suggested by PythonMentors list. I think the patch improves the documentation. This works on Python 3.4. -- Added file: http://bugs.python.org/file27605/DataModel__len__.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] Right Click Context Menu
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10405] IDLE breakpoint facility undocumented
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue10405> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13884] IDLE 2.6.5 Recent Files undocks
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue13884> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13504] Meta-issue for "Invent with Python" IDLE feedback
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue13504> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13884] IDLE: Remove tear-off menu feature
Todd Rovito added the comment: Terry, I would not miss the feature at all this is very old school Unix like and most people find it confusing. At my job I tend to provide Python support to my co-workers and have had many questions about it. In addition I think #13504 meta issue provides even more evidence that removing the tear off menus would be a good thing. Something to consider with IDLE is it is often the first thing a user sees when using Python and first impressions count in most circumstances. IDLE could be much improved and Roger Serwy has a good start on improvements with his IdleX project. Thanks for the review and I for one would appreciate this patch getting committed. -- ___ Python tracker <http://bugs.python.org/issue13884> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: I used taleinat's patch as the start for a patch that works with 3.4. Lots of code was changed from 2010 to 2012 so I basically hand merged the patch into 3.4. This patch was tested with Python 3.4.0a0 on both Mac OS X and Linux. As suggested by taleinat and Guilherme the shortcuts keys are not included in the context menu. -- Added file: http://bugs.python.org/file27614/RightClickContextMenuUpdatedFor3point4.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27614/RightClickContextMenuUpdatedFor3point4.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: This time I ran make patchcheck on the patch and it corrected a single white space. I used taleinat's patch as the start for a patch that works with 3.4. Lots of code was changed from 2010 to 2012 so I basically hand merged the patch into 3.4. This patch was tested with Python 3.4.0a0 on both Mac OS X and Linux. As suggested by taleinat and Guilherme the shortcuts keys are not included in the context menu. -- Added file: http://bugs.python.org/file27615/RightClickContextMenuUpdatedFor3point4.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: I used taleinat's patch as the start for a patch that works with 2.7. Lots of code was changed from 2010 to 2012 so I basically hand merged the patch into 2.7. This patch was tested with Python 2.7.3 on both Mac OS X and Linux. As suggested by taleinat and Guilherme the shortcuts keys are not included in the context menu. -- versions: +Python 2.7 -Python 3.4 Added file: http://bugs.python.org/file27616/RightClickContextMenuUpdatedFor2point7.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: Changed the version to make it clear this issue as a patch for 3.4 and 2.7. -- versions: +Python 3.4 ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27605/DataModel__len__.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Todd Rovito added the comment: Changed the file name so it is clear that this patch goes with version 3.4. -- Added file: http://bugs.python.org/file27624/RightClickContextMenuUpdatedFor3point4.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27624/RightClickContextMenuUpdatedFor3point4.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Todd Rovito added the comment: Used the right patch file name this time... -- Added file: http://bugs.python.org/file27625/DataModel__len__3point4.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1283110] Give __len__() advice for "don't know"
Todd Rovito added the comment: This patch is for Python 2.7. -- versions: +Python 2.7 Added file: http://bugs.python.org/file27626/DataModel__len__2point7.patch ___ Python tracker <http://bugs.python.org/issue1283110> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10405] IDLE breakpoint facility undocumented
Todd Rovito added the comment: Nick, I agree some documentation is better than none. But somebody could do better I am not sure how to debug in IDLE. I have taken your file and created a 2.7 patch. -- keywords: +patch type: -> enhancement versions: -Python 3.1, Python 3.2 Added file: http://bugs.python.org/file27627/IDLEBreakPointDocumentation2point7.patch ___ Python tracker <http://bugs.python.org/issue10405> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10405] IDLE breakpoint facility undocumented
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27627/IDLEBreakPointDocumentation2point7.patch ___ Python tracker <http://bugs.python.org/issue10405> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10405] IDLE breakpoint facility undocumented
Todd Rovito added the comment: This patch works for both Python 3.4 and Python 2.7, it is a very simple patch. -- versions: +Python 3.4 Added file: http://bugs.python.org/file27628/IDLEBreakPointDocumentation.patch ___ Python tracker <http://bugs.python.org/issue10405> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: David, Thanks for your bug report. Indeed os.rename does not exhibit the same behavior as the documentation describes. For Python 3.4 here is the fix I came up with: "Rename the file or directory src to dst. If dst is a directory that is not empty, OSError will be raised. On Unix, if dst exists and is a file, it will be replaced silently if the user has permission and src is a file. On Unix, if src is a directory and dst is a file NotADirectoryError will be raised. The operation may fail on some Unix flavors if src and dst are on different filesystems. If successful, the renaming will be an atomic operation (this is a POSIX requirement). On Windows, if dst already exists, OSError will be raised even if it is a file." I have attached a Python 3.4 patch for consideration. This might not be the best phrasing so please feel free to offer alternatives. -- keywords: +patch Added file: http://bugs.python.org/file27640/OSRenameTest3point4.patch ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27615/RightClickContextMenuUpdatedFor3point4.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27616/RightClickContextMenuUpdatedFor2point7.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: Same patch as before but updated the documentation and help.txt file for IDLE. This is for Python 2.7. -- Added file: http://bugs.python.org/file27644/RightClickContextMenuUpdatedWithDocs2point7.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: Same patch as before but updated the documentation and help.txt file for IDLE. This is for Python 3.4. -- Added file: http://bugs.python.org/file27645/RightClickContextMenuUpdatedWithDocs3point4.patch ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15869] IDLE: Include .desktop file and icon
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue15869> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15392] Create a unittest framework for IDLE
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue15392> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Thanks for the feedback! Over the weekend I will make sure the documentation and test cases cover all possibilities. I have not worked with test suite but I will do my best. -- ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Over the weekend I verified the test cases are incomplete for Python 3.4. Inside of Lib/test/test_os.py is a class FileTests that contains a single function test_rename which seems to only check to make sure that the reference count for the first argument is not mis-handeled. Nothing exists for the use case destination is a directory as described in the original bug. I will attempt to create suggested test cases but as I am not the most familiar with Python's unit test framework it might take me some time, I estimate as long as 11/6/2012. If somebody comes along with more experience that can fix the bug please feel free to proceed. -- ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: While writing test cases I discovered another conflict with the documentation. The phrase "On Unix, if dst exists and is a file, it will be replaced silently if the user has permission and src is a file." is not correct. According to the test cases I wrote in the attached patch see the method test_rename_src_file_dest_file_exists in the class FileTests the destination file is not replaced and the source file actually is removed. I will seek advice from Python Core Mentorship to see if this is a bug or normal behavior. First time writing test cases so I hope I am on the right track. -- Added file: http://bugs.python.org/file27804/OSRename_test_os.patch ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27804/OSRename_test_os.patch ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: False alarm my test case was buggy. -- ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1207589] IDLE: Right Click Context Menu
Todd Rovito added the comment: Ned, I respectfully disagree that this is not a new feature. IDLE could always copy/cut/paste from the edit menu and it had a right click menu. All this patch does is add options to right click menu and call the same functions as the edit menu does. I could be biased because I worked on the patch and I am a new contributor but I think Andrew's logic of commenting the patch makes sense. Python is a great scripting language but IDLE is really falling behind and it is often the first thing a user sees. Thanks for your attention in this matter and I will respect any solution you and Amdrew come up with. -- ___ Python tracker <http://bugs.python.org/issue1207589> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Attached is a patch for 16 test cases. All 16 test cases have been tested on Windows 7, Mac OS X, and Linux they seem to function well. Before this patch there was only a single test case for rename. For each test case I used "unittest.skipUnless" to make sure the platform was one of the three that I tested for Windows 7, Mac OS X, or Linux. These test cases demonstrate that the documentation is incorrect and perhaps a little fuzzy. I plan to submit updates to the documentation in the coming days. This patch is only for Python 3.4 but I will backport to 2.7 in a few days. I wrote the following code to find all the combinations based on parameters of the function: src = ['src_file','src_directory_empty', 'src_directory_not_empty', \ 'src_file_or_directory_not_exist'] dst = ['dst_file_exist','dst_not_exist','dst_directory_empty', \ 'dst_directory_not_empty'] print "Make sure you have functions in test_os for all of these" for index_src in range(0, len(src)): for index_dst in range(0, len(dst)): function_name = "test_rename_" + src[index_src] + "_" + \ dst[index_dst] print function_name -- versions: -Python 2.7, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file27890/OSRename_test_os_3point4.patch ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Chris, That is an excellent suggestion. I modified my OSRenameCombinations.py program and attached. This program prints a table with the src parameters as columns and the dst as rows. Hopefully it will show up ok in the bug tracker. For Unix src_file src_directory_emptysrc_directory_not_empty src_file_or_directory_not_exist dst_file_exist rename overwrite raises OSError raises OSError raises OSError dst_not_exist rename rename rename raises OSError dst_directory_emptyraises OSError rename overwrite rename overwrite raises OSError dst_directory_not_emptyraises OSError raises OSError raises OSError raises OSError For Windows src_file src_directory_emptysrc_directory_not_empty src_file_or_directory_not_exist dst_file_exist raises OSError raises OSError raises OSError raises OSError dst_not_exist rename rename rename raises OSError dst_directory_emptyraises OSError raises FileExistsError raises FileExistsError raises OSError dst_directory_not_emptyraises OSError raises OSError raises OSError raises OSError -- Added file: http://bugs.python.org/file27915/OSRenameCombinations.py ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Here is a draft suggestion for the documentation change, not all the formatting is worked out: .. function:: rename(src, dst, *, src_dir_fd=None, dst_dir_fd=None) Rename the file or directory *src* to *dst*. If *src* exists as either a file or directory and *dst* does not exist the rename will occur with no error raised. In some cases the rename function will behave differently across platforms which are noted below. In all cases if *src* does not exist :exc: 'OSError' will be raised. Unix If *dst* exists and is a file, it will be replaced silently if the user has permission and src is a file. If *src* is a directory and *dst* is a file :exc: 'OSError' will be raised. In the case where *src* is a directory and *dst* is a empty directory the rename will occur and the *src* directory name will overwrite the *dst* directory name.Yet a special case is noted where *src* is a directory and *dst* is a non-empty directory the rename will not occur and :exc: `OSError` will be raised. Windows If *src* is a file and *dst* exists either as a file or directory :exc: 'OSError` will be raised and the rename will not occur. In the case where *src* is a directory, either empty or not empty, and *dst* exists as a file or not empty directory :exc: `OSError` will be raised. If *src* is a directory, either empty or not empty, and *dst* is a empty directory then :exc: `FileExistsError` will be raised. If successful, the renaming will be an atomic operation (this is a POSIX requirement). This function can support specifying *src_dir_fd* and/or *dst_dir_fd* to supply :ref:`paths relative to directory descriptors `. If you want cross-platform overwriting of the destination, use :func:`replace`. Availability: Unix, Windows. .. versionadded:: 3.3 The *src_dir_fd* and *dst_dir_fd* arguments. -- ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Todd Rovito added the comment: Attached is patch with the final formatting for the documentation updates. I fixed the :exc:`OSError` problems that I had before and used indents to denote Unix behavior VS Windows behavior. Please let me know if I can do anything else to help get this issue resolved. Thanks! -- Added file: http://bugs.python.org/file28071/OSRenameDocs3point4.patch ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16278] os.rename documentation slightly inaccurate
Changes by Todd Rovito : Removed file: http://bugs.python.org/file27640/OSRenameTest3point4.patch ___ Python tracker <http://bugs.python.org/issue16278> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Changes by Todd Rovito : -- nosy: +Todd.Rovito ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: This is a good patch but it is rather out of date and won't apply. I will patch the patch and maybe somebody can apply it this time. Expect a new patch by 11/26/2012. -- ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: This patch is an extensive refactoring of help.txt and idle.rst. The first thing I did was merge issue5066.patch from jesstess into the current idle.rst file, because the original patch from jesstess was so old it had to be merged by hand into the 3.4 source code. Then I compared what the merge document said with the actual menus of IDLE and made several corrections because of missing menu options. Finally I refactored the help.txt based on idle.rst and created the resulting patch. Several capitalization's were fixed along with many inconsistencies between the two files. I have not tested on 2.7 only 3.4. My plan is to test with 2.7 and create another patch by end of the week 12/2/2012. -- versions: +Python 3.4 -Python 2.7, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file28138/5066IDLEocumentationforUnixObsoleteIncorrect.patch ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: Version 2 of the patch change include: -help.txt removed all tabs and replaced with spaces, as suggested by Roger -help.txt re-inserted the section on running IDLE without a subprocess as suggested by Roger -Added a note on line 162 (idle.rst) about how the Python Community standard is to use spaces and not tabs as suggested by ezio -Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine on my computer without the spaces but I think ezio is correct spaces should be present so I added them -Line 354 (idle.rst): are restricted to four spaces due to TCL/Tk issues.)s/issues/limitations/ so I replaced issues with limitations Thanks for the feedback Roger and ezio! -- Added file: http://bugs.python.org/file28141/5066IDLEocumentationforUnixObsoleteIncorrectVersion2.patch ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: For version 2 of the patch -Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine on my computer without the spaces but I think ezio is correct spaces should be present so I added them **SHOULD BE** -Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine on my computer without the empty line between entries but I think ezio is correct empty lines should be present so I added empty lines just to be safe -- ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: A "ping" on this bug since it has not had any forward movement. Can somebody please review and or commit? Thanks. -- ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: Thanks much appreciated! Sent from my iPhone On Jan 4, 2013, at 1:07 PM, Zachary Ware wrote: > > Zachary Ware added the comment: > > Hi Todd, I can't commit, but I have a review in the works for you. > > -- > nosy: +zach.ware > > ___ > Python tracker > <http://bugs.python.org/issue5066> > ___ -- ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
New submission from Todd Rovito: The Python Developer Guide in section 3.3 about the life cycle of a patch/review process makes no mention that a bug should be "pinged" first before posting to the python-...@python.org email list requesting a review. For more information see this thread on the Python-Dev email list: http://mail.python.org/pipermail/python-dev/2013-January/123453.html -- assignee: docs@python components: Documentation messages: 179109 nosy: Todd.Rovito, docs@python priority: normal severity: normal status: open title: Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner type: behavior versions: Python 3.4 ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
Changes by Todd Rovito : -- components: +Devguide -Documentation nosy: +ezio.melotti ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
Todd Rovito added the comment: Here is a suggested patch with help from R. David Murray: "To begin with, please be patient! There are many more people submitting patches than there are people capable of reviewing your patch. Getting your patch reviewed requires a reviewer to have the spare time and motivation to look at your patch (we cannot force anyone to review patches). If your patch has not received any notice from reviewers (i.e., no comment made) after a substantial amount of time first “ping” the issue on the issue tracker to remind the nosy list that the patch needs a review. It is possible that the nosy committers have just forgotten about the issue. After the issue has been “pinged” and if you don’t get a response after a few days then you may email python-...@python.org asking for someone to review your patch." -- keywords: +patch Added file: http://bugs.python.org/file28573/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-dev.patch ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
Todd Rovito added the comment: I agree with Meador it should be a specific amount of time. As a beginner at contributing to Python I thought "substantial amount of time" meant one month but it depends on interpretation. I think making it very specific makes the documentation more clear. Included in the new patch are the other suggestions made by Mr. Jerdonek. Thanks for the feedback! -- Added file: http://bugs.python.org/file28603/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-devV2.patch ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
Todd Rovito added the comment: Ok I changed the time to one month...now the patch reads: "To begin with, please be patient! There are many more people submitting patches than there are people capable of reviewing your patch. Getting your patch reviewed requires a reviewer to have the spare time and motivation to look at your patch (we cannot force anyone to review patches). If your patch has not received any notice from reviewers (i.e., no comment made) after one month, first “ping” the issue on the issue tracker to remind the nosy list that the patch needs a review. After the issue has been “pinged” and if you don’t get a response after a few days then you may email python-...@python.org asking for someone to review your patch." -- Added file: http://bugs.python.org/file28611/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-devV3.patch ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
Changes by Todd Rovito : Removed file: http://bugs.python.org/file28573/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-dev.patch ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16868] Python Developer Guide: Include a reminder to "ping" bug report if not reviewed in timely manner
Changes by Todd Rovito : Removed file: http://bugs.python.org/file28603/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-devV2.patch ___ Python tracker <http://bugs.python.org/issue16868> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: Zachary, I like your idea about joining idle.rst with help.txt but I think that should be covered under a separate bug issue. The way I see it this bug is about fixing the current documentation. So I suggest you open up a new issue and get people's take on it. I think a parser could be run at installation to convert idle.rst to help.txt or maybe IDLE could be modified to simply render idle.rst correctly. I am not sure what the best approach will be. PS Thanks for the review I should have your suggested changes integrating into a new patch today. -- ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5066] IDLE documentation for Unix obsolete/incorrect
Todd Rovito added the comment: Zachary, Thanks for your excellent review Your feedback was very helpful for making the patch even better. -- Added file: http://bugs.python.org/file28626/5066IDLEocumentationforUnixObsoleteIncorrectVersion3.patch ___ Python tracker <http://bugs.python.org/issue5066> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
