[issue16247] Report failing url in URLError?
Senthil Kumaran added the comment: It is going to take a few weeks for me to get to my alerts, I will address this as soon as I get to it . Thanks for the triage, Irit. On Mon, Dec 13, 2021, 12:31 AM Irit Katriel wrote: > > Change by Irit Katriel : > > > -- > status: open -> pending > > ___ > Python tracker > <https://bugs.python.org/issue16247> > ___ > -- status: pending -> open ___ Python tracker <https://bugs.python.org/issue16247> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46756] Incorrect authorization check in urllib.request
Senthil Kumaran added the comment: Pablo, we are good. The PRs were merged in open branches a while ago, and this was tracking security releases backports. -- ___ Python tracker <https://bugs.python.org/issue46756> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12924] Missing call to quote_plus() in test_urllib.test_default_quoting()
Senthil Kumaran added the comment: jon, thanks for the bug report. Fixed and closed in all the branches. -- ___ Python tracker <http://bugs.python.org/issue12924> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12938] html.escape docstring does not mention single quotes (')
Senthil Kumaran added the comment: Yes, single quotes should not escaped in the CGI escape. We should remove that from the table. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12938> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12938] html.escape docstring does not mention single quotes (')
Senthil Kumaran added the comment: The single quote escape was added due to Issue9061 and Issue2830. Since it was included deliberately due to above raised issues, it is best to document it, instead of removing it. -- ___ Python tracker <http://bugs.python.org/issue12938> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12955] urllib2.build_opener().open() is not friendly to "with ... as:"
Senthil Kumaran added the comment: Just as a quick guideline. If you are talking about context manager support for urlopen, it is available and present in 3.x but not on 2.7. And I fear, it is late to make it available on 2.7, because it is a feature. In any case, as Terry requested, a simple snippet would help us understand the problem and original poster's expectation. -- ___ Python tracker <http://bugs.python.org/issue12955> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12955] urllib.request example should use "with ... as:"
Senthil Kumaran added the comment: Valery, yes. I shall update 2.7 documentation with this known limitation and 3.x documentation with the example usage scenarios. Thanks! -- assignee: docs@python -> orsenthil ___ Python tracker <http://bugs.python.org/issue12955> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12938] html.escape docstring does not mention single quotes (')
Senthil Kumaran added the comment: This is fixed in all revisions. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue12938> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12991] Python 64-bit build on HP Itanium - Executable built successfully but modules failed with HP Compiler
Senthil Kumaran added the comment: Wah Meng and I were discussing about this in a separate thread as well. I think, it is a good idea to improve the Readme for this issue. Wah Meng, since you already went at length to contact HP and clarify linker issue with 64 bit and found a solution to it, it would be a good idea to document it. Is this the only change for the successful compilation - CC="cc +DD64" and CXX="aCC" . If there are more details, you can provide changes to the Readme in the form a diff and I shall commit to the trunk. Thanks! -- assignee: -> orsenthil components: +Documentation -Build nosy: +orsenthil resolution: works for me -> status: closed -> open versions: +Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issue12991> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12991] Python 64-bit build on HP Itanium - Executable built successfully but modules failed with HP Compiler
Senthil Kumaran added the comment: Wah meng - Instructions to get the _tkinter compile would be a good idea too. Also, can you verify the same instructions would work for 3.2 version of Python? -- keywords: +patch Added file: http://bugs.python.org/file23221/README.patch ___ Python tracker <http://bugs.python.org/issue12991> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7133] test_ssl failure
Senthil Kumaran added the comment: Keith, was your python compiled with ssl? Any extra information to reproduce this can help. (Download 2.7.2 from python.org, do a ./configure;make and verify if this can bug can be reproduced). -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue7133> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13024] cgitb uses stdout encoding
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue13024> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12966] cookielib.LWPCookieJar breaks on cookie values with a newline
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12966> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13073] message_body argument of HTTPConnection.endheaders is undocumented
Changes by Senthil Kumaran : -- assignee: docs@python -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue13073> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13073] message_body argument of HTTPConnection.endheaders is undocumented
Senthil Kumaran added the comment: This is fixed the following changesets. changeset a3f2dba93743 changeset 1ed413b52af3 changeset 277688052c5a Thanks for the patch, Ben Hayden. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue13073> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13073] message_body argument of HTTPConnection.endheaders is undocumented
Senthil Kumaran added the comment: I believe, I have addressed all the comments. Closing this report. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue13073> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13104] urllib.request.thishost() returns a garbage value
Senthil Kumaran added the comment: Thanks for the report. This is fixed now. I hope in 3.3 I remove this old utility functions. (real soon). -- assignee: -> orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue13104> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13104] urllib.request.thishost() returns a garbage value
Senthil Kumaran added the comment: hmm. interesting case in FreeBSD. Looks like socket.gethostname() did not return the hostname in freebsd buildbot. -- ___ Python tracker <http://bugs.python.org/issue13104> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13073] message_body argument of HTTPConnection.endheaders is undocumented
Senthil Kumaran added the comment: Yes, I agree. I think, it can be clarified at that point too. Because. in 2.7 the string is being checked and in 3.3 the message_body is checked if it's instance of bytes. But, I think, it should be carefully worded (aligned with how other socket message args are mentioned). -- ___ Python tracker <http://bugs.python.org/issue13073> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1673007] urllib2 requests history + HEAD support
Senthil Kumaran added the comment: Hi Ezio, I had probably overlooked this one. But It's a very interesting one for me. Do you mind if I commit it ? On Oct 10, 2011 7:20 PM, "Ezio Melotti" wrote: > > Ezio Melotti added the comment: > > Attached an updated patch that addresses the comments of Éric in the review > and adds an entry to the whatsnew. > > -- > assignee: orsenthil -> ezio.melotti > keywords: +needs review > nosy: -BreamoreBoy > stage: patch review -> commit review > Added file: http://bugs.python.org/file23366/issue1673007.diff > > ___ > Python tracker > <http://bugs.python.org/issue1673007> > ___ > ___ > Python-bugs-list mailing list > Unsubscribe: > http://mail.python.org/mailman/options/python-bugs-list/senthil%40uthcode.com > > -- ___ Python tracker <http://bugs.python.org/issue1673007> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1673007] urllib2 requests history + HEAD support
Senthil Kumaran added the comment:
Our discussion stemmed from this point. If you look at the change proposed,
Request class is taking a new parameter by name 'method' and it is initialized
to None:
class Request:
def __init__(self, url, data=None, headers={},
- origin_req_host=None, unverifiable=False):
+ origin_req_host=None, unverifiable=False,
+ method=None):
But that actually defaults to GET method in terms of HTTP request for often
used scenarios where the only required parameter (url) is sent.
This happens in the get_method call:
def get_method(self):
-if self.data is not None:
+"""Return a string indicating the HTTP request method."""
+if self.method is not None:
+return self.method
+elif self.data is not None:
return "POST"
else:
return "GET"
Since, it is understood that the default action of Request(url) is to do a GET,
I proposed that we have Request's method parameter default to GET instead of
None, so the change would look like:
class Request:
def __init__(self, url, data=None, headers={},
- origin_req_host=None, unverifiable=False):
+ origin_req_host=None, unverifiable=False,
+ method="GET"):
And it is more meaningful when someone is looking at the Request signature.
Specifying method=None and implicitly meaning it as "GET" for normal situations
was not intuitive to me. (This is not case when we do not pass an explicit
method arg).
At this point, Ezio's summary of API changes discussed becomes interesting. I
read again and it seems to me that, the assumption is get_method is an
important method which determines what method should be used and method should
be given preference over data.
My point is, get_method is an useful, helper function that is helpful is
sending the correct method to the http.client code which does the actual task.
In the current situation, get_method "determines" based on data parameter
should it send a "GET" or a "POST", but if we start using method=arg then,
get_method should just return what was initialized by the method arg
(defaulting to "GET").
2) The next problem comes when a user has specified both data and method="GET".
This becomes an invalid scenario, but a decision has been to taken as what
should be given preference?
- As the user has sent "data", should the request be considered a POST?
- But user specified it as "GET" (intentionally or by mistake), so should the
data not be used and Request should do only a GET?
- Or should we throw an error?
My personal on this is -1 on throwing an error and when data is sent, just do
the POST (data overrides method).
BTW, this needs to discussed irrespective of point 1). But having method="GET"
could give raise to his scenario more often. A person would just send data and
forget about changing the method to "POST".
Coming to specific questions which Ezio pointed:
My take:
1) should method always have priority or should 'POST' always be used whenever
data is passed?
If data is passed use POST.
2) if the method is e.g. 'GET' and data is passed, should an error be raised?
Nope, give data the priority and do POST. (As urllib is currently doing)
3) should Request.method be private?
Not necessarily, it should be public.
4) should the value of Request.method be initialized in the __init__ or can it
also be None?
My take - It should be initialized to default (GET), instead of None.
5) if the value of Request.method is always initialized, should we deprecate
get_method?
This is an interesting question. get_method essentially becomes less useful or
it could serve as an arbiter when data and GET is sent and may be used as
reliable way to get the Request's method. It should not be deprecated.
--
___
Python tracker
<http://bugs.python.org/issue1673007>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1673007] urllib2 requests history + HEAD support
Senthil Kumaran added the comment: Patrick, Lots of valid points. I had not looked at the RFC spec when I mentioned about data over request (GET) method, but was trying to derive the current functionality of module (so that users can have a seamless experience) with additional method="GET" as default. Note, my intention was to be explicit when we give method arg. But yeah, when user has specified the methods (PUT/DELETE etc) and given the data, correct rules should apply on how that method should deal with data. As you pointed out to RFC, I realize RFC clearly points out the data (message-body) should be ignored and method should be given preference, whenever specification of method has nothing to with data. I should take back my argument on giving data as preference even over GET. Now, question arises- Can we in anyway default the method="GET" and maintain compatibility as well consistency with user expectations? At the moment, just by sending data over Request, the method is assumed to be POST. If that is not possible, then the way, current patch does seems to be a good way to acheive the purpose. -- ___ Python tracker <http://bugs.python.org/issue1673007> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13154] pep-0000.txt doesn't build anymore
Senthil Kumaran added the comment: Fixed in 25ff1adf5f30 -- nosy: +orsenthil resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue13154> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1673007] urllib2 requests history + HEAD support
Senthil Kumaran added the comment: I have committed the patch accomodating the doc review comments which Ezio had mentioned. At the moment, the current way seems to be most backwards compatible one and did not want to delay it. Let's hope we get some feedback on this method arg. Thanks! -- ___ Python tracker <http://bugs.python.org/issue1673007> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1673007] urllib2 requests history + HEAD support
Senthil Kumaran added the comment: Hi Eric, The changes suggested in the patch are good for readability, I shall include them all. Thanks! -- ___ Python tracker <http://bugs.python.org/issue1673007> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12529] cgi.parse_header fails on double quotes and semicolons
Senthil Kumaran added the comment: Thanks for the patch, Petri and Ben.Darnell. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12529> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6090] zipfile: Bad error message when zipping a file with timestamp before 1980
Senthil Kumaran added the comment: Fixed in all active branches. Thanks for the patch, Petri. Mark, for this issue, raising ValueError from zipfile was seemingly a right thing to do, the previous error from struct for a side effect of sending a value lower than 1980. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue6090> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4733] Add a "decode to declared encoding" version of urlopen to urllib
Senthil Kumaran added the comment: - page.encoding is a good idea. - page.decode_content sounds definitely better than page.decode which can be confusing as page is not a bytes object, but a file-like object. I am thinking if an attribute to urlopen would be better? Not exactly the mode like attribute of the builtin open, but something like decoded=False The downside is that the attr is now for the implementation detail of the method in py3k and upside is it gives an idea to users as what return value they can/should expect. -- ___ Python tracker <http://bugs.python.org/issue4733> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13244] WebSocket schemes in urllib.parse
Senthil Kumaran added the comment: This kind of suggestion has come up before and easy fix is to add individual schemes as the patch does. There is a number of limitations if want to make the parser generic for any scheme. The difficult thing being the parsing behavior and requirements as defined by scheme. The generic parsing rule, which was added previously was, when someone comes up a new scheme and what could be default "fall-back parsing rule". In this report, I see ws and wss has some requirements, which needs to be codified in the parsing rules followed by urlparse module. To start with, going with patch is a good way. If you find any other library (I look at libcurl) handling it differently, please point it out here, so that it can could be useful. -- ___ Python tracker <http://bugs.python.org/issue13244> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13033] Add shutil.chowntree
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue13033> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13244] WebSocket schemes in urllib.parse
Senthil Kumaran added the comment: Similar issue Issue7904 and 7da7f9bfdaac wherein the accepted way to parse x-newscheme://foo.com/stuff was added. Does the new ws:// scheme not fall under that? -- ___ Python tracker <http://bugs.python.org/issue13244> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13277] tzinfo subclasses information
New submission from Senthil Kumaran : This was in the docs mailing list, not translated to bug report Paul Koning wrote: Section 8.1.6 of the library manual talks about utcoffset(dt)-dst(dt) as the "standard offset" and says that this should not depend on the date or +time but only on the location. This is not true as there cases were certain locations changed the time offsets as per their convenience. It is either a doc fix to remove that sentence if the datetime.astimezone does not depend upon utcoffset(dt)-dst(dt), or if it does, then it is a code fix. -- assignee: docs@python messages: 146501 nosy: docs@python, orsenthil priority: normal severity: normal stage: needs patch status: open title: tzinfo subclasses information type: behavior ___ Python tracker <http://bugs.python.org/issue13277> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13211] urllib2.HTTPError does not have 'reason' attribute.
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue13211> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
Re: [issue13208] Problems with urllib on windows
The code is pretty straight forward and works on Linux. Is the problem with the download? If you open the json file, is it a valid one? ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13287] urllib.request exposes too many names
Senthil Kumaran added the comment: Let's deprecate some of these (or add deprecation warnings) for upcoming release. But, doing from xxx import * is not a recommended way for any module, as we know that it stands to pollute the namespace with unneccesary functions/methods. I would be careful in adding anything to __all__ and if done, may go for only 3.3. Ezio has a valid point. -- ___ Python tracker <http://bugs.python.org/issue13287> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13281] robotparser.RobotFileParser ignores rules preceeded by a blank line
Senthil Kumaran added the comment: I agree with your interpretation of the RFC. The parsing rules do not specify any provision for inclusion of blank lines "within" the records. However, I find that inclusion is no harm either. I checked that with a robots.txt parser (Google webmaster tools) and presented the last.fm's robots.txt file which had blank line within records. As expected, it did not crib. I would say that we can be lenient on this front and the question would if we allow, would it break any parsing rules? I think, no. The patch does not break any tests, but a new test should be added to reflect this situation. I don't have a strong opinion on having a strict=(True|False) for the blank line accommodation within records(only). I think, it is better we don't add a new parameter and just be lenient. -- ___ Python tracker <http://bugs.python.org/issue13281> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook
Senthil Kumaran added the comment: This is fixed in all codelines. Thanks for your contribution, Jyrki Pulliainen. -- resolution: -> fixed status: open -> closed versions: +Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issue10817> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13287] urllib.request exposes too many names
Senthil Kumaran added the comment: Thanks flox for the patch. Just the News item is added. I don't think, this requires any Docs update. One change I had to make in the patch is to remote HTTPSHandler from __all__ because that is only conditionally available when http.client supports HTTPSConnection. Neither might this require a docs update because Handlers may be used only within urllib.request namespace and not standalone. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue13287> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13323] urllib2 does not correctly handle multiple www-authenticate headers in an HTTP response
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue13323> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13147] Multiprocessing Pool.map_async() does not have an error_callback parameter
Senthil Kumaran added the comment: Thanks for the report, Jakub and for the patch, Jyrki -- nosy: +orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue13147> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13211] urllib2.HTTPError does not have 'reason' attribute.
Senthil Kumaran added the comment:
Hi Jason & Petri,
urllib2.HTTPError never had a reason attribute. In the docs, it is mentioned
that only URLError has the reason attribute. The HTTPError sublasses URLError
and addinforurl class, but the further initialization happens only in the
addinforurl class atrs.
If you got confused that the HTTPError as args and not reason, the 'args' is
not coming from URLError.
HTTPError is raised for peculiar conditions such like authentication failures
and it is 'used' as expected failure for certain authentication conditions.
URLError is not so, it is seen more as an exception like socket errors.
The example your illustrated is an Authentication failure and as per docs, it
is guaranteed to have code attribute to verify the kind of HTTP error are
getting. msg is corresponding HTTP error code msg.
Take this example for URLError which will have reason attribute, it will work
in both 2.7,3.2 and 3.3
import urllib.request, urllib.error, urllib.parse
try:
urllib.request.urlopen('http://aninvalidsite/something')
except urllib.error.URLError as exc:
print(exc.reason)
Because this is a socket error, the reason as "[Errno -2] Name or service not
known" and HTTPError may not be a proper exception for this.
This is more of an IOError which urllib calls a URLError.
I am not sure, how the need for 'reason' attribute for HTTPError exception was
felt as the docs just say about 'code'. (HTTPError is informed as a subclass
of URLError, but HTTPError does not call the URLError 's __init__ and acts
standalone.
I am not sure, how to go about with this bug. If a new .reason attribute has to
be added to HTTPError, then it is a feature request though, I wonder why we
need when code and msg serve an adequate purpose.
--
___
Python tracker
<http://bugs.python.org/issue13211>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11082] ValueError: Content-Length should be specified
Senthil Kumaran added the comment: Here is the docs patch which will help us close the issue. Addressing Eric's last comment - I believe the what's new and News for this issue was added with the feature, this one was Exception msg change. -- Added file: http://bugs.python.org/file23641/issue-11082-docs.patch ___ Python tracker <http://bugs.python.org/issue11082> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13425] http.client.HTTPMessage.getallmatchingheaders() always returns []
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue13425> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13425] http.client.HTTPMessage.getallmatchingheaders() always returns
Senthil Kumaran added the comment: Let's make it useful, that's much better instead of removing it. I am +1 with Ezio's suggestion on this to return a list of tuples with matching headers. -- title: http.client.HTTPMessage.getallmatchingheaders() always returns [] -> http.client.HTTPMessage.getallmatchingheaders() always returns ___ Python tracker <http://bugs.python.org/issue13425> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13620] Support Chrome in webbrowser.py
Senthil Kumaran added the comment: This is in 3.3. Thanks for the patches. -- nosy: +orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue13620> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11012] Add log1p(), exp1m(), gamma(), and lgamma() to cmath
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11012> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13443] wrong links and examples in the functional HOWTO
Senthil Kumaran added the comment: Fixed this in 2.7. -- nosy: +orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue13443> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12798] Update mimetypes documentation
Senthil Kumaran added the comment: Updated the doc with Sandro Tosi's suggested changes in all the codelines. -- nosy: +orsenthil resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue12798> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13294] http.server: minor code style changes.
Senthil Kumaran added the comment: The original issue was invalid. Incorporated Michele Orrù's code style changes into the trunk and other codelines. -- resolution: -> fixed status: open -> closed title: http.server: HEAD request should not return a body -> http.server: minor code style changes. ___ Python tracker <http://bugs.python.org/issue13294> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13294] http.server: minor code style changes.
Senthil Kumaran added the comment: The concern here is if the request line had something like this. Method SP Request-URI SP HTTP-Version \r\n The previous behavior would have resulted in Method SP Request-URI SP HTTP-Version That is removing only the final \r\n, whereas the current change would make it Method SP Request-URI SP HTTP-Version That is removes all the trailing \r\n combination. BTW, thing to note this, this is only for request line and not the header lines. And for request-line, both HTTP 1.0 and HTTP 1.1 spec has this in section 5.1 5.1 Request-Line The Request-Line begins with a method token, followed by the Request-URI and the protocol version, and ending with CRLF. The elements are separated by SP characters. No CR or LF are allowed except in the final CRLF sequence. Request-Line = Method SP Request-URI SP HTTP-Version CRLF Which leads me to believe that, removing all the trailing \r\n is a fine thing to do and should not be harmful. Just to augment this with few other things I found while (re-)reading the spec. This advise is different from Header's trailing whitespace, which is called Linear White space (LWS). If the Host Header looks like, e.g. "Host: www.foo.com \r\n" (notice the trailing white space), According to RFC 2616 (HTTP 1.1), section 4.2 Message Headers: The field-content does not include any leading or trailing LWS: linear white space occurring before the first non-whitespace character of the field-value or after the last non-whitespace character of the field-value. Such leading or trailing LWS MAY be removed without changing the semantics of the field value. RFC 1945 (HTTP 1.0), section 4.2 Message Headers does not make such an explicit statement. My guess on the former behavior in http/server.py is that it was thought that Request-Line was following something like section 4.2 on HTTP 1.0 spec and only the last two characters were removed. But actually, the request-line as per spec should have only one CRLF as end char. In the Docstring of the BaseHTTPServer class, there is a mention about preserving the trailing white-space, but it does not point to any authoritative reference, so I am sure taking docstring as reference to preserve the behavior is a good idea. Before dwelling to find the reason, I was thinking if reverting the patch in 2.7 and 3.1 would be a good idea. But give that change has support from older specs to new ones, I am inclined to think that leave the change as such (without reverting) should be fine as well. Only if we find a stronger backwards compatibility argument for leaving trailing \r\n in request-line, then we should remove it in 2.7 and 3.2, otherwise we can leave it as such. -- ___ Python tracker <http://bugs.python.org/issue13294> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13696] [urllib.request.HTTPRedirectHandler.http_error_302] Relative Redirect issue
Senthil Kumaran added the comment: Here is the patch against 3.2. Something is wrong with the mercurial at the moment where 3.2 is shown as inactive. Once that is corrected, I shall commit and push this to 3.2 and cpython codelines. This bug is not present in 2.7 as different logic is followed in there. -- keywords: +patch Added file: http://bugs.python.org/file24136/13696.diff ___ Python tracker <http://bugs.python.org/issue13696> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13696] [urllib.request.HTTPRedirectHandler.http_error_302] Relative Redirect issue
Changes by Senthil Kumaran : -- resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue13696> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13642] urllib incorrectly quotes username and password in https basic auth
Senthil Kumaran added the comment: Some review comments. Instead of doing the inline unquote like this - -auth = base64.b64encode(user_passwd).strip() +auth = base64.b64encode(unquote(user_passwd)).strip() It is better to do the explicitly above the b64 encoding step. Just as host has been unquoted. user_passwd, host = splituser(host) host = unquote(host) Also, you have done this only for https_open, the same would need be replicated for http_open and also for proxy_passwd. Also on tests, Modifying sendall with def sendall(self, str): -pass +FakeHTTPConnection.request += str seems a bit odd to me, you are using a class level object and adding a str. I think, there should be better way to do. (I shall provide an example). Also str term can replaced, even if it was coming from old code. -- assignee: -> orsenthil stage: -> patch review ___ Python tracker <http://bugs.python.org/issue13642> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9637] docs do not say that urllib uses HTTP_PROXY
Senthil Kumaran added the comment: Sorry, this escaped for so long. First thing is, having different values for HTTP_PROXY and HTTP_proxy and http_proxy is plain wrong at the user side. They all should be same and in that case the possible problem which Kirikaza and Neil Muller state is extremely unlikely (and if the user faces any issue, it is due to improper HTTP configuration). The reason that lowering of environ vars is performed is similar to any string match with input from user where we want to ignore the case sensitivity. Having said that, I think, I shall just add teh info on lowering and verification of proxy environment to the docs. I am -1 on changing any behavior for this issue. -- assignee: docs@python -> orsenthil ___ Python tracker <http://bugs.python.org/issue9637> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13642] urllib incorrectly quotes username and password in https basic auth
Senthil Kumaran added the comment: Joonas and Michele - The fix along with the tests is in for 2.7 line. W.r.t to tests having it in the class level buf seems to be only easy way, for other it seemed to be that FakeSocket and FakeConnection stuff need some major change (and resulted in breaking of some tests). I thought it is better to push it in the current form as we use the buf for temporary storage and verification. I think, those tests can be brought into 3.x line as well. -- resolution: -> fixed stage: patch review -> committed/rejected ___ Python tracker <http://bugs.python.org/issue13642> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9637] docs do not say that urllib uses HTTP_PROXY
Senthil Kumaran added the comment: This is fixed. Thanks for your contribution. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue9637> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass
Senthil Kumaran added the comment: Justin, The patch and logic is okay. We can have this is 3.3. - I find that loop_actions as not appropriate name for the new method. It fails to give a intuitive meaning of what is supposed to do. request_action, request_action_continued or anything else which gives a meaning should be helpful. I agree with your reasoning to provide some flexiblity for the user to override this. - The patch lacks Documentation and tests should be added to Lib/test/test_socketserver.py. If you can, please append the patch with these, otherwise I shall do it. A suggestion for better method name is a must! :) Thanks! -- assignee: gregory.p.smith -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass
Senthil Kumaran added the comment: The feature is in 3.3. I did not remove the handle_timeout method from the Mixin class, because it might be used in the production by the existing servers. It is not appropriate to remove methods all of sudden without deprecation warnings and also it is not required to remove in this case. Added the Documentation and News entry too. -- ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass
Senthil Kumaran added the comment: This is fixed in 3.3 now. Keeping it open for test_socketserver update. After a ForkingServer service call, it should be asserted the collect_children routine is run. -- resolution: -> fixed stage: patch review -> committed/rejected versions: -Python 2.7, Python 3.2 ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass
Senthil Kumaran added the comment: Victor - Sure, I understand Issue #xxx: desc must be useful while generation reST docs. -- ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12184] socketserver.ForkingMixin collect_children routine needs to collect only it's children
New submission from Senthil Kumaran : socketserver.ForkingMixin class has a collect_children method, that waits for the children to exit. But, that waits for any child process and not just the ones spawned the socketserver alone. try: pid, status = os.waitpid(0, 0) except os.error: pid = None This is performance lag and can be improved. The collect_children can only wait/collect it's own children. -- messages: 136931 nosy: orsenthil, pitrou priority: normal severity: normal stage: needs patch status: open title: socketserver.ForkingMixin collect_children routine needs to collect only it's children type: resource usage versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue12184> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12184] socketserver.ForkingMixin collect_children routine needs to collect only it's children
Changes by Senthil Kumaran : -- nosy: +charles-francois.natali ___ Python tracker <http://bugs.python.org/issue12184> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10449] “os.environ was modified by test_httpservers”
Senthil Kumaran added the comment: I think, if you speak to RM, you can just have this change in. Don't we get "no commits please" email request from RM with hg or is the branch already cut? -- ___ Python tracker <http://bugs.python.org/issue10449> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11197] information leakage with SimpleHTTPServer
Senthil Kumaran added the comment: Ori, which platform did you try to reproduce this issue. I tried in all active codelines (cpython to all through 2.5) from hg and can't able to reproduce this bug on Linux. If someone can reproduce, can you provide exact instructions. -- ___ Python tracker <http://bugs.python.org/issue11197> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12255] A few changes to .*ignore
Senthil Kumaran added the comment: +libpython*.so* is fine, but please don't remove the rej and orig. By convention and practice, those files are meant to be in .ignore files to prevent accidental checkins. Usually when the conflict occurs you are notified immediately and you fix them subsequently. Being notified of pending merge by seeing the.rej files in the hg status seems remote to me. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12255> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12255] A few changes to .*ignore
Senthil Kumaran added the comment: I strictly have not faced any problem with those rej and orig files being present in the .hgignore. I also thought keeping the .hgignore in the repo was for distribution and never knew that it can affect local views (If you remove .rej and .orig your local version, will it help?) Yes, mercurial presents us with a list of files are that being added/committed, so we can be careful in not add those spurious leftovers. But at a time when you want to be fast with doing everything via cli options you are at a risk of adding unwanted files (unless protected by .hgignore file). I see that .hgignore can ignore itself. So, once commited with itself to ignore, I believe people can have personal customization in there. This suggestion is with the understanding that repo/.hgignore is just to distribution and does not affect hg tracking behavior. Please correct me if I am wrong here. -- ___ Python tracker <http://bugs.python.org/issue12255> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12255] A few changes to .*ignore
Senthil Kumaran added the comment: By "for distribution", I meant that everyone who checks out ( clones) from hg.cpython.org repository share the same .hgignore file, instead of each person having to create their own file. I got an impression from the earlier message that hg tracks (or ignores tracking) based on .hgignore file in the server itself, which I wanted to clarify. -- ___ Python tracker <http://bugs.python.org/issue12255> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12255] A few changes to .*ignore
Senthil Kumaran added the comment: I tried to a line .hgignore inside .hgignore file, so that it can ignore itself (weird concept, but wanted to try if it works) and users can make local customization of it without any problem. This has been suggest at many places in the Internet. I tried by completing removing the file and adding a new one with .hgignore ignoring itself. But it does'nt seem to work. So a possible solution seems like this: If .rej and .orig needs to be removed from .hgignore, one should just remove it from the .hgignore file and for people who do not want to be bothered by .rej/.orig files in hg st, they can create an addition ignore directive in their .hgrc http://mercurial.selenic.com/wiki/TipsAndTricks#Ignore_files_in_local_working_copy_only -- ___ Python tracker <http://bugs.python.org/issue12255> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12365] URLopener should support context manager protocol
Senthil Kumaran added the comment: well, urlopen does return an file like object for socket connection which closes itself when it goes out of scope, as you raised this bug, I think a more explicit context manager like behavior can be tried. But I am afraid that it would complex to implement with the module than it sounds. I see some example illustrated like this: http://stackoverflow.com/questions/1522636/should-i-call-close-after-urllib-urlopen import contextlib with contextlib.closing(urllib.urlopen(u)) as x: ...use x at will here... But it would be good to have this ticket as a feature request open. -- assignee: -> orsenthil nosy: +orsenthil status: closed -> open ___ Python tracker <http://bugs.python.org/issue12365> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12319] [http.client] HTTPConnection.putrequest not support "chunked" Transfer-Encodings to send data
Senthil Kumaran added the comment: We had support for chunked transfer encoding for POST method recently, which is exposed via urllib2 wrapper function. PUT is not exposed via urllib2 and users should use httplib. This feature of chunked transfer can be added to PUT by taking the body of the message as iterable. -- assignee: -> orsenthil stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue12319> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12327] in HTTPConnection the are len(body) and TypeError catch exception to detect if body is file like object, this hack do work with StringIO object
Senthil Kumaran added the comment: Hello Stephane, > I use HTTPConnection to simulate Apple Finder WebDAV client. When > this WebDAV client do PUT request, it transmit data in chunked > encoding mode and not set Content-Length HTTP field. > > Do you understand my context ? Is the server at fault in not returning Content-Length? Can you provide a full working snippet which demonstrates the bug you are facing? I fear, if I am lacking some information to completely determine what needs to be fixed (I understand the code change you suggested, but also need to know why and under what practical situation would code flow through that). -- ___ Python tracker <http://bugs.python.org/issue12327> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12289] http.server.CGIHTTPRequestHandler doesn't check if a Python script is executable
Senthil Kumaran added the comment: Both the changes suggested in the patch are fine. I think, it is okay to remove the executable function. It is undocumented as it is, and have not seen any standalone use of it. A note in NEWS can help. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12289> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12365] URLopener should support context manager protocol
Senthil Kumaran added the comment:
I forgot completely, but in Python3, Issue5418 had already added
support to addinfourl. It is now possible to write code like
import urllib.request
with urllib.request.urlopen('http://www.python.org') as req:
res = req.read()
But yeah, unlike normal file objects, it not a strict requirement for
closing those objects as they will be closed when socket connection is
closed.
This is available only 3.x series and I think, a documentation update
should be fine and this report can be closed.
--
___
Python tracker
<http://bugs.python.org/issue12365>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)
Senthil Kumaran added the comment: Yes, it is a feature. Sorry that I have not paid attention to this. The Windows (IIS) part led me to delay as I did not have any to test. Let me take this up and see through it in 3.3. -- ___ Python tracker <http://bugs.python.org/issue2202> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12390] urllib.parse.urlencode encoding lists as strings
Senthil Kumaran added the comment: I see you missed the doseq parameter which is applicable in this case. print(urllib.parse.urlencode(dictQuery, encoding='iso8859-1',doseq=True)) a=b&c=d&c=e&b=c -- nosy: +orsenthil resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue12390> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12390] urllib.parse.urlencode encoding lists as strings
Senthil Kumaran added the comment: Joseph, resolution applies for the bug not the process. tc. :) -- resolution: accepted -> invalid ___ Python tracker <http://bugs.python.org/issue12390> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11898] Sending binary data with a POST request in httplib can cause Unicode exceptions
Senthil Kumaran added the comment: Sorin, can you please open another report with more details and how some condition in httplib breaks PyAMF. We will see through that it is fixed. Commenting on an invalid closed issue is confusing. -- ___ Python tracker <http://bugs.python.org/issue11898> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11898] Sending binary data with a POST request in httplib can cause Unicode exceptions
Senthil Kumaran added the comment: Hi Sorin, On Sat, Jun 25, 2011 at 07:54:24PM +, sorin wrote: > type(message_body) is str ... even if I tried to manually force > Python for use bytes. It seams that in 2.7 bytes are alias to str. > Due to this the code will fail to run only on 2.7 because it will > try to convert binary data to unicode string. Bit confused here. You encode the string to bytes and decode it back to str. One does not force bytes to str. And if you use, str or bytes consistently in Python2.7 you wont face the problem. -- ___ Python tracker <http://bugs.python.org/issue11898> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12255] A few changes to .*ignore
Senthil Kumaran added the comment: Eric, sure go ahead. As I am not affected by remains of .rej and .orig (neither have I found their usefulness (yet)), so my concerns can be stepped over. Plus, I have found a way to ignore files via patterns in .hgrc. I already see you and RDM proposing the change, so I am okay to follow. But if you think discussion in python-dev or python-committers would be helpful it would be a good idea, because it affects people's working environment and some might have some concerns or ideas (which might be helpful). -- ___ Python tracker <http://bugs.python.org/issue12255> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10020] docs for sqlite3 describe functions not available without recompiling
Senthil Kumaran added the comment: Fixed in branch 2.7. Thanks Kristan. Eric, the documentation patch does not apply to 3.1 because those functions are not present in 3.1. -- nosy: +orsenthil status: open -> closed ___ Python tracker <http://bugs.python.org/issue10020> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12255] A few changes to .*ignore
Senthil Kumaran added the comment: On Sat, Jun 25, 2011 at 08:38:04PM +, Senthil Kumaran wrote: > As I am not affected by remains of .rej and .orig (neither have I > found their usefulness (yet)), so my concerns can be stepped over. Just a side-note. I wondered why is my case so, and I realized that I had integrated k3diff to handle any conflicts during merge so when a conflict arises, it immediately invokes k3diff and it allowed me to handle the conflicts giving me the contexts which are stored in .rej files. -- ___ Python tracker <http://bugs.python.org/issue12255> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11197] information leakage with SimpleHTTPServer
Senthil Kumaran added the comment: The module documentation for the SimpleHTTPServer class says that. """ This class serves files from the current directory and below, directly mapping the directory structure to HTTP requests. """ As it is already documented. Nothing else needs to be done for this report. Closing this one. Thanks! -- resolution: -> invalid stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue11197> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11253] autodocument first appearance of ctypes.wintypes constants
Senthil Kumaran added the comment: On Sun, Jun 26, 2011 at 10:44:59AM +, Mark Mc Mahon wrote: > So we need a doc patch? Should we update the older 'What's new in > Python 2.x' for added attribs? The Documentation patch may be applied only 2.7 and 3.2/3.3 releases now. What's new is updated for the upcoming release only. So, if documenting those constants will help in 2.7.x and 3.2.x and 3.3, it would be helpful to provide patches against those lines and it can be applied. As you said, the future version can be updated, but we cannot go back with updating the documentation of the already released versions. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11253> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11568] docstring of select.epoll.register() is wrong
Senthil Kumaran added the comment: On Sun, Jun 26, 2011 at 03:12:30PM +, Sandro Tosi wrote: > The patch is fine: but would you be interested in trying to write a > unittest for select.epoll.register ? it would be really nice to This is covered in test_epoll.py -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11568> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10020] docs for sqlite3 describe functions not available without recompiling
Senthil Kumaran added the comment: Eric, you mean for the whole of sqlite3 docmentation or the part in the footnote? -- ___ Python tracker <http://bugs.python.org/issue10020> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10403] Use "member" consistently
Senthil Kumaran added the comment: Yes, I agree with you. Good Suggestion. Thanks! -- ___ Python tracker <http://bugs.python.org/issue10403> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12431] urllib2.Request.get_full_url() broken in newer versions of Python
Senthil Kumaran added the comment: As Santosa said, this was discovered and fixed in 2.7 itself, surprised that you discovered it in any release Jon. If it was from a checkout, please update. -- resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue12431> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12455] urllib2 forces title() on header names, breaking some requests
Senthil Kumaran added the comment: AFAIR, that capitalize part is somewhere a requirement in RFC, if the server did not behave in proper manner, it may not be a good idea for the client to change (or be permissive the flag). -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12455> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12455] urllib2 forces title() on header names, breaking some requests
Senthil Kumaran added the comment: Sorry, not "Capitalize", but the "Title" part. One can some bugs which lead to this change in the urllib2. -- ___ Python tracker <http://bugs.python.org/issue12455> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10020] docs for sqlite3 describe functions not available without recompiling
Senthil Kumaran added the comment: Fixed the indentation issues. We could not use automatic reST footnotes because two links refer to same footnote, so left it as such. -- ___ Python tracker <http://bugs.python.org/issue10020> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1067702] urllib fails with multiple ftp transfers
Senthil Kumaran added the comment: Hello Stefen, Yes, I was able to reproduce the issue without the patch and at the same time, noticed that the problem was not observed in other branches (py3k), then saw the differences where the possible socket close delays can happen and fixed it. As it was multiple threads closely being closed it was most probably due to delay in closing socket connection that lead the problem in the first place. If it is required, then manually this can be verified by setting up an artificial delay in the network layer and trying multiple ftp transfers. (No, I did not do that to verify. :)) -- ___ Python tracker <http://bugs.python.org/issue1067702> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11253] autodocument first appearance of ctypes.wintypes constants
Senthil Kumaran added the comment: What's new docs are usually for what is coming up new in the upcoming releases. It is not updated once the release is done. Bug fixes and related docs are updated in documentation. -- ___ Python tracker <http://bugs.python.org/issue11253> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
Re: [issue12436] Provide reference to detailed installation instructions
I am not sure that is comprehensive enough. It is just organized into OS specific sections and gives little details further on. So, -1 to this, but +1 to the general idea of having detailed install and get started documentation. ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
Re: [issue12438] IDLE problem displaying warning message
Have fixed this. Even looking at the code, your suggestion was correct. But even before the fix, I was not able to reproduce the bug in Ubuntu and perhaps it was getting masked. May I ask, how did you invoke idle that this bug surfaced and what was the platform? ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12470] Fix cut&paste typo in test_shutil
Changes by Senthil Kumaran : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue12470> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12484] The Py_InitModule functions no longer exist, but remain in the docs
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12484> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12487] urllib2.urlopen() returns object missing context manager
Senthil Kumaran added the comment: It should be documented that in 2.x series the file-like object does not support context management protocol. I have added the superseder issue number, please see the note as if you really want in 2.x, how you can have it using contextlib and in 3.x the context management protocol support is available. -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> URLopener should support context manager protocol ___ Python tracker <http://bugs.python.org/issue12487> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12491] Update glossary documentation for the term 'attribute'
New submission from Senthil Kumaran : Update the term 'attribute' in the glossary http://docs.python.org/dev/glossary.html#term-attribute so that the reader can understand that the term attribute in Python can mean both 'data-attribute' and a 'callable' method. -- assignee: docs@python components: Documentation messages: 139809 nosy: docs@python, orsenthil priority: normal severity: normal status: open title: Update glossary documentation for the term 'attribute' versions: Python 2.7, Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issue12491> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12149] Segfault in _PyObject_GenericGetAttrWithDict
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue12149> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10883] urllib: socket is not closed explicitly
Senthil Kumaran added the comment: With the patch applied, test_urllib2net fails at test_ftp test case when a valid and invalid url are presented in sequence. I think test needs a change or a further look is needed at the patch. -- ___ Python tracker <http://bugs.python.org/issue10883> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
