[issue28686] py.exe ignored PATH when using python3 shebang

2022-02-04 Thread Segev Finer


Change by Segev Finer :


--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue28686>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue39010] ProactorEventLoop raises unhandled ConnectionResetError

2020-04-26 Thread Segev Finer


Change by Segev Finer :


--
nosy: +Segev Finer

___
Python tracker 
<https://bugs.python.org/issue39010>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23451] Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit

2017-06-21 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2368

___
Python tracker 
<http://bugs.python.org/issue23451>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-21 Thread Segev Finer

New submission from Segev Finer:

We are getting:

Warning C4005   'HAVE_MEMMOVE': macro redefinition  _elementtree
c:\users\segev\prj\python\cpython\modules\expat\winconfig.h 34  
Warning C4267   '=': conversion from 'size_t' to 'unsigned char', possible loss 
of data _elementtree
c:\users\segev\prj\python\cpython\modules\expat\siphash.h   316 
Warning C4996   'getenv': This function or variable may be unsafe. Consider 
using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details.  _elementtree
C:\Users\Segev\prj\python\cpython\Modules\expat\xmlparse.c  796 
Warning C4005   'HAVE_MEMMOVE': macro redefinition  _elementtree
c:\users\segev\prj\python\cpython\modules\expat\winconfig.h 34  
Warning C4005   'HAVE_MEMMOVE': macro redefinition  _elementtree
c:\users\segev\prj\python\cpython\modules\expat\winconfig.h 34

And in 64-bit:

c:\users\segev\prj\python\cpython\modules\expat\siphash.h(201): warning C4244: 
'initializing': conversion from '__int64' to 'char', possible loss of data

I'm not sure how many Python versions this affects.

--
components: Extension Modules, Windows
messages: 296590
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: [Windows] Warnings in elementtree due to new expat
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-21 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2369

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-21 Thread Segev Finer

Changes by Segev Finer :


--
type:  -> compile error

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30731] Use correct executable manifest for windows

2017-06-22 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2377

___
Python tracker 
<http://bugs.python.org/issue30731>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30745] Warnings in Modules/_winapi.c

2017-06-24 Thread Segev Finer

New submission from Segev Finer:

..\Modules\_winapi.c(886): warning C4090: 'function': different 'const' 
qualifiers
..\Modules\_winapi.c(848): warning C4101: 'wenvironment_size': unreferenced 
local variable

Added in d174d24a5d37d1516b885dc7c82f71ecd5930700

--
components: Windows
messages: 296761
nosy: Segev Finer, paul.moore, serhiy.storchaka, steve.dower, tim.golden, 
zach.ware
priority: normal
severity: normal
status: open
title: Warnings in Modules/_winapi.c
type: compile error
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30745>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2422

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-24 Thread Segev Finer

Segev Finer added the comment:

It seems that the issue repeats in pyexpat.vcxproj. I submitted a PR for that 
one as well.

--

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-24 Thread Segev Finer

Changes by Segev Finer :


--
versions: +Python 3.5, Python 3.6

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30745] Warnings in Modules/_winapi.c

2017-06-24 Thread Segev Finer

Segev Finer added the comment:

I tried the PR locally and I didn't get the warnings. :)

--

___
Python tracker 
<http://bugs.python.org/issue30745>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-06-28 Thread Segev Finer

New submission from Segev Finer:

This is caused by _GNU_SOURCE being defined here: 
https://github.com/python/cpython/blob/c08177a1ccad2ed0d50898c2731b518c631aed14/configure.ac#L124,
 But also getting defined by AC_USE_SYSTEM_EXTENSIONS 
(https://github.com/python/cpython/blob/c08177a1ccad2ed0d50898c2731b518c631aed14/configure.ac#L906).

AC_USE_SYSTEM_EXTENSIONS does use an #ifndef but Python's AC_DEFINE seems to be 
getting order after it.

--
components: Build
messages: 297238
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by 
default]
type: compile error
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-06-29 Thread Segev Finer

Segev Finer added the comment:

All that remains is back porting https://github.com/python/cpython/pull/2375 
and than this issue is fixed.

--

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-29 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2551

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-29 Thread Segev Finer

Segev Finer added the comment:

I submitted a PR which fixes some more warnings. The ones I haven't fixed are 
detailed in the PR description.

--
nosy: +Segev Finer
versions: +Python 3.7

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-29 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2556

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2641

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2642

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Segev Finer added the comment:

Python 2.7 diverged 
https://github.com/python/cpython/commit/ab3b0ade505ce07a3d5ec4fbc991a154242732e6.
 It's only missing _CRT_SECURE_NO_WARNINGS. :P

--

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2643

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30726] [Windows] Warnings in elementtree due to new expat

2017-07-04 Thread Segev Finer

Segev Finer added the comment:

> The approach used to suppress this warning will also suppress other warnings 
> that might be fixable. Hard to say it's definitely a good thing in this case, 
> though in general I agree that selectively suppressing warnings that cannot 
> be fixed is a good thing.

Most secure CRT warnings are a bit useless in portable code since you are 
unlikely to really use strcpy_s and friends...

--

___
Python tracker 
<http://bugs.python.org/issue30726>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-11 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2736

___
Python tracker 
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-11 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2739

___
Python tracker 
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-11 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2740

___
Python tracker 
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

2017-07-12 Thread Segev Finer

Segev Finer added the comment:

The fix is now in 3.5-3.7 and 2.7, unless you intend to also back port to 3.4 
and 3.3, this can be closed.

--

___
Python tracker 
<http://bugs.python.org/issue30797>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-12 Thread Segev Finer

New submission from Segev Finer:

Shows in buildbots:

/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Modules/_json.c: In 
function ‘scanner_new’:
/home/dje/cpython-buildarea/3.x.edelsohn-sles-z/build/Modules/_json.c:1212:5: 
warning: comparison is always false due to limited range of data type 
[-Wtype-limits]
 if (s->strict < 0)
 ^

This means that the error check doesn't work right.

--
components: Extension Modules
messages: 298239
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: Warning in _json.c on platforms where char is unsigned
type: compile error
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-12 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2749

___
Python tracker 
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-13 Thread Segev Finer

Segev Finer added the comment:

Introduced in 
https://github.com/python/cpython/commit/ac5bbd43bc7b769c13ae0412cb28a3521f4d4ff1
 which is only in 3.7 that means this wasn't ever released. I can send a PR 
with a NEWS entry if it still needs one?

--

___
Python tracker 
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-15 Thread Segev Finer

Segev Finer added the comment:

Serhiy's change added tests to test_json, so you can say this unearthed ref 
leaks rather than introduced them. Probably needs a separate bpo issue and fix.

--

___
Python tracker 
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30936] json module ref leaks detected by test_json

2017-07-15 Thread Segev Finer

New submission from Segev Finer:

>From builtbots:

test_json leaked [4, 4, 4] references, sum=12
test_json leaked [3, 3, 3] memory blocks, sum=9
1 test failed again:
test_json

Probably unearthed by:
https://github.com/python/cpython/pull/2692
https://github.com/python/cpython/pull/2693

--
components: Extension Modules
messages: 298391
nosy: Segev Finer, haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: json module ref leaks detected by test_json
type: resource usage
versions: Python 3.5, Python 3.6

___
Python tracker 
<http://bugs.python.org/issue30936>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30911] Warning in _json.c on platforms where char is unsigned

2017-07-15 Thread Segev Finer

Segev Finer added the comment:

Created http://bugs.python.org/issue30936

--

___
Python tracker 
<http://bugs.python.org/issue30911>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29672] `catch_warnings` context manager causes all warnings to be printed every time, even after exiting

2017-07-21 Thread Segev Finer

Segev Finer added the comment:

I think you will need to save and restore _filters_version and _onceregistry. 
Since _filters_version is a static variable in _warnings.c you will probably 
also have to modify it somehow to make it accessible to warnings.py.

--
components: +Library (Lib)
nosy: +Segev Finer
type:  -> behavior
versions: +Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue29672>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-21 Thread Segev Finer

Segev Finer added the comment:

Try with:

.\python.bat Tools\msi\make_zip.py -a amd64 -o py37-amd64.zip

It requires amd64 instead of x64. Probably can add a choices 
(https://docs.python.org/3/library/argparse.html#choices) argument there to 
make it more robust.

--
nosy: +Segev Finer

___
Python tracker 
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30986] Add --include-py argument to Tools/msi/make_zip.py

2017-07-21 Thread Segev Finer

New submission from Segev Finer:

Add an argument --include-py to Tools/msi/make_zip.py that allows including the 
Python modules sources and not only bytecode.

I found it useful while running Twisted's test suite in PR 2318, since I got an 
error otherwise. I don't remember what that error was and wasn't able to 
reproduce it while trying to run Twisted's test suite again.

--
components: Windows
messages: 298826
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Add --include-py argument to Tools/msi/make_zip.py
type: enhancement
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30986>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30986] Add --include-py argument to Tools/msi/make_zip.py

2017-07-21 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2857

___
Python tracker 
<http://bugs.python.org/issue30986>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-21 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2859

___
Python tracker 
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27790] test_distutils spews linker messages on Windows

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

We are getting those warnings because distutils builds extension modules 
without /GL (https://msdn.microsoft.com/en-us/library/0zza0de8.aspx) but with 
/LTCG (https://msdn.microsoft.com/en-us/library/xbf3tbeh.aspx). We should 
either add /GL to truly enable whole program optimizations/link-time code 
generation or remove it.

It is added in 
https://github.com/python/cpython/blob/896145d9d266ee2758cfcd7691238cbc1f9e1ab8/Lib/distutils/_msvccompiler.py#L233-L241.

--
nosy: +Segev Finer
type:  -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue27790>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27790] test_distutils spews linker messages on Windows

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

Investigated some more. We are adding /GL for release but not in debug. But 
adding /LTCG for both debug and release.

--

___
Python tracker 
<http://bugs.python.org/issue27790>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue27790] test_distutils spews linker messages on Windows

2017-07-22 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2866

___
Python tracker 
<http://bugs.python.org/issue27790>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30986] Add --include-py argument to Tools/msi/make_zip.py

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

I used the full one. I doubt virtualenv (used by tox) will work with the 
embedding layout :P.

I remember getting an exception from something because it was missing the .py 
source files but I don't remember what it was and wasn't able to reproduce it 
now.

--

___
Python tracker 
<http://bugs.python.org/issue30986>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-22 Thread Segev Finer

Segev Finer added the comment:

I did make a PR which only changes -a/--arch to a choices argument. 
https://github.com/python/cpython/pull/2808

I guess the PR you are talking about is 
https://github.com/python/cpython/pull/2750/files which changes this entirely.

--

___
Python tracker 
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30916] Pre-build OpenSSL and Tcl/Tk for Windows

2017-07-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2894

___
Python tracker 
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

New submission from Segev Finer:

..\Modules\_tracemalloc.c(88): warning C4359: '': Alignment 
specifier is less than actual alignment (8), and will be ignored.

For this to actually work we simply need to use #pragma pack instead.

--
components: Extension Modules, Windows
messages: 298999
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: _tracemalloc frame_t packing optimization not working in Windows x64
type: enhancement
versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2895

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2896

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests:  -2896

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2897

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-24 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2902

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-25 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2920

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31018] _tracemalloc frame_t packing optimization not working in Windows x64

2017-07-25 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2919

___
Python tracker 
<http://bugs.python.org/issue31018>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-26 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2942

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-26 Thread Segev Finer

New submission from Segev Finer:

>python -X tracemalloc=30 -m unittest 
>test.test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed
Running Debug|x64 interpreter...
lib\asyncio\sslproto.py:330: ResourceWarning: unclosed transport 

  source=self)
Object allocated at (most recent call first):
  File "lib\asyncio\sslproto.py", lineno 435
self, self._app_protocol)
  File "lib\asyncio\proactor_events.py", lineno 401
server_side, server_hostname)
  File "lib\asyncio\proactor_events.py", lineno 507
extra={'peername': addr}, server=server)
  File "lib\asyncio\events.py", lineno 122
self._callback(*self._args)
  File "lib\asyncio\base_events.py", lineno 1413
handle._run()
  File "lib\asyncio\base_events.py", lineno 420
self._run_once()
  File "lib\asyncio\base_events.py", lineno 453
self.run_forever()
  File "lib\test\test_asyncio\test_events.py", lineno 1099
self.loop.run_until_complete(f_c)
  File "lib\unittest\case.py", lineno 615
testMethod()
  File "lib\unittest\case.py", lineno 663
return self.run(*args, **kwds)
  File "lib\unittest\suite.py", lineno 122
test(result)
  File "lib\unittest\suite.py", lineno 84
return self.run(*args, **kwds)
  File "lib\unittest\suite.py", lineno 122
test(result)
  File "lib\unittest\suite.py", lineno 84
return self.run(*args, **kwds)
  File "lib\unittest\runner.py", lineno 176
test(result)
  File "lib\unittest\main.py", lineno 256
self.result = testRunner.run(self.test)
  File "lib\unittest\main.py", lineno 95
self.runTests()
  File "lib\unittest\__main__.py", lineno 18
main(module=None)
  File "lib\runpy.py", lineno 85
exec(code, run_globals)
  File "lib\runpy.py", lineno 193
"__main__", mod_spec)
.
--
Ran 1 test in 1.408s

OK

--
components: Tests, Windows
messages: 299256
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: ResourceWarning in 
test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed
type: resource usage
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30916] Pre-build OpenSSL and Tcl/Tk for Windows

2017-07-26 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2953

___
Python tracker 
<http://bugs.python.org/issue30916>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-26 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2955

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-26 Thread Segev Finer

Segev Finer added the comment:

@haypo https://github.com/python/cpython/pull/2904

--

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-27 Thread Segev Finer

Changes by Segev Finer :


--
components: +asyncio
nosy: +yselivanov

___
Python tracker 
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-27 Thread Segev Finer

Changes by Segev Finer :


--
title: ResourceWarning in 
test_asyncio.test_events..ProactorEventLoopTests.test_create_server_ssl_verify_failed
 -> ResourceWarning in 
test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed

___
Python tracker 
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31048] ResourceWarning in test_asyncio.test_events.ProactorEventLoopTests.test_create_server_ssl_verify_failed

2017-07-27 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2973

___
Python tracker 
<http://bugs.python.org/issue31048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30222] make_zip.py had a bug when setting up full 64 bit distribution.

2017-07-27 Thread Segev Finer

Segev Finer added the comment:

Since PR 2750 is merged, I think this can be closed.

--

___
Python tracker 
<http://bugs.python.org/issue30222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-07-27 Thread Segev Finer

Segev Finer added the comment:

The only warnings that remain are:

1. The one from gcmodule.c due to dtrace, which is handled in PR 2852.
2. The peephole warnings which I'm not sure about. Are overflows possible there 
or not? That is, if there are already internal caps that prevent them. If they 
are possible, it might require a larger change to support EXTENDED_ARG in some 
places. i.e. can the consts table really grow larger than `unsigned int` or can 
a jump target be large enough to overflow?

--

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31078] pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the parent pdb uses rawinput

2017-07-29 Thread Segev Finer

New submission from Segev Finer:

This is caused by 
https://github.com/python/cpython/blob/caa1280d1ee5f828f346b585169a7592371d3faa/Lib/pdb.py#L1096
 which always passes our own current stdin and stdout, and this triggers the 
conditional in 
https://github.com/python/cpython/blob/caa1280d1ee5f828f346b585169a7592371d3faa/Lib/pdb.py#L144-L145.

self.stdin and self.stdout are initialized to sys.stdin and sys.stdout 
respectively when not passed explicitly: 
https://github.com/python/cpython/blob/caa1280d1ee5f828f346b585169a7592371d3faa/Lib/cmd.py#L87-L94.

See Also: https://github.com/ipython/ipython/pull/10721

--
components: Library (Lib)
messages: 299485
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the 
parent pdb uses rawinput
type: behavior
versions: Python 2.7, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue31078>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9325] Add an option to pdb/trace/profile to run library module as a script

2017-07-29 Thread Segev Finer

Changes by Segev Finer :


--
nosy: +Segev Finer

___
Python tracker 
<http://bugs.python.org/issue9325>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31078] pdb's debug command (Pdb.do_debug) doesn't use rawinput even if the parent pdb uses rawinput

2017-07-29 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2996

___
Python tracker 
<http://bugs.python.org/issue31078>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26618] _overlapped extension module of asyncio uses deprecated WSAStringToAddressA() function

2017-08-04 Thread Segev Finer

Segev Finer added the comment:

It was fixed here: 
https://github.com/python/cpython/commit/cc16be85c0b7119854c00fb5c666825deef641cf#diff-1308fc2ab05154373172f10e931c78f0L986.
 So it's fixed for 3.6 and 3.7, but not in 3.5.

--
nosy: +Segev Finer

___
Python tracker 
<http://bugs.python.org/issue26618>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16865] ctypes arrays >=2GB in length causes exception

2017-08-05 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +3040

___
Python tracker 
<http://bugs.python.org/issue16865>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30747] _Py_atomic_* not actually atomic on Windows with MSVC

2017-08-18 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +3175

___
Python tracker 
<http://bugs.python.org/issue30747>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-08-18 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +3174

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31328] _sha3 is missing from Setup.dist

2017-09-01 Thread Segev Finer

New submission from Segev Finer:

_sha3 is missing a commented out line from Setup.dist like the rest of the 
modules. It's really only used if someone wants to edit Setup.dist to build 
with the _sha3 module statically. Mostly a trivial change to add it in.

--
components: Build, Extension Modules
messages: 301144
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: _sha3 is missing from Setup.dist
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue31328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31328] _sha3 is missing from Setup.dist

2017-09-01 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +3311

___
Python tracker 
<http://bugs.python.org/issue31328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31328] _sha3 is missing from Setup.dist

2017-09-04 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +3324

___
Python tracker 
<http://bugs.python.org/issue31328>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-04-10 Thread Segev Finer

Segev Finer added the comment:

It's been a while since this got any attention...

--

___
Python tracker 
<http://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-04-19 Thread Segev Finer

Segev Finer added the comment:

Added the 4th version after review by eryksun (In rietveld).

--
Added file: 
http://bugs.python.org/file46814/windows-subprocess-close-fds-v4.patch

___
Python tracker 
<http://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-04-20 Thread Segev Finer

Segev Finer added the comment:

Added the 5th version after another review by eryksun (In rietveld).

--
Added file: 
http://bugs.python.org/file46819/windows-subprocess-close-fds-v5.patch

___
Python tracker 
<http://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-04-20 Thread Segev Finer

Segev Finer added the comment:

Oh LOL!!! I missed the fact that Python finally moved to GitHub!
Rebased the patch on top of the Git master XD (And removed accidentally 
committed code... sorry...)

I still submitted as a patch since I don't know if the infrastructure handles 
moving a patch to a PR well :P

--
Added file: 
http://bugs.python.org/file46820/windows-subprocess-close-fds-v6.patch

___
Python tracker 
<http://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-04-20 Thread Segev Finer

Segev Finer added the comment:

OK Rietveld definitely punted on the git patch (I guess it's only for the old 
Mercurial repo, I don't think it actually even support Git...)

I will try re-submitting the patch as a PR so that it can be reviewed easily.

--

___
Python tracker 
<http://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30121] Windows: subprocess debug assertion on failure to execute the process

2017-04-20 Thread Segev Finer

New submission from Segev Finer:

subprocess triggers a debug assertion in the CRT on failure to execute the 
process due to closing the pipe *handles* in the except clause using os.close 
rather than .Close() (os.close closes CRT file descriptors and not handles).

In addition to that once this is fixed there is also a double free/close since 
we need to set `self._closed_child_pipe_fds = True` once we closed the handles 
in _execute_child so they won't also be closed in __init__.

To reproduce, do this in a debug build of Python:

import subprocess
subprocess.Popen('exe_that_doesnt_exist.exe', stdout=subprocess.PIPE)

See: https://github.com/python/cpython/pull/1218#discussion_r112550959

--
components: Library (Lib), Windows
messages: 292002
nosy: Segev Finer, eryksun, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Windows: subprocess debug assertion on failure to execute the process
type: behavior
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29191] liblzma is missing from pcbuild.sln

2017-04-20 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +1345

___
Python tracker 
<http://bugs.python.org/issue29191>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30121] Windows: subprocess debug assertion on failure to execute the process

2017-04-20 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +1346

___
Python tracker 
<http://bugs.python.org/issue30121>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29191] liblzma is missing from pcbuild.sln

2017-04-21 Thread Segev Finer

Segev Finer added the comment:

The PR was merged for Python 3.7. But this also affects older Python 3 versions 
that include liblzma/_lzma as far as I can tell. So I'm not closing this issue 
just yet, so that it will serve as a remainder, in case you do want to back 
port this.

Thanks for merging! :)

--

___
Python tracker 
<http://bugs.python.org/issue29191>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19764] subprocess: use PROC_THREAD_ATTRIBUTE_HANDLE_LIST with STARTUPINFOEX on Windows Vista

2017-05-22 Thread Segev Finer

Segev Finer added the comment:

GitHub PR bit rotting away... :P

Just a friendly reminder :)

--

___
Python tracker 
<http://bugs.python.org/issue19764>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30544] _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails

2017-06-01 Thread Segev Finer

New submission from Segev Finer:

Found due to this: https://github.com/pytest-dev/py/issues/103

I'm going to submit a PR.

--
components: IO, Windows
messages: 294975
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW 
fails
versions: Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30544>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30544] _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails

2017-06-01 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +1992

___
Python tracker 
<http://bugs.python.org/issue30544>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30544] _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails

2017-06-02 Thread Segev Finer

Segev Finer added the comment:

We might want to open a separate issue for the FD redirection issue since this 
one was really about the _io._WindowsConsoleIO.write GetLastError() issue.

Also see https://github.com/pytest-dev/pytest/pull/2462 where I discuss this 
more.

Still not sure why it's random in Pytest. I can only guess it's due to another 
console handle getting opened with the same number or something.

--

___
Python tracker 
<http://bugs.python.org/issue30544>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30555] _io._WindowsConsoleIO breaks in the face of fd redirection

2017-06-02 Thread Segev Finer

New submission from Segev Finer:

_WindowsConsoleIO works by taking the handle out of the file descriptors of the 
stdio handles (get_osfhandle) and reading/writing to it directly using 
ReadConsoleW/WriteConsoleW.

The problem is that some Python code wants to do file descriptor level 
redirection by overwriting the standard file descriptors using dup2. The 
problem is that this is also going to close the handle that Python itself is 
going to use to read/write to the console. Leading to the following:

>>> fd = os.open('stdout.txt', os.O_CREAT | os.O_WRONLY)
>>> os.dup2(fd, 1)
>>> print('spam')
Traceback (most recent call last):
  File "", line 1, in 
OSError: [WinError 87] The parameter is incorrect  # "OSError: [WinError 6] 
The handle is invalid" after https://bugs.python.org/issue30544

This manifests itself for example in Pytest which does fd redirection to 
capture test output. See https://github.com/pytest-dev/py/issues/103 for the 
issue. And see https://github.com/pytest-dev/pytest/pull/2462 for an WIP 
attempt to workaround this.

This issue also impacts other code that uses console handles itself like 
colorama: https://github.com/pytest-dev/pytest/issues/2465. Though that code is 
likely going to have to deal with this by itself.

Those file descriptors are an emulation implemented by the Universal CRT and 
you can see their implementation in your copy of the Windows SDK. It's quite 
possible that this doesn't happen in older CRT versions either since colorama 
doesn't seem to break on Python 2.7 for example.

One way I can think working around this is that Python will DuplicateHandle the 
console handles so that even if dup2 closes the original ones it will keep on 
working. We can also switch to calling _get_osfhandle always instead of caching 
the handle, it will break when the fd is redirected to a non-console. But so 
does _WindowsConsoleIO in general since it will try to continue writing to the 
console despite the redirection, meaning that Python code doing redirection has 
to handle sys.std* anyhow. Though I'm not sure about the performance of 
constantly calling _get_osfhandle. And their yet might be other ways to solve 
this.

Also see comment by eryksun https://bugs.python.org/msg294988

Solving this in CPython will remove the need for hacks like the PR I referenced.

--
components: IO, Windows
messages: 295041
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: _io._WindowsConsoleIO breaks in the face of fd redirection
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30555>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30555] _io._WindowsConsoleIO breaks in the face of fd redirection

2017-06-02 Thread Segev Finer

Changes by Segev Finer :


--
nosy: +eryksun

___
Python tracker 
<http://bugs.python.org/issue30555>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30544] _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails

2017-06-02 Thread Segev Finer

Changes by Segev Finer :


--
type:  -> behavior

___
Python tracker 
<http://bugs.python.org/issue30544>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30555] _io._WindowsConsoleIO breaks in the face of fd redirection

2017-06-03 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2007

___
Python tracker 
<http://bugs.python.org/issue30555>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30567] Leak in sys.getwindowsversion

2017-06-04 Thread Segev Finer

New submission from Segev Finer:

There is a ref leak in sys.getwindowsversion due to using PyTuple_Pack and 
forgetting that it increments the ref count of passed in objects. Found here: 
https://github.com/python/cpython/pull/1927#issuecomment-306019512.

Clearly shows up in python -m test -R 3:2 test_sys

--
components: Interpreter Core
messages: 295132
nosy: Segev Finer
priority: normal
severity: normal
status: open
title: Leak in sys.getwindowsversion
type: resource usage
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30567>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30567] Leak in sys.getwindowsversion

2017-06-04 Thread Segev Finer

Changes by Segev Finer :


--
nosy: +eryksun

___
Python tracker 
<http://bugs.python.org/issue30567>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30567] Leak in sys.getwindowsversion

2017-06-04 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2019

___
Python tracker 
<http://bugs.python.org/issue30567>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30631] Warnings in VS2015 Update 3 32-Bit

2017-06-11 Thread Segev Finer

New submission from Segev Finer:

I'm hitting the following warnings when building in VS2015 Update 3 in 32-bit:

liblzma:
warning C4028: formal parameter {} different from declaration
warning C4113: 'FARPROC' differs in parameter lists from '{}'
warning C4244: 'initializing': conversion from '{}' to '{}', possible loss 
of data
warning C4267: '=': conversion from '{}' to '{}', possible loss of data
warning C4996: 'GetVersion': was declared deprecated

libeay:
warning C4996: 'gethostbyname': Use getaddrinfo() or GetAddrInfoW() instead 
or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings

socketmodule:
 warning C4996: '{}': Use {}() or {}() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings (multiple)

tix:
warning C4090: 'function': different 'const' qualifiers
warning C4028: formal parameter {} different from declaration

And ValidateUcrtbase in python.vcxproj is failing on first build because it 
depends on ctypes but runs before it's built when building using the pcbuild.sln

--
components: Windows
messages: 295732
nosy: Segev Finer, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Warnings in VS2015 Update 3 32-Bit
type: behavior
versions: Python 3.7

___
Python tracker 
<http://bugs.python.org/issue30631>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30631] Warnings in VS2015 Update 3 32-Bit

2017-06-11 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2170

___
Python tracker 
<http://bugs.python.org/issue30631>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9566] Compilation warnings under x64 Windows

2017-06-11 Thread Segev Finer

Changes by Segev Finer :


--
pull_requests: +2171

___
Python tracker 
<http://bugs.python.org/issue9566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32814] smtplib.send_message mishandles 8BITMIME RFC 6152

2018-02-10 Thread Segev Finer

New submission from Segev Finer :

According to https://tools.ietf.org/html/rfc6152 you should only send an 8bit 
email body when the server advertises 8BITMIME in the EHLO, and you should 
declare it with BODY=8BITMIME in the MAIL command.

The default cte_type is 8bit for the new default email policy which is what 
will be used by smtplib.send_message when it calls BytesGenerator.flatten, but 
it will not set BODY=8BITMIME even if the message has any 8-bit characters. It 
will only set BODY=8BITMIME if the message uses any utf-8 mail/from addresses. 
This means that a message with ASCII addresses and an 8-bit utf-8 body will be 
sent without BODY=8BITMIME (I think that's actually quite common).

What should be done is checking if the server advertises 8BITMIME, and if it 
doesn't use cte_type=7bit; if it does we should set BODY=8BITMIME if the policy 
is using cte_type=8bit.

I don't know whether any real email server chokes on this. But it's best to 
follow the RFC, I think.

--
components: Library (Lib), email
messages: 311947
nosy: Segev Finer, barry, r.david.murray
priority: normal
severity: normal
status: open
title: smtplib.send_message mishandles 8BITMIME RFC 6152
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue32814>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32815] Document text parameter to subprocess.Popen

2018-02-10 Thread Segev Finer

New submission from Segev Finer :

The new text parameter in subprocess was documented for subprocess.run but not 
for subprocess.Popen in the Sphinx documentation. It is documented in the 
docstring for both though.

--
assignee: docs@python
components: Documentation
messages: 311949
nosy: Segev Finer, docs@python
priority: normal
severity: normal
status: open
title: Document text parameter to subprocess.Popen
type: enhancement
versions: Python 3.7

___
Python tracker 
<https://bugs.python.org/issue32815>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32370] Wrong ANSI encoding used by subprocess for some locales

2018-02-10 Thread Segev Finer

Change by Segev Finer :


--
keywords: +patch
pull_requests: +5418
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue32370>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32370] Wrong ANSI encoding used by subprocess for some locales

2018-02-10 Thread Segev Finer

Change by Segev Finer :


--
versions: +Python 3.8

___
Python tracker 
<https://bugs.python.org/issue32370>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32818] multiprocessing segmentfault under Windows compatibility mode

2018-03-01 Thread Segev Finer

Segev Finer  added the comment:

Windows seems to dereference lpStartupInfo->lpAttributeList, despite it being 
NULL since we had no attributes to set. Smells like a Windows bug in the 
compatibility shim, since it doesn't crash in non compatibility mode.

Not setting EXTENDED_STARTUPINFO_PRESENT when lpStartupInfo->lpAttributeList is 
NULL will fix this. Not sure about lpStartupInfo->cb, I think Windows only 
checks it's large enough.

Also attached is a crash dump with symbols and used source revision of a 
reproduction of this.

Stack Trace:
00 00fee690 5ad47c1c 
AcLayers!NS_ElevateCreateProcess::APIHook_CreateProcessW+0x110
01 00fee740 5ad45f79 python38_d!_winapi_CreateProcess_impl+0x15c 
[cpython\modules\_winapi.c @ 1046]
02 00fee798 5ad78e75 python38_d!_winapi_CreateProcess+0x79 
[cpython\modules\clinic\_winapi.c.h @ 326]
03 00fee7f8 5ad77b64 python38_d!_PyMethodDef_RawFastCallKeywords+0x245 
[cpython\objects\call.c @ 651]
04 00fee81c 5aed8f9f python38_d!_PyCFunction_FastCallKeywords+0x84 
[cpython\objects\call.c @ 730]
05 00fee854 5aee038f python38_d!call_function+0x15f [cpython\python\ceval.c @ 
4532]
06 00fee8f4 5ad7b336 python38_d!_PyEval_EvalFrameDefault+0x59bf 
[cpython\python\ceval.c @ 3128]
07 00fee92c 5ad77ce4 python38_d!function_code_fastcall+0xe6 
[cpython\objects\call.c @ 283]
08 00fee994 5ad79be7 python38_d!_PyFunction_FastCallDict+0x134 
[cpython\objects\call.c @ 322]
09 00fee9d8 5ad79aa6 python38_d!_PyObject_FastCallDict+0xc7 
[cpython\objects\call.c @ 98]
0a 00feea14 5ae0b8f7 python38_d!_PyObject_Call_Prepend+0xf6 
[cpython\objects\call.c @ 904]
0b 00feea50 5ae10a97 python38_d!slot_tp_init+0x47 [cpython\objects\typeobject.c 
@ 6597]
0c 00feea74 5ad7a28e python38_d!type_call+0x187 [cpython\objects\typeobject.c @ 
949]
0d 00feeae0 5aed91d1 python38_d!_PyObject_FastCallKeywords+0x37e 
[cpython\objects\call.c @ 199]
0e 00feeb18 5aedc95b python38_d!call_function+0x391 [cpython\python\ceval.c @ 
4576]

--
Added file: https://bugs.python.org/file47465/crash32818.zip

___
Python tracker 
<https://bugs.python.org/issue32818>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32818] multiprocessing segmentfault under Windows compatibility mode

2018-03-01 Thread Segev Finer

Change by Segev Finer :


--
keywords: +patch
pull_requests: +5716
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue32818>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >