[issue26876] Extend MSVCCompiler class to respect environment variables
Rohit Jamuar added the comment: Bump! The changes, that Steve was asking for, have been incorporated. If something was missed, please inform. Otherwise, could this be merged? -- ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : Removed file: http://bugs.python.org/file42725/distutils_patch_master.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : Added file: http://bugs.python.org/file45880/distutils_patch_master.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : Removed file: http://bugs.python.org/file45880/distutils_patch_master.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : Added file: http://bugs.python.org/file45881/distutils_patch_master.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Rohit Jamuar added the comment: Steve, I've limited the changes to _msvccompiler for the master-branch's patch. Is it alright? -- ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
New submission from Rohit Jamuar: The UnixCompiler class respects flags (CC, LD, AR, CFLAGS and LDFLAGS) set to the environment, whereas MSVCCompiler class does not. This change allows building CPython and any module that invokes distutils to utilize flags and executables that have been set to the environment. Inclusion of this change would ensure MSVCCompiler's behavior to be same as that of UnixCompiler and would also allow using a different set of compiler / linker / archiver, on Windows, without having the necessity for implementing separate compiler classes - using environment variables it should be possible to use a separate set of build executables - for example icl, clang, etc. -- components: Distutils files: msvc_respect_env_flags.patch keywords: patch messages: 264439 nosy: dstufft, eric.araujo, r.david.murray, rohitjamuar, zach.ware priority: normal severity: normal status: open title: Extend MSVCCompiler class to respect environment variables type: enhancement versions: Python 2.7, Python 3.5 Added file: http://bugs.python.org/file42642/msvc_respect_env_flags.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Rohit Jamuar added the comment: Just so that I understand it clearly - Inside MSVCCompiler class (in _msvccompiler.py / msvccompiler.py / msvc9compiler.py ), current implementation of find_exe() finds compiler / linker / ... after parsing PATH. Should the changes be so, that if DISTUTILS_USE_SDK is set to the environment, the values set to CC / AR / LD, etc. are used verbatim? Or did you mean to say, that just as CC, LD and AR are being read from the environment, the same way rc.exe, mc.exe and mt.exe should be read as well, in case DISTUTILS_USE_SDK is set to the environment? -- ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : Removed file: http://bugs.python.org/file42642/msvc_respect_env_flags.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : -- versions: +Python 3.6 -Python 2.7 Added file: http://bugs.python.org/file42725/distutils_patch_master.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26876] Extend MSVCCompiler class to respect environment variables
Changes by Rohit Jamuar : -- versions: +Python 2.7 -Python 3.5, Python 3.6 Added file: http://bugs.python.org/file42726/distutils_patch_27.patch ___ Python tracker <http://bugs.python.org/issue26876> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com