[issue17200] telnetlib.read_until() timeout uses the wrong units
New submission from Reuben D'Netto: read_until() takes a value for timeout in seconds, but passes it to poll(), which takes a value in milliseconds. -- files: telnetlib.py.patch keywords: patch messages: 181993 nosy: Reuben.D'Netto priority: normal severity: normal status: open title: telnetlib.read_until() timeout uses the wrong units type: behavior versions: Python 3.3 Added file: http://bugs.python.org/file29055/telnetlib.py.patch ___ Python tracker <http://bugs.python.org/issue17200> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17200] telnetlib.read_until() timeout uses the wrong units
Reuben D'Netto added the comment: Updated patch to fix expect() as well. -- Added file: http://bugs.python.org/file29056/telnetlib.py.patch ___ Python tracker <http://bugs.python.org/issue17200> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17200] telnetlib.read_until() timeout uses the wrong units
Reuben D'Netto added the comment: Sure, no problem. I'll upload the completed patch once I've got it working. -- ___ Python tracker <http://bugs.python.org/issue17200> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17200] telnetlib.read_until() timeout uses the wrong units
Reuben D'Netto added the comment: OK, I've implemented tests for read_until() and expect() using both poll and select. I ended up rewriting _read_until_with_select() to look more like the poll equivalent in the process, which should hopefully make it more maintainable. -- Added file: http://bugs.python.org/file29076/telnetlib.patch ___ Python tracker <http://bugs.python.org/issue17200> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
