[issue46028] 3.11.0a3: under tox, sys._base_executable is wrong

2021-12-09 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Steve, could this be related to the changes in getpath?

--
nosy: +steve.dower

___
Python tracker 
<https://bugs.python.org/issue46028>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46028] 3.11.0a3: under tox, sys._base_executable is wrong

2021-12-09 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
priority: normal -> release blocker

___
Python tracker 
<https://bugs.python.org/issue46028>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46028] 3.11.0a3: under tox, sys._base_executable is wrong

2021-12-09 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Ned, are you able to bisect this or provide a simpler reproducer that doesn't 
involve tox?

--

___
Python tracker 
<https://bugs.python.org/issue46028>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43931] Add the Python version to the API data.

2021-12-09 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue43931>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46028] 3.11.0a3: under tox, sys._base_executable is wrong

2021-12-10 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Indeed, seems my original hunch is correct. Steve, could you take a look when 
you have some time?

--

___
Python tracker 
<https://bugs.python.org/issue46028>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-10 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Thanks for the catch Carl!

> I can try to fix this.

Awesome, I will wait for the PR!

--

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-11 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28279
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30059

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-11 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Don't worry, turns out it was a bit messier than I thought, so I prepared the 
PR. If you have some time, it would be great if you can take a quick look.

--

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-11 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 59435eea08d30796174552c0ca03c59b41adf8a5 by Pablo Galindo Salgado 
in branch 'main':
bpo-46042: Improve SyntaxError locations in the symbol table (GH-30059)
https://github.com/python/cpython/commit/59435eea08d30796174552c0ca03c59b41adf8a5


--

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-11 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-11 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> Oh no, I was about to open mine ;-)

Sorry, Carl, I apologize. I hope it was not too disruptive to do the work. I 
was taking a look and I felt bad that the issue was probably messier than I 
thought and I didn't want you to have to iterate many times :(

Thanks a lot for helping review the PR and for pointing out the extra cases!!

--

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46042] Error range of "duplicate argument" SyntaxErrors is too big

2021-12-11 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 438817fdd5b731d486285d205bed2e78b655c0d6 by Miss Islington (bot) 
in branch '3.10':
bpo-46042: Improve SyntaxError locations in the symbol table (GH-30059) 
(GH-30064)
https://github.com/python/cpython/commit/438817fdd5b731d486285d205bed2e78b655c0d6


--

___
Python tracker 
<https://bugs.python.org/issue46042>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46054] Incorrect error when parsing non-utf8 files

2021-12-11 Thread Pablo Galindo Salgado


New submission from Pablo Galindo Salgado :

Python3.9 shows:

 ../3.9/python /bin/ls
SyntaxError: Non-UTF-8 code starting with '\xfc' in file /bin/ls on line 2, but 
no encoding declared; see https://python.org/dev/peps/pep-0263/ for detail

while 3.10 shows:

 python /bin/ls
  File "/bin/ls", line 0

SyntaxError: unknown parsing error

--
components: Parser
messages: 408361
nosy: lys.nikolaou, pablogsal
priority: normal
severity: normal
status: open
title: Incorrect error when parsing non-utf8 files
versions: Python 3.10, Python 3.11

___
Python tracker 
<https://bugs.python.org/issue46054>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46054] Incorrect error when parsing non-utf8 files

2021-12-11 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28288
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30068

___
Python tracker 
<https://bugs.python.org/issue46054>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46054] Incorrect error when parsing non-utf8 files

2021-12-11 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 4325a766f5f603ef6dfb8c4d5798e5e73cb5efd5 by Pablo Galindo Salgado 
in branch 'main':
bpo-46054: Fix parsing error when parsing non-utf8 characters in source files 
(GH-30068)
https://github.com/python/cpython/commit/4325a766f5f603ef6dfb8c4d5798e5e73cb5efd5


--

___
Python tracker 
<https://bugs.python.org/issue46054>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46054] Incorrect error when parsing non-utf8 files

2021-12-12 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
pull_requests: +28296
pull_request: https://github.com/python/cpython/pull/30074

___
Python tracker 
<https://bugs.python.org/issue46054>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46054] Incorrect error when parsing non-utf8 files

2021-12-12 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 94483f1e3cec182fabe19268e579f63045bc984a by Miss Islington (bot) 
in branch '3.10':
bpo-46054: Fix parsing error when parsing non-utf8 characters in source files 
(GH-30068) (GH-30069)
https://github.com/python/cpython/commit/94483f1e3cec182fabe19268e579f63045bc984a


--

___
Python tracker 
<https://bugs.python.org/issue46054>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46054] Incorrect error when parsing non-utf8 files

2021-12-12 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset c6d1c52c166968fb722ae26d44aa2c1c030dc613 by Pablo Galindo Salgado 
in branch 'main':
bpo-46054: Correct non-utf8 character tests in test_exceptions (GH-30074)
https://github.com/python/cpython/commit/c6d1c52c166968fb722ae26d44aa2c1c030dc613


--

___
Python tracker 
<https://bugs.python.org/issue46054>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46091] IndendationError from multi-line indented statements

2021-12-15 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

This is a side effect on the fix in:

https://bugs.python.org/issue40847

--

___
Python tracker 
<https://bugs.python.org/issue46091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46091] IndendationError from multi-line indented statements

2021-12-15 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Unfortunately I am not sure if this is going to be easier to retrofit for the 
reasons exposed in the issue. I will try to take a look, but if you have some 
cycles to spare, a PR would be welcomed.

--

___
Python tracker 
<https://bugs.python.org/issue46091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46091] IndendationError from multi-line indented statements

2021-12-15 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Actually, I am not sure if this is a bug, at least according to this comment:

https://bugs.python.org/msg370812

What are your thoughts on this Guido?

--
nosy: +gvanrossum

___
Python tracker 
<https://bugs.python.org/issue46091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46091] IndendationError from multi-line indented statements

2021-12-15 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28349
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30130

___
Python tracker 
<https://bugs.python.org/issue46091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46091] IndendationError from multi-line indented statements

2021-12-15 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

nevermind, I am convinced is a bug. I filed a PR for it

--
stage: patch review -> 

___
Python tracker 
<https://bugs.python.org/issue46091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46091] IndendationError from multi-line indented statements

2021-12-15 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
Removed message: https://bugs.python.org/msg408657

___
Python tracker 
<https://bugs.python.org/issue46091>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] `eval("-"*3000000 + "4")` in cmd causes hard crash

2021-12-17 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy:  -pablogsal

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46090] C extensions can't swap out live frames anymore

2021-12-17 Thread Pablo Galindo Salgado

Pablo Galindo Salgado  added the comment:

That is weird, but can happen for example if some pthread of some c extensiΓ³n 
for example picks up the Gil, causing a new PyThreadState to be created and 
linked but has not called into Python yet.

Basically, an external native thread that calls 
PyGILState_Ensure leaves a thread state with these characteristics.

--

___
Python tracker 
<https://bugs.python.org/issue46090>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46090] C extensions can't swap out live frames anymore

2021-12-17 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Relevant section:

 https://docs.python.org/3/c-api/init.html#non-python-created-threads

--

___
Python tracker 
<https://bugs.python.org/issue46090>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-17 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

This is a stack overflow in the parser, unfortunately, which unfortunately is 
very difficult to defend against.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-17 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

This is a known issue for recursive descendent parsers. The only thing we can 
do here is somehow limit the maximum stack depth of the C stack, but that can:

* Slow down the parser.
* Limit valid expressions that otherwise won't segfault.
* Still don't work in certain systems.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-17 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I worked in the past in a refactor of the math based rules 
(https://github.com/python/cpython/pull/20696/files) that could prevent 
**this** particular example, but others could still make the parser crash by 
stack overflow

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6110] IDLE has two "Preferences..." menu's on OSX

2021-12-17 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy: +pablogsal
nosy_count: 2.0 -> 3.0
pull_requests: +28394
pull_request: https://github.com/python/cpython/pull/30177

___
Python tracker 
<https://bugs.python.org/issue6110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-17 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I made a draft PR here:

https://github.com/python/cpython/pull/30177

to fix the issue. But we should benchmark and evaluate it before deciding 
anything.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-17 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28395
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30177

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6110] IDLE has two "Preferences..." menu's on OSX

2021-12-17 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
pull_requests: +28396
pull_request: https://github.com/python/cpython/pull/30177

___
Python tracker 
<https://bugs.python.org/issue6110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-20 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset e9898bf153d26059261ffef11f7643ae991e2a4c by Pablo Galindo Salgado 
in branch 'main':
bpo-46110: Add a recursion check to avoid stack overflow in the PEG parser 
(GH-30177)
https://github.com/python/cpython/commit/e9898bf153d26059261ffef11f7643ae991e2a4c


--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-20 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
pull_requests: +28435
pull_request: https://github.com/python/cpython/pull/30214

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-20 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
pull_requests: +28436
pull_request: https://github.com/python/cpython/pull/30215

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-20 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset dc73199a212a44553578eb4952631e5ba9e5f292 by Pablo Galindo Salgado 
in branch '3.10':
[3.10] bpo-46110: Add a recursion check to avoid stack overflow in the PEG 
parser (GH-30177) (GH-30214)
https://github.com/python/cpython/commit/dc73199a212a44553578eb4952631e5ba9e5f292


--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-20 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2021-12-20 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset e5cf31d3c2b30d12f238c6ab26d15855eefb2a8a by Pablo Galindo Salgado 
in branch '3.9':
[3.9] bpo-46110: Add a recursion check to avoid stack overflow in the PEG 
parser (GH-30177) (#30215)
https://github.com/python/cpython/commit/e5cf31d3c2b30d12f238c6ab26d15855eefb2a8a


--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue37295] Possible optimizations for math.comb()

2021-12-21 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy:  -pablogsal

___
Python tracker 
<https://bugs.python.org/issue37295>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46167] Parse assert (x == y, "Descriptive text") as statement params instead of a tuple

2021-12-23 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I can try to prototype something in the parser to see how it looks and work on 
the pep if everything looks ok.

Parentheses are a bit tricky in general as backtracking ends causing all sorts 
of tricky situations with custom syntax errors as the parser needs to 
distinguish between function calls, tuple construction and grouping so that's 
the only dangerous situation I can think of

--
nosy:  -gvanrossum, serhiy.storchaka

___
Python tracker 
<https://bugs.python.org/issue46167>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46167] Parse assert (x == y, "Descriptive text") as statement params instead of a tuple

2021-12-23 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> We managed to do this for 'with' so it should be possible here too, I'd 
> think. The "committing" token would be the newline following the close 
> parenthesis.


I am not so sure is that inmediate. Changing the assert statement from:

 'assert' a=expression b=[',' z=expression { z }]

to

| 'assert' '(' a=expression b=[',' z=expression { z }] ')'
| 'assert' a=expression b=[',' z=expression { z }] 

will render this invalid:

assert (a, b) <= c, "something"

The reason is that it will parse the (a, b) as the assert statement eagerly and 
then it will fail to parse the rest.

--

___
Python tracker 
<https://bugs.python.org/issue46167>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46167] Parse assert (x == y, "Descriptive text") as statement params instead of a tuple

2021-12-23 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

We could do this, but feels a bit hacky:

| 'assert' '(' a=expression b=[',' z=expression { z }] ')' &(NEWLINE | ';')
| 'assert' a=expression b=[',' z=expression { z }]

--

___
Python tracker 
<https://bugs.python.org/issue46167>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46167] Parse assert (x == y, "Descriptive text") as statement params instead of a tuple

2021-12-23 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Another possibility is actually handled this in the compiler:

if we see an assert with a tuple of two elements, we can assume is basically in 
the form that we want and proceed as if is in the form
assert A, B

This also feels a bit hacky because the AST is somehow wrong as the assert node 
is already prepared to differentiate these two cases.

--

___
Python tracker 
<https://bugs.python.org/issue46167>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46167] Parse assert (x == y, "Descriptive text") as statement params instead of a tuple

2021-12-23 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28465
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30247

___
Python tracker 
<https://bugs.python.org/issue46167>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46206] Crash when editing emoji containing strings

2021-12-31 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

This seems to be fixed on the main branch (at least I cannot reproduce it in 
the main branch). If so, this means that will be fixed in Python 3.10.2.

10maurycy10, could you please confirm that this is indeed the case?

--

___
Python tracker 
<https://bugs.python.org/issue46206>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46206] Crash when editing emoji containing strings

2021-12-31 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46206>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46206] Crash when editing emoji containing strings

2021-12-31 Thread Pablo Galindo Salgado

Pablo Galindo Salgado  added the comment:

Example:

>>> ___πŸ˜€
  File "", line 1
___πŸ˜€
   ^
SyntaxError: invalid character 'πŸ˜€' (U+1F600)
>>> __πŸ˜€
  File "", line 1
__πŸ˜€
  ^
SyntaxError: invalid character 'πŸ˜€' (U+1F600)

--

___
Python tracker 
<https://bugs.python.org/issue46206>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

>It seems that the PR was merged without discussion about 85% regression in 
>python_startup benchmark

Ugh, that's quite bad. We measured performance impact in general and that was 
quite acceptable  but seems that for startup this is quite sensitive :(

There isn't many other ways we can do this that I can think of unfortunately, 
so we need to make a decision on what we care most here, unless someone has a 
better idea on how we can overcome the recursion problem.

Adding Guido and Eric as they gave been working on startup quite a lot.

--
nosy: +eric.snow, gvanrossum
priority: normal -> release blocker
status: closed -> open

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy: +lukasz.langa
versions: +Python 3.11, Python 3.9

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Guido, Eric, what are your thoughts here?

The fix that I merged works by limiting the maximum recursion but seems that 
incrementing the recursion counter on every parser call makes quite a lot of 
impact on startup.

Unfortunately if we revert the fix, we still have the problem that Python can 
segfault for certain inputs that overload the stack.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> Let me have a look. May take a day, okay?--

Absolutely! There is no rush as the only close release IIRC is another alpha of 
3.11.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46230] NEWLINE* is missing in 'file' rule in PEG grammar

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I don't know what you mean with "it's missing". That is the actual rule used in 
the grammar:

https://github.com/python/cpython/blob/8e75c6b49b7cb8515b917f01b32ece8c8ea2c0a0/Grammar/python.gram#L88

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46230>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46231] grammar rule definition is missing: invalid_double_starred_kvpairs

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

invalid_* rules are not part of the official grammar as they are only used for 
error reporting. We need to update the peg grammar highlighter to exclude it

--

___
Python tracker 
<https://bugs.python.org/issue46231>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46231] grammar rule definition is missing: invalid_double_starred_kvpairs

2022-01-02 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28553
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30341

___
Python tracker 
<https://bugs.python.org/issue46231>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

This are my results running directly the pyperformance run script 
(https://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_python_startup/run_benchmark.py)
 with and without the fix (both PGO/LTO):

pablogsal@Obsidian-W:~$ ./cpython/python startup_benchmark.py --compare-to 
./cpython_base/python
python_with_fix: . 8.14 ms +- 0.17 ms
python_with_reverted_fix: . 8.05 ms +- 0.16 ms

Mean +- std dev: [python_with_fix] 8.14 ms +- 0.16 ms -> 
[python_with_reverted_fix] 8.05 ms +- 0.17 ms: 1.01x faster

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I am not able to reproduce on Linux either, with pyperformance or manual 
testing in the CLI. 

Interestingle, this shows up in both machines:

https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=1&revs=50&equid=off&quarts=on&extr=on

https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=4&revs=50&equid=off&quarts=on&extr=on

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> Does python_startup benchmark start with all modules parsed and __pycache__d, 
> or with no cache, so it includes the normally one-time parse time?

I don't know what pyperf does with the cache (adding Victor as maybe he knowns).

--
nosy: +vstinner

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado

Pablo Galindo Salgado  added the comment:

Ran pyperformance with PGO/LTO CPU-isol on my Linux box and I cannot reproduce 
either:

❯ pyperf compare_to json/* --table --table-format=md -G
| Benchmark  | 2021-12-20_10-23-master-6ca78affc802 | 
2021-12-20_15-43-master-e9898bf153d2 |
||::|::|
| python_startup | 19.7 ms  | 19.0 ms: 1.03x faster 
   |

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-02 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> Maybe something unrelated changed on the benchmark machines?

Very unlikely, it happened on two separate machines with different 
distributions and nothing was updated in the machines that I can see.

Both use a configuration file for pyperformance that looks like this:

-

$ cat bench.conf

[config]
json_dir = ~/json_cron

[scm]
repo_dir = ~/cpython_cron
update = True
remote = origin

[compile]
lto = True
pgo = True
bench_dir = ~/bench_tmpdir_cron

[run_benchmark]
system_tune = True
upload = False

[upload]
url = https://speed.python.org/
environment = speed-python
executable = lto-pgo
project = CPython

[compile_all]

[compile_all_revisions]
COMMIT_SHA=master

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42202] Optimize function annotation

2022-01-02 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy:  -pablogsal

___
Python tracker 
<https://bugs.python.org/issue42202>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> I propose a test: revert the PR and see if speed.Python.org shows a speedup
back to the previous number.--

Ok, let's do that and see what happens

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
pull_requests: +28577
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/30363

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 9d35dedc5e7e940b639230fba93c763bd9f19c09 by Pablo Galindo Salgado 
in branch 'main':
Revert "bpo-46110: Add a recursion check to avoid stack overflow in the PEG 
parser (GH-30177)" (GH-30363)
https://github.com/python/cpython/commit/9d35dedc5e7e940b639230fba93c763bd9f19c09


--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
pull_requests: +28579
pull_request: https://github.com/python/cpython/pull/30366

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44092] [sqlite3] Remove special rollback handling

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 9d6a239a34a66e16188d76c23a3a770515ca44ca by Erlend Egeberg 
Aasland in branch 'main':
bpo-44092: Don't reset statements/cursors before rollback (GH-26026)
https://github.com/python/cpython/commit/9d6a239a34a66e16188d76c23a3a770515ca44ca


--
nosy: +pablogsal

___
Python tracker 
<https://bugs.python.org/issue44092>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44092] [sqlite3] Remove special rollback handling

2022-01-03 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue44092>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I ran the benchmarks machines with the revert and seems that it doesn't go back 
to the previous timing:

https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=1&revs=50&equid=off&quarts=on&extr=on

(check last data point for 
https://github.com/python/cpython/commit/9d35dedc5e7e940b639230fba93c763bd9f19c09).

So this seems that the difference in speed remains a mystery but is not due to 
this fix.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

https://speed.python.org/timeline/#/?exe=12&ben=python_startup&env=4&revs=50&equid=off&quarts=on&extr=on

also doesn't show any difference with the revert

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset dd6c35761a4cd417e126a2d51dd0b89c8a30e5de by Pablo Galindo Salgado 
in branch 'main':
bpo-46110: Restore commit e9898bf153d26059261ffef11f7643ae991e2a4c
https://github.com/python/cpython/commit/dd6c35761a4cd417e126a2d51dd0b89c8a30e5de


--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

At thing at this point we can confidently say that is very very unlike that 
there is no actual regression.

What's going on with the performance servers is something I still cannot 
explain. I at least can confirm the servers system packages were not updated 
between these runs but I cannot think of anything that could have influenced 
that change.

I propose to close this issue as we are clearly unable to reproduce said 
slowdown.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-03 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

> I presume you mean
> "it is very very *likely* that there is no actual regression"

Yes, sorry, that's what I meant :)

> This shouldn't hold up releases

Cool, we will proceed with 3.9.10 and 3.11.0a3 tomorrow.

--

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46240] Incorrect hint about forgetting a comma

2022-01-03 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +28588
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/30378

___
Python tracker 
<https://bugs.python.org/issue46240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue44092] [sqlite3] Remove special rollback handling

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset a09062c267a94200ad299f779429fea1b571ee35 by Erlend Egeberg 
Aasland in branch 'main':
bpo-44092: Move What's New entry to where it belongs (GH-30381)
https://github.com/python/cpython/commit/a09062c267a94200ad299f779429fea1b571ee35


--

___
Python tracker 
<https://bugs.python.org/issue44092>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46240] Incorrect hint about forgetting a comma

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset 70f415fb8b632247e28d87998642317ca7a652ae by Pablo Galindo Salgado 
in branch 'main':
bpo-46240: Correct the error for unclosed parentheses when the tokenizer is not 
finished (GH-30378)
https://github.com/python/cpython/commit/70f415fb8b632247e28d87998642317ca7a652ae


--

___
Python tracker 
<https://bugs.python.org/issue46240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46231] grammar rule definition is missing: invalid_double_starred_kvpairs

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset e09d94a140a5f6903017da9b6ac752ba041d69da by Pablo Galindo Salgado 
in branch 'main':
bpo-46231: Remove invalid_* rules preceded by more tokens from the grammar docs 
(GH-30341)
https://github.com/python/cpython/commit/e09d94a140a5f6903017da9b6ac752ba041d69da


--

___
Python tracker 
<https://bugs.python.org/issue46231>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46231] grammar rule definition is missing: invalid_double_starred_kvpairs

2022-01-04 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46231>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46240] Incorrect hint about forgetting a comma

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Thanks Andre for the report!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46240>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue20369] concurrent.futures.wait() blocks forever when given duplicate Futures

2022-01-04 Thread Pablo Galindo Salgado

Pablo Galindo Salgado  added the comment:


New changeset 7d7817cf0f826e566d8370a0e974bbfed6611d91 by Kumar Aditya in 
branch 'main':
bpo-20369: concurrent.futures.wait() now deduplicates futures given a… 
(GH-30168)
https://github.com/python/cpython/commit/7d7817cf0f826e566d8370a0e974bbfed6611d91


--
nosy: +pablogsal

___
Python tracker 
<https://bugs.python.org/issue20369>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46260] Misleading SyntaxError on f-string

2022-01-04 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy: +eric.smith

___
Python tracker 
<https://bugs.python.org/issue46260>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46110] compile("-"*3000000 + "4", '', mode) causes hard crash

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I did a run of pyperformance manually forcing setuptools<60.0 and another with 
setuptools>=60.0 I can reproduce the timing difference.

I assume we can therefore close this issue and maybe open another one thinking 
about how to deal with the setuptools problem (maybe reaching to the package 
maintainera).

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46110>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46263] FreeBSL buiildbots cannot compile Python

2022-01-04 Thread Pablo Galindo Salgado


New submission from Pablo Galindo Salgado :

Seems that the FreeBSD buildbots cannot compile Python 3.11 anymore:

LD_LIBRARY_PATH=/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build CC='cc 
-pthread' LDSHARED='cc -pthread -shared' OPT='-g -O0 -Wall'  
_TCLTK_INCLUDES='' _TCLTK_LIBS=''  ./python -E ./setup.py  build
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/./setup.py", 
line 49, in 
from distutils.command.build_ext import build_ext
^
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/distutils/command/build_ext.py",
 line 13, in 
from distutils.sysconfig import customize_compiler, get_python_version
^^
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/distutils/sysconfig.py",
 line 53, in 
_config_vars = get_config_vars()
   ^
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/sysconfig.py", line 
621, in get_config_vars
_init_posix(_CONFIG_VARS)
^
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/sysconfig.py", line 
482, in _init_posix
_temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
^
ModuleNotFoundError: No module named 
'_sysconfigdata_d_freebsd14_x86_64-unknown-freebsd14'
*** [sharedmods] Error code 1
make: stopped in /usr/home/buildbot/python/3.x.koobs-freebsd-564d/build
make: stopped in /usr/home/buildbot/python/3.x.koobs-freebsd-564d/build

https://buildbot.python.org/all/#/builders/483/builds/1408

--
messages: 409719
nosy: lukasz.langa, pablogsal
priority: release blocker
severity: normal
status: open
title: FreeBSL buiildbots cannot compile Python
versions: Python 3.11

___
Python tracker 
<https://bugs.python.org/issue46263>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue40222] "Zero cost" exception handling

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Can this be closed?

--

___
Python tracker 
<https://bugs.python.org/issue40222>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43137] webbrowser to support "gio open "

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

If this is not fixed by this week, I will be forced to revert the PR

--

___
Python tracker 
<https://bugs.python.org/issue43137>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46263] FreeBSL buiildbots cannot compile Python

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

There is also this other builder:

https://buildbot.python.org/all/#/builders/172/builds/1093

failing what what seems is a freeze problem:

-  'use_frozen_modules': 1,
+  'use_frozen_modules': -1,
?+
   'use_hash_seed': 0,
   'user_site_directory': 1,
   'verbose': 0,
   'warn_default_encoding': 0,
   'warnoptions': [],
   'write_bytecode': 1,
   'xoptions': []}
--
Ran 1 test in 0.152s
FAILED (failures=1)
test test_embed failed
1 test failed again:
test_embed

Adding Eric and Guido for this particular problem to the nosy list

--
nosy: +eric.snow, gvanrossum

___
Python tracker 
<https://bugs.python.org/issue46263>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43683] Handle generator (and coroutine) state in the bytecode.

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Is there anything left here?

--
priority: release blocker -> 

___
Python tracker 
<https://bugs.python.org/issue43683>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46236] PyFunction_GetAnnotations returning Tuple vs Dict

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Yeah, the docs mention explicitly that is a dictionary or NULL.

--
priority: normal -> release blocker

___
Python tracker 
<https://bugs.python.org/issue46236>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46236] PyFunction_GetAnnotations returning Tuple vs Dict

2022-01-04 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy: +serhiy.storchaka

___
Python tracker 
<https://bugs.python.org/issue46236>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46236] PyFunction_GetAnnotations returning Tuple vs Dict

2022-01-04 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I am quite sure this is due to PR 23316

--

___
Python tracker 
<https://bugs.python.org/issue46236>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43137] webbrowser to support "gio open "

2022-01-05 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

>> I am not a regular CPython developer, so I don't have a good way to assess 
>> which reviewers speak for the project and which reviewers are only offering 
>> a personal opinion.

In this webpage (bpo) core developers have a little python logo close to their 
name (as myself).

In GitHub, you can sometimes tell by hovering over the profile or checking the 
core dev log in the devguide: https://devguide.python.org/developers/

--

___
Python tracker 
<https://bugs.python.org/issue43137>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43137] webbrowser to support "gio open "

2022-01-05 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:


New changeset dd50316e458d7c3284f8948b0606d8aa91ab855d by Simon McVittie in 
branch 'main':
bpo-43137: Revert "webbrowser: Don't run gvfs-open on GNOME" (GH-30417)
https://github.com/python/cpython/commit/dd50316e458d7c3284f8948b0606d8aa91ab855d


--

___
Python tracker 
<https://bugs.python.org/issue43137>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue43137] webbrowser to support "gio open "

2022-01-05 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

I am removing the "release blocker" tag.

Simon, thanks a lot for both PRs. I am sorry that we needed to revert your 
original work, but unfortunately it was blocking a release and we are forced to 
act in this case. PLease, work together with Christian and Matthias to make a 
version of the patch that works in all supported platforms.

--
priority: release blocker -> 

___
Python tracker 
<https://bugs.python.org/issue43137>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46236] PyFunction_GetAnnotations returning Tuple vs Dict

2022-01-05 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
priority: release blocker -> 
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.11

___
Python tracker 
<https://bugs.python.org/issue46236>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45665] Problems caused by isinstance(list[int], type) returning True

2022-01-05 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Gentle ping, as the next alpha will be release soon

--
nosy: +pablogsal

___
Python tracker 
<https://bugs.python.org/issue45665>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue45665] Problems caused by isinstance(list[int], type) returning True

2022-01-05 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy:  -pablogsal

___
Python tracker 
<https://bugs.python.org/issue45665>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46274] backslash creating statement out of nothing

2022-01-06 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy:  -pablogsal

___
Python tracker 
<https://bugs.python.org/issue46274>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46275] caret location for syntax error pointing with f-strings

2022-01-06 Thread Pablo Galindo Salgado


Change by Pablo Galindo Salgado :


--
nosy: +eric.smith

___
Python tracker 
<https://bugs.python.org/issue46275>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue46263] FreeBSD buildbots cannot compile Python

2022-01-06 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

Unfortunately the buildbots are still red:

https://buildbot.python.org/all/#/builders/483/builds/1416/steps/5/logs/stdio

https://buildbot.python.org/all/#/builders/172/builds/1102

One is the test_embed problem with frozen modules:

==
FAIL: test_init_setpythonhome (test.test_embed.InitConfigTests)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/Lib/test/test_embed.py",
 line 1253, in test_init_setpythonhome
self.check_all_configs("test_init_setpythonhome", config,
^
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/Lib/test/test_embed.py",
 line 736, in check_all_configs
self.check_config(configs, expected_config)
^^^
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/Lib/test/test_embed.py",
 line 662, in check_config
self.assertEqual(config, expected)
^^
AssertionError: {'_co[346 chars]'], 'xoptions': [], 'warnoptions': [], 
'python[1945 chars]': 1} != {'_co[346 chars]'], 'orig_argv': [], 'xoptions': 
[], 'warnopti[1946 chars]: -1}
  {'_config_init': 1,
   '_init_main': 1,
   '_install_importlib': 1,
   '_isolated_interpreter': 0,
   'argv': [''],
   'base_exec_prefix': 
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build',
   'base_executable': '',
   'base_prefix': 
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build',
   'buffered_stdio': 1,
   'bytes_warning': 0,
   'check_hash_pycs_mode': 'default',
   'code_debug_ranges': 1,
   'configure_c_stdio': 0,
   'dev_mode': 0,
   'dump_refs': 0,
   'exec_prefix': 
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build',
   'executable': '',
   'faulthandler': 0,
   'hash_seed': 0,
   'home': '/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build',
   'import_time': 0,
   'inspect': 0,
   'install_signal_handlers': 1,
   'interactive': 0,
   'isolated': 0,
   'malloc_stats': 0,
   'module_search_paths': 
['/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/target/lib/python311.zip',
   
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/Lib',
   
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/build/lib.freebsd-12.3-RELEASE-amd64-3.11',
   
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/lib/python311.zip',
   
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/lib/python3.11',
   
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/lib/python3.11/lib-dynload'],
   'module_search_paths_set': 1,
   'optimization_level': 0,
   'orig_argv': [],
   'parse_argv': 0,
   'parser_debug': 0,
   'pathconfig_warnings': 1,
   'platlibdir': 'lib',
   'prefix': '/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build',
   'program_name': 'python3',
   'pycache_prefix': None,
   'pythonpath_env': 
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/target/lib/python311.zip:/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/Lib:/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/build/lib.freebsd-12.3-RELEASE-amd64-3.11',
   'quiet': 0,
   'run_command': None,
   'run_filename': None,
   'run_module': None,
   'show_ref_count': 0,
   'site_import': 1,
   'skip_source_first_line': 0,
   'stdlib_dir': 
'/usr/home/buildbot/python/3.x.koobs-freebsd-9e36.nondebug/build/lib/python3.11',
   'tracemalloc': 0,
   'use_environment': 1,
-  'use_frozen_modules': 1,
+  'use_frozen_modules': -1,
?+
   'use_hash_seed': 0,
   'user_site_directory': 1,
   'verbose': 0,
   'warn_default_encoding': 0,
   'warnoptions': [],
   'write_bytecode': 1,
   'xoptions': []}
---

[issue46256] Objects __del__ called after module have been removed

2022-01-06 Thread Pablo Galindo Salgado


Pablo Galindo Salgado  added the comment:

This doesn't look like a bug to me and is documented behavior:

https://docs.python.org/3/reference/datamodel.html#object.__del__

Check this paragraph:

Warning Due to the precarious circumstances under which __del__() methods are 
invoked, exceptions that occur during their execution are ignored, and a 
warning is printed to sys.stderr instead. In particular:
__del__() can be invoked when arbitrary code is being executed, including from 
any arbitrary thread. If __del__() needs to take a lock or invoke any other 
blocking resource, it may deadlock as the resource may already be taken by the 
code that gets interrupted to execute __del__().

__del__() can be executed during interpreter shutdown. As a consequence, the 
global variables it needs to access (including other modules) may already have 
been deleted or set to None. Python guarantees that globals whose name begins 
with a single underscore are deleted from their module before other globals are 
deleted; if no other references to such globals exist, this may help in 
assuring that imported modules are still available at the time when the 
__del__() method is called.



Here, the object __del__ should take s strong reference to whatever is going to 
use to ensure is available when needed. Indeed, the standard library does this 
regularly, for example:

https://github.com/python/cpython/blob/f4c03484da59049eb62a9bfb963e2267d187/Lib/asyncio/windows_utils.py#L110


I am closing it as "not a bug" but feel free to reopen if we think we missed 
something or I misinterpret the bug report.

--
nosy: +pablogsal
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<https://bugs.python.org/issue46256>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   3   4   5   6   7   8   9   10   >