[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag
New submission from Matthieu S: Python build fails on AIX when using the _LINUX_SOURCE_COMPAT flag. When using this flag, the gethostbyname_r subroutine has 6 parameters instead of 3, like on Linux, but Modules/socketmodule.c always expects a gethostbyname_r subroutine with only 3 parameters on AIX. The attached patch allows to build with this flag. It has been tested for Python 3.5.1 and 3.5.2 with GCC and XLC compilers. -- components: Extension Modules files: Python-3.5.1-compat.patch keywords: patch messages: 274819 nosy: sarterm priority: normal severity: normal status: open title: Build fails on AIX with _LINUX_SOURCE_COMPAT flag type: compile error versions: Python 3.5 Added file: http://bugs.python.org/file0/Python-3.5.1-compat.patch ___ Python tracker <http://bugs.python.org/issue28000> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28016] test_fileio fails on AIX
New submission from Matthieu S: == FAIL: testAbles (test.test_fileio.COtherFileTests) -- Traceback (most recent call last): File "/opt/freeware/src/packages/BUILD/Python-3.5.2/64bit/Lib/test/test_fileio.py", line 382, in testAbles self.assertEqual(f.seekable(), False) AssertionError: True != False == FAIL: testAbles (test.test_fileio.PyOtherFileTests) -- Traceback (most recent call last): File "/opt/freeware/src/packages/BUILD/Python-3.5.2/64bit/Lib/test/test_fileio.py", line 382, in testAbles self.assertEqual(f.seekable(), False) AssertionError: True != False /dev/tty is seakable on AIX, like on some other Unix on wich this assertion is already skipped (macOS, BSD, SunOS). The attached patch adds adds AIX to the list of platform on wich the assertion should be skipped. -- components: Tests files: Python-3.5.1-fileio.patch keywords: patch messages: 274985 nosy: sarterm priority: normal severity: normal status: open title: test_fileio fails on AIX type: behavior versions: Python 3.5 Added file: http://bugs.python.org/file44460/Python-3.5.1-fileio.patch ___ Python tracker <http://bugs.python.org/issue28016> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag
Matthieu S added the comment: Sorry for the very late reply... Using _LINUX_SOURCE_COMPAT is sometimes preferable, as it greatly improves compatibility with code intended for Linux and improves XPG specs compliance. But I am not sure it should always be enabled. In our case, we use it as there where issues with AIX malloc and hotshot when building without it, but Python seems to globally work fine without, and we did not compare performances. Like you, I don't know why this was overridden, so it might be safer to keep the override and just add the #ifdef _LINUX_SOURCE_COMPAT. This also applies to Python 2.7. -- ___ Python tracker <http://bugs.python.org/issue28000> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28016] test_fileio fails on AIX
Matthieu S added the comment: Sorry for the late reply. I did some additional testing, and I can confirm that this assertion should also be skipped in Python 2.7 on AIX. And the test does not fail when run without a tty, so we can assume that this is what happens on the builbots. -- ___ Python tracker <http://bugs.python.org/issue28016> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag
Changes by Matthieu S : -- versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issue28000> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag
Matthieu S added the comment: Thanks ! -- resolution: fixed -> status: closed -> open versions: -Python 3.7 ___ Python tracker <http://bugs.python.org/issue28000> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28000] Build fails on AIX with _LINUX_SOURCE_COMPAT flag
Changes by Matthieu S : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue28000> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
