[issue29629] rgb_to_hls to colorsys.py

2017-02-22 Thread Madhavendra Sharma 

New submission from Madhavendra Sharma:

Calculations in rgb_to_hls at line number 67 in python version 2.7.3 for "h" 
the hue component are not correct according reference mentioned in the same 
source file "en.wikipedia.org/wiki/HSV_color_space".


code snippet:

if r == maxc:
#h = (bc-gc) #current code
h = (bc-gc)%6 # suggestion
elif g == maxc:
h = 2.0+rc-bc
else:
#h = 4.0+gc-rc #current code
h = 4.0+rc-gc # suggestion

#h = (h/6.0) % 1.0 not required 

# h = 60 *h # component should be multiplied by 60 but it depends on user

--
messages: 288410
nosy: madhavendra.sharma
priority: normal
severity: normal
status: open
title: rgb_to_hls to colorsys.py
type: behavior
versions: Python 2.7, Python 3.5

___
Python tracker 
<http://bugs.python.org/issue29629>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29629] rgb_to_hls in colorsys.py

2017-02-22 Thread Madhavendra Sharma 

Changes by Madhavendra Sharma :


--
title: rgb_to_hls to colorsys.py -> rgb_to_hls in colorsys.py

___
Python tracker 
<http://bugs.python.org/issue29629>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29629] rgb_to_hls in colorsys.py

2017-02-22 Thread Madhavendra Sharma 

Madhavendra Sharma added the comment:

Please check examples in en.wikipedia.org/wiki/HSL_and_HSV

I picked one of them
for R = .750, B=0.250, G=0.750 
corresponding HLS value are H= 300 = (5.0 * 60) , L =  .5, S=.5

but colorsys.rgb_to_hls(0.75 ,  0.25,  0.75) gives following output
(0.8334, 0.5, 0.5)
h*60 = 0.8334 * 60 is not equal to 300

correct out put should be (5.0, 0.5, 0.5) or if h is multiplied by 60 then 
(300, 0.5, 0.5)

Thank you.
Madhavendra Sharma

--

___
Python tracker 
<http://bugs.python.org/issue29629>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29629] rgb_to_hls in colorsys.py

2017-02-23 Thread Madhavendra Sharma 

Madhavendra Sharma added the comment:

OK, That's fine. 
Thanks for the clarification.

But most of the calculations I found for the conversion from RGB to HLS 
contains H = 60 * h' that's why I could not interpret it properly. Even on the 
same wiki page calculations specific to RGB to HLS were that way only.

Thank you.

--

___
Python tracker 
<http://bugs.python.org/issue29629>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29629] rgb_to_hls in colorsys.py

2017-02-23 Thread Madhavendra Sharma 

Changes by Madhavendra Sharma :


--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 
<http://bugs.python.org/issue29629>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com