[issue32957] distutils.command.install checks truthiness of .ext_modules instead of calling .has_ext_modules()

2018-02-26 Thread Korijn Van Golen

New submission from Korijn Van Golen :

distutils' Distribution class has a method has_ext_modules() that is used to 
determine if any extension modules are included in a distribution. There 
remains a call site in distutils.command.install where 
self.distribution.ext_modules is directly tested for truthiness, rather than 
calling has_ext_modules. This causes inconsistent behavior, e.g. when 
overriding has_ext_modules in a Distribution subclass.

--
components: Distutils
messages: 312932
nosy: Korijn Van Golen, dstufft, eric.araujo
priority: normal
severity: normal
status: open
title: distutils.command.install checks truthiness of .ext_modules instead of 
calling .has_ext_modules()
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 
<https://bugs.python.org/issue32957>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32957] distutils.command.install checks truthiness of .ext_modules instead of calling .has_ext_modules()

2018-02-26 Thread Korijn Van Golen

Change by Korijn Van Golen :


--
keywords: +patch
pull_requests: +5679
stage:  -> patch review

___
Python tracker 
<https://bugs.python.org/issue32957>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com