[issue13559] Use sendfile where possible in httplib
Changes by Kasun Herath : -- nosy: +kasun ___ Python tracker <http://bugs.python.org/issue13559> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12537] mailbox's _become_message is very fragile
Changes by Kasun Herath : -- nosy: +kasun ___ Python tracker <http://bugs.python.org/issue12537> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11882] test_imaplib failed on x86 ubuntu
New submission from Kasun Herath : test_imaplib failed on x86 ubuntu machine with following error(s) == FAIL: test_Internaldate2tuple (test.test_imaplib.TestImaplib) -- Traceback (most recent call last): File "/home/kasun/workplace/cpython/Lib/test/test_imaplib.py", line 31, in test_Internaldate2tuple self.assertEqual(time.mktime(tt), t0) AssertionError: 946683000.0 != 946684800 -- Ran 2 tests in 0.002s FAILED (failures=1) test test_imaplib failed -- Traceback (most recent call last): File "/home/kasun/workplace/cpython/Lib/test/test_imaplib.py", line 31, in test_Internaldate2tuple self.assertEqual(time.mktime(tt), t0) AssertionError: 946683000.0 != 946684800 1 test failed: test_imaplib -- components: Tests messages: 134091 nosy: kasun priority: normal severity: normal status: open title: test_imaplib failed on x86 ubuntu versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue11882> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: I did a patch that allows smtplib.SMTP_SSL constructor to accept an optional SSLContext -- keywords: +patch nosy: +kasun Added file: http://bugs.python.org/file21730/smtp_sslcontext.patch ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: I'm submitting a new patch with changes suggested by Terry. But I feel an example of how to use a SSLContext inside the Docstring of SMTP_SSL constructor is unnecessary since no smtp specific things are done to the passed SSLContext. Any ideas about this suggestion? -- Added file: http://bugs.python.org/file21737/smtp_sslcontext_updated.patch ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11882] test_imaplib failed on x86 ubuntu
Kasun Herath added the comment: Yes this is a repeatable error. My timezone is GMT + 5:30. The test fails even if the last element of 'calendar.timegm's tuple is changed to 0 or 1 but pass if the function is changed as follows print calendar.timegm((1999, 12, 31, 23, 30, 0, -1, -1, -1)) -- ___ Python tracker <http://bugs.python.org/issue11882> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: I did another patch based on feedback given. A test for SMTP_SSL wasn't added; will look into it later. Tab character that were present are removed. Also SSLContext support was added to starttls() but it is slightly different from the starttls() implementation of imaplib. Further feedback would be much appreciated. -- Added file: http://bugs.python.org/file21781/smtp_sslcontext_updated2.patch ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11882] test_imaplib failed on x86 ubuntu
Kasun Herath added the comment: Yes problem seems to be with time.mktime(). Here is my output, >>> calendar.timegm((2000, 1, 1, 0, 0, 0, -1, -1, -1)) 946684800 >>> x = imaplib.Internaldate2tuple(b'25 (INTERNALDATE "01-Jan-2000 00:00:00 >>> +")') >>> x time.struct_time(tm_year=2000, tm_mon=1, tm_mday=1, tm_hour=5, tm_min=30, tm_sec=0, tm_wday=5, tm_yday=1, tm_isdst=0) >>> time.mktime(x) 946683000.0 -- ___ Python tracker <http://bugs.python.org/issue11882> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: Thanks for the quick review. I'm submitting a new patch with changes suggested. -- Added file: http://bugs.python.org/file21791/smtp_sslcontext_updated3.patch ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11927] SMTP_SSL doesn't use port 465 by default
Kasun Herath added the comment: I did a quick patch based on the suggested solution. (pitrou, thanks for adding to the nosy list or could have missed this) -- keywords: +patch Added file: http://bugs.python.org/file21794/smtplib_default_ports.patch ___ Python tracker <http://bugs.python.org/issue11927> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11882] test_imaplib failed on x86 ubuntu
Kasun Herath added the comment: david, I'm not much familiar with c. Still trying to figure out how to do it -- status: pending -> open ___ Python tracker <http://bugs.python.org/issue11882> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11927] SMTP_SSL doesn't use port 465 by default
Kasun Herath added the comment: I'm submitting another patch which includes a test in test_smtpnet. Would appreciate further feedback. -- Added file: http://bugs.python.org/file21927/smtp_default_port_with_smtpnet_test.patch ___ Python tracker <http://bugs.python.org/issue11927> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: Yes, I would like to have a try at it -- ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: I added a test to smtpnet and submitting a separate patch for it as my test_smtpnet.py file was old and could have had conflicts. I didn't use keys and certificates for the SSLContext as those would have to be shipped with the source. Looking forward for reviews and suggestions. -- Added file: http://bugs.python.org/file22003/smtp_sslcontext_test.patch ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8809] smtplib should support SSL contexts
Kasun Herath added the comment: Thanks Antoine -- ___ Python tracker <http://bugs.python.org/issue8809> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
