[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Kamilla]

Kamilla added the comment:

I'm not sure about how the aliases are represented. I found some examples:

http://web.mit.edu/Mozilla/src/mozilla/intl/uconv/src/charsetalias.properties

So I wrote the aliases like this:

'iso-8859-8-i'   : 'iso8859_8_I',
'iso-8859-8-e'   : 'iso8859_8_E',

But I'm not sure if I should write as shown in the example above or if it 
should looks like:

'iso-8859-8-i'   : 'iso8859_8',
'iso-8859-8-e'   : 'iso8859_8',

And how about the tests? I couldn't locate the tests for this module. It it the 
tests inside the enconded_modules folder?

--
nosy: +kamie

___
Python tracker 
<http://bugs.python.org/issue18624>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18624] Add alias for iso-8859-8-i which is the same as iso-8859-8

[Kamilla]

Kamilla added the comment:

Adding aliases to the set of iso-8859-8.

--
keywords: +patch
Added file: http://bugs.python.org/file34449/adding_aliases.patch

___
Python tracker 
<http://bugs.python.org/issue18624>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20145] unittest.assert*Regex functions should verify that expected_regex has a valid type

[Kamilla]

Kamilla added the comment:

Just to be sure, the check must be implemented inside the assertRaisesRegex 
method, right?

--
nosy: +kamie

___
Python tracker 
<http://bugs.python.org/issue20145>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20145] unittest.assert*Regex functions should verify that expected_regex has a valid type

[Kamilla]

Kamilla added the comment:

I've implemented a piece of code to check if the expected_regex is a string or 
regex object. If it's not it raises a TypeError exception. The check is inside 
the __init__ method of the _AssertRaisesBaseContext class so it will always 
check the expected_regex in all methods that use the _AssertRaises.

I've added tests too. They are verifying the assertRaisesRegex and the 
assertWarnsRegex methods.

--
keywords: +patch
Added file: http://bugs.python.org/file34346/validate_regex.patch

___
Python tracker 
<http://bugs.python.org/issue20145>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20145] unittest.assert*Regex functions should verify that expected_regex has a valid type

[Kamilla]

Kamilla added the comment:

Applying changes as suggested by R. David Murray in the Core-mentorship e-mail 
list.

Instead of doing the if tests I've replaced the existing

   if isinstance(expected_regex, (bytes, str)):

by

   if expected_regex is not None:


And also made a change in one of the tests because I figure out it was wrong.

--
Added file: http://bugs.python.org/file34364/validate_regex_improved.patch

___
Python tracker 
<http://bugs.python.org/issue20145>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com