[issue809163] Can't add files with spaces
John Keyes added the comment: This is my first contribution as part of the Bug Weekend (and possibly my first to Python). I tested this by writing a MANIFEST.in and a very small setup.py but after looking at distutils I narrowed the area down to the FileList. I wrote a unittest and have attached the diff. I tested this on py3k. -- keywords: +patch nosy: +johnkeyes Added file: http://bugs.python.org/file19650/issue809163.diff ___ Python tracker <http://bugs.python.org/issue809163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue809163] Can't add files with spaces
John Keyes added the comment: I'll change the test to use TESTFN later today. Thanks for the feedback. -- ___ Python tracker <http://bugs.python.org/issue809163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue809163] Can't add files with spaces
John Keyes added the comment: I see that distutils.tests.support.TempdirManager uses tempfile for directory creation. What's the best course of action here? 1. Use TESTFN or 2. Use TempdirManager or 3. Change the test to use TempdirManager and change TempdirManager to use TESTFN instead of tempfile. Thanks. -- ___ Python tracker <http://bugs.python.org/issue809163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue809163] Can't add files with spaces
John Keyes added the comment: This patch uses TempdirManager to handle the temporary directory and file creation. -- Added file: http://bugs.python.org/file19718/issue809163v2.diff ___ Python tracker <http://bugs.python.org/issue809163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue809163] Can't add files with spaces
John Keyes added the comment: Gah! Silly mistake with the assert. What filelist.py patch are you referring to? I've tested this on py3k with no changes to filelist.py. Thanks for your patience. -- Added file: http://bugs.python.org/file19730/issue809163v3.diff ___ Python tracker <http://bugs.python.org/issue809163> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
