[issue46280] About vulnerabilities in Cpython native code
Joannah Nanjekye added the comment: > You mention here that your tool automatically "repairs" the code. Could you > >submit a sample PR with the repairs that your tool does so we can evaluate > it? I second this. I obviously, am assuming good intentions from the author, not experimenting on us. -- nosy: +nanjekyejoannah -414039482 ___ Python tracker <https://bugs.python.org/issue46280> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)
Joannah Nanjekye added the comment: paul.j3, The fix looks promising. Do you want to open a PR with this fix? -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue25299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1615158] POSIX capabilities support
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue1615158> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue20861> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values
Joannah Nanjekye added the comment: Could be related to some discussions in this PR: https://github.com/python/cpython/pull/14842 -- ___ Python tracker <https://bugs.python.org/issue20861> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20861] datetime argument handling inconsistent; should accept logical integers, not coercible values
Change by Joannah Nanjekye : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue20861> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37866] PyModule_GetState Segmentation fault when called Py_Initialize
Change by Joannah Nanjekye : -- nosy: +eric.snow, ncoghlan, vstinner ___ Python tracker <https://bugs.python.org/issue37866> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37872] Move statitics in Python/import.c to top of the file
New submission from Joannah Nanjekye : Following a PR review here: https://github.com/python/cpython/pull/15057 by @ericsnowcurrently i.e : Please move both these statics to the top of the file (next to CACHEDIR) as globals. To keep the diff in the above PR simple, I am tracking this refactor in this issue. -- assignee: nanjekyejoannah components: Library (Lib) messages: 349859 nosy: eric.snow, nanjekyejoannah, serhiy.storchaka priority: normal severity: normal stage: needs patch status: open title: Move statitics in Python/import.c to top of the file type: enhancement versions: Python 3.9 ___ Python tracker <https://bugs.python.org/issue37872> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37872] Move statitics in Python/import.c to top of the file
Joannah Nanjekye added the comment: Relevant comment from @gnprice. I think it would be better to make that as a separate change. This style where they're block-local is the way the existing code works, which keeps the diff simple. It's also the way that every use of _Py_IDENTIFIER in this file works. So I think the cleanest way to change the style would be to sweep through this whole file (or more) in one PR, separate from any substantive changes. -- ___ Python tracker <https://bugs.python.org/issue37872> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37872] Move statitics in Python/import.c to top of the file
Joannah Nanjekye added the comment: Keeping this until the PR https://github.com/python/cpython/pull/15057 is merged. -- ___ Python tracker <https://bugs.python.org/issue37872> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24754] argparse add_argument with action="store_true", type=bool should not crash
Joannah Nanjekye added the comment: See issue25299 also. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue24754> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)
Joannah Nanjekye added the comment: > this argument defaults to "None" Am leaning to the fact that this works as required. The documentation does not just say defaults to none. It says: With the 'store_const' and 'append_const' actions, the const keyword argument must be given. For other actions, it defaults to None. In the scenario, you have given, you are using 'store_const' so the const keyword argument must be given. This should be closed If you agree with what I have just stated. -- ___ Python tracker <https://bugs.python.org/issue25299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] sub-ineterpreters : Document PyThreadState_DeleteCurrent() ?
New submission from Joannah Nanjekye : I just noticed that PyThreadState_DeleteCurrent()in Python/pystate.c is not documented. Relevant documentation should go in Doc/c-api/init.rst If no one objects to this. -- assignee: docs@python components: Documentation keywords: easy messages: 349881 nosy: docs@python, eric.snow, nanjekyejoannah, ncoghlan, vstinner priority: normal severity: normal stage: needs patch status: open title: sub-ineterpreters : Document PyThreadState_DeleteCurrent() ? versions: Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-ineterpreters : Document PyThreadState_DeleteCurrent() ?
Change by Joannah Nanjekye : -- title: sub-ineterpreters : Document PyThreadState_DeleteCurrent() ? -> Sub-ineterpreters : Document PyThreadState_DeleteCurrent() ? ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Change by Joannah Nanjekye : -- title: Sub-ineterpreters : Document PyThreadState_DeleteCurrent() ? -> Sub-Interpreters : Document PyThreadState_DeleteCurrent() ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15034 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15315 ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)
Joannah Nanjekye added the comment: Since both the docs and implementation now match, I suggest we close this and open a new issue suggesting to change the implementation back to make const=None when action='store_const'. -- stage: needs patch -> resolved ___ Python tracker <https://bugs.python.org/issue25299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37880] For argparse add_argument with action='store_const', const should default to None.
New submission from Joannah Nanjekye :
Currently, when `parser.add_argument()` is given argument with
`action='store_const'` and no `const` argument , it throws an exception :
>>> from argparse import ArgumentParser
>>> parser = ArgumentParser()
>>> parser.add_argument("--foo", help="foo", action='store_const')
Traceback (most recent call last):
File "", line 1, in
File "/home/captain/projects/cpython/Lib/argparse.py", line 1350, in
add_argument
action = action_class(**kwargs)
TypeError: __init__() missing 1 required positional argument: 'const'
>>>
Specifying the `const` argument stops this exception:
>>> parser.add_argument("--foo", help="foo", action='store_const', const=None)
_StoreConstAction(option_strings=['--foo'], dest='foo', nargs=0, const=None,
default=None, type=None, choices=None, help='foo', metavar=None)
Originally the docs, said when `action` was set to` 'store_const'` `const`
defaulted to `None` which was not matching with the implementation at the time.
After this commit :
https://github.com/python/cpython/commi/b4912b8ed367e540ee060fe912f841cc764fd293,
The docs were updated to match the implementation to fix Bpo issues :
https://bugs.python.org/issue25299
https://bugs.python.org/issue24754 and
https://bugs.python.org/issue25314
I suggest that we make `const` default to `None` If `action='store_const'` as
was intended originally before edits to the docs. If no one objects, I can open
a PR for this.
--
messages: 349911
nosy: A. Skrobov, nanjekyejoannah, r.david.murray
priority: normal
severity: normal
status: open
title: For argparse add_argument with action='store_const', const should
default to None.
versions: Python 3.9
___
Python tracker
<https://bugs.python.org/issue37880>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25299] TypeError: __init__() takes at least 4 arguments (4 given)
Joannah Nanjekye added the comment: Opened issue37880 to track this change. -- ___ Python tracker <https://bugs.python.org/issue25299> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16468] argparse only supports iterable choices
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue16468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Joannah Nanjekye added the comment: >From what I know the GIL is released by calling PyEval_ReleaseThread() or >PyEval_SaveThread(). I see we can use PyThreadState_Delete() to clean up-specifically destroy thread state but does not release the GIL and requires a thread state. On the other hand, PyThreadState_DeleteCurrent() allows to both clean up the current thread state - no thread state is required as well release the GIL which is convenient. I would not fight so much to keep it public given we have PyEval_ReleaseThread() or PyEval_SaveThread(). -- ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37888] Sub-interpreters : Confusing docs about state after calling Py_NewInterpreter()
New submission from Joannah Nanjekye : In the documentation for Py_NewInterpreter(): It is said that : The return value points to the first thread state created in the new sub-interpreter. This thread state is made in the current thread state. I think changing : This thread state is made in the current thread state. To: This thread state is made the current thread state. Sounds good. Since a call such as: substate = Py_NewInterpreter() makes *substate* the current state. no? The *in* takes me in a different direction of thought. -- messages: 349964 nosy: nanjekyejoannah priority: normal severity: normal status: open title: Sub-interpreters : Confusing docs about state after calling Py_NewInterpreter() ___ Python tracker <https://bugs.python.org/issue37888> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18153] python imaplib - error 'unexpected response'
Change by Joannah Nanjekye : -- title: python imaplib - error 'unexpected repsonse' -> python imaplib - error 'unexpected response' ___ Python tracker <https://bugs.python.org/issue18153> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31956] Add start and stop parameters to the array.index()
Joannah Nanjekye added the comment: There is a pending PR here : https://github.com/python/cpython/pull/4435 by phaqui. @phaqui do you want to finish your PR ? -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue31956> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15542] Documentation incorrectly suggests __init__ called after direct __new__ call
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15164 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15478 ___ Python tracker <https://bugs.python.org/issue15542> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15542] Documentation incorrectly suggests __init__ called after direct __new__ call
Joannah Nanjekye added the comment: Since this has taken long on the tracker, I just opened a PR with proposed changes from Aaron. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue15542> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23061] Update pep8 to specify explicitly 'module level' imports at top of file
Joannah Nanjekye added the comment: Since this is a PEP related issue, it should be moved to the PEP Github repository here : https://github.com/python/peps . If it still exists. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue23061> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13341] Incorrect documentation for "u" PyArg_Parse format unit
Joannah Nanjekye added the comment: This is has taken years but am curious, are we allowed to patch Python 2 given its EOL is almost due. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue13341> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20806] os.times document points to wrong section of non-Linux manual
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15165 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15479 ___ Python tracker <https://bugs.python.org/issue20806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20806] os.times document points to wrong section of non-Linux manual
Joannah Nanjekye added the comment: I opened a PR for this. @david please review. -- nosy: +nanjekyejoannah stage: patch review -> ___ Python tracker <https://bugs.python.org/issue20806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20806] os.times document points to wrong section of non-Linux manual
Joannah Nanjekye added the comment: Serhiy, This sounds good. I will update the PR. -- ___ Python tracker <https://bugs.python.org/issue20806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23933] Struct module should accept arrays
Change by Joannah Nanjekye : -- title: Struct module should acept arrays -> Struct module should accept arrays ___ Python tracker <https://bugs.python.org/issue23933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32847] Add DirectoryNotEmptyError subclass of OSError
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15186 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15496 ___ Python tracker <https://bugs.python.org/issue32847> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Joannah Nanjekye added the comment: I updated the PR to make the function internal. -- ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20806] os.times document points to wrong section of non-Linux manual
Joannah Nanjekye added the comment: I updated the PR to reference times(2) and times(3) along with an MSDN link. -- ___ Python tracker <https://bugs.python.org/issue20806> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37970] urllib.parse docstrings incomplete
Joannah Nanjekye added the comment: > Also, the note about not splitting netloc is misleading; the components > of > netloc (username, password, hostname, and port) are available as >extra > attributes of the returned SplitResult. Also, the docs in urllib.parse.rst should also be updated to correct this misleading statement. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue37970> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32847] Add DirectoryNotEmptyError subclass of OSError
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue32847> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37973] improve docstrings of sys.float_info
Joannah Nanjekye added the comment: See also #37970 -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue37973> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37973] improve docstrings of sys.float_info
Joannah Nanjekye added the comment: I just referenced another area that may need help updating/improving doc strings. -- ___ Python tracker <https://bugs.python.org/issue37973> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15088] PyGen_NeedsFinalizing is public, but undocumented
Change by Joannah Nanjekye : -- pull_requests: +15356 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15702 ___ Python tracker <https://bugs.python.org/issue15088> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15088] PyGen_NeedsFinalizing is public, but undocumented
Joannah Nanjekye added the comment: My searches show references to this function in CPython cloned repositories. From @pitrous's views, I think it is better to deprecate it with a removal notice for a later release. I have deprecated the Function instead and will be removed in the next release in this PR https://github.com/python/cpython/pull/15702 . -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue15088> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14689] make PYTHONWARNINGS variable work in libpython
Joannah Nanjekye added the comment: @petere do you want to open a PR with your patch here: https://github.com/python/cpython/pulls -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue14689> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38037] Assertion failed: object has negative ref count
Joannah Nanjekye added the comment: I will look after my next meeting which is in 10 minutes. In the meantime have you perused this PR : https://github.com/python/cpython/pull/15701 If it can solve this? -- ___ Python tracker <https://bugs.python.org/issue38037> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21024] PyTypeObject tp_doc is char* instead of const char*
Joannah Nanjekye added the comment: tp_doc is now const char*. So this should be closed. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue21024> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27718] help('signal') incomplete (e.g: signal.signal not visible)
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue27718> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16649] Add a PyCF_DISPLAY_EXPRESSION_RESULTS flag
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue16649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37488] Document the "gotcha" behaviors in utcnow() and utcfromtimestamp()
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15426 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15773 ___ Python tracker <https://bugs.python.org/issue37488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15733] PEP 3121, 384 Refactoring applied to winapi module
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15427 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15773 ___ Python tracker <https://bugs.python.org/issue15733> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1615158] POSIX capabilities support
Change by Joannah Nanjekye : -- pull_requests: +15463 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15815 ___ Python tracker <https://bugs.python.org/issue1615158> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38109] Missing constants in Lib/stat.py
Change by Joannah Nanjekye : -- nosy: +pitrou, vstinner ___ Python tracker <https://bugs.python.org/issue38109> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10108] ExpatError not property wrapped
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue10108> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21023] PyTypeObject tp_name is char* instead of const char*
Joannah Nanjekye added the comment: This is nolonger an issue. All references to tp_name are as below. const char *tp_name; -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue21023> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27218] improve tracing performance with f_trace set to Py_None
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15767 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16157 ___ Python tracker <https://bugs.python.org/issue27218> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15729] PyStructSequence_NewType enhancement
Joannah Nanjekye added the comment:
All enhancements specified in this issue have since been done.
PyStructSequence_NewType() calls PyType_FromSpecWithBases() which sets the
needed flags and even the qualname:
PyObject *
PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases)
{
PyHeapTypeObject *res;
PyMemberDef *memb;
PyObject *modname;
PyTypeObject *type, *base;
PyType_Slot *slot;
Py_ssize_t nmembers;
char *s, *res_start;
nmembers = 0;
for (slot = spec->slots; slot->slot; slot++) {
if (slot->slot == Py_tp_members) {
nmembers = 0;
for (memb = slot->pfunc; memb->name != NULL; memb++) {
nmembers++;
}
}
}
res = (PyHeapTypeObject*)PyType_GenericAlloc(&PyType_Type, nmembers);
if (res == NULL)
return NULL;
res_start = (char*)res;
if (spec->name == NULL) {
PyErr_SetString(PyExc_SystemError,
"Type spec does not define the name field.");
goto fail;
}
/* Set the type name and qualname */
s = strrchr(spec->name, '.');
if (s == NULL)
s = (char*)spec->name;
else
s++;
type = &res->ht_type;
/* The flags must be initialized early, before the GC traverses us */
type->tp_flags = spec->flags | Py_TPFLAGS_HEAPTYPE;
res->ht_name = PyUnicode_FromString(s);
if (!res->ht_name)
goto fail;
res->ht_qualname = res->ht_name;
Py_INCREF(res->ht_qualname);
type->tp_name = spec->name;
/* Adjust for empty tuple bases */
if (!bases) {
base = &PyBaseObject_Type;
/* See whether Py_tp_base(s) was specified */
for (slot = spec->slots; slot->slot; slot++) {
if (slot->slot == Py_tp_base)
base = slot->pfunc;
else if (slot->slot == Py_tp_bases) {
bases = slot->pfunc;
Py_INCREF(bases);
}
}
if (!bases)
bases = PyTuple_Pack(1, base);
if (!bases)
goto fail;
}
else
Py_INCREF(bases);
/* Calculate best base, and check that all bases are type objects */
base = best_base(bases);
if (base == NULL) {
goto fail;
}
if (!PyType_HasFeature(base, Py_TPFLAGS_BASETYPE)) {
PyErr_Format(PyExc_TypeError,
"type '%.100s' is not an acceptable base type",
base->tp_name);
goto fail;
}
/* Initialize essential fields */
type->tp_as_async = &res->as_async;
type->tp_as_number = &res->as_number;
type->tp_as_sequence = &res->as_sequence;
type->tp_as_mapping = &res->as_mapping;
type->tp_as_buffer = &res->as_buffer;
/* Set tp_base and tp_bases */
type->tp_bases = bases;
bases = NULL;
Py_INCREF(base);
type->tp_base = base;
type->tp_basicsize = spec->basicsize;
type->tp_itemsize = spec->itemsize;
for (slot = spec->slots; slot->slot; slot++) {
if (slot->slot < 0
|| (size_t)slot->slot >= Py_ARRAY_LENGTH(slotoffsets)) {
PyErr_SetString(PyExc_RuntimeError, "invalid slot offset");
goto fail;
}
else if (slot->slot == Py_tp_base || slot->slot == Py_tp_bases) {
/* Processed above */
continue;
}
else if (slot->slot == Py_tp_doc) {
/* For the docstring slot, which usually points to a static string
literal, we need to make a copy */
const char *old_doc = _PyType_DocWithoutSignature(type->tp_name,
slot->pfunc);
size_t len = strlen(old_doc)+1;
char *tp_doc = PyObject_MALLOC(len);
if (tp_doc == NULL) {
type->tp_doc = NULL;
PyErr_NoMemory();
goto fail;
}
memcpy(tp_doc, old_doc, len);
type->tp_doc = tp_doc;
}
else if (slot->slot == Py_tp_members) {
/* Move the slots to the heap type itself */
size_t len = Py_TYPE(type)->tp_itemsize * nmembers;
memcpy(PyHeapType_GET_MEMBERS(res), slot->pfunc, len);
type->tp_members = PyHeapType_GET_MEMBERS(res);
}
else {
/* Copy other slots directly */
*(void**)(res_start + slotoffsets[slot->slot]) = slot->pfunc;
}
}
if (type->tp_dealloc == NULL) {
/* It's a heap type, so needs the heap types' dealloc.
subtype_dealloc will call the base type's tp_dealloc, if
necessary. */
type->tp_dealloc = subtype_dealloc;
}
if (PyType_Ready(type) < 0)
goto fail;
if (type-
[issue20066] PyStructSequence_NewType() not setting proper heap allocation flag?
Joannah Nanjekye added the comment: As commented in issue15729, the Py_TPFLAGS_HEAPTYPE flag is now set in PyType_FromSpecWithBases() which is called by PyStructSequence_NewType(). I think this is no longer an issue. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue20066> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Joannah Nanjekye added the comment: Update, Some user of this function just complained on the merged pull requests here : https://github.com/python/cpython/pull/15315#issuecomment-534522962. Do we revert and deprecate ? cc @victor -- ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal
Joannah Nanjekye added the comment: I am okay with the revert but @victor may still have some reservations on this. -- ___ Python tracker <https://bugs.python.org/issue38266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal
Joannah Nanjekye added the comment: +1 for moving from Include/pystate.h to Include/cpython/pystate.h -- ___ Python tracker <https://bugs.python.org/issue38266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal
Joannah Nanjekye added the comment: I will handle this later today. -- ___ Python tracker <https://bugs.python.org/issue38266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38266] Revert bpo-37878: Make PyThreadState_DeleteCurrent() Internal
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +16148 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16558 ___ Python tracker <https://bugs.python.org/issue38266> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Change by Joannah Nanjekye : -- pull_requests: +16149 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16558 ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue36225] Lingering subinterpreters should be implicitly cleared on shutdown
Joannah Nanjekye added the comment: I remember julien wanting to check this out during a discussion we had at the sprints hence the loop in. -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue36225> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37878] Sub-Interpreters : Document PyThreadState_DeleteCurrent()
Joannah Nanjekye added the comment: > Oh, I didn't notice something in the review: the revert moved > >PyThreadState_DeleteCurrent() definition from Include/pystate.h to > >Include/cpython/pystate.h. Previously, it was defined in > > Include/pystate.h, see the commit removing it: I made this change as it was requested by Eric snow in issue38266. "when we un-revert we should be sure to move PyThreadState_DeleteCurrent() from Include/pystate.h to Include/cpython/pystate.h." -- ___ Python tracker <https://bugs.python.org/issue37878> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38379] finalizer resurrection in gc
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue38379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38388] Pickle protocol v 5 needs to be documented
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue38388> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue32498] urllib.parse.unquote raises incorrect errormessage when string parameter is bytes
Joannah Nanjekye added the comment: > Should I update the Status and Resolution of the issue here, or wait for some > kind of confirmation? The status is changed after the patch is merged. The person that merges will usually change the status of the issue or If he/she forgets, anyone with developer role can update the status too. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue32498> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38445] os.path.exists() takes bool as argument and returns True
Change by Joannah Nanjekye : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue38445> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38468] Refactor python-config.in - use getvar()
New submission from Joannah Nanjekye : Use getvar for all still existing sysconfig.get_config_var() calls. -- messages: 354591 nosy: nanjekyejoannah priority: normal severity: normal status: open title: Refactor python-config.in - use getvar() versions: Python 3.9 ___ Python tracker <https://bugs.python.org/issue38468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38468] Refactor python-config.in - use getvar()
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +16323 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16749 ___ Python tracker <https://bugs.python.org/issue38468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38468] Refactor python-config.in - use getvar()
Joannah Nanjekye added the comment: New changeset 3cd21aa6a1467723ccc85e6411a6cbe7fa81ef76 by Joannah Nanjekye in branch 'master': bpo-38468 : Refactor python-config (#16749) https://github.com/python/cpython/commit/3cd21aa6a1467723ccc85e6411a6cbe7fa81ef76 -- ___ Python tracker <https://bugs.python.org/issue38468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38468] Refactor python-config.in - use getvar()
Change by Joannah Nanjekye : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue38468> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions
Joannah Nanjekye added the comment: @benedwards14 Feel free to open a PR. @netbnd said anyone can take on the issue since he may take long to revert with a PR. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue37838> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37838] typing.get_type_hints not working with forward-declaration and decorated functions
Joannah Nanjekye added the comment: Actually there is a patch. So please @netbnd please open a PR https://github.com/python/cpython -- ___ Python tracker <https://bugs.python.org/issue37838> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11176] [doc] give more meaningful argument names in argparse documentation
Joannah Nanjekye added the comment: Can you give the original authors some credit too on the PR, if you built on their work, please? We usually do it by putting co-author: in the PR comment. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue11176> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44045] canonicalize "upper-case" -> "uppercase"; "lower-case" -> "lowercase"
Joannah Nanjekye added the comment: New changeset 2138b2edaf5acb3b9c162a9ba620923e286239a8 by Jürgen Gmach in branch 'main': bpo-44045: fix spelling of uppercase vs upper-case (GH-25985) https://github.com/python/cpython/commit/2138b2edaf5acb3b9c162a9ba620923e286239a8 -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue44045> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue43750] Undefined constant PACKET_MULTIHOST referred to in package socket
Joannah Nanjekye added the comment: New changeset 5f28752f5b51a1866f2428eeaf6082266723c78d by Zackery Spytz in branch 'main': bpo-43750: Fix incorrect reference to PACKET_MULTIHOST in the docs (GH-25241) https://github.com/python/cpython/commit/5f28752f5b51a1866f2428eeaf6082266723c78d -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue43750> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39560] PyUnicode_FromKindAndData kind transformation is not documented
Joannah Nanjekye added the comment: New changeset 4eed2821d40373345ed133b2b8d912fef59acab7 by Zackery Spytz in branch 'main': bpo-39560: Document PyUnicode_FromKindAndData() kind transformation (GH-23848) https://github.com/python/cpython/commit/4eed2821d40373345ed133b2b8d912fef59acab7 -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue39560> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39560] PyUnicode_FromKindAndData kind transformation is not documented
Change by Joannah Nanjekye : -- stage: patch review -> resolved ___ Python tracker <https://bugs.python.org/issue39560> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44310] lru_cache memory leak
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah, pablogsal ___ Python tracker <https://bugs.python.org/issue44310> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44310] Document that lru_cache uses hard references
Joannah Nanjekye added the comment: I saw the thread but the idea was rejected by @rhettinger who seems to suggest the changes in the documentation this time himself. Maybe he has changed his mind, in which case he can explain the circumstances of his decisions if he wants. -- ___ Python tracker <https://bugs.python.org/issue44310> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42194] Docs for argparse.BooleanOptionalAction missing "New in version 3.9"
Joannah Nanjekye added the comment: Am inclined to merge the former PR because yours is just an exact replica. Please note that we can merge such small fixes without the author signing the CLA but the author is advised to sign the CLA for future contributions. Source: informed by other core devs on reviewing similar PRs recently and a similar discussion was on a ML some time back. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue42194> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue37880] For argparse add_argument with action='store_const', const should default to None.
Joannah Nanjekye added the comment: @jack__d, please feel free to work on a PR. Also, do not hesitate to ask any questions along the way. Thanks for contributing to CPython. -- ___ Python tracker <https://bugs.python.org/issue37880> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44389] Modules/_ssl.c, repeated 'SSL_OP_NO_TLSv1_2'
Joannah Nanjekye added the comment: New changeset cb7230c7a7d6d497e54c25e9ba640eec79de10f2 by Erlend Egeberg Aasland in branch 'main': bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680) https://github.com/python/cpython/commit/cb7230c7a7d6d497e54c25e9ba640eec79de10f2 -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue44389> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16845] warnings.simplefilter should validate input
Joannah Nanjekye added the comment: @Bonifacio2, As commented on the PR, I think opening a PR with a patch close to what @berker.peksag suggested looks more elaborate, IMHO. Thanks for your contribution. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue16845> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44526] Doc typo in "What’s New In Python 3.10" (x/y-axis)
Joannah Nanjekye added the comment: Since this is the intended behavior, we can just close the issue. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue44526> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44526] Doc typo in "What’s New In Python 3.10" (x/y-axis)
Joannah Nanjekye added the comment: I mean intended wording -- ___ Python tracker <https://bugs.python.org/issue44526> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26329] os.path.normpath("//") returns //
Joannah Nanjekye added the comment: New changeset 66c5853406bbcccecf35372795078c0641a5f385 by Furkan Onder in branch 'main': bpo-26329: update os.path.normpath documentation (GH-20138) https://github.com/python/cpython/commit/66c5853406bbcccecf35372795078c0641a5f385 -- ___ Python tracker <https://bugs.python.org/issue26329> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45555] Object stays alive for weak reference if an exception happens in constructor
Joannah Nanjekye added the comment: I can reproduce the described scenario. I will nosy Pablo and Neil for another eye. I suggest that if it's not a bug, then maybe the docs should be updated to explain this behavior. The only part that talks about exceptions in the documentation for weakref.ref() reads as: """ Exceptions raised by the callback will be noted on the standard error output, but cannot be propagated; they are handled in exactly the same way as exceptions raised from an object’s __del__() method. """ -- nosy: +nanjekyejoannah, nascheme, pablogsal ___ Python tracker <https://bugs.python.org/issue4> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44665] asyncio.create_task() documentation should mention user needs to keep reference to the task
Change by Joannah Nanjekye : -- keywords: +patch nosy: +nanjekyejoannah nosy_count: 2.0 -> 3.0 pull_requests: +27437 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29163 ___ Python tracker <https://bugs.python.org/issue44665> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44665] asyncio.create_task() documentation should mention user needs to keep reference to the task
Joannah Nanjekye added the comment: @bernat and ncoghlan, please see if the wording I have used in the linked PR helps to clarify this. -- stage: patch review -> ___ Python tracker <https://bugs.python.org/issue44665> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42538] AsyncIO strange behaviour
Joannah Nanjekye added the comment: I opened a documentation PR agreeing with @ncoghlan, that adds this behavior. See https://bugs.python.org/issue44665 -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue42538> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue42538] AsyncIO strange behaviour
Joannah Nanjekye added the comment: I meant, "that describes the behaviour" -- ___ Python tracker <https://bugs.python.org/issue42538> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue39838] Possible unnecessary redifinition of _POSIX_C_SOURCE
Joannah Nanjekye added the comment: Closing this, someone else can reopen if they see the same. -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue39838> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24151] test_pydoc fails
Joannah Nanjekye added the comment: I wonder if this is worth keeping open, since it's old and no one has reproduced it. I propose closing or OP to share environment details. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue24151> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45578] Missing tests for he dis module
New submission from Joannah Nanjekye : I don't see any tests for the following: dis.distb dis.findlabels They are documented, I wonder if it was intentional. dis.findlabels is also not dicumented. -- components: Tests messages: 404805 nosy: nanjekyejoannah priority: normal severity: normal status: open title: Missing tests for he dis module versions: Python 3.11 ___ Python tracker <https://bugs.python.org/issue45578> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45578] Missing tests for the dis module
Change by Joannah Nanjekye : -- title: Missing tests for he dis module -> Missing tests for the dis module ___ Python tracker <https://bugs.python.org/issue45578> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45578] Missing tests for the dis module
Joannah Nanjekye added the comment: maybe the latter is not a public function. -- ___ Python tracker <https://bugs.python.org/issue45578> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue45578] Missing tests for the dis module
Joannah Nanjekye added the comment: It looks like it actually -- ___ Python tracker <https://bugs.python.org/issue45578> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15795] Zipfile.extractall does not preserve file permissions
Joannah Nanjekye added the comment: I left a review on the PR requesting for some tests, if it makes sense. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue15795> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14067] Avoid more stat() calls in importlib
Joannah Nanjekye added the comment: I wonder if the circumstances changed since this is an old issue? the method looks to have a deprecation warning and changed a bit too, I stand to be corrected. -- nosy: +nanjekyejoannah ___ Python tracker <https://bugs.python.org/issue14067> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
