[issue38723] Pdb._runscript should use io.open_code() instead of open()
Jason Killen added the comment: I flipped through PEP 578 (Runtime Audit Hooks) and this seems like the type of situation that PEP 578 was trying to handle. I've got a change that seems to be working and can provide a PR or whatever once I remember/read up on doing that. (I'm a very seldom contributor and am more than happy to defer to those that know more than me.) -- nosy: +Jason.Killen ___ Python tracker <https://bugs.python.org/issue38723> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38741] Definition of multiple ']' in header configparser
Change by Jason Killen : -- keywords: +patch pull_requests: +16638 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17129 ___ Python tracker <https://bugs.python.org/issue38741> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38722] runpy should use io.open_code() instead of open()
Jason Killen added the comment: I'll plan on tackling this one. I already did pdb. -- nosy: +Jason.Killen ___ Python tracker <https://bugs.python.org/issue38722> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38724] Implement subprocess.Popen.__repr__
Change by Jason Killen : -- nosy: +Jason.Killen ___ Python tracker <https://bugs.python.org/issue38724> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38724] Implement subprocess.Popen.__repr__
Jason Killen added the comment: I think this sounds great and I'll take a crack at it over the next few days. If anybody wants to jump ahead of me I don't mind. -- ___ Python tracker <https://bugs.python.org/issue38724> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38722] runpy should use io.open_code() instead of open()
Jason Killen added the comment: I made the change but the test suite is giving me fits and I don't know why. Running: ./python -m test ... == Tests result: FAILURE == 392 tests OK. 1 test failed: test_tools 26 tests skipped: test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_idle test_kqueue test_msilib test_ossaudiodev test_readline test_smtpnet test_socketserver test_startfile test_tcl test_timeout test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle test_urllib2net test_urllibnet test_winconsoleio test_winreg test_winsound test_xmlrpc_net test_zipfile64 Total duration: 17 min 38 sec Tests result: FAILURE But running: ./python -m test -v test_tools ... Ran 223 tests in 2.503s OK (skipped=2, expected failures=14) == Tests result: SUCCESS == 1 test OK. Total duration: 2.6 sec Tests result: SUCCESS Any tips for a newbe? -- ___ Python tracker <https://bugs.python.org/issue38722> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38812] Comparing datetime.time objects incorrect for TZ aware and unaware
Jason Killen added the comment:
This appears to be a bug in pytz which as far as I can tell is not part of the
"standard" lib, at least it's not in Lib.
Running this example which does not use pytz:
from datetime import timedelta, datetime, tzinfo, timezone, time
# stole this from the docs, and beat it up a bit
class KabulTz(tzinfo):
def utcoffset(self, dt):
return timedelta(hours=4, minutes=30)
def fromutc(self, dt):
# Follow same validations as in datetime.tzinfo
if not isinstance(dt, datetime):
raise TypeError("fromutc() requires a datetime argument")
if dt.tzinfo is not self:
raise ValueError("dt.tzinfo is not self")
return dt + timedelta(hours=4)
def dst(self, dt):
# Kabul does not observe daylight saving time.
return timedelta(0)
def tzname(self, dt):
return "+04"
tzaware_time2 = time(7,30,tzinfo=timezone.utc)
tzaware_time1 = time(7,30,tzinfo=KabulTz())
tzunaware_time = time(7, 30)
tzaware_time1 < tzaware_time2
I get no error.
When I use your example I notice that utcoffset in pytz/tzinfo.py returns None
for the Denver example but for the UTC object returns ZERO which happens to be
timedelta(0) which seems correct. It's weird to me that pytz is returning None
in the Denver case because I think what it should return is right there in
self._utcoffset.
More info: It looks like pytz isn't handling the fact that it's a time only
type. `dt` appears to be a datetime when utcoffset is called from a datetime.
--
nosy: +Jason.Killen
___
Python tracker
<https://bugs.python.org/issue38812>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38722] runpy should use io.open_code() instead of open()
Change by Jason Killen : -- keywords: +patch pull_requests: +16734 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17234 ___ Python tracker <https://bugs.python.org/issue38722> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38722] runpy should use io.open_code() instead of open()
Jason Killen added the comment: Tests working now. PR submitted. -- ___ Python tracker <https://bugs.python.org/issue38722> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38812] Comparing datetime.time objects incorrect for TZ aware and unaware
Jason Killen added the comment: Yep I wasn't seeing the forest for the trees. Thanks for clearing that up. I'll swoop back in and see what I can do. -- ___ Python tracker <https://bugs.python.org/issue38812> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue38741] Definition of multiple ']' in header configparser
Change by Jason Killen : -- nosy: +Jason.Killen ___ Python tracker <https://bugs.python.org/issue38741> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8536] Support new features of ZLIB 1.2.4
Jason Killen added the comment: Given this is marked as good for a newbie and easy I figured I'd take a crack at it but I'm confused. As example I don't see where inflateReset2 would be useful. I don't see anywhere inflateReset is used and would need to be replaced by inflateReset2. I also don't see where the action of inflateReset2 (End then Init) is currently used. What am I missing? -- nosy: +Jason.Killen ___ Python tracker <http://bugs.python.org/issue8536> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: I've generated a patch that checks to see if seen_greeting is set before processing other commands. This is the first time I've submitted a patch so if there is something more I need to do let me know. -- nosy: +Jason.Killen Added file: http://bugs.python.org/file24826/smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: On using a different approach: I weighed an approach like that and decided to go with what I thought was the clean/simple/easy approach. If there were more commands that smptd.py accepted I would have probably gone with more like what you mentioned. Change in error text: That's fine with me. I don't really care what it says. I'll make the change and generate a new patch but won't be able to get it done until Monday. Given that the inclusion of EHLO in the error text depends on another patch should I include EHLO, and maybe have to remove it later, or leave it out now and maybe have to put it in later? 2 patches, maybe, and we can pick when the time comes? So when patches like this get applied? If that's covered in an FAQ someplace please point me to it, I'm interested in some of the details. I poked around a bit but couldn't find what I was looking for. -- ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: Redone diff including wording preferred by R. David Murray. -- Added file: http://bugs.python.org/file24948/smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: Change of the smtpd test code to match the wording from the smtpd.patch. Also, added \r\n to the end of the expected string. -- Added file: http://bugs.python.org/file24949/test_smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: I'm adding a patch for test_smtpd.py. This version includes the changes in my previous patch and adds sending HELO before the commands in the test. Works good for me. -- Added file: http://bugs.python.org/file24963/test_smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: smtpd.py does not require HELO before NOOP or QUIT. I added them to test_smtpd.py because I felt it made test_smtpd.py well written as opposed to doing the least the spec requires. That said I suppose I should have added QUITs to every test also if that's the way I really feel. I'll make the change and post a diff. I don't mind this going back and forth. It's my first time around and I'm glad I've been helpful. -- ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Changes by Jason Killen : Removed file: http://bugs.python.org/file24948/smtpd_nogo.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Changes by Jason Killen : Removed file: http://bugs.python.org/file24826/smtpd_nogo.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Changes by Jason Killen : Removed file: http://bugs.python.org/file24949/test_smtpd_nogo.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Changes by Jason Killen : Added file: http://bugs.python.org/file24968/smtpd.py ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Changes by Jason Killen : Removed file: http://bugs.python.org/file24968/smtpd.py ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Changes by Jason Killen : Added file: http://bugs.python.org/file24969/smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: Ok I think this quote from the spec referenced pretty much sums it up. "The NOOP, HELP, EXPN, VRFY, and RSET commands can be used at any time during a session, or without previously initializing a session. SMTP servers SHOULD process these normally (that is, not return a 503 code) even if no EHLO command has yet been received; clients SHOULD open a session with EHLO before sending these commands." All in all either way fits the spec, choose your favorite. -- Added file: http://bugs.python.org/file24971/test_smtpd.py ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: Yes, "either way" in the test. The server shouldn't expect them and the client can do it either way. I'm adding a patch that tests with and without HELO for those commands that can be sent either way. -- Added file: http://bugs.python.org/file24972/test_smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: Removed '_syntax' apparently I fix that before but didn't regen the patch. Added tests for noHELO before some commands to test that failures happen as expected. -- Added file: http://bugs.python.org/file24973/test_smtpd.patch ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14269] SMTPD server does not enforce client starting mail transaction with HELO or EHLO
Jason Killen added the comment: Thanks and thanks for all you help. My method names are known to need some tweaking. Where is the agreement I need to sign? I looked around the documentation stuff and didn't see it. I'd like to continue contributing just have to find another bug I know how to fix. One last thing, what is the ACKS file? -- ___ Python tracker <http://bugs.python.org/issue14269> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8536] Support new features of ZLIB 1.2.6
Jason Killen added the comment: Given I'm new I wouldn't say I "evaluated" the usefulness of the new functions but I have given them a look and didn't see anything obvious. If thats good enough great, if not then hopefully someone with a little more experience will take a look. -- ___ Python tracker <http://bugs.python.org/issue8536> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
