[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

2018-07-03 Thread Evgeny Prilepin


New submission from Evgeny Prilepin :

The misprint in the file lib/zipfile.py in the line 704 leads to 
AttributeError: '_SharedFile' object has no attribute 'writing'

"self.writing()" should be replaced by "self._writing()". I also think this 
code shold be covered by tests.

--
components: Library (Lib)
messages: 320996
nosy: espdev
priority: normal
severity: normal
status: open
title: zipfile: AttributeError in "seek" method of "_SharedFile" class
type: crash
versions: Python 3.7

___
Python tracker 
<https://bugs.python.org/issue34035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

2018-07-03 Thread Evgeny Prilepin


Evgeny Prilepin  added the comment:

I think the line 1031 also contains the misprint and will raise NameError.

> self._decompressor = zipfile._get_decompressor(self._compress_type)

"zipfile." is not correct code in this place.

--

___
Python tracker 
<https://bugs.python.org/issue34035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue34035] zipfile: AttributeError in "seek" method of "_SharedFile" class

2018-07-04 Thread Evgeny Prilepin

Evgeny Prilepin  added the comment:

Hi Rémi, it would be great if you posted a PR.

--

___
Python tracker 
<https://bugs.python.org/issue34035>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com