[issue14778] IrrationalVersionError should include the project name

2012-05-14 Thread Christoph Sieghart

Christoph Sieghart  added the comment:

I took a look at the code and I don't think that adding an argument to the 
IrrationalVersionError constructor is the right way to go. 

The exception is raised in places where we don't know for which project we are 
raising the exception (eg in packaging.version.NormalizedVersion).

Wouldn't it be better to make packaging.pypi.xmlrpc.Client just print the
package name with the exception?

I would be glad to contribute a patch.

--
nosy: +sigi

___
Python tracker 
<http://bugs.python.org/issue14778>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14778] logging messages about bad version numbers should include the project name

2012-05-14 Thread Christoph Sieghart

Christoph Sieghart  added the comment:

The optional argument approach doesn't seem clean to me either. 

I think the correct approach is - as you wrote - to change the higher level 
code to include the project name in the exception message.

--

___
Python tracker 
<http://bugs.python.org/issue14778>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14778] logging messages about bad version numbers should include the project name

2012-05-14 Thread Christoph Sieghart

Christoph Sieghart  added the comment:

I wrote a trivial patch against the CPython repository that adds the name to 
the exception message. Did I forget anything? What kind of test would make 
sense?

--
keywords: +patch
Added file: http://bugs.python.org/file25587/bad_version_number_with_name.patch

___
Python tracker 
<http://bugs.python.org/issue14778>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14778] logging messages about bad version numbers should include the project name

2012-05-14 Thread Christoph Sieghart

Changes by Christoph Sieghart :


Removed file: 
http://bugs.python.org/file25587/bad_version_number_with_name.patch

___
Python tracker 
<http://bugs.python.org/issue14778>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14778] logging messages about bad version numbers should include the project name

2012-05-14 Thread Christoph Sieghart

Changes by Christoph Sieghart :


Added file: http://bugs.python.org/file25589/bad_version_number_with_name.patch

___
Python tracker 
<http://bugs.python.org/issue14778>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14102] argparse: add ability to create a man page

2012-12-03 Thread Christoph Sieghart

Changes by Christoph Sieghart :


--
nosy: +sigi

___
Python tracker 
<http://bugs.python.org/issue14102>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23566] RFE: faulthandler.register() should support file descriptors

2015-03-04 Thread Christoph Sieghart

Changes by Christoph Sieghart :


--
nosy: +sigi

___
Python tracker 
<http://bugs.python.org/issue23566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue23566] RFE: faulthandler.register() should support file descriptors

2015-03-13 Thread Christoph Sieghart

Changes by Christoph Sieghart :


--
nosy:  -sigi

___
Python tracker 
<http://bugs.python.org/issue23566>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com