[issue14399] zipfile and creat/update comment
New submission from Cassaigne :
I want to update or create a comment to zip file.
For instance, I have test.zip file.
I'm using these statement to create a comment :
from zipfile import ZipFile
z=ZipFile('test.zip','a')
z.comment='Create a new comment'
z.close()
After to ran this script, the zip file test.zip doesn't including the new
comment !
I can have the expected behavior when I add a new file inner zip archive.
--
components: Library (Lib)
files: bug_zipfile_comment.py
messages: 156699
nosy: acassaigne
priority: normal
severity: normal
status: open
title: zipfile and creat/update comment
type: behavior
versions: Python 2.7
Added file: http://bugs.python.org/file25011/bug_zipfile_comment.py
___
Python tracker
<http://bugs.python.org/issue14399>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14399] zipfile and creat/update comment
Cassaigne added the comment: Tanks à lot. To complete Information about this bug. it up and take a look. The relevant code is in Python, and I'm guessing there is some logic bug when only the comment is set (and nothing is added to the zipfile), but I haven't looked at the code. I'm also adding 3.2 and 3.3; it fails on 3.3 as well. > > -- > keywords: +easy > nosy: +r.david.murray > stage: -> needs patch > versions: +Python 3.2, Python 3.3 > > ___ > Python tracker > <http://bugs.python.org/issue14399> > ___ > -- ___ Python tracker <http://bugs.python.org/issue14399> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)
Cassaigne added the comment: I correct the doc concerning subprocess.getstatusoutput(cmd) function. More specifically the part on examples and I add a quick explanation about how are manage the return code. -- keywords: +patch nosy: +acassaigne versions: +Python 3.6, Python 3.7 Added file: http://bugs.python.org/file45075/issue22635.diff ___ Python tracker <http://bugs.python.org/issue22635> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)
Cassaigne added the comment: I improve the patch a little bit, following the recommendations of the Stinner's review. I replace "status" mention by "exit code". -- Added file: http://bugs.python.org/file45077/issue22635-2.diff ___ Python tracker <http://bugs.python.org/issue22635> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)
Cassaigne added the comment: According to the Victor's review, I remove "Pay attention" words and change exit code by returncode. -- Added file: http://bugs.python.org/file45078/issue22635-3.diff ___ Python tracker <http://bugs.python.org/issue22635> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22635] subprocess.getstatusoutput changed behavior in 3.4 (maybe 3.3.4?)
Cassaigne added the comment: I add a crosslink to WEXITSTATUS function. According David Murray advices. -- Added file: http://bugs.python.org/file45079/issue22635-4.diff ___ Python tracker <http://bugs.python.org/issue22635> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
