[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Changes by Caio Romão :


Removed file: http://bugs.python.org/file23118/caioromao-fix-12930-v2.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

Third version, with slightly less code and my name added to the Misc/ACKS file.

--
Added file: http://bugs.python.org/file23146/caioromao-fix-12930-v3.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Changes by Caio Romão :


Removed file: http://bugs.python.org/file23146/caioromao-fix-12930-v3.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

New patch version ack-ing Éric's suggestion.

Note: I'm now confused as to whether I should add my name to the ACKS file or 
not, heh. This patch doesn't include the change.

--
Added file: http://bugs.python.org/file23194/caioromao-fix-12930-v4.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

Attaching files for testing in a gzipped tarball:

 - testfile-original.py: file to be reindented with reindent.py
 - testfile-issue.py: resulting file after using the current 
Tools/scripts/reindent.py
 - testfile-expected.py: expected output file; the result after applying the 
patch in this thread

--
Added file: http://bugs.python.org/file23195/bug12930-testfiles.tgz

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

It's been a while since this got any activity. Was the provided testfile not 
enough or any issue found? Just let me know and I'll make adjustments asap.

--

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

Attaching files from tarball as requested. See 
http://bugs.python.org/issue12930#msg144314 for explanation

--
Added file: http://bugs.python.org/file23500/testfile-original.py

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Changes by Caio Romão :


Added file: http://bugs.python.org/file23501/testfile-expected.py

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Changes by Caio Romão :


Added file: http://bugs.python.org/file23502/testfile-issue.py

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

This patch fixes the reported issue.

First time contributor here, feel free to bash.

--
keywords: +patch
nosy: +caioromao
Added file: http://bugs.python.org/file23117/caioromao-fix-12930.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Changes by Caio Romão :


Removed file: http://bugs.python.org/file23117/caioromao-fix-12930.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12930] reindent.py inserts spaces in multiline literals

[Caio Romão]

Caio Romão  added the comment:

New patch, fixing issue pointed out by gutworth and some others that came up.

I've used the following as a test input:

-8<--8<
#!/usr/bin/python
def x():
  """
  This is a doc
  """
  '''
  Another doc.'''
  s = """line one
line two
  line three
  '''
line five
"""
  var = '''test'''
  """Third doc"""
  return s
-8<--8<

The patch got way bigger than the initial version and feels a little hackish, 
but I couldn't come up with something better.

--
Added file: http://bugs.python.org/file23118/caioromao-fix-12930-v2.patch

___
Python tracker 
<http://bugs.python.org/issue12930>
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com