[issue11489] json.dumps not parsable by json.loads (on Linux only)
Brian added the comment:
On Mon, Mar 14, 2011 at 4:09 PM, Raymond Hettinger
wrote:
>
> Raymond Hettinger added the comment:
>
> > We seem to be in the worst of both worlds right now
> > as I've generated and stored a lot of json that can
> > not be read back in
>
> This is unfortunate. The dumps() should have never worked in the first
> place.
>
> I don't think that loads() should be changed to accommodate the dumps()
> error though. JSON is UTF-8 by definition and it is a useful feature that
> invalid UTF-8 won't load.
>
I may be wrong but it appeared that json actually encoded the data as the
string "u\da00" ie (6-bytes) which is slightly different than the encoding
of the utf-8 encoding of the json itself. Not sure if this is relevant but
it seems less severe than actually invalid utf-8 coding in the bytes.
Unfortunately I don't believe this does anything on python 2.x as only
python 3.x encode/decode flags this as invalid.
> --
> nosy: +rhettinger
> priority: normal -> high
>
> ___
> Python tracker
> <http://bugs.python.org/issue11489>
> ___
>
--
nosy: +merrellb
Added file: http://bugs.python.org/file21135/unnamed
___
Python tracker
<http://bugs.python.org/issue11489>
___On Mon, Mar 14, 2011 at 4:09 PM, Raymond Hettinger <mailto:rep...@bugs.python.org";>rep...@bugs.python.org>
wrote:
Raymond Hettinger <mailto:rhettin...@users.sourceforge.net";>rhettin...@users.sourceforge.net>
added the comment:
> We seem to be in the worst of both worlds right now
> as I've generated and stored a lot of json that can
> not be read back in
This is unfortunate. Â The dumps() should have never worked in the first
place.
I don't think that loads() should be changed to accommodate the dumps()
error though. Â JSON is UTF-8 by definition and it is a useful feature that
invalid UTF-8 won't load. I may be wrong
but it appeared that json actually encoded the data as the string
"u\da00" ie (6-bytes) which is slightly different than the encoding
of the utf-8 encoding of the json itself. Â Not sure if this is relevant but it
seems less severe than actually invalid utf-8 coding in the bytes.
Â
To fix the data you've already created (one that other compliant JSON
readers wouldn't be able to parse), I think you need to repreprocess those
file to make them valid:
 bs.decode('utf-8',
errors='ignore').encode('utf-8')Unfortunately
I don't believe this does anything on python 2.x as only python 3.x
encode/decode flags this as invalid.
Â
--
nosy: +rhettinger
priority: normal -> high
___
Python tracker <mailto:rep...@bugs.python.org";>rep...@bugs.python.org>
<http://bugs.python.org/issue11489";
target="_blank">http://bugs.python.org/issue11489>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7214] TreeBuilder.end(tag) differs between cElementTree and ElementTree
Brian added the comment: What solution did you chose? While matching cElementTree to the ElementTree is the simplest solution I think there is some ambiguity as to the what the preferred behavior as outlined in my original post. -brian On Tue, Feb 16, 2010 at 9:41 AM, Florent Xicluna wrote: > > Changes by Florent Xicluna : > > > -- > components: +XML -Library (Lib) > nosy: +flox > priority: -> normal > stage: -> test needed > versions: +Python 2.7 > > ___ > Python tracker > <http://bugs.python.org/issue7214> > ___ > -- Added file: http://bugs.python.org/file16571/unnamed ___ Python tracker <http://bugs.python.org/issue7214> ___What solution did you chose? Â While matching cElementTree to the ElementTree is the simplest solution I think there is some ambiguity as to the what the preferred behavior as outlined in my original post. -brianOn Tue, Feb 16, 2010 at 9:41 AM, Florent Xicluna <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> wrote: Changes by Florent Xicluna <mailto:la...@yahoo.fr";>la...@yahoo.fr>: -- components: +XML -Library (Lib) nosy: +flox priority: Â -> normal stage: Â -> test needed versions: +Python 2.7 ___ Python tracker <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> <http://bugs.python.org/issue7214"; target="_blank">http://bugs.python.org/issue7214> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
New submission from Brian :
Despite carefully matching my get() and task_done() statements I would
often trigger "raise ValueError('task_done() called too many times')" in
my multiprocessing.JoinableQueue (multiprocessing/queues.py)
Looking over the code (and a lot of debug logging), it appears that the
issue arises from JoinableQueue.put() not being protected with a locking
mechanism. A preemption after the first line allows other processes to
resume without releasing the _unfinished_tasks semaphore.
The simplest solution seems to be allowing task_done() to block while
waiting to acquire the _unfinished_tasks semaphore.
Replacing:
if not self._unfinished_tasks.acquire(False):
raise ValueError('task_done() called too many times')
With simply:
self._unfinished_tasks.acquire()
This would however remove the error checking provided (given the many
far more subtler error that can be made, I might argue it is of limited
value). Alternately the JoinableQueue.put() method could be better
protected.
--
components: Library (Lib)
messages: 77806
nosy: merrellb
severity: normal
status: open
title: multiprocessing.JoinableQueue task_done() issue
versions: Python 2.6, Python 2.7, Python 3.0, Python 3.1
___
Python tracker
<http://bugs.python.org/issue4660>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
Changes by Brian : -- type: -> behavior ___ Python tracker <http://bugs.python.org/issue4660> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
Brian added the comment: Here are a few stabs at how this might be addressed. 1) As originally suggested. Allow task_done() to block waiting to acquire _unfinished_tasks. This will allow the put() process to resume, release() _unfinished_tasks at which point task_done() will unblock. No harm, no foul but you do lose some error checking (and maybe some performance?) 2) One can't protect JoinableQueue.put() by simply acquiring _cond before calling Queue.put(). Fixed size queues will block if the queue is full, causing deadlock when task_done() can't acquire _cond. The most obvious solution would seem to be reimplementing JoinableQueue.put() (not simply calling Queue.put()) and then inserting self._unfinished_tasks.release() into a protected portion. Perhaps: def put(self, obj, block=True, timeout=None): assert not self._closed if not self._sem.acquire(block, timeout): raise Full self._notempty.acquire() self._cond.acquire() try: if self._thread is None: self._start_thread() self._buffer.append(obj) self._unfinished_tasks.release() self._notempty.notify() finally: self._cond.release() self._notempty.release() We may be able to get away with not acquiring _cond as _notempty would provide some protection. However its relationship to get() isn't entirely clear to me so I am not sure if this would be sufficient. ___ Python tracker <http://bugs.python.org/issue4660> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44819] assertSequenceEqual does not use _getAssertEqualityFunc
New submission from Brian : Like the title says, TestCase.assertSequenceEqual does not behave like TestCase.assertEqual where it uses TestCase._getAssertEqualityFunc. Instead, TestCase.assertSequenceEqual uses `item1 != item2`. That way I can do something like this: ``` def test_stuff(self): self.addTypeEqualityFunc( MyObject, comparison_method_which_compares_how_i_want, ) self.assertListEqual( get_list_of_objects(), [MyObject(...), MyObject(...)], ) ``` -- components: Tests messages: 398851 nosy: Rarity priority: normal severity: normal status: open title: assertSequenceEqual does not use _getAssertEqualityFunc type: behavior versions: Python 3.6, Python 3.9 ___ Python tracker <https://bugs.python.org/issue44819> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue44819] assertSequenceEqual does not use _getAssertEqualityFunc
Brian added the comment: I've attached an example of what I want. It contains a class, a function to be tested, and a test class which tests the function. What TestCase.addTypeEqualityFunc feels like it offers is a chance to compare objects however I feel like is needed for each test. Sometimes all I want is to compare the properties of the objects, and maybe not even all of the properties! When I have a list of these objects and I've added an equality function for the object, I was expecting the test class to use my equality function when comparing objects in the list. -- Added file: https://bugs.python.org/file50201/example.py ___ Python tracker <https://bugs.python.org/issue44819> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40027] re.sub inconsistency beginning with 3.7
Brian added the comment:
I just ran into this change in behavior myself.
It's worth noting that the new behavior appears to match perl's behavior:
# perl -e 'print(("he" =~ s/e*\Z/ah/rg), "\n")'
hahah
--
nosy: +bsammon
___
Python tracker
<https://bugs.python.org/issue40027>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue40027] re.sub inconsistency beginning with 3.7
Brian added the comment: txt = ' test' txt = re.sub(r'^\s*', '^', txt) substitutes once because the * is greedy. txt = ' test' txt = re.sub(r'^\s*?', '^', txt) substitutes twice, consistent with the \Z behavior. -- ___ Python tracker <https://bugs.python.org/issue40027> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue31192] "return await coro()" SyntaxError despite being "valid syntax" in PEP 492
New submission from Brian: PEP 492 lists the following under "valid syntax" and yet 3.5.2 raises a SyntaxError: def foo(): return await coro() but this works: def bar(): return await (coro()) -- components: Interpreter Core messages: 300209 nosy: merrellb priority: normal severity: normal status: open title: "return await coro()" SyntaxError despite being "valid syntax" in PEP 492 type: behavior versions: Python 3.5 ___ Python tracker <http://bugs.python.org/issue31192> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
Brian added the comment: Cool., let me know if there is anything I can do to help. On Mon, Jun 29, 2009 at 7:46 AM, Jesse Noller wrote: > > Jesse Noller added the comment: > > I'm leaning towards the properly protecting JoinableQueue.put() fix, I'm > not a terribly big fan of removing error checking. I'm trying to carve off > time this week to beat on my bug queue, so I'm hoping to be able to commit > something (once I have docs+tests) this week. > > -- > > ___ > Python tracker > <http://bugs.python.org/issue4660> > ___ > -- Added file: http://bugs.python.org/file14473/unnamed ___ Python tracker <http://bugs.python.org/issue4660> ___Cool., let me know if there is anything I can do to help.On Mon, Jun 29, 2009 at 7:46 AM, Jesse Noller <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> wrote: Jesse Noller <mailto:jnol...@gmail.com";>jnol...@gmail.com> added the comment: I'm leaning towards the properly protecting JoinableQueue.put() fix, I'm not a terribly big fan of removing error checking. I'm trying to carve off time this week to beat on my bug queue, so I'm hoping to be able to commit something (once I have docs+tests) this week. -- ___ Python tracker <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> <http://bugs.python.org/issue4660"; target="_blank">http://bugs.python.org/issue4660> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6628] IDLE freezes after encountering a syntax error
New submission from brian : Running Python 3.1/ IDLE, which was installed on top of a Python 2.5.4 install, Mac OSX 10.4 This seems like such an obvious bug, but I can't find it in the current list of issues - so I suspect that it may not be reproducible on other computers, but it's certainly reproducible on my laptop. If I run a module with (any?) syntax error (for example, for i in range(10) #missing semicolon print i the interpreter will catch it and send you to fix it. Then, any subsequent attempts to run that same module will freeze IDLE. The problem doesn't occur if you run a different module. -- components: IDLE messages: 91210 nosy: brian89 severity: normal status: open title: IDLE freezes after encountering a syntax error type: crash versions: Python 3.1 ___ Python tracker <http://bugs.python.org/issue6628> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6628] IDLE freezes after encountering a syntax error
brian added the comment: I have Tcl/tk 8.4.7 installed. To reproduce the hang on my machine: open IDLE new window enter the following code: for i in range(10) print(i) run module (saved as test.py) interpreter complains (shell is still responsive at this point) fix the code by adding the colon after the for loop run module again (at this point, IDLE hangs) While the top menu bar is responsive, all options are greyed out, and apple-Q doesn't work. Force-quit is necessary to shut IDLE down. Also, the force-quit menu doesn't show IDLE as being unresponsive, whereas usually there will be a red alert for an unresponsive program. Hope this helps -- components: -Macintosh ___ Python tracker <http://bugs.python.org/issue6628> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7214] TreeBuilder.end(tag) differs between cElementTree and ElementTree
New submission from Brian : In the pure python ElementTree, the tag passed to the end() tag is verified to be closing the last tag opened (self._last). This cElementTree performs no such validation and closes the last tag regardless of what tag is passed to the method. In my mind this raises a couple questions beyond simply fixing this discrepancy. 1) Why make this tag mandatory if it has no effect in the cElementTree version (and in the pure python version is only used to verify the user isn't confused what tag they are closing) 2) Could the argument be removed, simply closing the last tag if not present? 3) Or could the behavior be changed to actually influence which tag is closed, allowing one to close all tags out to a specific outer/encompassing tag (much like close(), closes all tags)? -brian -- components: Library (Lib) messages: 94542 nosy: merrellb severity: normal status: open title: TreeBuilder.end(tag) differs between cElementTree and ElementTree type: behavior versions: Python 2.6 ___ Python tracker <http://bugs.python.org/issue7214> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7215] TreeBuilder.end(tag) differs between cElementTree and ElementTree
New submission from Brian : In the pure python ElementTree, the tag passed to the end() tag is verified to be closing the last tag opened (self._last). This cElementTree performs no such validation and closes the last tag regardless of what tag is passed to the method. In my mind this raises a couple questions beyond simply fixing this discrepancy. 1) Why make this tag mandatory if it has no effect in the cElementTree version (and in the pure python version is only used to verify the user isn't confused what tag they are closing) 2) Could the argument be removed, simply closing the last tag if not present? 3) Or could the behavior be changed to actually influence which tag is closed, allowing one to close all tags out to a specific outer/encompassing tag (much like close(), closes all tags)? -brian -- components: Library (Lib) messages: 94543 nosy: merrellb severity: normal status: open title: TreeBuilder.end(tag) differs between cElementTree and ElementTree type: behavior versions: Python 2.6 ___ Python tracker <http://bugs.python.org/issue7215> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7215] TreeBuilder.end(tag) differs between cElementTree and ElementTree
Changes by Brian : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue7215> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
Brian added the comment: Hey Jesse, It was good meeting you at Pycon. I don't have anything handy at the moment although, if memory serves, the most trivial of example seemed to illustrate the problem. Basically any situation where a joinable queue would keep bumping up against being empty (ie retiring items faster than they are being fed), and does enough work between get() and task_done() to be preempted would eventually break. FWIW I was running on a Windows box. I am afraid I am away from my computer until late tonight but I can try to cook something up then (I presume you are sprinting today?). Also I think the issue becomes clear when you think about what happens if joinablequeue.task_done() gets preempted between its few lines. -brian On Mon, Mar 30, 2009 at 2:55 PM, Jesse Noller wrote: > > Jesse Noller added the comment: > > Hi Brian - do you have a chunk of code that exacerbates this? I'm having > problems reproducing this, and need a test so I can prove out the fix. > > -- > > ___ > Python tracker > <http://bugs.python.org/issue4660> > ___ > -- Added file: http://bugs.python.org/file13485/unnamed ___ Python tracker <http://bugs.python.org/issue4660> ___Hey Jesse,It was good meeting you at Pycon. Â I don't have anything handy at the moment although, if memory serves, the most trivial of example seemed to illustrate the problem. Â Basically any situation where a joinable queue would keep bumping up against being empty (ie retiring items faster than they are being fed), and does enough work between get() and task_done() to be preempted would eventually break. Â FWIW I was running on a Windows box. I am afraid I am away from my computer until late tonight but I can try to cook something up then (I presume you are sprinting today?). Â Also I think the issue becomes clear when you think about what happens if joinablequeue.task_done() gets preempted between its few lines. -brianOn Mon, Mar 30, 2009 at 2:55 PM, Jesse Noller <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> wrote: Jesse Noller <mailto:jnol...@gmail.com";>jnol...@gmail.com> added the comment: Hi Brian - do you have a chunk of code that exacerbates this? I'm having problems reproducing this, and need a test so I can prove out the fix. -- ___ Python tracker <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> <http://bugs.python.org/issue4660"; target="_blank">http://bugs.python.org/issue4660> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
Brian added the comment:
Jesse,
I am afraid my last post may have confused the issue. As I mentioned in
my first post, the problem arises when JoinableQueue.put is preempted
between its two lines. Perhaps the easiest way to illustrate this is to
exacerbate it by modifying JoinableQueue.put to force a preemption at
this inopportune time.
import time
def put(self, item, block=True, timeout=None):
Queue.put(self, item, block, timeout)
time.sleep(1)
self._unfinished_tasks.release()
Almost any example will now fail.
from multiprocessing import JoinableQueue, Process
def printer(in_queue):
while True:
print in_queue.get()
in_queue.task_done()
if __name__ == '__main__':
jqueue = JoinableQueue()
a = Process(target = printer, args=(jqueue,)).start()
jqueue.put("blah")
--
___
Python tracker
<http://bugs.python.org/issue4660>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4660] multiprocessing.JoinableQueue task_done() issue
Brian added the comment: Filipe, Thanks for the confirmation. While I think the second option (ie properly protecting JoinableQueue.put()) is best, the first option (simply removing the 'task_done() called too many times' check) should be safe (presuming your get() and put() calls actually match). Jesse, any luck sorting out the best fix for this? I really think that JoinableQueue (in my opinion the most useful form of multiprocessing queues) can't be guaranteed to work on any system right now. -brian -- ___ Python tracker <http://bugs.python.org/issue4660> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7214] TreeBuilder.end(tag) differs between cElementTree and ElementTree
Brian added the comment: Florent, Does keeping the current behavior mean no change? This issue, more fundamental than this discrepancy, is what is the purpose of the argument to *end* in the first place? Why have a required argument that is usually ignored and when not ignored it used only to verify that one actually knows the current tag they are ending (ie the argument doesn't actually seem to DO anything)? -brian On Sun, Aug 8, 2010 at 4:42 PM, Florent Xicluna wrote: > > Florent Xicluna added the comment: > > The verification of the matching between start and end tag is performed in > a debug "assert" statement in the Python version. > This check is ignored if the module is compiled with -O. > It is ignored in the C version, too. > > I would suggest to keep the current behavior for both versions. > Fredrik and Stefan are CC'd if they want to comment. > > -- > nosy: +effbot, scoder > versions: +Python 3.2 -Python 2.6 > > ___ > Python tracker > <http://bugs.python.org/issue7214> > ___ > -- Added file: http://bugs.python.org/file18445/unnamed ___ Python tracker <http://bugs.python.org/issue7214> ___Florent,Does keeping the current behavior mean no change?  This issue, more fundamental than this discrepancy, is what is the purpose of the argument to end in the first place?  Why have a required argument that is usually ignored and when not ignored it used only to verify that one actually knows the current tag they are ending (ie the argument doesn't actually seem to DO anything)? -brianOn Sun, Aug 8, 2010 at 4:42 PM, Florent Xicluna <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> wrote: Florent Xicluna <mailto:florent.xicl...@gmail.com";>florent.xicl...@gmail.com> added the comment: The verification of the matching between start and end tag is performed in a debug "assert" statement in the Python version. This check is ignored if the module is compiled with -O. It is ignored in the C version, too. I would suggest to keep the current behavior for both versions. Fredrik and Stefan are CC'd if they want to comment. -- nosy: +effbot, scoder versions: +Python 3.2 -Python 2.6 ___ Python tracker <mailto:rep...@bugs.python.org";>rep...@bugs.python.org> <http://bugs.python.org/issue7214"; target="_blank">http://bugs.python.org/issue7214> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25396] A Python runtime not could be located.
New submission from Brian: Hello - I'm new to this community and an system error brings me here. Thank you all in advance for any help and support! I'm using a MacBook Pro (Retina, 15-inch, Late 2013) with OS 10.11 El Capitan. I receive the following error every 15-30 minutes: "Utility[601]: A Python runtime not could be located. You may need to install a framework build of Python, or edit the PyRuntimeLocations array in this application's Info.plist file." I have the option to "Open Console" or "Terminate" to clear the window. I wasn't aware of Python before the error popped up which leads me to believe a third party application used/uses Python in the background. I installed Python 3.5.0 and I still received the error. I removed Python 3.5.0 and I still received the error. I installed Python 2.7.10 and I still received the error. I removed Python 2.7.10 and I still received the error. I'm at a loss for options moving forward and the error window popping up every 20 minutes is not the most ideal situation for teaching via PowerPoint. HELP :) If there's a diagnostic report I need to run, please let me know and I'll run it. Thank you in advance, Brian -- messages: 252955 nosy: bkbdrummer priority: normal severity: normal status: open title: A Python runtime not could be located. ___ Python tracker <http://bugs.python.org/issue25396> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23791] Identify Moved Lines with difflib
New submission from Brian: It would be a helpful feature to incorporate logic into the difflib module to optionally identify and ignore identical, but relocated lines when doing a diff. This would be used when the order of lines in a document is not critical, but rather just the overall content. The Notepad++ Compare plug-in has this feature for reference. I would be willing to help submit a patch for this change. The only drawbacks I see using this function is it will either have to increase processing time or increase memory usage. -- components: Library (Lib) messages: 239416 nosy: bkiefer priority: normal severity: normal status: open title: Identify Moved Lines with difflib type: enhancement versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/issue23791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23791] Identify Moved Lines with difflib
Brian added the comment: I have put together 5 basic tests to implement moved lines in difflib. All diffs should be compared against the 'diffmove_base.txt' file. Below is a short description of each test. 1) Basic reordering of lines 2) Reordering of lines with new lines added 3) Reordering of lines with one line removed 4) Reordering of lines with one character omitted from a line and character added to another line 5) Combination of all previous tests -- Added file: http://bugs.python.org/file38747/python_diff_move.zip ___ Python tracker <http://bugs.python.org/issue23791> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46073] ast.unparse produces: 'FunctionDef' object has no attribute 'lineno' for valid module
New submission from Brian Carlson : Test file linked. When unparsing the output from ast.parse on a simple class, unparse throws an error: 'FunctionDef' object has no attribute 'lineno' for a valid class and valid AST. It fails when programmatically building the module AST as well. It seems to be from this function: https://github.com/python/cpython/blob/1cbb88736c32ac30fd530371adf53fe7554be0a5/Lib/ast.py#L790 -- components: Library (Lib) files: test.py messages: 408546 nosy: TheRobotCarlson priority: normal severity: normal status: open title: ast.unparse produces: 'FunctionDef' object has no attribute 'lineno' for valid module type: crash versions: Python 3.10, Python 3.11, Python 3.9 Added file: https://bugs.python.org/file50490/test.py ___ Python tracker <https://bugs.python.org/issue46073> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46073] ast.unparse produces: 'FunctionDef' object has no attribute 'lineno' for valid module
Brian Carlson added the comment:
The second solution seems more optimal, in my opinion. I monkey patched the
function like this in my own code:
```
def get_type_comment(self, node):
comment = self._type_ignores.get(node.lineno) if hasattr(node, "lineno")
else node.type_comment
if comment is not None:
return f" # type: {comment}"
```
Thanks!
--
___
Python tracker
<https://bugs.python.org/issue46073>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue46073] ast.unparse produces: 'FunctionDef' object has no attribute 'lineno' for valid module
Brian Carlson added the comment: I don't think passing `lineno` and `column` is preferred. It makes code generation harder because `lineno` and `column` are hard to know ahead of when code is being unparsed. -- ___ Python tracker <https://bugs.python.org/issue46073> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1574217] isinstance swallows exceptions
Changes by Brian Harring : -- versions: +Python 2.5 _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1574217> _ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12988] IDLE on Win7 crashes when saving to Documents Library
New submission from Brian Gernhardt : Python 3.2.1 (default, Jul 10 2011, 20:02:51) [MSC v.1500 64 bit (AMD64)] on win32 Steps: 1) Start IDLE 2) Open Save dialog (File > Save or Ctrl-S) 3) Select Libraries from the buttons on the left or the dropdown on top. 4) Double-click on Documents 5) Enter any file name (test.txt) 6) Hit enter or click save 7) See "pythonw.exe has stopped working dialog" I tried running it from the command line (via c:\python32\python -m idlelib.idle) and it produced no useful error messages. -- components: IDLE messages: 144106 nosy: Brian.Gernhardt priority: normal severity: normal status: open title: IDLE on Win7 crashes when saving to Documents Library versions: Python 3.2 ___ Python tracker <http://bugs.python.org/issue12988> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12989] Consistently handle path separator in Py_GetPath on Windows
Changes by Brian Curtin : -- keywords: +needs review stage: -> patch review type: -> security versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue12989> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13081] Crash in Windows with unknown cause
Brian Curtin added the comment: I recently created "minidumper" to write Visual Studio "MiniDump" files of interpreter crashes, but it's currently only available on 3.x. If I port it to 2.x, you could add "import minidumper;minidumper.enable()" to the top of your script, then we could probably get somewhere with it. An additional example script, possibly including sample data to run through it, would be even better. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue13081> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9035] os.path.ismount on windows doesn't support windows mount points
Brian Curtin added the comment: We can't depend on stuff from pywin32, but we could expose GetVolumePathName ourselves. -- ___ Python tracker <http://bugs.python.org/issue9035> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13101] Module Doc viewer closes when browser window closes on Windows 8
New submission from Brian Curtin : Reported by Ryan Wells (v-ry...@microsoft.com) of Microsoft, in reference to a problem with the Module Doc viewer on Windows 8 when using Internet Explorer 10. This was reported on 3.2.2, but it's likely the same on 2.7. Reference #: 70652 Description of the Problem: The application Python Module Doc is automatically closed when Internet Explorer 10 is closed. Steps to Reproduce: 1. Install Windows Developer Preview 2. Install Python 3.2.2 3. Launch Module Doc. Start Menu -> All Program -> Python -> Manual Docs 4. Click on the button open browser 5. It should open the site http://localhost:7464/ In Internet Explorer 10 and the contents should be displayed 6. Should be able to view list of Modules, Scripts, DLLs, and Libraries etc. 7. Close Internet Explorer Expected Result: Internet Explorer 10 should only get closed and we should be able to work with the application Module Doc. Actual Result: The application Module Doc is closed with Internet Explorer 10. Developer Notes: There is likely a difference in return values between IE8 and IE9/10 when launched from the app. -- assignee: docs@python components: Documentation, Windows messages: 144918 nosy: brian.curtin, docs@python priority: normal severity: normal status: open title: Module Doc viewer closes when browser window closes on Windows 8 type: behavior versions: Python 3.3 ___ Python tracker <http://bugs.python.org/issue13101> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13101] Module Doc viewer closes when browser window closes on Windows 8
Brian Curtin added the comment: The menu shortcut opens up the following: "C:\Python32\pythonw.exe" "C:\Python32\Tools\scripts\pydocgui.pyw", which is just pydoc.gui() -- ___ Python tracker <http://bugs.python.org/issue13101> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13081] Crash in Windows with unknown cause
Brian Curtin added the comment: I tried that script on 2.7 and like it did for you, it just ran until my machine became unusable. On 3.x I think I got a RuntimeError after a while, but I forgot exactly what happened since the machine ended up being hosed later from the 2.7 run. In any event, it certainly didn't crash there and only went a short time before erroring out with some exception. -- ___ Python tracker <http://bugs.python.org/issue13081> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13078] Python Crashes When Saving Or Opening
Brian Curtin added the comment: You are attempting to open or save .py files from what? IDLE? What are the steps you would use to reproduce this issue? How was this error message obtained? -- ___ Python tracker <http://bugs.python.org/issue13078> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13096] ctypes: segfault with large POINTER type names
Brian Brazil added the comment:
The problem is around line 1734 of callproc.c in tip:
} else if (PyType_Check(cls)) {
typ = (PyTypeObject *)cls;
buf = alloca(strlen(typ->tp_name) + 3 + 1);
sprintf(buf, "LP_%s", typ->tp_name); <-- segfault is here
Replacing the alloca with a malloc fixes it, so I presume it's hitting the
stack size limit as 2^25 is 32MB (my stack limit is 8MB).
--
nosy: +bbrazil
___
Python tracker
<http://bugs.python.org/issue13096>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13050] RLock support the context manager protocol but this is not documented
New submission from Brian Brazil : This is already documented: http://docs.python.org/library/threading.html#using-locks-conditions-and-semaphores-in-the-with-statement -- nosy: +bbrazil ___ Python tracker <http://bugs.python.org/issue13050> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12923] test_urllib fails in refleak mode
Brian Brazil added the comment: This appears to fail every 9th, 19th, 29th, etc. repetition of the test. This seems to be something to do with the reference counting/close logic of the FakeSocket but I haven't managed to figure out what. -- nosy: +bbrazil ___ Python tracker <http://bugs.python.org/issue12923> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12923] test_urllib fails in refleak mode
Brian Brazil added the comment: The actual problem is that FancyURLOpener self.tries isn't being reset if the protocol is file:// I've attached a patch that'll help improve the test at least. -- keywords: +patch Added file: http://bugs.python.org/file23358/12923-unittest-improvement.patch ___ Python tracker <http://bugs.python.org/issue12923> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12923] test_urllib fails in refleak mode
Brian Brazil added the comment: Here's a path to fix the problem. -- Added file: http://bugs.python.org/file23359/12923-maxtries-reset.patch ___ Python tracker <http://bugs.python.org/issue12923> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6807] No such file or directory: 'msisupport.dll' in msi.py
Changes by Brian Curtin : -- components: +Windows nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue6807> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13169] Regular expressions with 0 to 65536 repetitions and above makes Python crash
Brian Curtin added the comment: I might be missing something, but what's the issue? 65535 is the limit, and doing 65536 gives a clear overflow exception (no crash). -- nosy: +brian.curtin type: crash -> behavior ___ Python tracker <http://bugs.python.org/issue13169> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13169] Regular expressions with 0 to 65536 repetitions raises OverflowError
Changes by Brian Curtin : -- title: Regular expressions with 0 to 65536 repetitions and above makes Python crash -> Regular expressions with 0 to 65536 repetitions raises OverflowError ___ Python tracker <http://bugs.python.org/issue13169> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13210] Support Visual Studio 2010
Brian Curtin added the comment:
We can make Python compile with Visual Studio 2010, but it will not be the
platform Python is released on, it would be optional while 2008 stays the
release target, at least through Python 3.3. In Python 3.4, we may re-evaluate
this, and it's likely we would jump over 2010 and move to Visual Studio 2012 at
that point (per discussions on python-dev).
As for your first point, Visual Studio 2008 is still available on the Microsoft
site, it's just not the first thing you usually find. If you look here -
http://msdn.microsoft.com/en-us/express/future/bb421473 - you can find it.
Anyway, I've done this port internally at my company, but I'm not able to
release that patch. I am, however, willing to do it personally so it could be
included here. If anyone else is interested in working on it, it should follow
the same format as other VS version support, going in the PC/VS{version} folder.
Also, reclassified this to the proper version, 3.3, since it's a feature
request.
--
assignee: tarek ->
components: -Distutils, Distutils2, Installation
versions: +Python 3.3 -Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue13210>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12527] assertRaisesRegex doc'd with 'msg' arg, but it's not implemented?
Brian Jones added the comment: I've just done a fresh hg pull and new build, and I can no longer reproduce the problem. Yay! -- ___ Python tracker <http://bugs.python.org/issue12527> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5788] datetime.timedelta is inconvenient to use...
Brian Quinlan added the comment: You'll probably get more traction if you file a new bug. -- ___ Python tracker <http://bugs.python.org/issue5788> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1559549] ImportError needs attributes for module and file name
Brian Curtin added the comment: Here's an updated patch, plus support for a second attribute that I need for #10854. I previously wrote a patch that does this same thing for that issue, but this one handles things a lot more nicely :) I renamed "module_name" to just be "name" since I was adding "path" and didn't want to have to name it "module_path" and have two "module_" attributes since I think it's clear what they are for. We can go back to "module_" names if you want - no big deal. It's really just the same patch as before but updated for a few minor changes (the ComplexExtendsException sig changed), and the moving of keyword handling in ImportError_init into a macro since we have to do the same initialization twice now. I'm not married to that implementation, it just minimized duplication and seems to work alright. Also, this removes the import.c change (see Brett's last message). -- nosy: +brian.curtin Added file: http://bugs.python.org/file23522/issue1559549.diff ___ Python tracker <http://bugs.python.org/issue1559549> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13281] robotparser.RobotFileParser ignores rules preceeded by a blank line
New submission from Brian Bernstein : When attempting to parse a robots.txt file which has a blank line between allow/disallow rules, all rules after the blank line are ignored. If a blank line occurs between the user-agent and its rules, all of the rules for that user-agent are ignored. I am not sure if having a blank line between rules is allowed in the spec, but I am seeing this behavior in a number of sites, for instance: http://www.whitehouse.gov/robots.txt has a blank line between the disallow rules all other lines, including the associated user-agent line, resulting in the python RobotFileParser to ignore all rules. http://www.last.fm/robots.txt appears to separate their rules with arbitrary blank lines between them. The python RobotFileParser only sees the first two rule between the user-agent and the next newline. If the parser is changed to simply ignore all blank lines, would it have any adverse affect on parsing robots.txt files? I am including a simple patch which ignores all blank lines and appears to find all rules from these robots.txt files. -- files: robotparser.py.patch keywords: patch messages: 146518 nosy: bernie9998 priority: normal severity: normal status: open title: robotparser.RobotFileParser ignores rules preceeded by a blank line type: behavior versions: Python 2.7 Added file: http://bugs.python.org/file23538/robotparser.py.patch ___ Python tracker <http://bugs.python.org/issue13281> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13327] Update utime API to not require explicit None argument
New submission from Brian Curtin : os.utime currently requires an explicit `None` as the second argument in order to update to the current time. Other APIs would just have the second argument as optional in this case, operating with one argument. Attached is a patch which changes the second argument to accept the time tuple, `None`, or literally nothing. Tested on Windows and Mac. If this is acceptable, I'll make the same change for futimes, lutimes, and futimens. -- assignee: brian.curtin components: Library (Lib) files: utime.diff keywords: needs review, patch messages: 146884 nosy: brian.curtin priority: normal severity: normal stage: patch review status: open title: Update utime API to not require explicit None argument type: feature request versions: Python 3.3 Added file: http://bugs.python.org/file23600/utime.diff ___ Python tracker <http://bugs.python.org/issue13327> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13327] Update utime API to not require explicit None argument
Brian Curtin added the comment: Ah, yes. Would the following work better for the last line? self.assertAlmostEqual(st1.st_mtime, st2.st_mtime, places=2) -- ___ Python tracker <http://bugs.python.org/issue13327> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13327] Update utime API to not require explicit None argument
Brian Curtin added the comment: The `delta` keyword would actually be better than `places`, especially on the slower buildbots. delta=10 would allow up to 10 seconds between those utime calls. Is that being too permissive? -- ___ Python tracker <http://bugs.python.org/issue13327> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13327] Update utime API to not require explicit None argument
Brian Curtin added the comment: Changeset 045e8757f10d was also entered for this, which should conclude the changes. Everything seems to have survived the buildbots for now, so closing as fixed. Feel free to reopen if there are any other issues. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue13327> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13368] Possible problem in documentation of module subprocess, method send_signal
Brian Curtin added the comment: > But it is useless for terminating a process with os.kill() in combination > with signal.SIGTERM, which corresponds to a CTRL-C-EVENT. SIGTERM does not correspond to CTRL_C_EVENT. They may be similar in what they do, but os.kill on Windows only works with exactly CTRL_C_EVENT and CTRL_BREAK_EVENT, as this uses GenerateConsoleCtrlEvent which only works with those two values. As the documentation states, anything other than those two constants is sent to TerminateProcess. If you call os.kill with signal.SIGTERM, it would kill the process with return code 15. I will look into adjusting the text a little, and I also need to look into the tests. I currently have CTRL_C_EVENT tests skipped, probably because I am passing the wrong process stuff as he mentioned. I had it working at some point, but I may have generalized it too far. -- assignee: docs@python -> brian.curtin components: +Windows stage: -> needs patch type: -> behavior versions: +Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issue13368> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13384] Unnecessary __future__ import in random module
Changes by Brian Curtin : -- assignee: -> brian.curtin nosy: +brian.curtin resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> behavior versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue13384> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10854] Output .pyd name in error message of ImportError when DLL load fails
Brian Curtin added the comment: Marked #1559549 as a dependency. I combine the patch in this issue with the one over there. -- dependencies: +ImportError needs attributes for module and file name ___ Python tracker <http://bugs.python.org/issue10854> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13384] Unnecessary __future__ import in random module
Brian Curtin added the comment: That's news to me since it probably pre-dates my involvement around here. I'll revert if that's correct. -- ___ Python tracker <http://bugs.python.org/issue13384> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10772] Several actions for argparse arguments missing from docs
Changes by Brian Curtin : -- status: pending -> open versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue10772> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10652] test___all_ + test_tcl fails (Windows installed binary)
Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue10652> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13412] No knowledge of symlinks on Windows
Brian Curtin added the comment: I think we could still make os.listdir work properly. I'll look into a patch for this. One "problem" here is the testability, since we'd need to rely on the mklink CLI app to create the symlinks, which requires that the calling application (python.exe) has elevated privileges. It wont be exercised by any of the buildbots. -- ___ Python tracker <http://bugs.python.org/issue13412> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13412] No knowledge of symlinks on Windows
Brian Curtin added the comment: symlinks when listing a dir and traverses them naturally when referencing them as part of a path to listdir. Under what conditions does it fail? > > -- > > ___ > Python tracker > <http://bugs.python.org/issue13412> > ___ Jason - I'm responding on a phone - I haven't confirmed anything yet (and hadn't yet seen your examples when I was typing). Alex - the Windows API also requires elevation - that's what we have to do in 3.2+ as well. The symlink calls require a specific privilege which is only granted when elevated, even for the mklink program. -- ___ Python tracker <http://bugs.python.org/issue13412> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13419] import does not recognise SYMLINKDs on Windows 7
Brian Curtin added the comment: Duplicate of #6727 -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> ImportError when package is symlinked on Windows ___ Python tracker <http://bugs.python.org/issue13419> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6727] ImportError when package is symlinked on Windows
Brian Curtin added the comment: Not fixed, but if it's easy, you're welcome to fix it before we get around to it. -- ___ Python tracker <http://bugs.python.org/issue6727> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6727] ImportError when package is symlinked on Windows
Brian Curtin added the comment: There are a few of us, and Jason and myself have done most of the Windows symlink related work. We'll certainly get to this and have it fixed, but with no releases on the immediate horizon, there isn't a rush. This and your other symlink issue are on my radar for things to make sure we cover. -- ___ Python tracker <http://bugs.python.org/issue6727> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10469] test_socket fails using Visual Studio 2010
Brian Curtin added the comment: FYI: this would likely be handled through #13210. I have a conversion sandbox started at http://hg.python.org/sandbox/vs2010port/ and am working through fixing test failures after the initial conversion. -- ___ Python tracker <http://bugs.python.org/issue10469> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13210] Support Visual Studio 2010
Brian Curtin added the comment: I mentioned this on another issue, but I created a clone at http://hg.python.org/sandbox/vs2010port/. I've already gone through the port in the past but wasn't able to release the code at the time. As I work through it, I'll occasionally announce large milestones here. -- ___ Python tracker <http://bugs.python.org/issue13210> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2286] Stack overflow exception caused by test_marshal on Windows x64
Changes by Brian Curtin : -- components: +Windows nosy: +brian.curtin status: closed -> open ___ Python tracker <http://bugs.python.org/issue2286> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10562] Change 'j' for imaginary unit into an 'i'
Changes by Brian Curtin : -- resolution: remind -> wont fix status: open -> closed ___ Python tracker <http://bugs.python.org/issue10562> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10562] Change 'j' for imaginary unit into an 'i'
Brian Curtin added the comment: Please stop re-opening this thread. The reasons it will not be fixed have been laid out. -- nosy: +brian.curtin -gvanrossum resolution: remind -> wont fix status: open -> closed ___ Python tracker <http://bugs.python.org/issue10562> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13457] Display module name as string in `ImportError`
Brian Curtin added the comment: 3.3 will be adding an attribute which would have "datetime\r" here. See #1559549, which might make this a duplicate. You shouldn't (have to) rely on parsing the exception string. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue13457> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue10854] Output .pyd name in error message of ImportError when DLL load fails
Changes by Brian Curtin : -- assignee: -> brian.curtin ___ Python tracker <http://bugs.python.org/issue10854> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13210] Support Visual Studio 2010
Brian Curtin added the comment: Just to be sure in case you didn't know, but patches against 2.7 for this issue won't be accepted. -- ___ Python tracker <http://bugs.python.org/issue13210> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13210] Support Visual Studio 2010
Brian Curtin added the comment: Before we both go down the same paths and duplicate effort, http://hg.python.org/sandbox/vs2010port/ has already completed the transition in terms of running the conversion, saving off the VS9 files, making some minimal code changes (errno module specifically), and has begun to fix tests. This is already done for 'default' aka 3.3. 8 tests failed: test_distutils test_email test_io test_os test_packaging test_pep3151 test_socket test_subprocess The distutils and packaging test failures seem to be about differences in command line flags for some of the VS2010 binaries (looks like a link.exe issue in one). Most of the others are about remaining errno differences, and the subprocess issue is with too many files being open. -- ___ Python tracker <http://bugs.python.org/issue13210> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11732] Skip decorator for tests requiring manual intervention on Windows
Brian Curtin added the comment: That would certainly be preferable when available on Windows 7. I'll look into how we can incorporate that. Thanks for the idea! -- ___ Python tracker <http://bugs.python.org/issue11732> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13210] Support Visual Studio 2010
Brian Curtin added the comment: If you want to clone from that repo, use the "vs2010" branch. hg clone http://hg.python.org/sandbox/vs2010port/ hg up vs2010 >From there, you can post patches here that I can integrate for you. -- assignee: -> brian.curtin ___ Python tracker <http://bugs.python.org/issue13210> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13483] Use VirtualAlloc to allocate memory arenas
Brian Curtin added the comment: > Tim, Brian, do you know anything about this? Unfortunately, no. It's on my todo list of things to understand but I don't see that happening in the near future. I'm willing to run tests or benchmarks for this issue, but that's likely the most I can provide. -- ___ Python tracker <http://bugs.python.org/issue13483> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13210] Support Visual Studio 2010
Brian Curtin added the comment: Again, rather than work off of the default branch and duplicate effort, can you work off of the vs2010 branch on http://hg.python.org/sandbox/vs2010port/? -- ___ Python tracker <http://bugs.python.org/issue13210> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13509] On uninstallation, distutils bdist_wininst fails to run post install script
Changes by Brian Curtin : -- components: +Windows nosy: +brian.curtin stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue13509> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13536] ast.literal_eval fails on sets
Brian Curtin added the comment: I don't profess to have any special ast knowledge, but given the context around there and the fact that it works...it looks fine to me. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue13536> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1559549] ImportError needs attributes for module and file name
Brian Curtin added the comment: If I add back in the import.c change, would this then be alright? Eric - fullname seems fine, I'll update that. -- ___ Python tracker <http://bugs.python.org/issue1559549> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1559549] ImportError needs attributes for module and file name
Brian Curtin added the comment: I think I'm going to stick with name unless anyone is super opposed. If we can eventually import something else (sausages?), then setting module_name with a sausage name will seem weird. I'll work up a more complete patch. The private helper is a good idea. -- ___ Python tracker <http://bugs.python.org/issue1559549> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13051] Infinite recursion in curses.textpad.Textbox
Brian Curtin added the comment: Would you be able to produce a unit test which fails before your patch is applied, but succeeds after applying your changes? That'll make your changes more likely to get accepted. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue13051> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13651] Improve redirection in urllib
Brian Curtin added the comment: Can you explain the patch and state why you would like that change included? This would require a test. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue13651> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13670] Increase test coverage for pstats.py
Changes by Brian Curtin : -- nosy: +brian.curtin stage: -> patch review ___ Python tracker <http://bugs.python.org/issue13670> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13702] relative symlinks in tarfile.extract broken (windows)
Changes by Brian Curtin : -- nosy: +brian.curtin stage: -> test needed ___ Python tracker <http://bugs.python.org/issue13702> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue13719] bdist_msi upload fails
Changes by Brian Curtin : -- components: +Windows nosy: +brian.curtin type: -> behavior ___ Python tracker <http://bugs.python.org/issue13719> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12084] os.stat() on windows doesn't consider relative symlink
Brian Curtin added the comment: Here's standalone patch which should cover this problem. The patch fails right now but succeeds if you apply it back to 652baf23c368 (the changeset before one of several changes around this code). I'll try to find the actual offending checkin and workout the differences to make a fix. -- keywords: +patch Added file: http://bugs.python.org/file22088/test.diff ___ Python tracker <http://bugs.python.org/issue12084> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12084] os.stat() on windows doesn't consider relative symlink
Brian Curtin added the comment: Ok, so it's 893b098929e7 where that test stops working. -- ___ Python tracker <http://bugs.python.org/issue12084> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6560] socket sendmsg(), recvmsg() methods
Brian May added the comment: Hello, Are there any problems applying the v5 version of the patch to 3.3? Also is there any remote chance for a backport to 2.7? Thanks -- ___ Python tracker <http://bugs.python.org/issue6560> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12084] os.stat() on windows doesn't consider relative symlink
Brian Curtin added the comment: Correction for msg136711 -- s/patch/test/g -- ___ Python tracker <http://bugs.python.org/issue12084> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12084] os.stat() on windows doesn't consider relative symlink
Brian Curtin added the comment: Ok, so it's actually 0a1baa619171 that broke it, not sure how I came up with the other revision. In any case, it's too hairy to try and piece everything together across the numerous bug fixes, feature adds, and refactorings in this area in order to get back to a working state (plus you'll want to jump out the window if you try, believe me). I'm going to have a go at basically rewriting the os.stat Windows path tonight and tomorrow and see what that does. -- ___ Python tracker <http://bugs.python.org/issue12084> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12084] os.stat() on windows doesn't consider relative symlink
Brian Curtin added the comment:
It turns out DeviceIoControl/FSCTL_GET_REPARSE_POINT (in win32_read_link) will
only work for us as long as the symlink was created with a full path. Starting
at the top level of a source checkout, if I create `os.symlink("README",
"README.lnk")` and then do `os.stat("..\\README.lnk")` from up a directory (or
any other directory), DeviceIoControl can only find out that the symlink was
created with "README", so the reparse tag it knows about is "README", which
doesn't really help us in figuring out where that file is actually located.
Everything is fine if I create the symlink with full paths.
I'm in the middle of refactoring this to work with GetFinalPathNameByHandle. I
had thought about a quick-and-dirty solution of modifying os.symlink to convert
all paths into fully qualified paths in order to give DeviceIoControl the info
it needs for os.stat...but that doesn't help for any previously created links,
or for any links created by Microsoft tools such as the "mklink" command line
tool (it doesn't set the reparse tag with a fully qualified path either).
--
___
Python tracker
<http://bugs.python.org/issue12084>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11416] netrc module does not handle multiple entries for a single host
Changes by Brian Curtin : -- keywords: +needs review stage: -> patch review ___ Python tracker <http://bugs.python.org/issue11416> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11864] sporadic failure in test_concurrent_futures
Changes by Brian Quinlan : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue11864> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue6560] socket sendmsg(), recvmsg() methods
Brian May added the comment: Have tested my code with this patch, the recvmsg(...) call seems to work fine. Also had a half-hearted attempt at porting to Python 2.7, but didn't get past compiling, the code requires BEGIN_SELECT_LOOP and END_SELECT_LOOP macros that aren't defined in Python 2.7 - I tried copying the definitions from Python 3.3, but that didn't work either. Not sure if it is worth the effort if Python 2.7 is closed to new features. Brian May -- ___ Python tracker <http://bugs.python.org/issue6560> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11271] concurrent.futures.ProcessPoolExecutor.map() slower than multiprocessing.Pool.map() for fast function argument
Brian Quinlan added the comment: On my crappy computer, ProcessPoolExecutor.map adds <3ms of added execution time per call using your test framework. What is your use case where that is too much? That being said, I don't have any objections to making improvements. If you want to pursue this, could you attach a working map_comprison.py? -- ___ Python tracker <http://bugs.python.org/issue11271> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12226] use secured channel for uploading packages to pypi
Brian Curtin added the comment: This should probably be discussed on catalog-SIG, not the CPython bug tracker. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue12226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12226] use secured channel for uploading packages to pypi
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue12226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12226] use secured channel for uploading packages to pypi
Brian Curtin added the comment: Oops, nevermind that, thought this was suggesting a change to PyPI itself, not distutils. -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue12226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12226] use secured channel for uploading packages to pypi
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue12226> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12084] os.stat() on windows doesn't consider relative symlink
Brian Curtin added the comment: I have this working when you stat the symlink from the directory it was created or above...but oddly it does not work when you open a symlink below the directory it exists in. DeviceIoControl isn't used for reparse tag handling anymore, and I'm using GetFinalPathNameByHandle similar to how it was used in previous versions of this code. There's still a case to handle and maybe some cleanup, but there's decent progress and hope that I can get it done very soon. -- ___ Python tracker <http://bugs.python.org/issue12084> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
