[issue30593] sqlite3 executescript does not respect isolation_level?
Changes by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue30593> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Pinging. As I mentioned in the PR I need a little help with __contains__. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26187] sqlite3 trace callback prints duplicate line
Changes by Aviv Palivoda : -- pull_requests: +384 ___ Python tracker <http://bugs.python.org/issue26187> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29903] struct.Struct Addition
New submission from Aviv Palivoda:
I would like to suggest that the struct.Struct class will support addition. For
example you will be able to do:
>>> s1 = Struct(">L")
>>> s2 = Struct(">B")
>>> s3 = s1 + s2
>>> s3.format
b">LB"
--
components: Extension Modules
messages: 290486
nosy: mark.dickinson, meador.inge, palaviv
priority: normal
severity: normal
status: open
title: struct.Struct Addition
type: enhancement
versions: Python 3.7
___
Python tracker
<http://bugs.python.org/issue29903>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29903] struct.Struct Addition
Changes by Aviv Palivoda : -- pull_requests: +723 ___ Python tracker <http://bugs.python.org/issue29903> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29903] struct.Struct Addition
Aviv Palivoda added the comment:
I have two use cases for this feature:
1.
struct a {
int a;
#ifdef VER2
unsigned int b;
#endif
}
Now I may do:
>>> ver1 = Struct("i")
>>> ver2 = ver1 + Struct("I")
2.
struct a {
int a;
union inner {
int b;
unsigned int c;
} u;
}
As you can see with this feature I may do:
>>> start = Struct("i")
>>> union_b = Struct("i")
>>> union_c = Struct("I")
>>> version_a = start + union_b
>>> version_b = start + union_c
If you have a big struct with many options in the union this save's copying the
initial format.
> As for the concrete implementation, it looks to me that Struct('2L') +
> Struct('25B') results to Struct('2L5B').
I will fix the case when there is no format provided.
--
___
Python tracker
<http://bugs.python.org/issue29903>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29725] sqlite3.Cursor doesn't properly document "arraysize"
Changes by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue29725> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29725] sqlite3.Cursor doesn't properly document "arraysize"
Aviv Palivoda added the comment:
Hi Cheryl, the arraysize value can be set by doing:
>>> cursor.array = 5
For example I can do the following
>>> import sqlite3
>>> s = sqlite3.connect(":memory:")
>>> s.execute("create table a(a,b)")
>>> s.execute("insert into a(a,b) values (1,2)")
>>> s.execute("insert into a(a,b) values (3,4)")
>>> c = s.cursor() # Array size is 1
>>> c.execute("select * from a")
>>> c.fetchmany()
[(1, 2)]
>>> c.fetchmany()
[(3, 4)]
>>> c.arraysize = 2 # Change array size
>>> c.fetchmany()
[(1, 2), (3, 4)]
As you can see the arraysize set the number of results the fetchmany will
return.
--
___
Python tracker
<http://bugs.python.org/issue29725>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24139] Use sqlite3 extended error codes
Changes by Aviv Palivoda : -- pull_requests: +1249 ___ Python tracker <http://bugs.python.org/issue24139> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16379] SQLite error code not exposed to python
Changes by Aviv Palivoda : -- pull_requests: +1248 ___ Python tracker <http://bugs.python.org/issue16379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29021] Custom functions in sqlite receive None on invalid UTF-8
Aviv Palivoda added the comment: In my patch I use sqlite3_create_function_v2 which was added in sqlite 3.7.3 (2010-10-08). There were a few problems after adding sqlite3_stmt_readonly in 284676cf2ac8 as can be seen in issue #29355. sqlite3_stmt_readonly was added in 3.7.4 (2010-12-07) so I guess using sqlite3_create_function_v2 will cause the same problems. Do you think I should find another way to fix this issue? I can follow all the user functions and free on my own but that will make the code more complex. On the other hand I can add this fix in ifdef and the behavior will be different when using sqlite in versions smaller then 3.7.3. -- ___ Python tracker <http://bugs.python.org/issue29021> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30126] CheckTraceCallbackContent of test_sqlite3 fails on OS X Tiger
Aviv Palivoda added the comment: > It's even more strange. The test started to fail since this build, Sun Apr 9 > 10:10:15 2017: This was merged on Apr 9 (commit 0e6cb2ea624570ed08c354f1ed1f595dab4192d6). >From a quick look in the internet some other people had a similar problem: http://stackoverflow.com/questions/28973887/how-to-fix-sqlite3-libversion-mismatch It seems there might be mismatch between sqlite3_libversion() and SQLITE_VERSION. I am not familiar with the buildbots but can you run a test that check that sqlite3_libversion() == SQLITE_VERSION? -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue30126> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30262] Don't expose sqlite3 Cache and Statement
New submission from Aviv Palivoda: Both the Cache and Statement objects are internally used and should not be exposed to the user from the sqlite3 module. They are not mentioned in the documentation as well. -- components: Extension Modules messages: 292936 nosy: berker.peksag, ghaering, palaviv priority: normal severity: normal status: open title: Don't expose sqlite3 Cache and Statement type: behavior versions: Python 3.7 ___ Python tracker <http://bugs.python.org/issue30262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30262] Don't expose sqlite3 Cache and Statement
Changes by Aviv Palivoda : -- pull_requests: +1538 ___ Python tracker <http://bugs.python.org/issue30262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30270] Remove sqlite3.Cache display method
New submission from Aviv Palivoda: The display method is there for debugging and should not be in the released code. -- components: Extension Modules messages: 293005 nosy: berker.peksag, ghaering, palaviv priority: normal severity: normal status: open title: Remove sqlite3.Cache display method type: enhancement versions: Python 3.7 ___ Python tracker <http://bugs.python.org/issue30270> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30270] Remove sqlite3.Cache display method
Changes by Aviv Palivoda : -- pull_requests: +1559 ___ Python tracker <http://bugs.python.org/issue30270> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30271] Make sqlite3 statement cache optional
New submission from Aviv Palivoda: Currently the minimum size of the statement cache is 10. I suggest that it will be any value above 1 or no cache at all if the size is set to 0. -- components: Extension Modules messages: 293006 nosy: berker.peksag, ghaering, palaviv priority: normal severity: normal status: open title: Make sqlite3 statement cache optional type: enhancement versions: Python 3.7 ___ Python tracker <http://bugs.python.org/issue30271> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30271] Make sqlite3 statement cache optional
Changes by Aviv Palivoda : -- pull_requests: +1560 ___ Python tracker <http://bugs.python.org/issue30271> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30270] Remove sqlite3.Cache display method
Aviv Palivoda added the comment: >From looking at the git blame this is there since 2006. Maybe this should be >dependent on issue #30262. Maybe at first there should be a deprecation >warning and then removing this later. I understand that this might break someone's code but this is an undocumented method of an undocumented class in the sqlite3 module. I don't think that there will be a lot of people that use the sqlite3.Cache object. -- ___ Python tracker <http://bugs.python.org/issue30270> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30262] Don't expose sqlite3 Cache and Statement
Aviv Palivoda added the comment: I have 3 argument for the motivation for this change: 1. Cleaner API - Both objects are internal implementation details. I think that we can look on exposing them as a bug. 2. Easier development - When you remove these objects from the API you can change them without any concern. I for one think that I can make the sqlite3 module faster by changing them from Python objects to simple C structs. 3. Documentation - Currently both objects are part of the API. Thus they should be documented but how would you document the Statement class? Do we really want to have a generic Cache class in the sqlite3 module? I have less experience with cpython then you. Do you think that maybe the Cache class should be moved to more appropriate place (maybe collections) and be used by others? > At a minimum there would need to be a deprecation period, Is there a place that document the deprecation process? I will update the patch. -- ___ Python tracker <http://bugs.python.org/issue30262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30262] Don't expose sqlite3 Cache and Statement
Aviv Palivoda added the comment: I am not sure how to raise the deprecation waning in this case. We use both the Cache and Statement objects as part of the sqlite3 module internal flow. How can I only warn the user when he creates this classes directly and not when the sqlite3 module uses them? -- ___ Python tracker <http://bugs.python.org/issue30262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30262] Don't expose sqlite3 Cache and Statement
Changes by Aviv Palivoda : -- pull_requests: +1668 ___ Python tracker <http://bugs.python.org/issue30262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30262] Don't expose sqlite3 Cache and Statement
Aviv Palivoda added the comment: I opened a separate PR for the deprecation of the Cache and Statement. > I would think you could replace those entries with calls to wrapper functions > that issue the deprecation and then call the real function. I made wrapper deprecation classes that issue the deprecation. I am not sure if there is a easier way... -- ___ Python tracker <http://bugs.python.org/issue30262> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30271] Make sqlite3 statement cache optional
Aviv Palivoda added the comment: I think we can close this issue and open a different one that will disable the cache implicitly on `set_authorizer()`. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue30271> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27645] Supporting native backup facility of SQLite
Change by Aviv Palivoda : -- pull_requests: +5892 ___ Python tracker <https://bugs.python.org/issue27645> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27645] Supporting native backup facility of SQLite
Aviv Palivoda added the comment: The problem is that change https://www.sqlite.org/src/info/169b5505498c0a7e was part of sqlite version 3.8.8 I opened a PR with a fix. -- ___ Python tracker <https://bugs.python.org/issue27645> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: As I wrote in the PR: I think that the contains operation should not be supported for blobs. As blobs can be very large, looking for a subset of bytes inside them will be a very inefficient process in memory or in compute. I believe that this is a very good feature for the sqlite module. I know that there is no active core developer that is currently working on sqlite module but this patch is already waiting 2 years. Could I do anything to help this patch merged? -- ___ Python tracker <https://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue33376] [pysqlite] Duplicate rows can be returned after rolling back a transaction
Change by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <https://bugs.python.org/issue33376> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue30271] Make sqlite3 statement cache optional
Aviv Palivoda added the comment: I don't have any specific use case for making the statement cache optional. I expected that by changing the cache size to 0 there will be no statement cache. I think that this is a common assumption as can be seen in https://github.com/ghaering/pysqlite/issues/126#issue-346189937. rogerbinns did give a use case where we would like to disable the statement cache in https://github.com/ghaering/pysqlite/issues/126#issuecomment-410030910. I think that statement cache should be disable implicitly in that case as you suggest. The code change will be very similar and I do believe we should allow the user to disable the cache. I will be happy to open a new PR once this is merged that will disable the statement cache implicitly when calling `set_authorizer()` -- ___ Python tracker <https://bugs.python.org/issue30271> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: I searched in the sqlite tickets from something related to this issue and I couldn't find anything. I wanted to check the sqlite-users mailing list to see if anyone had already reported it but there is a problem in gmane archives. I tried to find a good way to solve this problem but I couldn't. I am adding a patch that should solve this problem but it is for sure not a good way :(. -- keywords: +patch Added file: http://bugs.python.org/file45639/28518.patch ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: There are already a few test's that start a transaction explicitly: In dbapi.SqliteOnConflictTests CheckOnConflictRollbackWithExplicitTransaction, CheckOnConflictAbortRaisesWithExplicitTransactions which set ``isolation_level = None``. On the other hand in transaction.TransactionalDDL.CheckTransactionalDDL the test do not set the isolation_level to None but start a transaction explicitly. The test pass because sqlite3_stmt_readonly return true for "begin" and "begin deferred". I think that if we say that in order to start a transaction implicitly the isolation_level needs to be None CheckTransactionalDDL should be changed. -- ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue8145] Documentation about sqlite3 isolation_level
Changes by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue8145> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'
Aviv Palivoda added the comment: Pinging as mentioned in the devguide. -- ___ Python tracker <http://bugs.python.org/issue14156> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'
Aviv Palivoda added the comment: Hi paul thanks for looking into this. First are you sure this is a bug in python 2? If so I will happily port this patch once it is reviewed. As for use cases you may look at issue #26488. Although the patch was rejected you can see that I first used argparse.FileType and moved it because of this issue. I can't prove this patch is free of backward's compatibility issue's but there are tests now which should help to avoid problem. -- ___ Python tracker <http://bugs.python.org/issue14156> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'
Aviv Palivoda added the comment: As we talk here about stdin and stdout which we don't want to close I think this issue is irrelevant to python2. In any case the patch in issue #13824 cover that problem. I actually write a lot of small scripts and if I need to open the file in binary mode I don't use FileType because of this issue. Any way I think this discussion is irrelevant because it does not seem like any core developer is currently working on argparse. -- ___ Python tracker <http://bugs.python.org/issue14156> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: I think that adding Serhiy patch in addition to the documentation improvement in issue #8145 would be the best way to proceed. This will insure no regression problems. We can add a warning when someone try to use BEGIN, ROLLBACK, SAVEPOINT, and RELEASE without changing the isolation_level to None. -- ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: Issue #29003 seems to be related to this one. I think that they can be solved the same way as done in Serhiy patch but I would like to suggest a different approach. I suggest changing the check for DDL statement with a check for DML statement. We actually should start a transaction only for DML statements (https://docs.python.org/3/library/sqlite3.html#controlling-transactions) so all other statements (DDL, DCL and TCL) should not start a transaction. The attached patch solve both this issue and issue #29003. -- Added file: http://bugs.python.org/file46079/sqlite-ddl-dml.patch ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29121] sqlite3 Controlling Transactions documentation not updated
New submission from Aviv Palivoda: commit 284676cf2ac8 changed the sqlite3 module so it will no longer implicitly commit an open transaction before DDL statements. The docs have been updated but there is still an incorrect paragraph that has not been removed. Attached is a patch that remove the old paragraph. -- files: sqlite-transaction-doc.patch keywords: patch messages: 284396 nosy: berker.peksag, ghaering, palaviv, serhiy.storchaka priority: normal severity: normal status: open title: sqlite3 Controlling Transactions documentation not updated versions: Python 3.6, Python 3.7 Added file: http://bugs.python.org/file46101/sqlite-transaction-doc.patch ___ Python tracker <http://bugs.python.org/issue29121> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: Adding the vacuum test can't actually happen because the change in commit 284676cf2ac8 changed the API and we don't commit before non DML statements. I opened a issue that will clarify the docs (#29121). -- ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: Yes. If a transaction is open you will need to explicitly commit before doing vacuum. I am not sure if that was intentional or not. From quick look in the sqlite source code there are few things that cannot happen from a transaction: 1. VACUUM 2. ATTACH 3. DETACH 4. BEGIN 5. Few PRAGMAs (temp_store, synchronous) All of the above worked with implicit commit before commit 284676cf2ac8 but now has to call commit explicitly. -- ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29021] Custom functions in sqlite receive None on invalid UTF-8
Aviv Palivoda added the comment:
The problem is in _pysqlite_build_py_params function at connection.c. In case
we have text we do the following code:
case SQLITE_TEXT:
val_str = (const char*)sqlite3_value_text(cur_value);
cur_py_value = PyUnicode_FromString(val_str);
/* TODO: have a way to show errors here */
if (!cur_py_value) {
PyErr_Clear();
Py_INCREF(Py_None);
cur_py_value = Py_None;
}
break;
As you can see we call PyUnicode_FromString instead of text_factory.
I started making a patch to fix this by passing the text_factory to
_pysqlite_build_py_params function but I currently have a problem with setting
the result to the sqlite. User text_factory may return any type of object and I
can't see how to handle that...
--
nosy: +palaviv
___
Python tracker
<http://bugs.python.org/issue29021>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29021] Custom functions in sqlite receive None on invalid UTF-8
Aviv Palivoda added the comment: I actually was wrong and there is no problem with the type that is returned from the text_factory as it passes directly as argument for the create_function function. Attached is a patch that change create_function and create_aggregate to use the text_factory when a TEXT data type is received. I am now using sqlite3_create_function_v2 but this is fine because we use sqlite3_stmt_readonly and it is from a newer version. As for Ingo example code it still don't work with this current fix but this is due to a different problem. Now the _pysqlite_set_result function fail when we do PyUnicode_AsUTF8 on the result from py_identity. As this is a different problem I will fix this in a different patch. -- keywords: +patch Added file: http://bugs.python.org/file46164/29021.patch ___ Python tracker <http://bugs.python.org/issue29021> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29021] Custom functions in sqlite receive None on invalid UTF-8
Aviv Palivoda added the comment: Actually had a small mistake in the patch I uploaded. Uploading a fixed one. -- Added file: http://bugs.python.org/file46166/29021-fixed.patch ___ Python tracker <http://bugs.python.org/issue29021> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29006] 2.7.13 _sqlite more prone to "database table is locked"
Changes by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue29006> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29021] Custom functions in sqlite receive None on invalid UTF-8
Aviv Palivoda added the comment: After looking more into the _pysqlite_set_result function fail in Ingo example I think this is the expected behavior. The PyUnicode_AsUTF8 fails but this is expected as the value is an invalid UTF-8. -- ___ Python tracker <http://bugs.python.org/issue29021> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: Uploading a new patch with fixes from Ma Lin comments. Two points: 1. Should we add the VACUUM with a explicit commit? Maybe there should be an implicit commit before VACUUM? 2. Should a SELECT start a transaction? I think it should according to PEP 249. There is a open issue on the case (#9924). Should we just change this on this patch? -- Added file: http://bugs.python.org/file46354/sqlite-ddl-dml-2.patch ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9924] sqlite3 SELECT does not BEGIN a transaction, but should according to spec
Changes by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue9924> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue28518] execute("begin immediate") throwing OperationalError
Aviv Palivoda added the comment: Removed opening a transaction on select. I will argue for that in issue 9924 after this is resolved. -- Added file: http://bugs.python.org/file46397/sqlite-ddl-dml-3.patch ___ Python tracker <http://bugs.python.org/issue28518> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29228] sqlite3 OperationalError on changing into WAL transaction mode
Aviv Palivoda added the comment: There is also a issue with the docs here. Look at issue 29121. -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue29228> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29121] sqlite3 Controlling Transactions documentation not updated
Aviv Palivoda added the comment: I would just like to note that I think that the correct solution is to do an implicit commit before: 1. VACUUM 2. ATTACH 3. DETACH 4. BEGIN -- ___ Python tracker <http://bugs.python.org/issue29121> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Pinging again. I think this would be a great enhancement to the sqlite module. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Thanks for the CR Serhiy. Attached is a new patch after the fixes from the CR. What other developers should I ask? The interface is file like and is the same as apsw. -- Added file: http://bugs.python.org/file46531/blob3.patch ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Uploading patch after fixes from berker CR. The `blob_open` API can can have the following options: 1. The table, column and row must be mandatory parameters. 2. The read/write permissions can have the following options: a. No default (mandatory parameter). b. default read-only c. default write-only 3. The dbname can be without a default of "main" and then it will be a mandatory parameter. I don't think that there is enough differences between the possible API's to justify sending a message to the mailing lists. -- Added file: http://bugs.python.org/file46549/blob4.patch ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Changes by Aviv Palivoda : -- pull_requests: +244 ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: I opened a PR in github. I tagged some other developers if that will not start a discussion on the API I will post in the python-ideas. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: I am not a DB expert but from a quick search I couldn't find a similar API. I did find a few API's in other programming languages to sqlite blob: 1. https://jgallagher.github.io/rusqlite/rusqlite/blob/index.html 2. https://godoc.org/github.com/mxk/go-sqlite/sqlite3 3. http://www.ch-werner.de/javasqlite/SQLite/Blob.html It seems like most of them give the same API as apsw. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue27645] Supporting native backup facility of SQLite
Aviv Palivoda added the comment: I actually looked at the patch and have a few comments: 1. You need to put Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS before the sqlite3 calls (especially the sleep). 2. I think that the `pysqlite_connection_backup` function will look a lot better if you will have a cleanup/error label. I am not a core developer but I think you should open the PR as it will be easier for the CR. -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue27645> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9303] Migrate sqlite3 module to _v2 API to enhance performance
Changes by Aviv Palivoda : -- pull_requests: +306 ___ Python tracker <http://bugs.python.org/issue9303> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Just to make sure when you say "sequence protocol" you thin about the doing blob[4:6] = "ab"? I actually think this is a nice feature. The Blob and the mmap object has a lot in common so I think that making the same API will be best. I think that adding the sequence protocol in addition to the file protocol is best. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9303] Migrate sqlite3 module to _v2 API to enhance performance
Aviv Palivoda added the comment: I opened a PR. This actually is a bugfix in addition to an enhancement as it solves issue 26187 as well. -- ___ Python tracker <http://bugs.python.org/issue9303> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9303] Migrate sqlite3 module to _v2 API to enhance performance
Aviv Palivoda added the comment: from https://www.sqlite.org/changes.html: sqlite3_open_v2 - 2007-09-04 (3.5.0) alpha sqlite3_prepare_v2 - 2007-01-04 (3.3.9) sqlite3_close_v2 - 2012-09-03 (3.7.14) In issue 29355 Ma Lin says that RHEL6 comes with SQLite 3.6.x. I think that removing that removing the check for sqlite3_prepare_v2 and sqlite3_open_v2 is fine but sqlite3_close_v2 need to stay. > Don't forget about Windows where autotools are not used. What should I do for this to work on windows? -- ___ Python tracker <http://bugs.python.org/issue9303> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9303] Migrate sqlite3 module to _v2 API to enhance performance
Aviv Palivoda added the comment: I changed the patch to use SQLITE_VERSION_NUMBER and it looks way better. Thanks Serhiy -- ___ Python tracker <http://bugs.python.org/issue9303> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Pinging as mentioned in the devguide. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: Thanks for the review Serhiy. Attached is the updated patch after the changes. -- Added file: http://bugs.python.org/file44142/blob2.patch ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26488] hashlib command line interface
Aviv Palivoda added the comment: Hi, is there anything more I need to do on this patch? If not do you think this can be added in 3.6? -- ___ Python tracker <http://bugs.python.org/issue26488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26488] hashlib command line interface
Aviv Palivoda added the comment: The use case that made me think about this feature was when I was working on a Windows PC and needed to calculate an md5 of a file. I agree that in a unix environment there are existing tools but on windows you usually don't have them. -- ___ Python tracker <http://bugs.python.org/issue26488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16379] SQLite error code not exposed to python
Aviv Palivoda added the comment: Attached is a patch based on Daniel last patch with the following changes: * There is no errorcode mapping. * The exception object has a error_name attribute. I think this two changes should solve the API problems raised by Ezio and Gerhard about the error code mapping. > I propose to also set the SQLite extended error code if this is implemented. I think that this should be done in a separate patch. I will start working on the extended error code and will upload a patch to issue 24139. -- nosy: +palaviv Added file: https://bugs.python.org/file44213/16379.patch ___ Python tracker <https://bugs.python.org/issue16379> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24139] Use sqlite3 extended error codes
Aviv Palivoda added the comment: Attached is a patch to enable the extended error codes. This patch should be dependent on issue 16379. Without returning the sqlite error code in the exception the extended error code does not reveal any information not currently available. As you can see in https://github.com/mackyle/sqlite/blob/ebb27fe5bd5045d924d99cdd7dec9b7064c24768/src/main.c#L1318 there are messages only for the non-extended error codes and that is what is exposed now. -- keywords: +patch nosy: +palaviv Added file: http://bugs.python.org/file44280/24139.patch ___ Python tracker <http://bugs.python.org/issue24139> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26061] logging LogRecordFactory allow kwargs
New submission from Aviv Palivoda: The logging LogRecord factory receives kwargs. However because _log and makeRecord functions in the Logger class don't support kwargs we can't actually pass additional positional arguments to LogRecord. A use case for this is attached. I had made a patch to fix this by changing _log and makeRecord to accept kwargs and pass them. -- components: Library (Lib) files: usecase.py messages: 257831 nosy: palaviv, vinay.sajip priority: normal severity: normal status: open title: logging LogRecordFactory allow kwargs type: behavior versions: Python 3.6 Added file: http://bugs.python.org/file41553/usecase.py ___ Python tracker <http://bugs.python.org/issue26061> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26061] logging LogRecordFactory allow kwargs
Aviv Palivoda added the comment: adding the patch :) -- keywords: +patch Added file: http://bugs.python.org/file41554/LogRecordFactoryKwargs.patch ___ Python tracker <http://bugs.python.org/issue26061> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26187] sqlite3 trace callback prints duplicate line
New submission from Aviv Palivoda:
I am running the following script:
--
>>> import sqlite3
>>> import os
>>> import time
>>> con1 = sqlite3.connect("/tmp/test.db")
>>> con2 = sqlite3.connect("/tmp/test.db")
>>> con1.set_trace_callback(print)
>>> cur = con1.cursor()
>>> cur.execute("create table test(a)")
create table test(a)
>>> con2.execute("create table test2(a)")
>>> cur.execute("insert into test(a) values(1)")
BEGIN
insert into test(a) values(1)
insert into test(a) values(1)
>>> for a in con1.execute("select * from test"):
... print("result:", a)
...
select * from test
result: (1,)
---
As you can see i get duplicate traceback print of the "insert into test(a)
values(1)" line. The duplicate print has no effect on the actual db.
I have tested this both on python 3.4.3 and 3.6.0a0 on ubuntu14.04
--
components: Extension Modules
messages: 258874
nosy: ghaering, palaviv
priority: normal
severity: normal
status: open
title: sqlite3 trace callback prints duplicate line
type: behavior
versions: Python 3.4, Python 3.6
___
Python tracker
<http://bugs.python.org/issue26187>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Changes by Aviv Palivoda : -- nosy: +palaviv ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26243] zlib.compress level as keyword argument
New submission from Aviv Palivoda: Currently zlib.compress allow only positional arguments. For code readability reasons i think that we should allow the level argument to be keyword argument. Now when someone uses zlib.compress he will be able to do zlib.compess(some_data, level=7) instead of zlib.compress(some_data, 7). There is a patch included with the change. -- components: Extension Modules files: zlib-compress-level-keyword.patch keywords: patch messages: 259266 nosy: nadeem.vawda, palaviv, twouters priority: normal severity: normal status: open title: zlib.compress level as keyword argument type: behavior versions: Python 3.6 Added file: http://bugs.python.org/file41760/zlib-compress-level-keyword.patch ___ Python tracker <http://bugs.python.org/issue26243> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26244] zlib.compressobj level default value documentation
New submission from Aviv Palivoda: In the zlib.compressobj documentation the default value of the compress level is -1 while it is actually 6. patch is included -- assignee: docs@python components: Documentation, Extension Modules files: zlib-compressobj-level-doc.patch keywords: patch messages: 259267 nosy: docs@python, nadeem.vawda, palaviv, twouters priority: normal severity: normal status: open title: zlib.compressobj level default value documentation versions: Python 3.6 Added file: http://bugs.python.org/file41761/zlib-compressobj-level-doc.patch ___ Python tracker <http://bugs.python.org/issue26244> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: I opened a pull request for blob support in the pysqlite github repository: https://github.com/ghaering/pysqlite/pull/93 I will do the needed changes for python3 and will post a patch soon. -- ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26244] zlib.compressobj level default value documentation
Aviv Palivoda added the comment: I think that we can leave the level=-1 as the default in the documentation. What should be added is what Z_DEFAULT_COMPRESSION means. I tried to be as close as possible to the zlib module documentation. -- Added file: http://bugs.python.org/file41766/zlib-compressobj-level-doc2.patch ___ Python tracker <http://bugs.python.org/issue26244> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26243] zlib.compress level as keyword argument
Aviv Palivoda added the comment: Thanks for the review. 1. Changed "bytes" to "data". 2. Updated Doc as in issue 26244 (will update the patch if there will be changes there). 3. Added version changed notice but i don't think there is a need for What's new update. -- Added file: http://bugs.python.org/file41773/zlib-compress-level-keyword2.patch ___ Python tracker <http://bugs.python.org/issue26243> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26243] zlib.compress level as keyword argument
Aviv Palivoda added the comment: Added the "suggested" test -- Added file: http://bugs.python.org/file41797/zlib-compress-level-keyword3.patch ___ Python tracker <http://bugs.python.org/issue26243> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24905] Allow incremental I/O to blobs in sqlite3
Aviv Palivoda added the comment: I did the needed changes for the pull request at pysqlite for porting to python3. I will continue updating the patch if there will be changes in pysqlite and vice versa. -- keywords: +patch Added file: http://bugs.python.org/file41798/blob.patch ___ Python tracker <http://bugs.python.org/issue24905> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26250] no document for sqlite3.Cursor.connection
Aviv Palivoda added the comment: Added patch with my suggestion for sqlite3.Cursor.connection attribute documentation -- assignee: -> docs@python components: +Documentation, Extension Modules -Library (Lib) keywords: +patch nosy: +docs@python, ghaering, palaviv versions: +Python 3.5, Python 3.6 Added file: http://bugs.python.org/file41838/sqlite3-cursor-connection-doc.patch ___ Python tracker <http://bugs.python.org/issue26250> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26309] socketserver.BaseServer._handle_request_noblock() don't shutdwon request if verify_request is False
New submission from Aviv Palivoda: When socketserver.BaseServer.verify_request() return False then we do not call shutdown_request. If we will take the TCPServer as example we will call get_request thus calling socket.accept() and creating a new socket but we will not call shutdown_request to close the unused socket. -- components: Library (Lib) files: socketserver-shutdown-if-verify-false.patch keywords: patch messages: 259861 nosy: palaviv priority: normal severity: normal status: open title: socketserver.BaseServer._handle_request_noblock() don't shutdwon request if verify_request is False type: resource usage versions: Python 2.7, Python 3.5, Python 3.6 Added file: http://bugs.python.org/file41855/socketserver-shutdown-if-verify-false.patch ___ Python tracker <http://bugs.python.org/issue26309> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26309] socketserver.BaseServer._handle_request_noblock() don't shutdwon request if verify_request is False
Aviv Palivoda added the comment: Had a small mistake in the previous patch (did not notice process_request) call shutdown_request. fixed the patch -- Added file: http://bugs.python.org/file41856/socketserver-shutdown-if-verify-false2.patch ___ Python tracker <http://bugs.python.org/issue26309> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26309] socketserver.BaseServer._handle_request_noblock() don't shutdwon request if verify_request is False
Aviv Palivoda added the comment: I added a test to check the specific bug. There seems to be no testing at all on the verify_request feature so I will create some in different issue in the future. -- Added file: http://bugs.python.org/file41874/socketserver-shutdown-if-verify-false3.patch ___ Python tracker <http://bugs.python.org/issue26309> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26309] socketserver.BaseServer._handle_request_noblock() don't shutdwon request if verify_request is False
Aviv Palivoda added the comment: I changed the test to just check that shutdown_request is called. Hope this is more clear then the previous test. -- Added file: http://bugs.python.org/file41930/socketserver-shutdown-if-verify-false4.patch ___ Python tracker <http://bugs.python.org/issue26309> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26392] socketserver.BaseServer.close_server should stop serve_forever
New submission from Aviv Palivoda: Currently if you call server_close you only close the socket. If we called serve_forever and then call server_close without calling shutdown the serve_forever loop keep running. Before using the selectors module for doing the poll we would have had exception thrown from the select (The socket fd is -1) in serve_forever. IMO you should be able to call server_close at any time and expect it to stop the serve_forever. Maybe even adding a block option to server_close that will wait on the server_forever if it's running (waiting for issue 12463 to resolve before doing this). Added a patch that closes serve_forever if server_close is called. -- components: Library (Lib) files: socketserver_close_stop_serve_forever.patch keywords: patch messages: 260524 nosy: palaviv priority: normal severity: normal status: open title: socketserver.BaseServer.close_server should stop serve_forever versions: Python 3.5, Python 3.6 Added file: http://bugs.python.org/file41971/socketserver_close_stop_serve_forever.patch ___ Python tracker <http://bugs.python.org/issue26392> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26393] random.shuffled
New submission from Aviv Palivoda: I am suggesting adding random.shuffled to the random module. This is very similar to the shuffle function just return a new shuffled list instead of in place shuffle. This is very similar to the sorted and list.sort. As you can see in the patch the shuffled function just return random.sample(x, len(x)) as this is what i usually do when i want to get back a shuffled list. -- components: Library (Lib) files: random-shuffled.patch keywords: patch messages: 260529 nosy: mark.dickinson, palaviv, rhettinger priority: normal severity: normal status: open title: random.shuffled type: enhancement versions: Python 3.6 Added file: http://bugs.python.org/file41976/random-shuffled.patch ___ Python tracker <http://bugs.python.org/issue26393> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26392] socketserver.BaseServer.close_server should stop serve_forever
Aviv Palivoda added the comment: I see your point about the server_close purpose and I changed the patch to simulate the behavior of closed file (raising ValueError when operating on closed file). I don't think that this should be an enhancement as what i try to do is return the behavior as it was before the change to the selectors module. When closing the socket using server_close at the next serve_forever loop you would have gotten ValueError for bad file descriptor to select. In the current implementation we actually keep on pulling on a already free resource. I know that the user should call shutdown before the server_close but i think that as you said the behavior should simulate closed file. When someone will try to use any other function of a closed file he will receive a ValueError. -- Added file: http://bugs.python.org/file41978/socketserver_close_stop_serve_forever2.patch ___ Python tracker <http://bugs.python.org/issue26392> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26404] socketserver context manager
New submission from Aviv Palivoda: As Martin commented on my patch at issue 26392 the socketserver.server_close is like the file close. That made me think that we should add a context manager to the socketserver. -- components: Library (Lib) files: socketserver_context_manager.patch keywords: patch messages: 260639 nosy: martin.panter, palaviv priority: normal severity: normal status: open title: socketserver context manager type: enhancement versions: Python 3.6 Added file: http://bugs.python.org/file41993/socketserver_context_manager.patch ___ Python tracker <http://bugs.python.org/issue26404> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26404] socketserver context manager
Aviv Palivoda added the comment:
Only closing the server :).
1. Did the changes requested in the CR.
2. Changed the example's in xmlrpc.server, http.server to use context manager.
3. Changed the xmlrpc.server, http.server server implementation when running
python -m {xmlrpc.server, http.server} to use context manager.
--
Added file: http://bugs.python.org/file42008/socketserver_context_manager2.patch
___
Python tracker
<http://bugs.python.org/issue26404>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26392] socketserver.BaseServer.close_server should stop serve_forever
Aviv Palivoda added the comment: I understand the problem and why this patch should be rejected. -- resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.python.org/issue26392> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26404] socketserver context manager
Aviv Palivoda added the comment: Updated the patch: 1. Did the changes requested in the CR. 2. Changed the example's in wsgiref.simple_server to use context manager. 3. Added What's New entry. -- Added file: http://bugs.python.org/file42016/socketserver_context_manager3.patch ___ Python tracker <http://bugs.python.org/issue26404> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26404] socketserver context manager
Aviv Palivoda added the comment: updated the patch according to the CR comments. -- Added file: http://bugs.python.org/file42030/socketserver_context_manager4.patch ___ Python tracker <http://bugs.python.org/issue26404> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26404] socketserver context manager
Aviv Palivoda added the comment: The examples did not close the server but I am not sure if that was a mistake. The server is not being closed only on examples where it is expected to run until there is a keyboard interrupt. However you can see that when you send keyboard interrupt to a server you start using python -m http.server you will do close the server. -- ___ Python tracker <http://bugs.python.org/issue26404> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14156] argparse.FileType for '-' doesn't work for a mode of 'rb'
Aviv Palivoda added the comment:
I fixed the tests to work with Steven patch. Also changed the patch to open
sys.std{in,out} with closefd=False.
I changed the 'io.StringIO' that we redirect the stdout, stderr to. Now the
'StdIOBuffer' return the real stdout,stderr when '-' is passed to FileType.
This was already done in the 'stderr_to_parser_error' function previously after
the call to 'parse_args'.
--
nosy: +palaviv
Added file: http://bugs.python.org/file42072/14156-2.patch
___
Python tracker
<http://bugs.python.org/issue14156>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26488] hashlib command line interface
New submission from Aviv Palivoda: I am suggesting to add a command line interface to the hashlib module. A simple example of the api I suggest is: $ python -m hashlib md5 /bin/sh $ d985d0ea551c1253c2305140c583d11f A patch is included. -- components: Library (Lib) files: hashlib-script-mod.patch keywords: patch messages: 261225 nosy: christian.heimes, gregory.p.smith, palaviv priority: normal severity: normal status: open title: hashlib command line interface type: enhancement versions: Python 3.6 Added file: http://bugs.python.org/file42074/hashlib-script-mod.patch ___ Python tracker <http://bugs.python.org/issue26488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()
Aviv Palivoda added the comment: Changed SSLSocket.sendall() to return None. Also added a check of the return value of the SSLSocket.send(), SSLSocket.sendall() in the tests. -- keywords: +patch nosy: +palaviv Added file: http://bugs.python.org/file42278/25951.patch ___ Python tracker <http://bugs.python.org/issue25951> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()
Aviv Palivoda added the comment: Thanks for the review. I don't have any use cases for this change. I just saw this issue while looking for something else and thought I will give it a try. -- Added file: http://bugs.python.org/file42285/25951-2.patch ___ Python tracker <http://bugs.python.org/issue25951> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26488] hashlib command line interface
Aviv Palivoda added the comment: I actually have noticed issue 13824 while working on this issue. The patch I uploaded to Issue 14156 actually fixes the problem in issue 13824 in addition to the problem with the stdin/stdout. I think we should add a dependency in issue 14156 for this issue. -- ___ Python tracker <http://bugs.python.org/issue26488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26488] hashlib command line interface
Aviv Palivoda added the comment: Sorry on the late response for some reason i don't receive email notification from the tracker for the past few days. 1) Thanks for the review SilentGhost the patch attached include your CR suggestions. 2) Raymond I have fixed the problem with ctrl+D. I tried writing a test to simulate this problem but i don't seem to be able to simulated the terminal behavior on ctrl+D. 3) Removed the block_size option as suggested by Raymond and Victor and using os.stat().st_blksize as suggested by Victor. 4) I changed the CLI to support all available algorithms in hashlib. I am not sure if this is too many choices to show in the --help message. 5) About removing the use of argparse.FileType i would prefer resolving issue 14156 but if you think this is problematic i will do the change. 6) What do you think about changing the API to be more like md5sum? a) Allowing * in the file name to calcualte on multiple files. b) Adding the check option. c) printing file name in output. -- Added file: http://bugs.python.org/file42329/hashlib-script-mod-2.patch ___ Python tracker <http://bugs.python.org/issue26488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue26488] hashlib command line interface
Aviv Palivoda added the comment: I am adding a new patch with a API compatible to GNU md5sum: $ python -m hashlib md5 /bin/sh $ d985d0ea551c1253c2305140c583d11f /bin/sh I will soon add the feature's requested by Victor: 1) The check option. 2) Running the hash calculation for different files in different threads. If anyone would like any other feature he thinks will be helpful please post it. If we choose to use this API we should remove the dependency on issue 14156. -- Added file: http://bugs.python.org/file42333/hashlib-script-mod-md5sum-style.patch ___ Python tracker <http://bugs.python.org/issue26488> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
