[issue29649] struct.pack_into check boundary error message didn't respect offset
Andrew Nester added the comment: Thanks! Just added PR fixing this. -- nosy: +andrewnester ___ Python tracker <http://bugs.python.org/issue29649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29649] struct.pack_into check boundary error message didn't respect offset
Changes by Andrew Nester : -- pull_requests: +354 ___ Python tracker <http://bugs.python.org/issue29649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29649] struct.pack_into check boundary error message didn't respect offset
Andrew Nester added the comment: yeah, I also thought about this too. Something like 'pack_into requires a buffer of at least 6 bytes (size is 1, offset is 5)' -- ___ Python tracker <http://bugs.python.org/issue29649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29649] struct.pack_into check boundary error message didn't respect offset
Andrew Nester added the comment: thanks Serhiy! just implemented your variant in my PR. -- ___ Python tracker <http://bugs.python.org/issue29649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29657] os.symlink: FileExistsError shows wrong message
Andrew Nester added the comment: I've been investigating this issue and did not come up with some easy solution. So the problem is: os_symlink uses `path_error2` to throw exception. the order of file arguments now is src then dest. For provided example src is `a` and dest is `sym_link`. As a result `src` -> `dest` is generated here https://github.com/python/cpython/blob/master/Objects/exceptions.c#L1059 If we change order of arguments passed to `path_error2`, error message will be generated properly but OSError.filename will be incorrect (a_link instead of a) and following test will fail for `link`/`symlink` https://github.com/python/cpython/blob/master/Lib/test/test_os.py#L2901 Not sure if it's OK or not, so it definitely needs some input from Python core developers. -- nosy: +andrewnester ___ Python tracker <http://bugs.python.org/issue29657> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29649] struct.pack_into check boundary error message ignores offset
Andrew Nester added the comment: Thanks Serhiy! Just implemented new error messages in my PR for case you mentioned. -- ___ Python tracker <http://bugs.python.org/issue29649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29863] Add a COMPACT constant to the json module
Changes by Andrew Nester : -- pull_requests: +657 ___ Python tracker <http://bugs.python.org/issue29863> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29649] struct.pack_into check boundary error message ignores offset
Andrew Nester added the comment: any updates on this issue? looks like PR is ready to go -- ___ Python tracker <http://bugs.python.org/issue29649> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted
Andrew Nester added the comment: any updates? -- ___ Python tracker <http://bugs.python.org/issue29573> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: any updates? -- ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: >From my perspective current behaviour is a bit frustrate that's why it would >be nice to have this issue fixed, but I would say it's critic one. At the same time it doesn't introduce any BC breaking changes and kind safe -- ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: so any feedback on this? -- ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29863] Add a COMPACT constant to the json module
Andrew Nester added the comment: any conclusion on this? looks like it's a bit stuck -- nosy: +andrewnester ___ Python tracker <http://bugs.python.org/issue29863> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted
Andrew Nester added the comment: any conclusion on this? looks like it's a bit stuck -- ___ Python tracker <http://bugs.python.org/issue29573> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29534] _decimal difference with _pydecimal
Andrew Nester added the comment: I've just added PR for this issue. -- nosy: +andrewnester pull_requests: +51 ___ Python tracker <http://bugs.python.org/issue29534> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29534] _decimal difference with _pydecimal
Andrew Nester added the comment: actually, it's more related to subclassing, because the problem comes from the fact that before the fix __init__ method receives value as int not Decimal if int passed to from_float call. That's why only subclasses of Decimal can see difference in arguments received by __init__ -- ___ Python tracker <http://bugs.python.org/issue29534> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29534] _decimal difference with _pydecimal
Andrew Nester added the comment: Agree about surprising behaviour but I guess it's better to fix it as other issue because it could break BC in some cases. At least it needs to be investigated. For now I would like to stick with same behaviour for _decimal and _pydecimal -- ___ Python tracker <http://bugs.python.org/issue29534> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29534] _decimal difference with _pydecimal
Andrew Nester added the comment: thanks for your notes, it's absolutely fine and I agree with you :) -- ___ Python tracker <http://bugs.python.org/issue29534> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29540] Add compact=True flag to json.dump/dumps
Andrew Nester added the comment: I've just added PR implementing alternative version provided by R. David Murray as more simple and straight-forward one. -- nosy: +andrewnester pull_requests: +53 ___ Python tracker <http://bugs.python.org/issue29540> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Changes by Andrew Nester : -- pull_requests: +76 ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: I've just added PR fixing this. -- nosy: +andrewnester ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Changes by Andrew Nester : -- pull_requests: +80 ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: Ive just added alternative PR that drops inner brackets. So we've got options to choose! -- ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: any updates on this? -- ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted
Changes by Andrew Nester : -- pull_requests: +96 ___ Python tracker <http://bugs.python.org/issue29573> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted
Andrew Nester added the comment: I've just added PR fixing this issue. -- nosy: +andrewnester ___ Python tracker <http://bugs.python.org/issue29573> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted
Andrew Nester added the comment: any updates on this? :) -- ___ Python tracker <http://bugs.python.org/issue29573> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29540] Add compact=True flag to json.dump/dumps
Andrew Nester added the comment: Adding new argument sucs as format= or compact= will make API more complicated. In addition it's not easy and has obvious how to handle situations wheb we have both separatots= and format= arguments set. -- ___ Python tracker <http://bugs.python.org/issue29540> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29573] NamedTemporaryFile with delete=True should not fail if file already deleted
Andrew Nester added the comment: some updates? -- ___ Python tracker <http://bugs.python.org/issue29573> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29553] Argparser does not display closing parentheses in nested mutex groups
Andrew Nester added the comment: JFYI, from my perspective as a developer PR 120 is more preferred one. -- ___ Python tracker <http://bugs.python.org/issue29553> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29678] email.Message.get_params decodes only first one header value
Changes by Andrew Nester : -- pull_requests: +326 ___ Python tracker <http://bugs.python.org/issue29678> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue29678] email.Message.get_params decodes only first one header value
Andrew Nester added the comment: Thanks for reporting! Just added PR fixing this. -- nosy: +andrewnester ___ Python tracker <http://bugs.python.org/issue29678> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
