[issue18728] Increased test coverage for test_filecmp
New submission from Alex Volkov: I increased test coverage from 68% to 74% of filecmp.py by adding test cases in test_filecmp.py in functions phase2 & phase4 in dircmp class. -- components: Tests files: test_filecmp.patch keywords: patch messages: 195085 nosy: Alex.Volkov priority: normal severity: normal status: open title: Increased test coverage for test_filecmp type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file31280/test_filecmp.patch ___ Python tracker <http://bugs.python.org/issue18728> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18728] Increased test coverage for filecmp.py
Changes by Alex Volkov : -- title: Increased test coverage for test_filecmp -> Increased test coverage for filecmp.py ___ Python tracker <http://bugs.python.org/issue18728> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
Changes by Alex Volkov : -- components: Tests files: telnet_uu_tests.patch keywords: patch nosy: Alex.Volkov priority: normal severity: normal status: open title: Increased test coverage for uu and telnet type: enhancement versions: Python 3.4 Added file: http://bugs.python.org/file31284/telnet_uu_tests.patch ___ Python tracker <http://bugs.python.org/issue18731> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18728] Increased test coverage for filecmp.py
Alex Volkov added the comment: HI Vajrasky, I fixed the typo in a comment and removed WIN32 constant definition from the code. I looked at the existing tearDown method, on line 79, it calls shutil.rmtree on a directory above the files/directories I'm writing my test files, so the statements and the end of each function or combining these statements in a cleanup function is redundant, so I removed them. Alex. -- Added file: http://bugs.python.org/file31465/test_filecmp_v2.patch ___ Python tracker <http://bugs.python.org/issue18728> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18833] Increased test coverage for telnetlib
New submission from Alex Volkov: This issue splits up an unrelated patch from issue 18731 http://bugs.python.org/issue18731 Added a test for telnetlib increasing test coverage. Updated with the changes from code review of issue 18731 http://bugs.python.org/review/18731/patch/8923/33000 -- components: Tests files: test_telnetlib_getter.patch keywords: patch messages: 196158 nosy: Alex.Volkov priority: normal severity: normal status: open title: Increased test coverage for telnetlib versions: Python 3.4 Added file: http://bugs.python.org/file31466/test_telnetlib_getter.patch ___ Python tracker <http://bugs.python.org/issue18833> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18731] Increased test coverage for uu and telnet
New submission from Alex Volkov: Okay, I'm submitting the patch just for uu / test_uu. I replaced all try/finally statemets with 'with' context, added try..finally statement for both test cases. uu.py, line 61 is exposed by test_encode_osstat_assert -- os.stat is duckpunched out of the system, then test case verifies that default permissions(666) is written into a file. I didn't have try...finally statement because I wasn't sure how the test case will behave when inner try..finally is triggered, so far the tests seem to pass.. -- Added file: http://bugs.python.org/file31489/uu_test_v2.patch ___ Python tracker <http://bugs.python.org/issue18731> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
