[issue27572] Support bytes-like objects when base is given to int()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34660] Replace ableist terms and pejoratives in source code.

[Gabriel Marko]

Gabriel Marko  added the comment:

@terry.reedy

> Gabriel, I believe I addressed most your concerns in my previous post.

I don't think so (see below) but we don't have to agree in everything. :)

> Are you are suggesting that we judge proposals _by the proposer_, rather than 
> the substance of the proposal?

Definitely not. It really doesn't matter who has made a proposal if _it makes 
sense_. However, that doesn't matter either when a proposal doesn't make sense 
or it's ill-advised or not justified.

> who made the proposal and _why_

I don't care about who but the _why_ is the matter here as I put it in point 1. 
of my previous post. IMO one has to be clear and explicit about his/her 
intentions/justifications i.e. if one does something for clarity than he or she 
should declare it :)

> There seems to be a misperception that we have collectively changed how we 
> judge doc proposals.  Should we 'announce' that we proceed as we have been?

When I use your word: PSF and core developers should address the misperception. 
To be honest with you, IMO the "Python officials" handled these issues very 
badly and unprofessionally. Let me clarify. I'm not the only one who has 
perceived this BPO and V. Stinner's master/slave change (or some "gender 
neutralizations" of the documentation in the past) as PC/SJW ergo 
politically/ideologically motivated. So, what is perceived to be the main issue 
is the motivation. The way these were handled brings quite an _ambiguous_ 
impression and it's not clear if PSF or core developers are willing to proceed 
in this PC/SJW (ergo political/ideological) direction or what exactly is their 
stance. I read the BPOs and GH PRs and also some other articles and discussions 
where this ambiguity created a lot of confusion. There were statements in those 
articles and discussions like "GvR were asked to decide this question and he 
agrees with PC/SJW direction..." Therefore, I don't know how to interpret "that 
w
 e proceed as we have been" as IMO no clear statement has been made so far.

tl;dr

To conclude: I think we still aren't at the same page. However, I'm not sure if 
it makes sense to continue in this debate _at the moment_ at least for me. The 
amount of absurdity, nonsense*  and misconduct, _I've perceived_ while 
discussing these two BPOs, made me disappointed and discouraged me for any 
further participation on trying to make Python better at least for now. I want 
to give it some time and come back to this with a "cool(er) head".

To be specific: merging unjustified politically or ideologically motivated 
changes without discussion, not addressing factual arguments, silencing and 
censoring discussions**, sending people to Twitter (even if they don't have an 
account), using Code of Conduct as a tool***, making "feeling-based" arguments 
aren't characteristics of rational discourse or open community. I can't imagine 
what comes next but after all these things, I'm (rather) pessimistic.

* e.g. "cleaning/censoring" language based on its "potential offensiveness" is 
a nonsense as any language _is_ potentially offensive.
** "no further discussion is needed" (or even welcomed) without further context 
or clarification _can be perceived_ as arrogant as saying "Shut up! I know it 
better!"
*** To be clear, I don't mean your warning under issue34694. I can completely 
agree that I shouldn't/mustn't make sarcastic comments. IMO CoC is a 
written-down common sense. If it needs to be used as an argument (i.e. a tool) 
in a discussion, it's a sign of deeper issues or that something went to far.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26979] The danger of PyType_FromSpec()

[Petr Viktorin]

Petr Viktorin  added the comment:

Ah! It seems you don't need access to all tp_* slots of any type here, but just 
to PyType.tp_new – only one specific type, and only one specific slot.
Specifically, you need a way to create class with a metaclass, from C.

Is that right? Or was this only an example of a larger problem?

(Sorry for drawing the discussion out! Dropping the checks in PyType_GetSlot 
would be a simple change technically, but it doesn't match my mental model of 
what the stable ABI should be. I'm hoping to get a better solution for your use 
case, and others like it.)


> To obtain sizeof(PyType_Type), we simply used the Python code
> type.__basicsize__
> It is a simple trick, but probably very few people know this path
> to get that info. At least, for me it took way too long ;-)

Well, basicsize might be exposed through Python, but it's still not part of the 
limited API. Which is fine – all that means is you might need to change the 
extension for some future version of Python. I'm sure your tests will tell you 
when the time comes, and I hope we'll have a better solution then!
BTW, I'm honestly very impressed how far PySide got with the limited API!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34704] Do not access ob_type directly, introduce Py_TP

[Ronald Oussoren]

Ronald Oussoren  added the comment:

IMHO there doesn't need to be a new API unless the semantics change w.r.t 
Py_TYPE (for example by adding an API that returns an owned reference instead 
of a borrowed reference).   Py_TYPE can work with an opaque version of PyObject 
by turning it into a function.

BTW. Changing PyObject into an opaque structure is non-trivial because every 
instance currently explicitly contains a PyObject structure as the first field 
of the object definition.

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[Alexandru Ardelean]

New submission from Alexandru Ardelean :

See: https://github.com/openwrt/packages/pull/7051
The issue seems a bit older ; see comment: 
https://github.com/python/cpython/pull/3943#discussion_r148949292

Build error happens on OpenWrt as well:


---
/build_dir/target-i386_pentium4_musl/Python-3.7.0/Modules/_ssl.c:4000:5:
 error: implicit declaration of function 'DH_free'; did you mean 'lh_free'? 
[-Werror=implicit-function-declaration]
 DH_free(dh);
 ^~~
 lh_free
cc1: some warnings being treated as errors

Python build finished successfully!
The necessary bits to build these optional modules were not found:
_tkinter  _uuid nis
To find the necessary bits, look in setup.py in detect_modules() for the 
module's name.

The following modules found by detect_modules() in setup.py, have been
built by the Makefile instead, as configured by the Setup files:
_abc  atexitpwd
time  zlib

Failed to build these modules:
_ssl

Makefile:618: recipe for target 'sharedmods' failed

---

The fix seems to be to include .

--
assignee: christian.heimes
components: Build, SSL
messages: 325518
nosy: Alexandru Ardelean, christian.heimes
priority: normal
severity: normal
status: open
title: SSL Module build fails with more pedantic compiler flags
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[Alexandru Ardelean]

Change by Alexandru Ardelean :


--
keywords: +patch
pull_requests: +8770
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] Fix test_httpservers on AIX

[Michael Felt]

New submission from Michael Felt :

Going back to issue17234 - there has been a test to check that a URL with a 
trailing slash reports 404 status.

On AIX a trailing-slash is ignored - if the rest of the path is a valid 
filename.

At a very low-level, in Modules/_io/fileio.c the code could be adjusted to 
always look for a trailing slash, and if AIX considers the name to be a file 
(S_ISREG(mode)) then this could be promoted to an error. just as it does for 
"posix" opens directories with trailing slashes (and fileio.c deals with that 
in a Python way).

A quick fix is to skip the test issue17324 introduced;
A medium fix would be to modify Lib/http/server.py to verify that a URL with 
trailing slash is a directory, and otherwise raise an exception;
A deeper fix would be to add "a hack" specific to AIX, and raise (emulate) an 
OSError when there is a trailing slash and the pathname is a file.

In short, the simple resolution - without impacting core in any way is:
diff --git a/Lib/test/test_httpservers.py b/Lib/test/test_httpservers.py
index cc829a522b..31be9b4479 100644
--- a/Lib/test/test_httpservers.py
+++ b/Lib/test/test_httpservers.py
@@ -13,6 +13,7 @@ import sys
 import re
 import base64
 import ntpath
+import platform
 import shutil
 import email.message
 import email.utils
@@ -29,6 +30,7 @@ from io import BytesIO
 import unittest
 from test import support

+AIX = platform.system() == 'AIX'

 class NoLogRequestHandler:
 def log_message(self, *args):
@@ -417,9 +419,11 @@ class SimpleHTTPServerTestCase(BaseTestCase):
 #constructs the path relative to the root directory of the HTTPServer
 response = self.request(self.base_url + '/test')
 self.check_status_and_reason(response, HTTPStatus.OK, data=self.data)
-# check for trailing "/" which should return 404. See Issue17324
-response = self.request(self.base_url + '/test/')
-self.check_status_and_reason(response, HTTPStatus.NOT_FOUND)
+# AIX open() will open a filename with a trailing slash - as a file
+if not AIX:
+# check for trailing "/" which should return 404. See Issue17324
+response = self.request(self.base_url + '/test/')
+self.check_status_and_reason(response, HTTPStatus.NOT_FOUND)
 response = self.request(self.base_url + '/')
 self.check_status_and_reason(response, HTTPStatus.OK)
 response = self.request(self.base_url)
@@ -519,8 +523,9 @@ class SimpleHTTPServerTestCase(BaseTestCase):
 def test_path_without_leading_slash(self):
 response = self.request(self.tempdir_name + '/test')
 self.check_status_and_reason(response, HTTPStatus.OK, data=self.data)
-response = self.request(self.tempdir_name + '/test/')
-self.check_status_and_reason(response, HTTPStatus.NOT_FOUND)
+if not AIX:
+response = self.request(self.tempdir_name + '/test/')
+self.check_status_and_reason(response, HTTPStatus.NOT_FOUND)
 response = self.request(self.tempdir_name + '/')
 self.check_status_and_reason(response, HTTPStatus.OK)
 response = self.request(self.tempdir_name)

Comments!

--
components: Tests
messages: 325519
nosy: Michael.Felt
priority: normal
severity: normal
status: open
title: Fix test_httpservers on AIX
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26544] platform.libc_ver() returns incorrect version number

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Seems the only difference between PR 8952 and PR 9062 is additional tests. This 
is not important.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22851] 2.7 core crashes with generator.gi_frame.f_restricted

[Zackery Spytz]

Change by Zackery Spytz :


--
keywords: +patch
pull_requests: +8771
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue22851] 2.7 core crashes with generator.gi_frame.f_restricted

[Zackery Spytz]

Change by Zackery Spytz :


--
nosy: +ZackerySpytz

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] Fix test_httpservers on AIX

[Jeremy Kloth]

Jeremy Kloth  added the comment:

This is also an issue on Windows when the target path resides within a 
junction, paths outside of a junction respond (err, fail) as expected.

https://developercommunity.visualstudio.com/content/problem/272379/createfile-non-error-on-filename-with-trailing-bac.html

--
nosy: +jkloth

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset e0e5065daef36dafe10a46eaa8b7800274d73062 by Serhiy Storchaka in 
branch 'master':
bpo-34610: Fixed iterator of multiprocessing.managers.DictProxy. (GH-9113)
https://github.com/python/cpython/commit/e0e5065daef36dafe10a46eaa8b7800274d73062


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

[miss-islington]

Change by miss-islington :


--
pull_requests: +8772

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

[miss-islington]

Change by miss-islington :


--
pull_requests: +8773

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26979] The danger of PyType_FromSpec()

[Christian Tismer]

Christian Tismer  added the comment:

> ... Specifically, you need a way to create class with a metaclass, from C.
> 
> Is that right? Or was this only an example of a larger problem?

Yes, you are exactly right. I needed access to very few fields.
In particular:

PyTypeObject.tp_init
PyTypeObject.tp_basicsize(workaround using Python)

.tp_dict

The latter would not be necessary for Pep 384, but for my __signature__
extension, but that is another story :)



> Well, basicsize might be exposed through Python, but it's still not
> part of the limited API. Which is fine – all that means is you might
> need to change the extension for some future version of Python.

Oh? I thought it is automatically allowed to use if it is exposed
by Python. I thought that the central property of basicsize would be
that it is no longer a constant, but that a size is always there.

Sure, we could have worked without the size and create a more complex 
structure that does not know anything about types. I actually started
with that approach. But in the end I thought it would not hurt to assume 
that there is a (variable) size, as long as we are below Python 4.0 .

> I'm sure your tests will tell you when the time comes, and I hope we'll
> have a better solution then!

Yes, I had a very hard time to convince myself that I _may_ use some
assumptions, as long as I always prove that these assumptions are right.
But in a way, I feel guilty and would prefer to go without any trickery.

> BTW, I'm honestly very impressed how far PySide got with the limited API!

Thank you! I was hoping to get ready after 2 months, when I realized that 
all types needed to be changed. So I pulled teeth, and it took >5 months.
Btw., I don't understand how the PyQt5 guy(s) solved this. Maybe his 
structure is way cleaner and simpler than the PySide mess? I'll ask him.

Ciao -- Chris

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34707] Python not reentrant

[Eric V. Smith]

Eric V. Smith  added the comment:

I think this is along the lines of a recent discussion on the c-api mailing 
list about passing a context value (your handle) to every C call. See this 
message for some discussion: 
https://mail.python.org/mm3/archives/list/capi-...@python.org/message/ZN6BJVUGIOGWKHY47PKPX5Z3SGCYUAX5/

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[Christian Heimes]

Christian Heimes  added the comment:


New changeset b3a271fc0ce3e13e427be8914decfc205a220ca8 by Christian Heimes 
(Alexandru Ardelean) in branch 'master':
bpo-34710: fix SSL module build (GH-9347)
https://github.com/python/cpython/commit/b3a271fc0ce3e13e427be8914decfc205a220ca8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[miss-islington]

Change by miss-islington :


--
pull_requests: +8775

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[miss-islington]

Change by miss-islington :


--
pull_requests: +8774

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26979] The danger of PyType_FromSpec()

[Christian Tismer]

Christian Tismer  added the comment:

If somebody is interested to see how the transition to the
Limited API was done, here is the documentation that I was
forced to write :)

https://github.com/pyside/pyside2-setup/blob/5.11/sources/shiboken2/libshiboken/pep384impl_doc.rst

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34707] Python not reentrant

[john skaller]

john skaller  added the comment:

eric: yes, that's relevant. Very happy it is discussed.

Contrary to some indication in the post, passing a context handle around 
everywhere is NOT a burden at all. My system does exactly that.

I would note, API's which already require, say, an interpreter handle, don't 
require any modification.

Also, I would note, legacy API's do not have to be broken, you just have a 
single, legacy, global variable holding the default context, and deprecate any 
functions using it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

[miss-islington]

miss-islington  added the comment:


New changeset 1d3078849381335008379e3de96d5a81d2131113 by Miss Islington (bot) 
in branch '3.7':
bpo-34610: Fixed iterator of multiprocessing.managers.DictProxy. (GH-9113)
https://github.com/python/cpython/commit/1d3078849381335008379e3de96d5a81d2131113


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34610] Incorrect iteration of Manager.dict() method of the multiprocessing module.

[miss-islington]

miss-islington  added the comment:


New changeset f35e4d5851555d66f1e7a36b2a37f0d82b3d1706 by Miss Islington (bot) 
in branch '3.6':
bpo-34610: Fixed iterator of multiprocessing.managers.DictProxy. (GH-9113)
https://github.com/python/cpython/commit/f35e4d5851555d66f1e7a36b2a37f0d82b3d1706


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[miss-islington]

Change by miss-islington :


--
pull_requests: +8777

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 5e99b56d6b249995a4fa2bc09c0bb03841f49572 by Serhiy Storchaka in 
branch 'master':
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784)
https://github.com/python/cpython/commit/5e99b56d6b249995a4fa2bc09c0bb03841f49572


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset afa591d7748c66831e6e650108024f3293be33f1 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-33216: Clarify the documentation for CALL_FUNCTION_* (GH-8338) 
(GH-8783)
https://github.com/python/cpython/commit/afa591d7748c66831e6e650108024f3293be33f1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +8776

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[miss-islington]

Change by miss-islington :


--
pull_requests: +8778

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] Fix test_httpservers on AIX

[Michael Felt]

Michael Felt  added the comment:

On 17/09/2018 12:47, Jeremy Kloth wrote:
> Jeremy Kloth  added the comment:
>
> This is also an issue on Windows when the target path resides within a 
> junction, paths outside of a junction respond (err, fail) as expected.
>
> https://developercommunity.visualstudio.com/content/problem/272379/createfile-non-error-on-filename-with-trailing-bac.html
:) Glad to hear I am not the only one facing this. However, looking at
the standard - it looks like it may be "a bug". Not the easiest to read,
but my understanding of this leans to calling opening a file using
"/some/path/to/file/" is wrong:

[ENOTDIR]
A component of the path prefix names an existing file that is
neither a directory nor a symbolic link to a directory; or O_CREAT
and O_EXCL are not specified, the /path/ argument contains at least
one non-  character and ends with one or more trailing
 characters, and the last pathname component names an
existing file that is neither a directory nor a symbolic link to a
directory; or O_DIRECTORY was specified and the /path/ argument
resolves to a non-directory file.

from http://pubs.opengroup.org/onlinepubs/9699919799/functions/open.html

> --
> nosy: +jkloth
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12458] Tracebacks should contain the first line of continuation lines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset da8d72c953369b872a12c13f136ada77a786714a by Serhiy Storchaka in 
branch 'master':
bpo-12458: Fix line numbers for multiline expressions. (GH-8774)
https://github.com/python/cpython/commit/da8d72c953369b872a12c13f136ada77a786714a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[miss-islington]

miss-islington  added the comment:


New changeset e2c0aea670d603b187733606a4601d77f355bc47 by Miss Islington (bot) 
in branch '3.7':
bpo-34710: fix SSL module build (GH-9347)
https://github.com/python/cpython/commit/e2c0aea670d603b187733606a4601d77f355bc47


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[miss-islington]

miss-islington  added the comment:


New changeset fff869e2a0ee3d2d65973d82e57f05479828f5a3 by Miss Islington (bot) 
in branch '3.6':
bpo-34710: fix SSL module build (GH-9347)
https://github.com/python/cpython/commit/fff869e2a0ee3d2d65973d82e57f05479828f5a3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34341] Appending to ZIP archive blows up existing Central Directory entries

[miss-islington]

Change by miss-islington :


--
pull_requests: +8779

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34341] Appending to ZIP archive blows up existing Central Directory entries

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 9bdb7be482aef8f60daa1d36606568a132dcb616 by Serhiy Storchaka in 
branch 'master':
bpo-34341: Fix appending to ZIP archives with the ZIP64 extension. (GH-8683)
https://github.com/python/cpython/commit/9bdb7be482aef8f60daa1d36606568a132dcb616


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34341] Appending to ZIP archive blows up existing Central Directory entries

[miss-islington]

Change by miss-islington :


--
pull_requests: +8780

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Thank you Larry for your rewriting.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Thomas Gläßle]

Change by Thomas Gläßle :


--
keywords: +patch
pull_requests: +8781
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34624] -W option does not accept module regexes

[Thomas Gläßle]

Thomas Gläßle  added the comment:

Thanks for your response. I have opened a PR at [1] that would remove the 
re.escape such that the implementation matches the documentation if you decide 
that this is fine.

[1]: https://github.com/python/cpython/pull/9358

Personally, I would go even further and always add the `(\..*)?$` suffix 
(instead of only `$`) to make it easier to match all modules in a package which 
is probably the most important use-case for the case of packages. What do you 
think?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23278] multiprocessing maxtasksperchild=1 + logging = task loss

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34341] Appending to ZIP archive blows up existing Central Directory entries

[miss-islington]

miss-islington  added the comment:


New changeset efdf316d23c2bc81f499c46faaba5e1b49509afa by Miss Islington (bot) 
in branch '3.7':
bpo-34341: Fix appending to ZIP archives with the ZIP64 extension. (GH-8683)
https://github.com/python/cpython/commit/efdf316d23c2bc81f499c46faaba5e1b49509afa


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[miss-islington]

miss-islington  added the comment:


New changeset f8e34eee74871b3343f6c3545bce41242ba378e8 by Miss Islington (bot) 
in branch '3.7':
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784)
https://github.com/python/cpython/commit/f8e34eee74871b3343f6c3545bce41242ba378e8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33216] [3.5] Wrong order of stack for CALL_FUNCTION_VAR and CALL_FUNCTION_VAR_KW

[miss-islington]

miss-islington  added the comment:


New changeset 1e7193bd027a5a4aa1a387e3f201a3e465c25f01 by Miss Islington (bot) 
in branch '3.6':
bpo-33216: Improve the documentation for CALL_FUNCTION_* (GH-8338) (GH-8784)
https://github.com/python/cpython/commit/1e7193bd027a5a4aa1a387e3f201a3e465c25f01


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34683] Caret positioned wrong for SyntaxError reported by ast.c

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34341] Appending to ZIP archive blows up existing Central Directory entries

[miss-islington]

miss-islington  added the comment:


New changeset 83a0985165abf340294c10d732840e9d46ba218c by Miss Islington (bot) 
in branch '3.6':
bpo-34341: Fix appending to ZIP archives with the ZIP64 extension. (GH-8683)
https://github.com/python/cpython/commit/83a0985165abf340294c10d732840e9d46ba218c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34676] Guarantee that divmod() and PyNumber_Divmod() return a 2-tuple

[Paul Ganssle]

Paul Ganssle  added the comment:

@Serhiy I like the "convert to a tuple" idea before returning *better*, though 
I think I'd prefer to just check that it's tuple-like, something like:

if not all(hasattr(return_val, attr) for attr in ['__getitem__', 
'__len__']) or len(return_val) != 2:
warnings.warn("divmod must return a Sequence of length 2. " +
  "This will be an exception in Python 3.9+",
  Deprecationwarning)

Or some similar equivalent to `if not isinstance(return_val, 
collections.abc.Sequence) or len(return_val) != 2`.

That said, the PR seems to have already run into an issue, which is that 
`unittest.mock.MagicMock` returns a `unittest.mock.MagicMock` from `divmod`, 
which is not a 2-tuple.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[miss-islington]

miss-islington  added the comment:


New changeset 5f883fcb9b50b8335953b3849b7f224d5cd59d56 by Miss Islington (bot) 
(Christian Heimes) in branch '2.7':
[2.7] bpo-34710: fix SSL module build (GH-9347) (GH-9353)
https://github.com/python/cpython/commit/5f883fcb9b50b8335953b3849b7f224d5cd59d56


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31635] test_strptime failure on OpenBSD

[Paul Ganssle]

Paul Ganssle  added the comment:

@Serhiy Looking more closely at #13414, I think there's a good chance that 
we've just discovered a different bug in OpenBSD's implementation of wcsftime 
(or strftime). Looks like OpenBSD 6.1 was released in 2017, which should have 
been years after the fix from #13414 was released.

It seems that OpenBSD does not have a bug tracker per se, and I can't see if 
this bug has been reported. I can try to install OpenBSD in a VM later and try 
to reproduce it, but if it's a bug in OpenBSD, I see some possible options:

1. Add an exception to the test suite on OpenBSD (to be removed or pinned when 
it's fixed in OpenBSD)

2. If the bug is just in wcsftime and not in strftime, it may be fixed by 
switching to using strftime as is done on Windows: 
https://github.com/python/cpython/blob/master/Modules/timemodule.c#L673

I have never tested it, but it's possible this will impact performance, and if 
it's a bad enough hit it may not be worth sacrificing general performance to 
avoid a bug in a corner case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] return ENOTDIR when open() accepts filenames with a trailing slash

[Michael Felt]

Change by Michael Felt :


--
components: +IO
title: Fix test_httpservers on AIX -> return ENOTDIR when open() accepts 
filenames with a trailing slash

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] return ENOTDIR when open() accepts filenames with a trailing slash

[Michael Felt]

Michael Felt  added the comment:

OK - issue17324 (not 1 7 2 3 4)

And, as jkloth reported that Windows also has an issue - sometimes, found a way 
to do this in Modules/_io/fileio.c

diff --git a/Modules/_io/fileio.c b/Modules/_io/fileio.c
index c0e43e0ae4..3623ff16ea 100644
--- a/Modules/_io/fileio.c
+++ b/Modules/_io/fileio.c
@@ -228,6 +228,7 @@ _io_FileIO___init___impl(fileio *self, PyObject *nameobj, 
const char *mode,
 #endif
 PyObject *stringobj = NULL;
 const char *s;
+char *rcpt;
 int ret = 0;
 int rwa = 0, plus = 0;
 int flags = 0;
@@ -447,6 +448,23 @@ _io_FileIO___init___impl(fileio *self, PyObject *nameobj, 
const char *mode,
 }
 }
 else {
+#if defined(S_ISREG) && defined(ENOTDIR)
+/* On AIX and Windows, open may succeed for files with a trailing 
slash.
+   The Open Group specifies filenames ending with a trailing slash 
should
+   be an error - ENOTDIR */
+if (S_ISREG(fdfstat.st_mode)) {
+#ifdef MS_WINDOWS
+rcpt= strrch(widename, '\');
+#else
+   rcpt = strrchr(name, '/');
+#endif
+if ((rcpt != NULL) && (strlen(rcpt) == 1)) {
+   errno = ENOTDIR;
+   PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, 
nameobj);
+   goto error;
+   }
+   }
+#endif
 #if defined(S_ISDIR) && defined(EISDIR)
 /* On Unix, open will succeed for directories.
In Python, there should be no file objects referring to

And, now for the PR tests...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] return ENOTDIR when open() accepts filenames with a trailing slash

[Michael Felt]

Change by Michael Felt :


--
keywords: +patch
pull_requests: +8782
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[Christian Heimes]

Change by Christian Heimes :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34710] SSL Module build fails with more pedantic compiler flags

[Christian Heimes]

Christian Heimes  added the comment:

Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30455] Generate C code from token.py and not vice versa

[Emily Morehouse]

Change by Emily Morehouse :


--
pull_requests: +8783

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33608] [subinterpreters] Add a cross-interpreter-safe mechanism to indicate that an object may be destroyed.

[Eric Snow]

Eric Snow  added the comment:

@Neil, we're definitely on the same page.  In fact, in a world where 
subinterpreters do not share a GIL, we can't ever use an object in one 
interpreter that was created in another (due to thread safety on refcounts).  
The role of "tightly controlling" passing/sharing objects (for a very loose 
definition of "sharing") falls to the channels described in PEP 554. [1]

However, there are several circumstances where interpreters may collaborate 
that involves one holding a reference (but not using it) to an object owned by 
the other.  For instance, see PyBuffer_Release(). [2]  This issue is about 
addressing that situation safely.  It is definitely not about safely using 
objects from other interpreters.

[1] The low-level implementation, including channels, already exists in 
Modules/_xxsubinterpretersmodule.c.
[2] https://docs.python.org/3/c-api/buffer.html#c.PyBuffer_Release

--
assignee:  -> eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34707] Python not reentrant

[Eric Snow]

Eric Snow  added the comment:

Also see PEP 432 ("Restructuring the CPython startup sequence"), which is still 
in the process of fine-tuning.

--
nosy: +eric.snow, ncoghlan, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34711] return ENOTDIR when open() accepts filenames with a trailing slash

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34712] Style fixes in examples of "Input and Output" tutorial section

[Ben Hoyt]

New submission from Ben Hoyt :

There are a couple of examples in the "Input and Output" section of the 
tutorial that use an unusual / non-PEP 8 Python style or whitespace. I think 
our examples, especially in the tutorial, should reflect good, PEP 8 style. 
I'll fix these in a PR which I'll attach soon.

--
assignee: docs@python
components: Documentation
messages: 325550
nosy: akuchling, benhoyt, docs@python, rhettinger
priority: normal
severity: normal
status: open
title: Style fixes in examples of "Input and Output" tutorial section
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34712] Style fixes in examples of "Input and Output" tutorial section

[Ben Hoyt]

Change by Ben Hoyt :


--
keywords: +patch
pull_requests: +8784
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34712] Style fixes in examples of "Input and Output" tutorial section

[Ben Hoyt]

Ben Hoyt  added the comment:

GitHub PR link with changes and commit notes attached.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30140] Binary arithmetic does not always call subclasses first

[Guido van Rossum]

Guido van Rossum  added the comment:

If anyone cares, here's what I recall of the history of this feature.

Originally my design was just

1. try left arg's __op__
2. if that returns NotImplemented, try right arg's __rop__

That's simple to explain and usually works. But when thinking through edge 
cases, we found that if the right class is a subclass of the left class, this 
gives unexpected results, so we added the exception

0. if the right class subclasses the left class *and it overrides __rop__*, try 
that first

I honestly believe that I didn't realize that it could ever matter if the right 
class subclasses the left class *without overriding __rop__*. And nobody else 
realized it either.

I think we decided on the "right class must override __rop__" condition in part 
to preserve the original, simpler rules for cases where we thought they would 
suffice, in part because for most users trying __rop__ before __op__ is 
unexpected, and in part because we didn't realize that it mattered.

And it only matters if the base class uses something like type(self) or 
self.__class__, which as a design pattern is sometimes dubious and other times 
useful.

Also note that the language Stephan quoted is somewhat different: it uses 
"provides" (__rop__) instead of "overrides". I could imagine that this, again, 
was a difference too subtle for most folks to notice.

If I had to do it over, I agree that if the right class subclasses the left 
class, we should always try __rop__ first. But now that this has been an 
ingrained behavior for so long I worry that it will break existing code, esp. 
in cases where there is an asymmetry between __op__ and __rop__ and the class 
author did not expect __rop__ ever to be called first.

Whether that's enough to stop this PR I think this is a question for the next 
BDFL to decide, alas. (I don't think it requires a PEP, it just requires 
someone to decide.)

--
nosy: +gvanrossum
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34589] Py_Initialize() and Py_Main() should not enable C locale coercion

[STINNER Victor]

STINNER Victor  added the comment:

> I'd strongly prefer to just go back to the PEP 538 design. It's much simpler 
> to implement, we don't actually want anyone turning off locale coercion 
> except for debugging purposes (unlike UTF-8 mode), and the only argument 
> against doing this the way PEP 538 describes is a purist one, not a practical 
> one (which was already resolved in favour of practicality when PEP 538 was 
> accepted).
> (...)
> That's quite a bit of code to add for the sake of a flag we don't really want 
> anyone to ever use, though. (If it hadn't been for the 
> debugging-CentOS-7-problems-on-Fedora issue, I doubt I would have included 
> the off switch in PEP 538 at all)

Why did you add PYTHONCOERCECLOCALE=warn if you don't want that people use it?

> The actual functional error is that the following will currently give 
> different outputs on Fedora and CentOS 7, whereas in the original PEP 538 
> implementation it would always print "C", even if locale coercion would 
> otherwise normally work on your current platform:
>
>LC_CTYPE=C PYTHONCOERCECLOCALE=0 python3 -E -c 'import os; 
> print(os.env["LC_CTYPE"])'

You wrote that we need PYTHONCOERCECLOCALE=0 and then that we don't need it, I 
don't understand :-)

IMHO there are use cases where PYTHONCOERCECLOCALE=0 is important, that's why I 
propose to add -X coerce_c_locale=0.

There are also cases where you want the warning, so -X coerce_c_locale=warn 
would help as well, when -E or -I is needed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34691] _contextvars missing in x64 master branch Windows build?

[Steve Dower]

Steve Dower  added the comment:

It looks like _contextvars has both its own project and is also built as part 
of pythoncore.vcxproj.

However, _contextvars.vcxproj is not in PCbuild.sln, which means when you build 
through Visual Studio (rather than with build.bat via pcbuild.proj), you don't 
get the separate extension module.

And even though it's built into pythoncore.vcxproj, it hasn't been added to 
PC/config.c, and so it isn't initialised as a regular builtin module.

Yury - is there a specific reason for it to be a standalone module? How much do 
you think it hurts to have it always loaded into memory, even if it hasn't 
truly been imported or used?

--
nosy: +yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34691] _contextvars missing in x64 master branch Windows build?

[Yury Selivanov]

Yury Selivanov  added the comment:

> How much do you think it hurts to have it always loaded into memory, even if 
> it hasn't truly been imported or used?

I'd be fine with that.  Would you be able to do the necessary change (I don't 
have VS at hand)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34713] csvwriter.writerow()'s return type is undocumented

[Nicholas Chammas]

New submission from Nicholas Chammas :

It _looks_ like csvwriter.writerow() returns the number of bytes (or is it 
characters?) written. However, there is no documentation of this:

https://docs.python.org/3.7/library/csv.html#csv.csvwriter.writerow

Is this behavior part of the method's "contract"? And if so, shouldn't we 
document it?

The same goes for csvwriter.writerows().

--
assignee: docs@python
components: Documentation, Library (Lib)
messages: 325557
nosy: docs@python, nchammas
priority: normal
severity: normal
status: open
title: csvwriter.writerow()'s return type is undocumented
type: enhancement
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34688] Segfault in pandas that works fine on 3.7

[Vladimir Matveev]

Vladimir Matveev  added the comment:

somewhat shortened repro that fails with the same error on master:
```
import pandas
import numpy

now = pandas.Timestamp.now()
arr = numpy.array([ ['a', now] for i in range(0, 3)])
arr.sum(0)
```

--
nosy: +v2m

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34713] csvwriter.writerow()'s return type is undocumented

[Nicholas Chammas]

Nicholas Chammas  added the comment:

Looks like it's bytes written, not characters:

```
>>> import csv
>>> with open('test.csv', 'w', newline='') as csv_file:
... csv_writer = csv.writer(
... csv_file,
... dialect='unix',
... )
... csv_writer.writerow('야 너')  # 3 characters
... 
12
```

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34691] _contextvars missing in x64 master branch Windows build?

[Steve Dower]

Steve Dower  added the comment:

Shouldn't need VS for this change (updating the SLN file generally does need 
it). I'm happy to do it though.

In case someone else gets to it before me:
* delete _contextvars.vcxproj and remove all references from PCbuild and 
Tools/msi
* add _contextvars entries to PC/config.c

The CI builds will tell you pretty quickly if it worked or not.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34689] Lib/sysconfig.py expands non-variables

[Erwan Le Pape]

Change by Erwan Le Pape :


--
keywords: +patch
pull_requests: +8786
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34688] Segfault in pandas that works fine on 3.7

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Pandas issue that contains other segfaults : 
https://github.com/pandas-dev/pandas/issues/22714

Thanks

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34712] Style fixes in examples of "Input and Output" tutorial section

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17239] XML vulnerabilities in Python

[Steve Dower]

Steve Dower  added the comment:

Ned - I don't think this is necessarily a release blocker, as we've been 
shipping it for a long time, but it would be nice if we can hold 3.7.1rc1 just 
long enough to get it in (provided Christian jumps in and says he'll get the 
last minor concerns on the PRs wrapped up very soon)

--
nosy: +ned.deily, steve.dower
versions: +Python 3.6, Python 3.7, Python 3.8 -Python 2.6, Python 3.1, Python 
3.2, Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34683] Caret positioned wrong for SyntaxError reported by ast.c

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34713] csvwriter.writerow()'s return type is undocumented

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32533] SSLSocket read/write thread-unsafety

[Steve Dower]

Steve Dower  added the comment:


New changeset c6fd1c1c3a65217958b68df3a4991e4f306e9b7d by Steve Dower in branch 
'master':
bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158)
https://github.com/python/cpython/commit/c6fd1c1c3a65217958b68df3a4991e4f306e9b7d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32533] SSLSocket read/write thread-unsafety

[miss-islington]

Change by miss-islington :


--
pull_requests: +8787

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33649] asyncio docs overhaul

[Yury Selivanov]

Change by Yury Selivanov :


--
pull_requests: +8788

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34714] timeout in test_multiprocessing_spawn x86 Windows7 3.x buildbot

[Pablo Galindo Salgado]

New submission from Pablo Galindo Salgado :

https://buildbot.python.org/all/#/builders/58/builds/1338/steps/3/logs/stdio

Timeout (0:15:00)!
Thread 0x09d8 (most recent call first):
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\multiprocessing\popen_spawn_win32.py",
 line 91 in wait
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\multiprocessing\process.py",
 line 140 in join
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\_test_multiprocessing.py",
 line 612 in test_error_on_stdio_flush_1
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\case.py", 
line 610 in run
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\case.py", 
line 658 in __call__
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\suite.py", 
line 122 in run
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\suite.py", 
line 84 in __call__
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\suite.py", 
line 122 in run
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\suite.py", 
line 84 in __call__
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\suite.py", 
line 122 in run
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\suite.py", 
line 84 in __call__
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\unittest\runner.py",
 line 176 in run
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\support\__init__.py",
 line 1900 in _run_suite
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\support\__init__.py",
 line 1990 in run_unittest
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\runtest.py",
 line 175 in test_runner
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\runtest.py",
 line 179 in runtest_inner
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\runtest.py",
 line 140 in runtest
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\main.py",
 line 286 in rerun_failed_tests
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\main.py",
 line 570 in _main
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\main.py",
 line 531 in main
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\libregrtest\main.py",
 line 584 in main
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\__main__.py", 
line 2 in 
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\runpy.py", 
line 85 in _run_code
  File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\runpy.py", 
line 192 in _run_module_as_main
Traceback (most recent call last):
  File "", line 1, in 
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\multiprocessing\spawn.py",
 line 107, in spawn_main
new_handle = reduction.duplicate(pipe_handle,
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\multiprocessing\reduction.py",
 line 79, in duplicate
return _winapi.DuplicateHandle(
PermissionError: [WinError 5] Access is denied

--
components: Tests, Windows
messages: 325564
nosy: pablogsal, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: timeout in test_multiprocessing_spawn x86 Windows7 3.x buildbot
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32533] SSLSocket read/write thread-unsafety

[miss-islington]

miss-islington  added the comment:


New changeset 1229664f30dd5fd4da32174a19258f8312464d45 by Miss Islington (bot) 
in branch '3.7':
bpo-32533: Fixed thread-safety of error handling in _ssl. (GH-7158)
https://github.com/python/cpython/commit/1229664f30dd5fd4da32174a19258f8312464d45


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[Pablo Galindo Salgado]

New submission from Pablo Galindo Salgado :

Example:

https://buildbot.python.org/all/#/builders/87/builds/1434

./Modules/timemodule.c:573:24: warning: assigning to 'char *' from 'const char 
*' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
p->tm_zone = PyUnicode_AsUTF8(item);
   ^ ~~
./Modules/timemodule.c:1545:44: warning: incompatible pointer to integer 
conversion passing 'char *(int, int)' to parameter of type 'long' 
[-Wint-conversion]
PyModule_AddIntConstant(m, "timezone", timezone);
   ^~~~
./Include/modsupport.h:118:71: note: passing argument to parameter here
PyAPI_FUNC(int) PyModule_AddIntConstant(PyObject *, const char *, long);
  ^
./Modules/timemodule.c:1568:44: error: use of undeclared identifier 'daylight'
PyModule_AddIntConstant(m, "daylight", daylight);
   ^
2 warnings and 1 error generated.
*** [Modules/timemodule.o] Error code 1
make: stopped in /usr/home/buildbot/python/3.x.koobs-freebsd10/build
make: stopped in /usr/home/buildbot/python/3.x.koobs-freebsd10/build
1 error

--
components: Build, FreeBSD
messages: 325566
nosy: koobs, pablogsal
priority: normal
severity: normal
status: open
title: timemodule.c fails to compile on BSD
type: compile error
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Bisecting returns commit 5633c4f342d as possible culprit

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33649] asyncio docs overhaul

[Yury Selivanov]

Yury Selivanov  added the comment:


New changeset 394374e30c85f6eacddbbfc7471aab62b54ce021 by Yury Selivanov in 
branch 'master':
bpo-33649: Add low-level APIs index. (GH-9364)
https://github.com/python/cpython/commit/394374e30c85f6eacddbbfc7471aab62b54ce021


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34708] Odd crashes/freezes when sys.stdout.shell.console is typed

[Terry J. Reedy]

Terry J. Reedy  added the comment:

3.4 and 3.5 only get security fixes and I doubt this qualifies.

I reproduced the described behavior with 3.7 on Win 10, so it is not 
Mac-specific.

Python sys.stdout: <_io.TextIOWrapper name='' mode='w' encoding='utf-8'>
IDLE's sys.stdout: 
The PseudoFiles are unusual in being internal objects accessible from user code.

Comparing attributes with public names (not starting with single or double 
underscore) PseudoOutputFile lacks buffer, line_buffering, mode, reconfigure, 
and write_through.  #21995 is about fixing or documenting each omission for all 
3 streams.

PseudoFiles add shell and tags.  Both should have private names that warn users 
that their behavior is undocumented and usage is at one's own risk.  'shell' 
should be double underscored. This minimal fix would be sufficient to close 
this issue.  Some manual testing should be sufficient for such a change.

'Tags' should be singular, as it is one of 'stdin', 'stdout', or 'stderr'.  The 
tag is used in the write method to tell Shell whether to display with the 
configured stdout or stderr colors.

Shell is an idlelib.rpc.RPCProxy object.  As an object in itself, in the run 
process, it has 2 public attributes: oid ('console') and sockio (an  
idlelib.run.MyHandler object).  But as a proxy representing the Shell console 
object in the IDLE process, it supposedly 'has' all the attributes of the 
latter.  These are accessed with a custom __getattr__.

def __getattr__(self, name):
if self.__methods is None:
self.__getmethods()
if self.__methods.get(name):
return MethodProxy(self.sockio, self.oid, name)
if self.__attributes is None:
self.__getattributes()
if name in self.__attributes:
value = self.sockio.remotecall(self.oid, '__getattribute__',
   (name,), {})
return value
else:
raise AttributeError(name)

Note that self.__attributes is mangled to shell._RPCProxy__attributes when 
accessed externally.  (Also, it is a set still implemented in this ancient code 
as a dict with int 1 values.)

More importantly, remote calls to the Shell console can only pass and return 
objects that can be pickled, and there is currently no provision for graceful 
failure.  Hence sys.stdout.shell.width is (for me, currently) 80, but .console 
or .stdout are impossible to return.

I am extremely dubious about trying to fix this in the IDLE side of the link.  
Instead, the proxy should be initialized with sets of known usable attributes 
and methods.  I think the underlying problem is trying to be unnecessarily and 
impossibly generic.  Run only calls the .readline, .write, and .close methods 
of the console proxy.  It only calls stack viewer setup on the interp proxy.  A 
third proxy, for flist, is passed to the stack viewer (I have not yet checked 
what is needed for that).  Restricting proxies to things that are needed and 
*should* work would make it more feasible to test them.  But setting up 
automated tests would still require some work.

--
stage:  -> needs patch
versions: +Python 3.8 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue30140] Binary arithmetic does not always call subclasses first

[Raymond Hettinger]

Change by Raymond Hettinger :


--
nosy: +tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34686] Add `-r`, as opposed to `-R` to Python core interpreter

[Erwan Le Pape]

Erwan Le Pape  added the comment:

Given that marshal basically only just dumps code objects, the only viable 
solution I can see is adding a flag that can be passed all the way to the AST 
from `Python/bltinmodule.c:builtin_compile_impl` that would sort elements when 
creating code objects of unordered types.

This could be automatically enabled when compiling a file if we assume imported 
files are trustworthy or add a flag to the `Lib/compileall.py` module.

I only fear that this might break compiled code objects that make use of 
unordered types. Since I haven't sifted through the AST internals and the 
implications of such a change yet, so this is largely up for debate.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34716] MagicMock.__divmod__ should return a pair

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

It is documented, that divmod() returns a pair. It is usually used with tuple 
unpacking:

x, y = divmod(a, b)

But this doesn't work when one of arguments is a MagicMock.

>>> from unittest.mock import *
>>> x, y = divmod(MagicMock(), 2)
Traceback (most recent call last):
  File "", line 1, in 
ValueError: not enough values to unpack (expected 2, got 0)

I expect that tuple unpacking will work with the result of 
MagicMock.__divmod__(). There possible following options:

1. Return some constant value, e.g. (1, 0).

2. Return a pair of new MagicMock instances.

3. Define __divmod__ in terms of __floordiv__ and __mod__. This will 
automatically return a pair of MagicMock instances by default, but setting 
return values for __floordiv__ and __mod__ will affect the result of __divmod__.

What is more preferable?

--
components: Library (Lib)
messages: 325571
nosy: michael.foord, serhiy.storchaka
priority: normal
severity: normal
status: open
title: MagicMock.__divmod__ should return a pair
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34716] MagicMock.__divmod__ should return a pair

[Paul Ganssle]

Change by Paul Ganssle :


--
nosy: +p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[Paul Ganssle]

Change by Paul Ganssle :


--
nosy: +p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Reverting afde1c1a05c and 5633c4f342d fixes the issue.

--
nosy:  -p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +p-ganssle

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34676] Guarantee that divmod() and PyNumber_Divmod() return a 2-tuple

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
dependencies: +MagicMock.__divmod__ should return a pair

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32533] SSLSocket read/write thread-unsafety

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +8789

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17239] XML vulnerabilities in Python

[Ned Deily]

Ned Deily  added the comment:

We discussed this last week at the sprint.  Christian, it would be great if you 
could get this merged for 3.7 and possibly 3.6 in the next 24 hours.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +8790
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[STINNER Victor]

STINNER Victor  added the comment:

I wrote PR 9366 to fix the compilation of timemodule.c on FreeBSD.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34715] timemodule.c fails to compile on BSD

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 1fb399ba4e977e697d194769070316247237f68e by Victor Stinner in 
branch 'master':
bpo-34715: Revert "Simplify PyInit_timezone. (GH-9323)" (GH-9366)
https://github.com/python/cpython/commit/1fb399ba4e977e697d194769070316247237f68e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34587] test_socket: testCongestion() hangs on my Fedora 28

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 7484bdfd1e2e33fdd2c44dd4ffa044aacd495337 by Victor Stinner in 
branch 'master':
bpo-34587, test_socket: remove RDSTest.testCongestion() (GH-9277)
https://github.com/python/cpython/commit/7484bdfd1e2e33fdd2c44dd4ffa044aacd495337


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34587] test_socket: testCongestion() hangs on my Fedora 28

[miss-islington]

Change by miss-islington :


--
pull_requests: +8791

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34587] test_socket: testCongestion() hangs on my Fedora 28

[miss-islington]

Change by miss-islington :


--
pull_requests: +8792

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34717] docs: disable numbered sections for stdlib in html

[Yury Selivanov]

New submission from Yury Selivanov :

I'd like to remove the ":numbered:" option from Doc/library/index.rst TOC.  
Most standard library modules don't have extensive documentation, but some, for 
example asyncio, have.  For such modules, numbering makes title to contain too 
much noise.  Sphinx does not allow to opt-out from sections numbering if it's 
enabled on the top level.

--
assignee: docs@python
components: Documentation
files: now_2.png
messages: 325577
nosy: docs@python, yselivanov
priority: normal
severity: normal
status: open
title: docs: disable numbered sections for stdlib in html
type: enhancement
Added file: https://bugs.python.org/file47809/now_2.png

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com