[issue32595] Deque with iterable object as one object

2018-01-19 Thread Jonathan

Jonathan  added the comment:

Hello,

I dont know why but yesterday when i appended it behaved like extend.
I should sleep more.

2018-01-18 20:27 GMT+00:00 Raymond Hettinger :

>
> Raymond Hettinger  added the comment:
>
> Sorry Jonathan, this is the way the python containers work if they take an
> iterable input.  In the case of a str, it is not possible for us to know
> whether you mean for deque('abc') to go it as three arguments or as one.
>
> FWIW, if you don't what to put the single element in a list, the API
> provides the append() method for adding scalars and extend() method for
> adding iterables:
>
>d = deque()
>d.append('abc')
>d.extend('abc')
>
> Note that lists behave the same way.
>
> --
> resolution:  -> not a bug
> stage:  -> resolved
> status: open -> closed
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32551] Zipfile & directory execution in 3.5.4 also adds the parent directory to sys.path

2018-01-19 Thread Larry Hastings

Larry Hastings  added the comment:

If you're certain it isn't a security bug, then please downgrade it from 
release blocker.

I might permit a fix for it in 3.5.5 anyway, depending on how small it is, 
because nobody likes regressions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32225] Implement PEP 562: module __getattr__ and __dir__

2018-01-19 Thread INADA Naoki

INADA Naoki  added the comment:

I didn't notice this is implemented.
Congrats, Ivan!

BTW, would you update the PEP status to Final?

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32596] Lazy import concurrent.futures.process and thread

2018-01-19 Thread INADA Naoki

New submission from INADA Naoki :

Since PEP 562 is implemented, we can use lazy imports easily.

Asyncio uses concurrent.futures.Future and 
concurrent.futures.ThreadPoolExecutor,
but not concurrent.futures.ProcessPoolExecutor by default.

Since importing concurrent.futures.process is slow, I want to import it lazily.
And it make sense to import concurrent.futures.thread too, because it's very
easy when we start to use __getattr__ once.

Here is quick benchmark:


$ ./python -m perf command ./python -c 'import asyncio'  # patched
.
command: Mean +- std dev: 60.5 ms +- 0.1 ms
$ git stash
$ ./python -m perf command ./python -c 'import asyncio'  # original
.
command: Mean +- std dev: 74.3 ms +- 0.2 ms

--
components: Library (Lib)
messages: 310272
nosy: inada.naoki, levkivskyi, yselivanov
priority: normal
severity: normal
status: open
title: Lazy import concurrent.futures.process and thread
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32596] Lazy import concurrent.futures.process and thread

2018-01-19 Thread INADA Naoki

Change by INADA Naoki :


--
keywords: +patch
pull_requests: +5087
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32578] x86-64 Sierra 3.6: test_asyncio fails with timeout after 15 minutes

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

Oh wait, this issue is just a duplicate of bpo-32517.

--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> test_read_pty_output() of test_asyncio hangs on macOS 10.13.2 
(darwin 17.3.0)

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32517] test_read_pty_output() of test_asyncio hangs on macOS 10.13.2 (darwin 17.3.0)

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

bpo-32578 has been marked as a duplicate of this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32410] Implement loop.sock_sendfile method

2018-01-19 Thread Andrew Svetlov

Change by Andrew Svetlov :


--
pull_requests: +5088

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32311] Implement asyncio.create_task() shortcut

2018-01-19 Thread Andrew Svetlov

Change by Andrew Svetlov :


--
pull_requests: +5089

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32597] Bad detection of clang

2018-01-19 Thread bapt

New submission from bapt :

When building modules and trying to set the proper linker flags for the library 
runtime path, the detection of the compiler is wrong. the issue: 
https://bugs.python.org/issue20767 was showing the issue and imho badly fixed.

Clang behave like gcc regarding how it passes flags to the linker: -Wl,... so 
clang and gcc should be treated exactly the same way and no specific code 
should be added for FreeBSD

Here 
https://github.com/python/cpython/blob/master/Lib/distutils/unixccompiler.py#L237,
 it should accept both clang and gcc,

This block 
https://github.com/python/cpython/blob/master/Lib/distutils/unixccompiler.py#L230
 should be removed

The issue is not only on FreeBSD but on any system which compiler is clang. 
side note, the detection of gcc looks at first glance wrong, as on many system 
gcc is installed as cc sometime.

--
components: Distutils
messages: 310275
nosy: bapt, dstufft, eric.araujo
priority: normal
severity: normal
status: open
title: Bad detection of clang
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32597] Bad detection of clang

2018-01-19 Thread bapt

Change by bapt :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32517] test_read_pty_output() of test_asyncio hangs on macOS 10.13.2 (darwin 17.3.0)

2018-01-19 Thread Nathan Henrie

Nathan Henrie  added the comment:

I can reproduce on my local machine.

MacOS 10.13.2, trying to build 3.6.4. Waited for up to 6 hours for it to fail 
or finish, never does, just hangs at `test_asyncio`.

--
nosy: +n8henrie

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32598] Use autoconf to detect OpenSSL and libssl features

2018-01-19 Thread Christian Heimes

New submission from Christian Heimes :

Starting with #31399 Python will require some OpenSSL 1.0.2 features. The 
features are not available in LibreSSL yet. There is no easy way to detect the 
feature from setup.py. The inc_dir variable in setup.py does not reflect 
CPPFLAG. I tried "self.compiler.preprocess()" but run into more issues. For 
example prints to stderr in error cases.

https://www.gnu.org/software/autoconf-archive/ax_check_openssl.html makes it 
easy to check for working OpenSSL. It uses either pkg-config or falls back to 
manual detection in common locations.

Based on the M4 macro it is easy to check for features like working 
X509_VERIFY_PARAM_set1_host() function.

--
components: Extension Modules, Installation
messages: 310277
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: Use autoconf to detect OpenSSL and libssl features
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32598] Use autoconf to detect OpenSSL and libssl features

2018-01-19 Thread Christian Heimes

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +5090
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32410] Implement loop.sock_sendfile method

2018-01-19 Thread Giampaolo Rodola'

Change by Giampaolo Rodola' :


--
nosy: +giampaolo.rodola

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32599] Add dtrace hook for PyCFunction_Call

2018-01-19 Thread Frank Ch. Eigler

New submission from Frank Ch. Eigler :

Similar to https://bugs.python.org/issue31574, it would be useful the the 
interpreter allowed a tracing tool to hook the PyCFunction_Call() site, maybe 
via the C_TRACE() macro, kind of how it already does in  
_PyEval_EvalFrameDefault().  This would help diagnose problems in the C upcalls.

--
components: Interpreter Core
messages: 310278
nosy: fche
priority: normal
severity: normal
status: open
title: Add dtrace hook for PyCFunction_Call
type: performance

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32410] Implement loop.sock_sendfile method

2018-01-19 Thread Andrew Svetlov

Andrew Svetlov  added the comment:


New changeset 7464e87a6511d3626b04c9833a262a77b1f21e23 by Andrew Svetlov in 
branch 'master':
bpo-32410: Make SendfileNotAvailableError exception public (#5243)
https://github.com/python/cpython/commit/7464e87a6511d3626b04c9833a262a77b1f21e23


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32410] Implement loop.sock_sendfile method

2018-01-19 Thread Andrew Svetlov

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32590] Proposal: add an "ensure(arg)" builtin for parameter validation

2018-01-19 Thread Sylvain Marie

Sylvain Marie  added the comment:

Very much interested by the topic.

For reference I tried to summarize the status of inline type and value 
validation here: https://smarie.github.io/python-valid8/why_validation/

And I proposed a solution with a library here 
https://smarie.github.io/python-valid8 (with a somewhat smart handling of the 
ValueError / TypeError inheritance dilemma, for what's worth)

--
nosy: +smarie

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32600] SpooledTemporaryFile should implement IOBase

2018-01-19 Thread Greg Matous

New submission from Greg Matous :

SpooledTemporaryFile returns alternately a buffer or a TemporaryFile().

In either case it should behave like a file-thing.
However it doesn't implement certain properties in IOBase like readable, 
seekable which seems like should be available.

for example, on Ubuntu Linux with Python 3.6.2, 

reader = csv.reader(TextIOWrapper(csvfile), *args, **kwargs)

gives error AttributeError: 'SpooledTemporaryFile' object has no attribute 
'readable'
when csvfile is a werkzeug.datastructures.FileStorage object

see also:
https://stackoverflow.com/questions/47160211/why-doesnt-tempfile-spooledtemporaryfile-implement-readable-writable-seekable

--
components: Library (Lib)
messages: 310281
nosy: dutchmo
priority: normal
severity: normal
status: open
title: SpooledTemporaryFile should implement IOBase
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32601] PosixPathTest.test_expanduser fails in NixOS build sandbox

2018-01-19 Thread Anders Kaseorg

New submission from Anders Kaseorg :

PosixPathTest.test_expanduser fails in the NixOS build sandbox, where every 
user has home directory /, so it falls off the end of the for pwdent in 
pwd.getpwall() loop.

nixbld:x:30001:3:Nix build user:/:/noshell
nobody:x:65534:65534:Nobody:/:/noshell

==
FAIL: test_expanduser (__main__.PosixPathTest)
--
Traceback (most recent call last):
  File "/nix/store/mdak9gcy16dc536ws08rshyakd1l7srj-test_pathlib.py", line 
2162, in test_expanduser
self.assertEqual(p3.expanduser(), P(otherhome) / 'Documents')
AssertionError: PosixPath('/Documents') != PosixPath('Documents')

--
components: Tests
messages: 310282
nosy: andersk
priority: normal
pull_requests: 5091
severity: normal
status: open
title: PosixPathTest.test_expanduser fails in NixOS build sandbox
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32601] PosixPathTest.test_expanduser fails in NixOS build sandbox

2018-01-19 Thread R. David Murray

Change by R. David Murray :


--
nosy: +pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32545] Unable to install Python 3.7.0a4 on Windows 10 - Error 0x80070643: Failed to install MSI package.

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

"Other installers work without issue?"  Is this a comment about other 
installers for other versions on your machine?  Or a question about other 
people using the same binary on other machines?

Using the same python-3.7.0a4-amd64.exe binary, I successfully upgraded an 
existing 3.7.0a3 all-users installation in a custom C: directory on Win-10/64.  
If I read the log correctly, you tried a single user installation in the 
standard location.

The first error indication I see in the log is this line:
MSI (s) (BC:04) [20:15:48:208]: Note: 1: 2205 2:  3: Error 

'Error 0x80070643' is a generic installation failure that can occur either 
during Windows update or 3rd party program installation.  I searched and one of 
the top hits was
  https://www.drivereasy.com/knowledge/fix-error-0x80070643-on-windows/
You could try the 3 generic suggestions under
  2) Fix the 0x80070643 error during a program installation
(The first is restart your machine, if you have not already.)
You could also run the system scan described in section '1)'.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32602] Test ECDSA and dual mode context

2018-01-19 Thread Christian Heimes

New submission from Christian Heimes :

OpenSSL supports ECDSA certs and dual EC/RSA mode context, e.g. a context a RSA 
and an ECDSA key/cert pair loaded at the same time. Python shoulkd verify that 
ECDSA certs are working properly.

--
assignee: christian.heimes
components: SSL, Tests
messages: 310284
nosy: christian.heimes
priority: normal
severity: normal
status: open
title: Test ECDSA and dual mode context
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32602] Test ECDSA and dual mode context

2018-01-19 Thread Christian Heimes

Change by Christian Heimes :


--
keywords: +patch
pull_requests: +5092
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32553] venv says to use python3 which does not exist in 3.6.4

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

As far as I know, Windows binaries have only been named python.exe or 
pythonw.exe.  Before 3.5, I believe, "C:\Pythonxy", where x,y were major,minor, 
*was* the default Windows installation directory.  'Python35' must have been 
the result of a mechanical update.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32557] allow shutil.disk_usage to take a file path on Windows also

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

Seems sensible to me.

--
nosy: +terry.reedy
title: allow shutil.disk_usage to take a file path -> allow shutil.disk_usage 
to take a file path on Windows also

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32566] Not able to run Python 3.6 on Windows

2018-01-19 Thread Terry J. Reedy

Change by Terry J. Reedy :


--
title: Not able to open Python IDLE -> Not able to run Python 3.6 on Windows

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32567] Venv’s config file (pyvenv.cfg) should be compatible with ConfigParser

2018-01-19 Thread Terry J. Reedy

Change by Terry J. Reedy :


--
nosy: +vinay.sajip
versions:  -Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32572] Add the ftplib option, overrides the IP address.

2018-01-19 Thread Terry J. Reedy

Change by Terry J. Reedy :


--
nosy: +giampaolo.rodola
versions:  -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32573] All sys attributes (.argv, ...) should exist in embedded environments

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

Pedro: David and Nick are proposing initializing sys.argv to [] rather than 
[''] for embedded interpreters.  This would say 'running embedded'.  The .argv 
entry would need an additional sentence.

I like Nick's proposal, except that _xoptions should be {}.  Documenting 
absence should only be a fallback is there is no sensible default.

--
components: +Library (Lib) -Documentation
nosy: +terry.reedy
title: sys.argv documentation should include caveat for embedded environments 
-> All sys attributes (.argv, ...) should exist in embedded environments
versions: +Python 3.8 -Python 2.7, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32582] chr raises OverflowError

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

The message I get on Windows is 
OverflowError: Python int too large to convert to C long

Given that the exception type is documented, making this a clear bug, I would 
be tempted to fix in 3.6 also.  But your decision.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32583] Crash during decoding using UTF-16/32 and custom error handler

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

As written, decode_crash.py crashes on Windows also.  Passing 'replace' instead 
of 'w3lib_replace' results in no crash and lots of boxes and blanks.

--
nosy: +benjamin.peterson, ezio.melotti, lemburg, terry.reedy, vstinner
stage:  -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32600] SpooledTemporaryFile should implement IOBase

2018-01-19 Thread Martin Panter

Martin Panter  added the comment:

There is apparently some work done on this already in Issue 26175.

--
nosy: +martin.panter
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Fully implement IOBase abstract on SpooledTemporaryFile

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-19 Thread Guido van Rossum

Guido van Rossum  added the comment:

I won't object. It makes sense that the implementation of __annotations__ 
should be low-key.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue29708] support reproducible Python builds

2018-01-19 Thread Brett Cannon

Brett Cannon  added the comment:

Since Barry chose an option that wasn't listed, I'm planning on accepting 
Bernhard's https://github.com/python/cpython/pull/5200 at some point next week 
barring any new, unique objections.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32585] Add ttk::spinbox to tkinter.ttk

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

As said in review, I would like to see this added unless there is a good reason 
for the omission. Still needed are patches for doc and tests.

--
nosy: +serhiy.storchaka, terry.reedy
stage: patch review -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32589] Statistics as a result from timeit

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

I am also skeptical that this will do more good than harm (by adding time and 
fostering mis-impressions).  (This might better have started as a discussion on 
python-ideas list.)

--
nosy: +terry.reedy, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32592] Drop support of Windows Vista in Python 3.7

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

I believe that PEP 11 originally said, or should have said "3.6 supports 
Windows Vista and newer."  I believe 3.5 supports XP, so it should be "please 
install Python 3.4".

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32592] Drop support of Windows Vista in Python 3.7

2018-01-19 Thread Terry J. Reedy

Change by Terry J. Reedy :


--
Removed message: https://bugs.python.org/msg310295

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32592] Drop support of Windows Vista in Python 3.7

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

I believe that PEP 11 originally said, or should have said "3.6 supports 
Windows Vista and newer."  I believe 3.5 supports XP, so it should be "please 
install Python 3.5".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32592] Drop support of Windows Vista in Python 3.7

2018-01-19 Thread Zachary Ware

Zachary Ware  added the comment:

3.4 was the last version to support XP.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue26175] Fully implement IOBase abstract on SpooledTemporaryFile

2018-01-19 Thread Martin Panter

Martin Panter  added the comment:

It may also be worth implementing BufferedIOBase and TextIOBase. (It seems 
buffering=0 isn’t reliable, e.g. rollover with limited disk space, so it may 
not be worth implementing RawIOBase.)

To implement BufferedIOBase, “read1” and “readinto1” should be added.

To implement TextIOBase, “errors” should be added, and “newlines” should only 
list translated newlines, not the “newline” constructor argument.

Technically, “detach” should also be implemented, although it doesn’t have to 
do anything useful.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

2018-01-19 Thread Yury Selivanov

Yury Selivanov  added the comment:

> I think the simplest thing is probably to write the warning code in Python 
> and stash it in Lib/_corohelper.py or something.

I'd put the helper that accepts a list of traceback-like tuples and emits a 
warning in warnings.py and a C function to call it in warnings.c.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32599] Add dtrace hook for PyCFunction_Call

2018-01-19 Thread Pablo Galindo Salgado

Change by Pablo Galindo Salgado :


--
type: performance -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32603] Deprecation warning on strings used in re module

2018-01-19 Thread Cheryl Sabella

New submission from Cheryl Sabella :

I apologize if this is a duplicate question, but I couldn't find another issue 
about this.  It's hard to search on 're'.

In 3.7, I get a deprecation warning when using a regular string with re escape 
characters:
>>> s = '123abcd'
>>> re.findall('\d', s)
:1: DeprecationWarning: invalid escape sequence \d
['1', '2', '3']

Of course, this works:
>>> s = '123abcd'
>>> re.findall(r'\d', s)
['1', '2', '3']


I know that the documentation strongly suggests using raw strings with re, but 
I didn't see anywhere mentioning that it would be a requirement.  I would think 
this would break a lot of 're' code.

--
assignee: docs@python
components: Documentation
messages: 310300
nosy: csabella, docs@python
priority: normal
severity: normal
status: open
title: Deprecation warning on strings used in re module
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32603] Deprecation warning on strings used in re module

2018-01-19 Thread Zachary Ware

Zachary Ware  added the comment:

This is actually combination of a deprecation in in 3.6's string literals (not 
related to the re module), documented here: 
https://docs.python.org/dev/whatsnew/3.6.html#deprecated-python-behavior (see 
issue27364) and showing DeprecationWarning in the REPL by default in 3.7 (PEP 
565).

--
nosy: +zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32589] Statistics as a result from timeit

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

I suggest you to take a look at my perf project which has a timeit function and 
command. perf has a different design: it stores all values, and so many 
statisticals functions can be used. By the way, it does include most common 
statistical functions in its API, and provide a few more in the CLI.

The timeit module of the stdlib computes 5 values by default... I'm not sure 
that it's revelant to compute the standard deviation only on 5 values. perf 
computes 60 values and computes then in 20 different processes (run 
sequentially). With 60 values, I expect that the computing statistics makes 
more sense.

About the PR itself, I dislike providing a fixed list of statistical functions. 
For example, what if someone needs the geometric mean? What if you want to 
count outliers? etc.

If someone really wants timeit to evolve, I suggest to return all values rather 
than only the minimum: as repeat() does.

By the way, using the minimum is IMHO a bad idea, but I already proposed to 
change timeit, and my change was rejected because of the backward compatibility.

I decided to stop trying to convince other core developers and leave the timeit 
module unchanged, with all its bugs. And instead, I suggest to everyone to stop 
using it (PyPy also warns users and asks to use perf instead), and use perf 
timeit instead...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32592] Drop support of Windows Vista in Python 3.7

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

Terry: see my notes about platforms suported by Python.
http://vstinner.readthedocs.io/cpython.html#supported-platforms

The PEP 11 doesn't want to have an explicit list of supported Windows versions, 
but I'm unable to *guess* which Windows version is supported by which Python 
version, so I wrote my own doc...

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32573] All sys attributes (.argv, ...) should exist in embedded environments

2018-01-19 Thread Pedro

Pedro  added the comment:

I agree that an empty list, instead of a list with an empty string, makes more 
sense. Leaving _xoptions as {} would be the same as when it runs non-embedded 
without any -X arguments, but I guess there's no way of making {} any more 
empty.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32573] All sys attributes (.argv, ...) should exist in embedded environments

2018-01-19 Thread STINNER Victor

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32603] Deprecation warning on strings used in re module

2018-01-19 Thread Cheryl Sabella

Cheryl Sabella  added the comment:

Thank you, Zach.

There was some mention of regular expressions in #27364, but I'm still 
wondering if the DeprecationWarning should be mentioned on the re doc page and 
if there should be stronger language about using raw strings.

Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25910] Fixing links in documentation

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:


New changeset 338cd83c5dceaed785f5bf613e2122f871908e2a by Victor Stinner 
(Sanyam Khurana) in branch 'master':
bpo-25910: Link redirections in docs (#1933)
https://github.com/python/cpython/commit/338cd83c5dceaed785f5bf613e2122f871908e2a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25910] Fixing links in documentation

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

Can we now close this old issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-19 Thread Barry A. Warsaw

Change by Barry A. Warsaw :


--
pull_requests: +5093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32592] Drop support of Windows Vista in Python 3.7

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

I personally think it was a mistake to stop being explicit about Windows 
support in PEP 11.  The rationale was to avoid having to update it.  But it is 
updated for other systems; an explicit list is needed somewhere (as illustrated 
by my memory lapse; and PEP 11 is the most obvious and discoverable place.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32573] All sys attributes (.argv, ...) should exist in embedded environments

2018-01-19 Thread Terry J. Reedy

Terry J. Reedy  added the comment:

For detecting 'embedded', it is enough that only one documented attribute value 
be unique to embedded situations.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32596] Lazy import concurrent.futures.process and thread

2018-01-19 Thread INADA Naoki

INADA Naoki  added the comment:


New changeset 6690bb9f17d34eb3dec0aca8919d8d27d6c3c452 by INADA Naoki in branch 
'master':
bpo-32596: Lazy import concurrent.futures.process and thread (GH-5241)
https://github.com/python/cpython/commit/6690bb9f17d34eb3dec0aca8919d8d27d6c3c452


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32429] Outdated Modules/Setup warning is invisible

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

> I'm ok with turning the warning into an error. Does anyone object here?

Please don't convert the warning to an error. Usually, I ignore the warning and 
"make" produces a working ./python binary anyway.

It's common that I get the warning when using git bisect, since it updates 
Modules/Setup.dist.

If you want to make it an error, I would prefer to have an option to "ignore 
the warning", like always copy Modules/Setup.dist to Modules/Setup (if it's 
detected as outdated).

I like Xavier's proposal (msg309078): only create Modules/Setup if you want to 
customize it, otherwise use Modules/Setup.dist. I *never* modified 
Modules/Setup, I don't even know its purpose, whereas it bugs me frequently 
with it's annoying warning...

It seems like I would prefer to see bpo-32430 fixed.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32430] Simplify Modules/Setup{,.dist,.local}

2018-01-19 Thread STINNER Victor

STINNER Victor  added the comment:

I like the idea of removing the Modules/Setup.dist => Modules/Setup copy which 
removes immediately the annoying warning (bpo-32429).

> ... that one can modify and commit

I'm not sure about the "commit" part. I see Modules/Setup as a configuration 
file. Python provides a default configuration, fine.

Why not adding an option in Makefile or configure to allow to specify a 
different path to a custom Setup file?

./configure --setup-file=google_uber_cool_setup_file && make

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32225] Implement PEP 562: module __getattr__ and __dir__

2018-01-19 Thread Ivan Levkivskyi

Ivan Levkivskyi  added the comment:

> BTW, would you update the PEP status to Final?

Good point, here is the PR https://github.com/python/peps/pull/554

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32604] Expose the subinterpreters C-API in Python for testing use.

2018-01-19 Thread Eric Snow

New submission from Eric Snow :

In the interest of getting something landed for 3.7, so we can start using it 
in tests, I'm putting up a patch for a low-level interpreters module.  In some 
ways this is a precursor for issue #30439, which will add a proper public 
stdlib module in 3.8.

The module I'm adding draws from the ideas in PEP 554 (particularly for 
channels).  Consequently, this will also give us an opportunity to try out some 
of the semantics from the PEP to give us better ideas for 3.8.

I expect to have some follow-on patches to facilitate simpler use in tests.  
This patch is big enough already. :)

--
assignee: eric.snow
components: Interpreter Core
messages: 310314
nosy: eric.snow, ncoghlan, yselivanov
priority: normal
severity: normal
stage: needs patch
status: open
title: Expose the subinterpreters C-API in Python for testing use.
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue30439] Expose the subinterpreters C-API in the stdlib.

2018-01-19 Thread Eric Snow

Eric Snow  added the comment:

FYI, I'm working on a low-level patch for use in the test suite for 3.7.  See 
issue #32604.

--
versions: +Python 3.8 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32604] Expose the subinterpreters C-API in Python for testing use.

2018-01-19 Thread Eric Snow

Eric Snow  added the comment:

@Ned, it may be a little tight to land this given the time left before beta 1.  
However, this is meant as a tool for us to use in the test suite (particularly 
to test the subinterpreter C-API).  So I'm arguing that, if necessary, it would 
still be okay to land this after the feature freeze.  (I'm still hoping to get 
this in before the cutoff.)  What do you think?

--
nosy: +ned.deily, steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32604] Expose the subinterpreters C-API in Python for testing use.

2018-01-19 Thread Eric Snow

Eric Snow  added the comment:

@Nick, I may make the name change you suggested in issue #30439 
("_subinterpreters").

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32604] Expose the subinterpreters C-API in Python for testing use.

2018-01-19 Thread Eric Snow

Change by Eric Snow :


--
keywords: +patch
pull_requests: +5094
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32604] Expose the subinterpreters C-API in Python for testing use.

2018-01-19 Thread Eric Snow

Eric Snow  added the comment:

FYI, there are a few things I need to clean up in the PR.  However, I expect 
that those changes will be minor relative to the the whole patch, so I wanted 
to get the ball rolling on a review. :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32551] Zipfile & directory execution in 3.5.4 also adds the parent directory to sys.path

2018-01-19 Thread Nick Coghlan

Nick Coghlan  added the comment:

Thanks Larry - I've reduced the priority accordingly.

While the NEWS entry sounds a bit complicated, the actual fix is nicely 
self-contained: it's all within Modules/main.c, and relates to how that 
manipulates sys.argv[0] during startup.

Historically, the code would put a potentially incorrect entry into 
sys.path[0], then amend it later (and that amendment step could sometimes do 
the wrong thing), but after this patch, it stores the candidate entry in a 
local C variable and adds it to the path only after it knows it's correct to do 
so.

The backport also comes with test cases to ensure everything's working as we 
expect, and this is the code that 3.6 has been using since its release.

--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25910] How many "critical"-level open issues are there?

2018-01-19 Thread Schmehl Bastian

Change by Schmehl Bastian :


--
title: Fixing links in documentation -> How many "critical"-level open issues 
are there?
versions: +Python 2.7 -Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32028] Syntactically wrong suggestions by the new custom print statement error message

2018-01-19 Thread Nick Coghlan

Nick Coghlan  added the comment:


New changeset d57f26c753dce61f72b52b96db3a3253d9f2fc3e by Nick Coghlan (Sanyam 
Khurana) in branch 'master':
bpo-32028: Fix suggestions for indented print statements (GH-4688)
https://github.com/python/cpython/commit/d57f26c753dce61f72b52b96db3a3253d9f2fc3e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32028] Syntactically wrong suggestions by the new custom print statement error message

2018-01-19 Thread Roundup Robot

Change by Roundup Robot :


--
pull_requests: +5096

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32596] Lazy import concurrent.futures.process and thread

2018-01-19 Thread INADA Naoki

Change by INADA Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32028] Syntactically wrong suggestions by the new custom print statement error message

2018-01-19 Thread Nick Coghlan

Nick Coghlan  added the comment:


New changeset 4002d5dbf4c058bbf2462f9f5dea057956d1caff by Nick Coghlan (Miss 
Islington (bot)) in branch '3.6':
[3.6] bpo-32028: Fix suggestions for indented print statements (GH-5249)
https://github.com/python/cpython/commit/4002d5dbf4c058bbf2462f9f5dea057956d1caff


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32028] Syntactically wrong suggestions by the new custom print statement error message

2018-01-19 Thread Nick Coghlan

Nick Coghlan  added the comment:

Thanks CuriousLearner for the PR and mdraw for the original issue report!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32603] Deprecation warning on strings used in re module

2018-01-19 Thread Steven D'Aprano

Steven D'Aprano  added the comment:

I agree with Cheryl that it would be a good idea to mention this change in the 
re docs, since regexes are especially likely to run into this issue.

--
nosy: +steven.daprano

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25910] How many "critical"-level open issues are there?

2018-01-19 Thread Guido van Rossum

Guido van Rossum  added the comment:

Who is Basti5611 (Schmehl Bastian), why do they have permission to change issue 
titles, and why did they change this issue title?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32605] Should we really hide unawaited coroutine warnings when an exception is pending?

2018-01-19 Thread Nathaniel Smith

New submission from Nathaniel Smith :

There's a curious bit of code in genobject.c:_PyGen_Finalize:

if (!error_value) {
PyErr_WarnFormat(PyExc_RuntimeWarning, 1,
 "coroutine '%.50S' was never awaited",
 gen->gi_qualname);
}

Obviously this is the code that issues "coroutine ... was never awaited" 
warnings. That's not so curious. What's curious is the 'if' statement: what it 
does is suppress this warning if -- at the moment the coroutine object was GCed 
-- there is an active exception propagating.

This was added by bpo-27968, apparently as a way to hide some warnings in 
test_coroutine.py. This justification seems dubious to me, though, and there 
doesn't seem to have been much/any scrutiny of this at the time. We can 
certainly write those tests more carefully, so that they don't issue warnings 
-- e.g. by using 'with closing(corofn()) as coro: ...'. And this has a much 
broader effect than on just those tests. For example, say we accidentally write:

   def foo():
   len(corofn())  # should be len(await corofn())

we'll get an error that was caused by the coroutine not being awaited -- and we 
*won't* get the usual warning message explaining this, because the coroutine 
object is GCed while the exception propagates. Or, if an unawaited coroutine 
happens to get stuck in a reference cycle, then it's a matter of luck whether 
the message gets printed, depending on when exactly the cycle collector happens 
to trigger.

I guess in most cases where someone forgets an await and it causes errors, the 
coroutine happens to get stashed into a local variable, so it can't be GCed 
until after the exception is no longer active. And if another exception becomes 
active in the mean time, probably it will capture the first one as __context__, 
so that also keeps the coroutine alive past the time when the warning would be 
suppressed. So maybe this isn't a huge issue in practice? But this all feels 
very finicky and accidental, so I wanted to raise the issue for discussion.

--
components: asyncio
messages: 310325
nosy: asvetlov, benjamin.peterson, giampaolo.rodola, njs, yselivanov
priority: normal
severity: normal
status: open
title: Should we really hide unawaited coroutine warnings when an exception is 
pending?
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25910] How many "critical"-level open issues are there?

2018-01-19 Thread Sanyam Khurana

Sanyam Khurana  added the comment:

Victor, there is just one last thing to do in here.

All the links pointing to Github (that are build automatically) are permanently 
redirected from https://github.com/python/cpython/tree/master/* to 
https://github.com/python/cpython/blob/master/*

I will issue a separate PR for it, and then we're good to close this issue.

PS: Guido, I'm not sure about the title change either.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32567] Venv’s config file (pyvenv.cfg) should be compatible with ConfigParser

2018-01-19 Thread Vinay Sajip

Vinay Sajip  added the comment:

"Seems wrong to me" is not a sufficient reason for changing things in this 
area. The pyvenv.cfg file is intended to be parsed by the interpreter's C code 
as well as by Python code, so its format needs to be kept as simple as possible.

--
resolution:  -> rejected
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue25910] Fixing links in documentation

2018-01-19 Thread Serhiy Storchaka

Change by Serhiy Storchaka :


--
title: How many "critical"-level open issues are there? -> Fixing links in 
documentation
versions: +Python 3.7 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32585] Add ttk::spinbox to tkinter.ttk

2018-01-19 Thread Serhiy Storchaka

Serhiy Storchaka  added the comment:

Needed tests, documentation, etc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32550] STORE_ANNOTATION bytecode is unnecessary and can be removed.

2018-01-19 Thread Serhiy Storchaka

Serhiy Storchaka  added the comment:

> This PR moves the constant for the name from `co_names` to `co_consts`. There 
> is no duplication.

But if there is an initializer, the name is left in `co_names` too.

I don't think this (as well as possible performance difference) is important. 
My only concerns are about subtle behavior differences.

For example, is the name always interned (even if long or non-ASCII)? Does any 
code depend on interning keys in __annotations__? (There is a code that depends 
on interning keys in type.__dict__).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com