[issue12129] Document Object Model API - validation

[Pradeep]

Pradeep added the comment:

xml minidom.py needs extra validation in setAttributes for certain special 
characters depending on the attribute name. Attribute values cannot have 
special characters like <,> and cant be nested as described in the example below

element01 = doc.createElement('element01')
element01.setAttribute('attribute', 
"script>")
doc.firstChild.appendChild(element01)

script shouldn't be allowed as a value for an attribute and I feel it should 
throw an exception (Value Exception) and as described above <,> shouldn't be 
allowed as attributes are more like key-value pairs. Could someone tell me if 
this is right? If it is, then minidom.py needs this extra level of validation 
for the same

--
nosy: +pdeep5693

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29051] Improve error reporting involving f-strings (PEP 498)

[Chi Hsuan Yen]

New submission from Chi Hsuan Yen:

Here are the two examples I found confusing when playing with f-strings. The 
first one involves with a NameError:

$ cat test2
f'''
{
FOO
}
'''

$ python3.7m test2
Traceback (most recent call last):
  File "test2", line 5, in 
'''
NameError: name 'FOO' is not defined


It would be better if the error reporter points to the actual line of the error:

$ python3.7m test2
Traceback (most recent call last):
  File "test2", line 3, in 
FOO
NameError: name 'FOO' is not defined

The second one involves a SyntaxError:

$ cat test2 
f'''
{
a b c
}
'''

$ python3.7m test2
  File "", line 2
a b c
  ^
SyntaxError: invalid syntax

It would be better if the line number is relative to the file instead of the 
expression in f-strings:

$ python3.7m test2
  File "test2", line 3
a b c
  ^
SyntaxError: invalid syntax

By the way, external checkers like pyflakes also suffers. They rely on ASTs. 
Nodes in f-strings have their lineno relative to the {...} expression instead 
of the whole code string. For example:

import ast

code = '''
f'{LOL}'
'''

for node in ast.walk(ast.parse(code, "", "exec")):
if isinstance(node, ast.Name):
print(node.lineno)


Prints 1 instead of 2.

Another by the way, ruby reports correct line numbers:

$ cat test3 
"
#{
FOO
}
"

$ ruby test3 
test3:3:in `': uninitialized constant FOO (NameError)


$ cat test3 
"
#{
@@
}
"

$ ruby test3
test3:3: `@@' without identifiers is not allowed as a class variable name
test3:3: syntax error, unexpected end-of-input


Added the author and the primary reviewer of issue24965.

--
components: Interpreter Core
messages: 283874
nosy: Chi Hsuan Yen, eric.smith, martin.panter
priority: normal
severity: normal
status: open
title: Improve error reporting involving f-strings (PEP 498)
type: enhancement
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29052] Detect Windows platform 32bit/64bit automatically

[Karsten Tinnefeld]

New submission from Karsten Tinnefeld:

When navigating https://www.python.org/ with a browser, in the main menu 
fly-out Downloads/Download for Windows it suggests to download the 32 bit 
version of the current 2.x and 3.x releases (leaving out the information that 
the buttons provide 32 bit binaries).

Further, https://www.python.org/downloads/ repeats this pattern in its header 
area "Download the latest version for Windows".

May I suggest that, depending on the User-Agent header, the menu offers 64 bit 
versions of the interpreter and tools package by default in case the browser 
suggests it is running on a 64 bit platform?

According to own tests and 
http://www.useragentstring.com/pages/useragentstring.php, this should be 
possible with a regexp like '(WOW|x)64' on at least IE, FF, Chrome and Edge.

--
assignee: docs@python
components: Documentation
messages: 283875
nosy: Karsten Tinnefeld, docs@python
priority: normal
severity: normal
status: open
title: Detect Windows platform 32bit/64bit automatically
type: enhancement
versions: Python 2.7, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29052] Detect Windows platform 32bit/64bit automatically

[Berker Peksag]

Berker Peksag added the comment:

Thanks, it looks like a reasonable request to me, but the issue tracker for 
python.org is located at https://github.com/python/pythondotorg/issues Please 
open a new issue there (or send a pull request)

--
nosy: +berker.peksag
resolution:  -> third party
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29018] Misinformation when showing how slices work in The Tutorial

[issuefinder]

issuefinder added the comment:

You seem to be right.
Sorry about the incovenience.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14483] inspect.getsource fails to read a file of only comments

[Pam McA'Nulty]

Changes by Pam McA'Nulty :


--
nosy: +Pam.McANulty

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29051] Improve error reporting involving f-strings (PEP 498)

[R. David Murray]

R. David Murray added the comment:

These are not problems with f-strings in particular, they are problems in 
general with the way python parsing and error reporting happens.  The second is 
presumably (I haven't gotten around to understanding how f-strings work under 
the hood) an example of error reporting from a separately evaled string.

Improvements in this area are certainly welcome.  There is an open issue 
relevant to your first example, issue 12458.  I'm sure that f-strings 
complicate the solution at least slightly, but I think there are more 
fundamental pre-requisites to be addressed first in solving it.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29051] Improve error reporting involving f-strings (PEP 498)

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
dependencies: +Tracebacks should contain the first line of continuation lines

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29053] Implement >From_ decoding on input from mbox

[bpoaugust]

New submission from bpoaugust:

The email package implements mboxo From_ mangling on output by default.

However there is no provision to unmangle >From_ on input.

This means that it's not possible to import mboxo files correctly.

--
components: email
messages: 283879
nosy: barry, bpoaugust, r.david.murray
priority: normal
severity: normal
status: open
title: Implement >From_ decoding on input from mbox
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

[Cornelius Diekmann]

New submission from Cornelius Diekmann:

My OS: Debian GNU/Linux 8.6 (jessie)
Python 3.4.2
pty.py from Python-3.5.2/Lib (pty.py is just a tiny, portable python file which 
did not see many changes)


Bug Report

Steps to Reproduce:

I wrote a very simple python remote shell:

#!/usr/bin/env python3
import pty
pty.spawn('/bin/sh')


It can be run in a terminal (call it TermA) with `nc -e 
./myfancypythonremoteshell.py -l -p 6699`
In a different terminal (call it TermB), I connect to my fancy remote shell 
with `nc 127.0.0.1 6699`.
The shell works fine. In TermB, I quit by pressing ctrl+c.

Observed Behavior: In TermA, the nc process, the python process, and the 
spawned /bin/sh still exist. They still occupy TermA.

Expected Behavior: The client in TermB has disconnected, /bin/sh in TermA can 
no longer read anything from stdin and it should close down. Ultimately, in 
TermA, nc should have exited successfully.

Fix: End the _copy loop in pty.py once EOF in STDIN is reached. Everything 
shuts itself down automatically. I included a small patch to demonstrate this 
behavior.

This patch is not meant to go straight into production. I have not verified if 
this behavior somehow breaks other use cases. This bug report is meant to 
document exactly one specific use case and supply exactly one line of code 
change for it.

This issue is related to issue26228. Actually, it is complementary. issue26228 
wants to return if master_fd is EOF, this issue wants to return if stdin is 
EOF. Both behaviors together looks good to me. By the way, I hacked a hacky 
`assert False` into my patch as a placeholder for issue26228's proper handling 
of exec failures at that part of the code.

I suggest to combine the patches of this issue and issue26228.

--
components: Library (Lib)
files: pty.patch
keywords: patch
messages: 283880
nosy: Cornelius Diekmann, martin.panter
priority: normal
severity: normal
status: open
title: pty.py: pty.spawn hangs after client disconnect over nc (netcat)
type: enhancement
versions: Python 3.4, Python 3.5
Added file: http://bugs.python.org/file46006/pty.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14483] inspect.getsource fails to read a file of only comments

[Sean Grider]

Sean Grider added the comment:

I had forgotten all about this bug until I saw an email from Pam today.

The appears to still be some delay.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29053] Implement >From_ decoding on input from mbox

[bpoaugust]

bpoaugust added the comment:

Is there any way to override the current behaviour?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29053] Implement >From_ decoding on input from mbox

[R. David Murray]

R. David Murray added the comment:

Not easily.  Making the feedparser more pluggable is on my wish list, but at 
this point someone would have to fund me for work on the email package before 
I'd be able to even clear the backlog to think about it :)

I'd say accepting this as a new feature is a no-brainer, if you want to work on 
a patch.  Make enabling it a Policy option that defaults to the current 
behavior.

--
stage:  -> needs patch
type: behavior -> enhancement
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14483] inspect.getsource fails to read a file of only comments

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29055] random.choice on empty sequence should hide previous exception [patch]

[then0rTh]

New submission from then0rTh:

Passing empty sequence to random.choice function leads to:


Traceback (most recent call last):
  ...
ValueError: number of bits must be greater than zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  ...
IndexError: Cannot choose from an empty sequence


* the ValueError doesn't add any useful information, only bloats stderr
* the "During handling" line indicates that something went wrong inside 
random.py


This patch uses `raise x from None` to hide the ValueError, resulting in much 
cleaner output.

-Tested on Python 3.7.0a0

--
components: Library (Lib)
files: random_choice_errmsg.patch
keywords: patch
messages: 283884
nosy: mark.dickinson, rhettinger, then0rTh
priority: normal
severity: normal
status: open
title: random.choice on empty sequence should hide previous exception [patch]
type: behavior
versions: Python 3.7
Added file: http://bugs.python.org/file46007/random_choice_errmsg.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29026] time.time() documentation should mention UTC timezone

[STINNER Victor]

STINNER Victor added the comment:

Another suggestion: mention localtime() and gmtime() in time() documentation to 
explain how to convert such timestamp to a more common date format.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29055] random.choice on empty sequence should hide previous exception [patch]

[Josh Rosenberg]

Josh Rosenberg added the comment:

Seems reasonable to me.

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29026] time.time() documentation should mention UTC timezone

[Eric Appelt]

Eric Appelt added the comment:

I had some checks performed on a Windows platform using the following snippet:

# valid for 2016
import time
def check():
t = time.gmtime()
print(46*86400*365 + 11*86400 + (t.tm_yday-1)*86400 + t.tm_hour*3600 + 
t.tm_min*60 + t.tm_sec)
print(time.time())
print(time.gmtime(0))
check()

This ensures that the time since the epoch is counted excluding leap seconds if 
the first two lines of output are approximately the same (to nearest second), 
and finally that the epoch is the Unix epoch.

On Python 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 07:18:10) [MSC v.1900 32 bit 
(Intel)] on win32 I see:

1482502941
1482502941.9609053
time.struct_time(tm_year=1970, tm_mon=1, tm_mday=1, tm_hour=0, tm_min=0, 
tm_sec=0, tm_wday=3, tm_yday=1, tm_isdst=0)

Unless there is major variation among windows versions on how FILETIMEs are 
calculated and the results of basic system calls, I feel fairly confident now 
that the calculation of time since the epoch in CPython is the same on Windows 
as it is in POSIX-compliant platforms.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29056] logging.Formatter doesn't respect more than one formatException()

[Dan Passaro]

New submission from Dan Passaro:

If two formatters maintain the default implementation of Formatter.format(), but
provide custom behavior for Formatter.formatException(), whichever
formatException() is called first and returns something truthy is the only
formatException() that is used.

This is due to a misplaced check for a cached value.  logging.Formatter.format()
sets (maybe monkey-patches?) an exc_text attribute onto the record it receives,
with a comment indicating it's to prevent needlessly re-formatting the
exception.  If this value is set, it avoids the call to formatException() and
just returns the exc_text attribute.

If this check for exc_text is moved to Formatter.formatException() instead, I am
sure this behavior will be fixed. I.e. Formatter.formatException()'s first few
lines turn into something like:

if record.exc_text:
return record.exc_text
sio = cString.StringIO()
# ... and so on (rest of current impl)

This way the default implementation still caches, and subclass implementation
changes still have an effect.

The only problem here is this method has no access to the record object. It's
not clear to me what is the best way to solve this.  I don't have experience
making changes to Python or projects of this size but these are my thoughts:

* Since the formatException() API is public it shouldn't be changed (e.g. to add
  record)
* Removing the caching might have a significant performance penalty for certain
  users, although I haven't really tested it
* Users who care can copy format() source code into their subclasses and remove
  the caching code. Alternatively, a class-level flag can be added to determine
  whether the cache should be used. Documentation in formatException() is added
  to indicate this issue. This seems like a very poor solution to me.
* Adding @functools.lru_cache() in front of the base implementation (after
  e.g. making it a staticmethod() or something like that) seems clean from a
  code POV but could negatively impact memory usage, and might also negatively
  impact CPU usage if the cache isn't effective.
* Adding `self._record = record` to format(), before the call to
  formatException(), probably has the lowest performance impact and is the
  change I'd lean towards personally, but seems like bad coding practice.

I've attached a script that demonstrates the buggy behavior. If someone can
weigh in on what a good strategy is to resolve this issue I'd be glad to supply
a patch.

--
files: logging_formatter_exc_bug.py
messages: 283888
nosy: daniel.passaro
priority: normal
severity: normal
status: open
title: logging.Formatter doesn't respect more than one formatException()
type: behavior
versions: Python 3.6
Added file: http://bugs.python.org/file46008/logging_formatter_exc_bug.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Pam McA'Nulty]

New submission from Pam McA'Nulty:

make failed on Mac OS X including sys/random.h

It looks to be caused by this commit: 
https://github.com/python/cpython/commit/1958527a2c5dda766b1917ab563622434b3dad0d

Restoring the removed ifdefs solves the problem (see github PR)

Official patch to follow


Failure message.
```
In file included from Python/random.c:16:
/usr/include/sys/random.h:37:32: error: unknown type name 'u_int'
void read_random(void* buffer, u_int numBytes);
   ^
/usr/include/sys/random.h:38:33: error: unknown type name 'u_int'
void read_frandom(void* buffer, u_int numBytes);
^
/usr/include/sys/random.h:39:33: error: unknown type name 'u_int'
int  write_random(void* buffer, u_int numBytes);
^
3 errors generated.
make: *** [Python/random.o] Error 1
```

--
components: Build
messages: 283889
nosy: Pam.McANulty
priority: normal
pull_requests: 6
severity: normal
status: open
title: Compiler failure on Mac OS X - sys/random.h
type: compile error
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
components: +macOS
nosy: +benjamin.peterson, mark.dickinson, ned.deily, rhettinger, ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Ned Deily]

Ned Deily added the comment:

Pam, what version of macOS / OS X did this fail on?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23903] Generate PC/python3.def by scraping headers

[Steve Dower]

Steve Dower added the comment:

> ast.h and node.h are private headers.

You're right, these should be excluded (possibly from the release too?)

I've been playing with the script in a separate context and I think I've hit a 
few issues (though I have made some modifications, so YMMV). It's probably just 
as well we waited. I'll thoroughly validate it before coming back with a new 
patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Pam McA'Nulty]

Pam McA'Nulty added the comment:

Patch for fix

--
keywords: +patch
Added file: http://bugs.python.org/file46009/Issue29057_random_include.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Pam McA'Nulty]

Pam McA'Nulty added the comment:

OSX: 10.11.6 (15G1212)
Xcode 8.2.1  Build version 8C1002

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14483] inspect.getsource fails to read a file of only comments

[Pam McA'Nulty]

Pam McA'Nulty added the comment:

I just clicked "Random Issue" and it seemed to be an "easy" (ish) one - which 
is just what I'd like to tackle over xmas break :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29056] logging.Formatter doesn't respect more than one formatException()

[Dan Passaro]

Dan Passaro added the comment:

Working around this issue can be done by overriding format() in subclasses like 
so:

def format(self, record):
record.exc_text = ''
try:
return super().format(record)
finally:
record.exc_text = ''

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Ned Deily]

Ned Deily added the comment:

Argh!  This is the third go-around on this problem, starting with the quick fix 
for macOS 10.12 in Issue28676 then on to Issue28932 where Benjamin added a more 
elaborate configure test when it broke OpenBSD, and now that causes builds on 
macOS versions earlier than 10.12 but newer than 10.4 or 10.5 to fail. (And, we 
haven't noticed it because, ATM, the only OS X buildbot active is a 10.4 one 
and the OpenBSD buildbot is down.)  Benjamin, if you could have a look, please, 
if I don't get to it first.

--
assignee:  -> benjamin.peterson
nosy: +larry
priority: normal -> release blocker
stage:  -> patch review
versions: +Python 2.7, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14483] inspect.getsource fails to read a file of only comments

[R. David Murray]

R. David Murray added the comment:

Well, there's nobody being paid for keeping track of bugs and responding, so 
things do slip through the cracks.  Pinging an issue after there's been a lack 
of response for a while is appropriate, if you notice it yourself :)  (Mark, 
while he was trying to be helpful, does not speak for the Python community.)

As far as the question of is this intentional, the answer is yes.  Presumably 
you are calling it on the 'main' function.  If you call it on the module, you 
will get all source lines from that module.  (You can't call it "on the file", 
the argument must be an object.)

You'll see why it is intentional for the 'main' case if you consider that while 
in Python whitespace is syntactically significant, this is *not* true for 
Python comments indentation, because comments are treated as if they *are* 
whitespace.  getsourcelines stops looking at sourcelines on the last line 
recorded in the lnotab for that function, so any subsequent comments are not 
considered part of the function.

So, I'm closing this as "not a bug" since it works as expected for me in both 
python 2.7 and 3.6.

Thanks for waking the issue up, Pam.  You have contributed to python by getting 
an open issue closed, but you'll have to find something else to work on during 
the break I'm afraid.

--
nosy: +r.david.murray
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14483] inspect.getsource fails to read a file of only comments

[Pam McA'Nulty]

Pam McA'Nulty added the comment:

Yeah, I looked at the code and saw what you described, David.  I think I'll see 
if there's a good place to mention this constraint in the docs and then I'll 
find another one (besides the macOS build issue I ran into when trying to build 
the latest master)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

[Cornelius Diekmann]

Cornelius Diekmann added the comment:

I wrote a proper patch for the issue of handling EOF in STDIN, including tests. 
My patch is against the github mirror head, but don't worry, the files I touch 
haven't been touched in recent years ;-)

I only tested on Linux. My patch only addresses the issue in this thread. It 
does not include the patch for issue26228. I still recommend to also merge the 
patch for issue26228 (but I don't have a FreeBSD box to test).

--
versions: +Python 3.6, Python 3.7
Added file: http://bugs.python.org/file46010/pty.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Pam McA'Nulty]

Pam McA'Nulty added the comment:

I will say that, though my fix seems to work, it feels that the "right" place 
to put the fix is in ./configure.  

Sadly, I don't speak './configure', though I apparently remember enough C from 
17 years ago to get this working.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23903] Generate PC/python3.def by scraping headers

[Roundup Robot]

Roundup Robot added the comment:

New changeset 9cb87e53e324 by Serhiy Storchaka in branch '3.5':
Sort and remove duplicates from PC/python3.def (issue #23903).
https://hg.python.org/cpython/rev/9cb87e53e324

New changeset 0927b5c80c50 by Serhiy Storchaka in branch '3.6':
Sort and remove duplicates from PC/python3.def (issue #23903).
https://hg.python.org/cpython/rev/0927b5c80c50

New changeset e64a82371d72 by Serhiy Storchaka in branch 'default':
Sort and remove duplicates from PC/python3.def (issue #23903).
https://hg.python.org/cpython/rev/e64a82371d72

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23903] Generate PC/python3.def by scraping headers

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Reordered to make diffs easier for reviewing.

--
Added file: http://bugs.python.org/file46011/python3def.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28695] Add SSL_CTX_set_client_cert_engine

[Andrea Grandi]

Andrea Grandi added the comment:

What about using OPENSSL_init_crypto(OPENSSL_INIT_LOAD_CONFIG, NULL) instead of 
OPENSSL_config()?

--
nosy: +Andrea Grandi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

[Cornelius Diekmann]

Cornelius Diekmann added the comment:

Removed git patch header from pty.patch to make python code review tool happy. 
Sorry, this is my first contribution.

--
Added file: http://bugs.python.org/file46012/pty.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

[Cornelius Diekmann]

Cornelius Diekmann added the comment:

Review tool still did not show the test_pty.py file. Sry.

--
Added file: http://bugs.python.org/file46013/pty.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29051] Improve error reporting involving f-strings (PEP 498)

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28702] Confusing error message when None used in expressions, eg. "'NoneType' object has no attribute 'foo'"

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28559] Unclear error message when raising wrong type of exceptions

[Ivan Levkivskyi]

Changes by Ivan Levkivskyi :


--
nosy: +levkivskyi

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28997] test_readline.test_nonascii fails on Android

[Martin Panter]

Martin Panter added the comment:

The basic idea of your patch may be reasonable, but something is not right. 
Imagine the locale is something other than UTF-8. The input code will now 
contain mojibake print("\xC3\xAB"), although the decode() call will translate 
the result back to the expected "\xEB".

I suggest this 2nd version of the patch. I used io.TextIOWrapper to use the 
locale encoding, and incorporated the other test character "\xEF". I also 
changed the preliminary test to call input() instead of relying on the 
interactive interpreter, quiet mode, etc.

Just to clarify, is the problem that Python (correctly) assumes UTF-8 encoding 
on Android, but Readline does not unless you tweak the environment variable? 
I.e. is Readline assuming ASCII or something and ignoring the test characters? 
If so, it sounds like this may be a more general problem with Gnu tools and 
libraries on Android.

--
Added file: http://bugs.python.org/file46014/readline_multibyte.v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23903] Generate PC/python3.def by scraping headers

[Steve Dower]

Steve Dower added the comment:

Good call.

I think I might actually replace the script with a build step that uses the C 
preprocessor to get all the names, then a script to generate the file. If 
someone who knows the POSIX build system can help out, we could generate a list 
on each build for various platforms and fail when it doesn't match what's 
committed.

Since the preprocessor doesn't have to generate valid code, we should be able 
to cross-compile for other platforms, though that's less critical.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28968] xml rpc server fails with connection reset by peer error no 104

[Martin Panter]

Martin Panter added the comment:

Python 2.6 is quite old and doesn’t even receive security patches any more as 
far as I know. I would start by trying 2.7, or failing that, try backporting 
the changes from Issue 6267. My guess is this is related to persistent HTTP 
connections being dropped.

I don’t think the bug tracker is the right place to discuss 2.6 these days. 
Even if you can find someone interested in helping with 2.6, you may need to 
provide more information (e.g. client and server code) to produce the problem.

--
nosy: +martin.panter
resolution:  -> out of date

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

[Cornelius Diekmann]

Cornelius Diekmann added the comment:

Make review tool happy by giving it less broken patch format :)
`make patchcheck` is already happy.
Sorry for the noise :(

--
Added file: http://bugs.python.org/file46015/pty_and_tests.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Christian Heimes]

Changes by Christian Heimes :


--
nosy: +christian.heimes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29058] Mark new limited C API

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Functions added to a limited API after 3.2 should be available only when 
Py_LIMITED_API is not defined or is set to corresponding hexadecimal Python 
version (e.g. 0x0305).

Proposed patch makes following names available only for corresponding versions 
of a limited API.

Removed declaration: PyErr_SetExcWithArgsKwargs().

Excluded from stable ABI: _PyBytes_DecodeEscape(), PyInit_imp().

3.3: Py_hexdigits, PyImport_ExecCodeModuleObject(), PyImport_AddModuleObject(), 
PyImport_ImportFrozenModuleObject(), PyMemoryView_FromMemory(), 
PyModule_NewObject(), PyModule_GetNameObject(), PyObject_GenericSetDict(), 
PyErr_GetExcInfo(), PyErr_SetExcInfo(), PyErr_SetImportError(), 
PyParser_SimpleParseStringFlagsFilename(), PyThread_GetInfo(), 
PyUnicode_Substring(), PyUnicode_AsUCS4(), PyUnicode_AsUCS4Copy(), 
PyUnicode_GetLength(), PyUnicode_ReadChar(), PyUnicode_WriteChar(), 
PyUnicode_DecodeCodePageStateful(), PyUnicode_EncodeCodePage(), 
PyUnicode_DecodeLocaleAndSize(), PyUnicode_DecodeLocale(), 
PyUnicode_EncodeLocale(), PyUnicode_FindChar(), and a number of OSError 
subclasses.

3.4: PyErr_SetFromErrnoWithFilenameObjects(), 
PyErr_SetExcFromWindowsErrWithFilenameObjects().

3.5: PyNumber_MatrixMultiply(), PyNumber_InPlaceMatrixMultiply(), 
PyCodec_NameReplaceErrors(), Py_DecodeLocale(), Py_EncodeLocale(), 
PyImport_ImportModuleLevelObject(), PyObject_Calloc(), 
PyExc_StopAsyncIteration, PyExc_RecursionError, PyMem_Calloc(), 
a number of PyODict_* macros.

3.6: Py_FileSystemDefaultEncodeErrors, PyOS_FSPath(), 
PyExc_ModuleNotFoundError, PyErr_SetImportErrorSubclass(), 
PyErr_ResourceWarning().

However it may be better that some was added to stable ABI by mistake. 
Py_hexdigits looks as a stuff for internal use, PyThread_GetInfo() and 
PyODict_* macros are not documented.

--
components: Interpreter Core
files: limited-api.patch
keywords: patch
messages: 283910
nosy: haypo, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Mark new limited C API
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file46016/limited-api.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23903] Generate PC/python3.def by scraping headers

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

See also issue29058.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29054] pty.py: pty.spawn hangs after client disconnect over nc (netcat)

[Martin Panter]

Martin Panter added the comment:

This is a change in behaviour of the _copy() loop: it will stop as soon as EOF 
is read from the parent’s input, and immediately close the terminal master. 
Unpatched, the loop continues to read output from the child, until the child 
closes the terminal slave.

I agree that your new behaviour may be desired in some cases, but you need to 
respect backwards compatibility. With your patch, things will no longer work 
robustly when the child “has the last word”, i.e. it writes output and exits 
without reading any (extra) input. Simple example: the child prints a message, 
but the parent has no input:

python -c 'import pty; pty.spawn("./message.py")' < /dev/null

Any new functionality would also need documenting. (If you want to suggest some 
wording to document the existing behaviour better, that would also be welcome :)

--
versions:  -Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29059] Windows: Python not using ANSI compatible console

[Joseph Hackman]

New submission from Joseph Hackman:

On windows, Python does not request that Windows enable VT100 for console 
output for Python.

That is to say that ANSI codes such as \033[91m will function on Mac and Linux 
Pythons, but not Windows.

As there is no good interface in core Python to the kernel32 console operations 
(and there probably shouldn't be, it would be better to be consistent), I 
suggest just flipping the bit at startup on Windows.

I would be happy to submit a patch, but seek guidance on the best location for 
addition of code to 'at startup iff a tty is attached'.

The following code solves the issue:
import platform
if platform.system().lower() == 'windows':
from ctypes import windll, c_int, byref
stdout_handle = windll.kernel32.GetStdHandle(c_int(-11))
mode = c_int(0)
windll.kernel32.GetConsoleMode(c_int(stdout_handle), byref(mode))
mode = c_int(mode.value | 4)
windll.kernel32.SetConsoleMode(c_int(stdout_handle), mode)

Please see:
https://msdn.microsoft.com/en-us/library/windows/desktop/ms686033(v=vs.85).aspx 
(Search for ENABLE_VIRTUAL_TERMINAL_PROCESSING)
https://msdn.microsoft.com/en-us/library/windows/desktop/ms683231(v=vs.85).aspx 
(As for why stdout is -11 on Windows)

--
components: Windows
messages: 283913
nosy: joseph.hackman, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Windows: Python not using ANSI compatible console
type: behavior
versions: Python 2.7, Python 3.3, Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29053] Implement >From_ decoding on input from mbox

[bpoaugust]

bpoaugust added the comment:

Attached please find patch which works for me.

To use it independently of email, do something like:

messages = mailbox.mbox(filename, MboxoFactory)

where:

class MboxoFactory(mailbox.mboxMessage):
def __init__(self, message=None):
super().__init__(message=MboxoReader(message))

HTH

--
Added file: http://bugs.python.org/file46017/mboxo_patch.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19756] test_nntplib: sporadic failures, network isses? server down?

[Martin Panter]

Martin Panter added the comment:

Multi-connect.patch is a smaller patch that changes setUpClass() → setUp(), so 
that each test method creates a new NNTP connection. The downside is all the 
reconnecting slows the test execution from 42 s down to 115 s, which is why I 
would like to move the testing to a local server.

--
versions: +Python 3.7
Added file: http://bugs.python.org/file46018/multi-connect.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29060] Changing the installation location still adds AppData filepaths that do not exist to the path variable on Windows 10

[Daz]

New submission from Daz:

New to python issue tracking; prone to ignorance.

I'm on Windows 10. I noticed after checking to add Python to my path variable 
and then changing the location from AppData's directory that after the 
installation, the filepaths associated with AppData were added to the path 
variable. The new path and any would-be associated filepaths were not added to 
the path variable.

Thanks in advance if you can at least let me know if this is typical or a 
problem.

--
components: Installation
messages: 283916
nosy: Dazc
priority: normal
severity: normal
status: open
title: Changing the installation location still adds AppData filepaths that do 
not exist to the path variable on Windows 10
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29060] Changing the installation location still adds AppData filepaths that do not exist to the path variable on Windows 10

[Daz]

Daz added the comment:

New to python issue tracking; prone to ignorance.

I'm on Windows 10. I noticed after checking to add Python to my path variable 
and then changing the location from AppData's directory that after the 
installation, the filepaths associated with AppData were added to the path 
variable.

Thanks in advance if you can at least let me know if this is typical or a 
problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29060] Changing the installation location still adds AppData filepaths that do not exist to the path variable on Windows 10

[Zachary Ware]

Changes by Zachary Ware :


--
assignee:  -> steve.dower
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15795] Zipfile.extractall does not preserve file permissions

[Karen Tracey]

Karen Tracey added the comment:

Note the zipfile being processed may have been created on a non-Unix system, 
and the external_attr value can't be usefully interpreted as permission bits 
when the value at _CD_CREATE_SYSTEM 
(https://hg.python.org/cpython/file/default/Lib/zipfile.py#l107) in the central 
directory entry is not Unix (3). Patches so far don't seem to guard against 
mistakenly assuming a foreign-system external_attr value can be interpreted as 
Unix permission bits.

(At present github is delivering zipfiles of repos with a create system value 
of 0 and external_attr values of 0.)

--
nosy: +kmtracey

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

[Carl George]

Carl George added the comment:

While attempting to build a Python 3.6 RPM for RHEL/CentOS 6, I noticed the 
following warning.

*** WARNING: renaming "_sqlite3" since importing it failed: 
build/lib.linux-i686-3.6-pydebug/_sqlite3.cpython-36dm-i386-linux-gnu.so: 
undefined symbol: sqlite3_stmt_readonly

The resolution of this issue introduced usage of the sqlite3_stmt_readonly 
interface.  That interface wasn't added to sqlite until 3.7.4 
(http://www.sqlite.org/releaselog/3_7_4.html).  My RPM build failed because 
RHEL/CentOS 6 only has sqlite 3.6.20.  I understand that Python can't support 
old libraries forever, but can this minimum sqlite version be noted somewhere 
in the documentation?

--
nosy: +carlwgeorge

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29057] Compiler failure on Mac OS X - sys/random.h

[Benjamin Peterson]

Benjamin Peterson added the comment:

So, if sys/random.h can't be included without error why does the configure 
check for it work?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

[R. David Murray]

R. David Murray added the comment:

Please open a new issue for this request.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29060] Changing the installation location still adds AppData filepaths that do not exist to the path variable on Windows 10

[Steve Dower]

Steve Dower added the comment:

You should have a set of log files in your %TEMP% directory. Could you zip them 
up and attach to this issue? That should show whether the installer got 
confused about something.

Note that if you install the launcher but not for all users (the other check 
box on the first page) you can't actually reconfigure where it installs to, and 
it will be put on PATH, so you may be seeing that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29061] secrets.randbelow(-1) hangs

[Brian Nenninger]

New submission from Brian Nenninger:

secrets.randbelow(-1) causes the interpreter to hang. It should presumably 
raise an exception like secrets.randbelow(0) does. This is on Mac OS X 10.11.6, 
shell transcript below.

=

$ python3
Python 3.6.0 (v3.6.0:41df79263a11, Dec 22 2016, 17:23:13) 
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import secrets
>>> secrets.randbelow(1)
0
>>> secrets.randbelow(0)
Traceback (most recent call last):
  File "", line 1, in 
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/secrets.py", 
line 29, in randbelow
return _sysrand._randbelow(exclusive_upper_bound)
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/random.py", 
line 232, in _randbelow
r = getrandbits(k)  # 0 <= r < 2**k
  File 
"/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/random.py", 
line 678, in getrandbits
raise ValueError('number of bits must be greater than zero')
ValueError: number of bits must be greater than zero
>>> secrets.randbelow(-1)

(hangs using 100% CPU until aborted)

--
components: Library (Lib)
messages: 283923
nosy: Brian Nenninger
priority: normal
severity: normal
status: open
title: secrets.randbelow(-1) hangs
type: behavior
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28971] nntplib is broken when responses are longer than _MAXLINE

[Martin Panter]

Martin Panter added the comment:

Max_over_line.patch is my attempt: Keep the original _MAXLINES = 2048 code, but 
override it with _MAX_OVER_LINE = 64000 when reading OVER response lines. I 
also added a test case.

--
Added file: http://bugs.python.org/file46019/max_over_line.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28971] nntplib is broken when responses are longer than _MAXLINE

[Martin Panter]

Changes by Martin Panter :


Added file: http://bugs.python.org/file46020/max_over_line.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28971] nntplib is broken when responses are longer than _MAXLINE

[Martin Panter]

Changes by Martin Panter :


Removed file: http://bugs.python.org/file46019/max_over_line.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue29061] secrets.randbelow(-1) hangs

[Ned Deily]

Changes by Ned Deily :


--
nosy: +rhettinger, steven.daprano
priority: normal -> high
stage:  -> needs patch
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com