[issue28759] access to mkfifo, mknod and hard links is controled by SELinux MAC on Android

[Xavier de Gaye]

New submission from Xavier de Gaye:

List of the tests that fail with PermissionError when run as a non-root user on 
an Android emulator (API 24) and fixed by this patch:
test_posix test_shutil test_stat test_genericpath test_ntpath 
test_posixpath test_macpath test_eintr test_pathlib
Android uses SELinux mandatory access control (MAC), see:
https://source.android.com/security/selinux/
Android commit message that does not grant hard link capabilities by default:
https://android.googlesource.com/platform/external/sepolicy/+/85ce2c7

--
assignee: xdegaye
components: Tests
files: android_not_root.patch
keywords: patch
messages: 281329
nosy: xdegaye
priority: normal
severity: normal
stage: patch review
status: open
title: access to mkfifo, mknod and hard links is controled by SELinux MAC on 
Android
type: behavior
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45577/android_not_root.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28032] --with-lto builds segfault in many situations

[Gregory P. Smith]

Gregory P. Smith added the comment:

doc references fixed.  thanks!

remote: notified python-check...@python.org of incoming changeset a5e2add2c37b
remote: notified python-check...@python.org of incoming changeset 6ae0e6d435de
remote: notified python-check...@python.org of incoming changeset ea9cc29a274b
remote: notified python-check...@python.org of incoming changeset 38e9761ccc13

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28032] --with-lto builds segfault in many situations

[Gregory P. Smith]

Gregory P. Smith added the comment:

This is no longer a release blocker as --with-lto is not enabled by default by 
--enable-optimizations since my commits in September.

Regarding --with-lto itself segfaulting... Fixing compiler+linker toolchains is 
beyond what CPython itself should do.  But the reason the flag remains named 
"optimizations" is that it is fair for us to include --with-lto or other future 
build time optimization in known good configurations detected by the autoconf 
configure.ac in the future if desired.

I do not think there is anything more for us to do here.  We should explicitly 
_not_ try to add smarts to --with-lto itself as to whether we believe it will 
build a broken binary or not.

--
priority: release blocker -> normal
resolution:  -> not a bug
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28748] Make _Py_PackageContext of type "const char *"

[Nick Coghlan]

Nick Coghlan added the comment:

Ah, my apologies - for some reason I completely failed to notice the leading 
underscore until I saw you refer to this as a private variable in the What's 
New note.

That means the note only needs to go in the NEWS file for the benefit of 
maintainers, rather than in the public porting notes. Sorry for 
overcomplicating things :)

Aside from my confusion about this actually being a private interface, the 
patch looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28748] Make _Py_PackageContext of type "const char *"

[Roundup Robot]

Roundup Robot added the comment:

New changeset d2dd6578aa16 by Serhiy Storchaka in branch 'default':
Issue #28748: Private variable _Py_PackageContext is now of type "const char *"
https://hg.python.org/cpython/rev/d2dd6578aa16

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28748] Make _Py_PackageContext of type "const char *"

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thanks Nick.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19948] POSIX semantics of PATH search in execvpe is not respected

[Antti Haapala]

Antti Haapala added the comment:

Someone on Stack Overflow just had a problem where their shell script would 
work in shell but get `OSError: [Errno 8] Exec format error` when calling it 
with `subprocess.call`. I'd say rather fix this (on POSIX platforms).

Why does Python do path resolving on its own anyway? Shouldn't it delegate 
these all to appropriate execv* variants.

--
nosy: +ztane

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

[INADA Naoki]

INADA Naoki added the comment:

> If someone comes forward with more fully formed idea for code generation or 
> overall structural enchancement, that can be put in another tracker item.

I noticed argument clinic supports Python [1]. So there is one way to code 
generation already.
Attached patch uses Argument Clinic and Makefile to generate source.

[1]: 
https://docs.python.org/3.5/howto/clinic.html#using-argument-clinic-in-python-files

--
Added file: http://bugs.python.org/file45578/namedtuple-clinic.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Xiang Zhang]

New submission from Xiang Zhang:

PyUnicode_AsUnicodeEscapeString now still has some old comments and codes about 
the original "quotes" parameter of unicodeescape_string. Current implementation 
could get rid of them.

--
files: PyUnicode_AsUnicodeEscapeString.patch
keywords: patch
messages: 281337
nosy: xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Cleanup PyUnicode_AsUnicodeEscapeString
type: enhancement
versions: Python 3.5, Python 3.6, Python 3.7
Added file: 
http://bugs.python.org/file45579/PyUnicode_AsUnicodeEscapeString.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19948] POSIX semantics of PATH search in execvpe is not respected

[Antti Haapala]

Antti Haapala added the comment:

While at it, another POSIX semantic that execvp doesn't support is the 
behaviour when `PATH` is not set, e.g. on Linux, the search path is set to '.', 
followed by confstr(_CS_PATH). It is debatable whether this is desired (having 
current directory first in search path doesn't exactly sound right, which is 
also acknowledged by Linux man pages: 

NOTES
   On some other systems, the default path (used when the environment
   does not contain the variable PATH) has the current working direc‐
   tory  listed after /bin and /usr/bin, as an anti-Trojan-horse mea‐
   sure.  Linux uses here the traditional "current  directory  first"
   default path.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Ezio Melotti]

Changes by Ezio Melotti :


--
components: +Interpreter Core, Unicode
nosy: +ezio.melotti, haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

[INADA Naoki]

INADA Naoki added the comment:

Updated patch: fixed small issue in argument clinic, and added
comment why we use code generation.

--
Added file: http://bugs.python.org/file45580/namedtuple-clinic2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28761] Add the const qualifier to fields name and doc of public structs

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Proposed patch makes the fields name and doc of structures PyMemberDef, 
PyGetSetDef, PyStructSequence_Field, PyStructSequence_Desc, and wrapperbase 
being of type "const char *" rather of "char *".

These structures often are initialized as static variables and name and doc 
fields are initialized from literal strings. These fields are always refer to 
constant string literal, NULL, or readonly UTF8 representation of a Unicode 
object. They are never refer to mutable data. Changing the data referred by 
these pointers is an error. Adding the const qualifier makes clear that this is 
an immutable data.

This change may need some changes in third-party code. But it needs to change 
only one line in CPython sources, and I believe that most third-party projects 
don't need any changes at all.

--
components: Interpreter Core
files: const-name-and-doc-fields.patch
keywords: patch
messages: 281340
nosy: ncoghlan, serhiy.storchaka
priority: normal
severity: normal
stage: patch review
status: open
title: Add the const qualifier to fields name and doc of public structs
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file45581/const-name-and-doc-fields.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

LGTM. Thanks Xiang.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2d0ce3f4dfbd by Serhiy Storchaka in branch '3.6':
Issue #28760: Clean up and fix comments in PyUnicode_AsUnicodeEscapeString().
https://hg.python.org/cpython/rev/2d0ce3f4dfbd

New changeset d656b93c5603 by Serhiy Storchaka in branch 'default':
Issue #28760: Clean up and fix comments in PyUnicode_AsUnicodeEscapeString().
https://hg.python.org/cpython/rev/d656b93c5603

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28760] Cleanup PyUnicode_AsUnicodeEscapeString

[Xiang Zhang]

Xiang Zhang added the comment:

Thanks for your work, Serhiy. ;-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28762] configure links with lockf and F_LOCK is not declared in Android API 24

[Xavier de Gaye]

New submission from Xavier de Gaye:

The patch fixes the following error:

==
ERROR: test_lockf (test.test_posix.PosixTester)
--
Traceback (most recent call last):
  File "/sdcard/org.bitbucket.pyona/lib/python3.7/test/test_posix.py", line 
195, in test_lockf
posix.lockf(fd, posix.F_LOCK, 4)
AttributeError: module 'posix' has no attribute 'F_LOCK'

--
assignee: xdegaye
components: Interpreter Core
files: test_posix_flock.patch
keywords: patch
messages: 281344
nosy: xdegaye
priority: normal
severity: normal
stage: patch review
status: open
title: configure links with lockf and F_LOCK is not declared in Android API 24
type: behavior
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45582/test_posix_flock.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28532] Show sys.version when -V option is supplied twice.

[INADA Naoki]

INADA Naoki added the comment:

I noticed today is code freeze for final beta.
Is this too late for 3.6.0?

--
priority: normal -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28023] python-gdb.py must be updated for the new Python 3.6 compact dict

[INADA Naoki]

INADA Naoki added the comment:

ping

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[INADA Naoki]

Changes by INADA Naoki :


Added file: 
http://bugs.python.org/file45583/28731-PyDict_NewPresized-too-small-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28763] Use en-dashes for ranges in docs

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

It is recommended to use an em-dash instead of a hyphen for numerical ranges. 
It looks better in the rendered document. Python documentation already use it, 
but not always. Proposed patch adds more en-dashes.

--
assignee: docs@python
components: Documentation
files: docs-en-dash.patch
keywords: patch
messages: 281347
nosy: docs@python, martin.panter, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Use en-dashes for ranges in docs
type: enhancement
Added file: http://bugs.python.org/file45584/docs-en-dash.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28532] Show sys.version when -V option is supplied twice.

[Martin Panter]

Martin Panter added the comment:

Ned indicated he was open to the idea: 
. Maybe just 
double check; there’s still a few hours left!

I’m not sure, but maybe there should be “.. versionchanged:: 3.6” in the RST 
documentation, and an entry in What’s New?

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28532] Show sys.version when -V option is supplied twice.

[STINNER Victor]

STINNER Victor added the comment:

verbose-version3.patch LGTM and seems useful to me.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue21590] Systemtap and DTrace support

[Charalampos Stratakis]

Charalampos Stratakis added the comment:

@Łukasz

Would it be possible to review the patch?

Or is it preferable to open a new issue?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28532] Show sys.version when -V option is supplied twice.

[Roundup Robot]

Roundup Robot added the comment:

New changeset fc6bb69cec05 by INADA Naoki in branch '3.6':
Issue #28532: Show sys.version when -V option is supplied twice
https://hg.python.org/cpython/rev/fc6bb69cec05

New changeset 02aa667bd02d by INADA Naoki in branch 'default':
Issue #28532: Show sys.version when -V option is supplied twice
https://hg.python.org/cpython/rev/02aa667bd02d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28532] Show sys.version when -V option is supplied twice.

[INADA Naoki]

INADA Naoki added the comment:

Thanks for review.
Since doc update is allowed after final beta, I committed 
verbose-version3.patch for now.

Here is patch for doc.

--
Added file: http://bugs.python.org/file45585/vervose-version-doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

A variant in msg281118 looks better to me than 
28731-PyDict_NewPresized-too-small-2.patch. It doesn't look good to me that 
newsize is set to arbitrary small value if estimated size is larger than very 
large PyDict_MAXSIZE (this is 2**28 on 32-bit and 2**60 on 64-bit).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[INADA Naoki]

Changes by INADA Naoki :


Added file: 
http://bugs.python.org/file45586/28731-PyDict_NewPresized-too-small-3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[INADA Naoki]

INADA Naoki added the comment:

OK. I've updated the patch.

BTW, I used const Py_ssize_t for function local constant.
Should I use file scope macro for such heuristic threshold, even it
is used only one function?

--
priority: high -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I think function scope constant is good. Similar code in dictresize() should 
have different bound.

The patch LGTM.

--
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

[Nick Coghlan]

Nick Coghlan added the comment:

Ah, I had forgotten that Larry had already included Python support in Argument 
Clinic.

With the inline code auto-generated from the pure Python implementation, that 
addresses the main maintenance concerns I had. I did briefly wonder about the 
difficulties of bootstrapping Argument Clinic (since it uses functools), but 
that's already accounted for in the comment-based design of Argument Clinic 
itself (i.e. since the generated code is checked in, the previous iteration can 
be used to generate the updated one when the namedtuple template changes).

Raymond, how does this variant look to you?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28761] Add the const qualifier to fields name and doc of public structs

[Nick Coghlan]

Nick Coghlan added the comment:

+1 from me. The only thing I noticed in the patch was that the issue number 
needs filling in now that you've filed it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28763] Use en-dashes for ranges in docs

[Ezio Melotti]

Ezio Melotti added the comment:

While you are at it, have you checked how many en-dashes have been used instead 
of em-dashes?  "--" is commonly used to indicate em-dashes (e.g. in emails), 
but in rst it renders to an en-dash.

--
nosy: +ezio.melotti

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28023] python-gdb.py must be updated for the new Python 3.6 compact dict

[STINNER Victor]

STINNER Victor added the comment:

I reviewed dict_gdb.patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28763] Use en-dashes for ranges in docs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

353 en-dashes with spaces.
479 em-dashes with spaces.
89 em-dashes without spaces.

And some number of hyphens with spaces. It is hard to automatically distinguish 
them from minuses in code examples, but in issue18529 I provided large patches 
that converted all of them to dashes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28763] Use en-dashes for ranges in docs

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Some of these double hyphens are in code examples. Thus the actual number of 
en-dashes that can be changed to em-dashes is smaller.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

[STINNER Victor]

STINNER Victor added the comment:

Back to basis, patch 6:

* revert changes on indexgroup and groupindex types: I will fix this later, 
once this issue is fixed
* pattern_richcompare() and pattern_hash() also uses pattern, but don't use 
groups, indexgroup nor groupindex anymore

I removed the @cpython_only unit test and rewrote test_pattern_compare_bytes() 
to make it easier to follow.

re.compile('abc', re.IGNORECASE) is different than re.compile('ABC', 
re.IGNORECASE), but it's a deliberate choice to not test it. I consider that 
the behaviour can change depending on the Python implementation and in a future 
version.

--
Added file: http://bugs.python.org/file45587/pattern_compare-6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

pattern_compare-6.patch LGTM.

--
assignee:  -> haypo
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28764] test_mailbox fails when run as a non-root user on Android API 24

[Xavier de Gaye]

New submission from Xavier de Gaye:

The patch fixes the problem that on Android API 24, a non-root user is not 
allowed to create the hard links used by the mailbox module.
Related to issue 28759.

--
assignee: xdegaye
components: Library (Lib)
files: test_mailbox_link.patch
keywords: patch
messages: 281364
nosy: xdegaye
priority: normal
severity: normal
stage: patch review
status: open
title: test_mailbox fails when run as a non-root user on Android API 24
type: behavior
versions: Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45588/test_mailbox_link.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5e8ef1493843 by Victor Stinner in branch '3.6':
Implement rich comparison for _sre.SRE_Pattern
https://hg.python.org/cpython/rev/5e8ef1493843

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18383] test_warnings modifies warnings.filters when running with "-W default"

[Roundup Robot]

Roundup Robot added the comment:

New changeset 5e8ef1493843 by Victor Stinner in branch '3.6':
Implement rich comparison for _sre.SRE_Pattern
https://hg.python.org/cpython/rev/5e8ef1493843

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26865] Meta-issue: support of the android platform

[Xavier de Gaye]

Xavier de Gaye added the comment:

New issues raised upon testing on the Android API 24 emulator:
  issue #28683: bind() on a unix socket raises PermissionError on Android for a 
non-root user
  issue #28684: [asyncio] bind() on a unix socket raises PermissionError on 
Android for a non-root user
  issue #28746: cannot set_inheritable() for a file descriptor on Android
  issue #28759: access to mkfifo, mknod and hard links is controled by SELinux 
MAC on Android
  issue #28762: configure links with lockf and F_LOCK is not declared in 
Android API 24
  issue #28764: test_mailbox fails when run as a non-root user on Android API 24

--
dependencies: +[asyncio] bind() on a unix socket raises PermissionError on 
Android for a non-root user, access to mkfifo, mknod and hard links is 
controled by SELinux MAC on Android, bind() on a unix socket raises 
PermissionError on Android for a non-root user, cannot set_inheritable() for a 
file descriptor on Android, configure links with lockf and F_LOCK is not 
declared in Android API 24, test_mailbox fails when run as a non-root user on 
Android API 24

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28023] python-gdb.py must be updated for the new Python 3.6 compact dict

[INADA Naoki]

Changes by INADA Naoki :


Added file: http://bugs.python.org/file45589/dict_gdb2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28688] Warning -- warnings.filters was modified by test_warnings

[Roundup Robot]

Roundup Robot added the comment:

New changeset 75b1091594f8 by Victor Stinner in branch '3.5':
Issue #28688: Remove warnings.filters check from regrtest
https://hg.python.org/cpython/rev/75b1091594f8

New changeset a2616863de06 by Victor Stinner in branch '3.6':
Issue #28688: Null merge 3.5
https://hg.python.org/cpython/rev/a2616863de06

New changeset da042eec6743 by Victor Stinner in branch 'default':
Issue #28688: Null merge 3.6
https://hg.python.org/cpython/rev/da042eec6743

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

[STINNER Victor]

STINNER Victor added the comment:

Serhiy Storchaka: "pattern_compare-6.patch LGTM."

Thank you very much for your very useful reviews! I pushed the change.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[INADA Naoki]

INADA Naoki added the comment:

Thanks.
As @haypo suggests, I'll commit this to default branch first, and
backport to 3.6 after 3.6.0 is released.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28688] Warning -- warnings.filters was modified by test_warnings

[STINNER Victor]

STINNER Victor added the comment:

I implemented x==y operator for _sre.SRE_Pattern in Python 3.6 and 3.7, it 
fixed this issue.

For Python 3.5, I removed the warnings.filters test, as we discussed.

@Martin Panter: immortal-filters.patch works because I'm not super excited by 
the change. Somehow, it looks like a hack... even if I don't see any better 
solution for Python 3.5.

Since the bug only impacts Python test suite in the practical, is it really 
worth it to fix it in Python 3.5 which is almost in the "security fix only" 
stage?


@Martin: It's up to you, I have no strong opinion on your patch.


> I agree there is no need to change Python 2 at this stage.

Ok.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28731] _PyDict_NewPresized() creates too small dict

[Roundup Robot]

Roundup Robot added the comment:

New changeset b708b3190ecb by INADA Naoki in branch 'default':
Issue #28731: Optimize _PyDict_NewPresized() to create correct size dict
https://hg.python.org/cpython/rev/b708b3190ecb

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

[STINNER Victor]

New submission from STINNER Victor:

Attached patch makes _sre.compile() more strict on types: groupindex must be a 
dictionary and indexgroup must be a tuple.

Currently, indexgroup is passed as a list. I chose to convert it to a tuple to 
use less memory and to prevent unwanted changes. For unwanted changed, I'm not 
sure because groupindex remains a mutable dictionary. Do you think that it's 
worth it to require a tuple? Another option is to accept a list but to convert 
it to a list, but this change is more specific to the current implementation.

--
files: sre_types.patch
keywords: patch
messages: 281373
nosy: haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: _sre.compile(): be more strict on types of indexgroup and groupindex
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file45590/sre_types.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

[STINNER Victor]

STINNER Victor added the comment:

For stricter checks on _sre.compile() arguments, I created the issue #28765: 
"_sre.compile(): be more strict on types of indexgroup and groupindex".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28740] Add sys.getandroidapilevel()

[Xavier de Gaye]

Xavier de Gaye added the comment:

I agree with Marc-Andre, Windows has sys.getwindowsversion() returning system 
information for the Windows version, and a platform.win32_ver() returning 
additional version information from the Registry obtained at run time. So it is 
consistent to add the sys.getandroidapilevel() function returning the version 
based on the ANDROID_API_LEVEL macro (a build, system level data, that 
specifies the libc version Python has been built against) and to add the 
platform.android_ver() version returning the device/emulator run time version 
obtained from the local properties system.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 176fc21f8430 by Ethan Furman in branch '3.6':
closes issue28082: doc update and NEWS entry
https://hg.python.org/cpython/rev/176fc21f8430

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23591] enum: Add Flags and IntFlags

[Roundup Robot]

Roundup Robot added the comment:

New changeset f404a59d834e by Ethan Furman in branch '3.6':
closes issue23591: add NEWS entry
https://hg.python.org/cpython/rev/f404a59d834e

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28766] Remove the semicolon in source code

[Yuwei Ba]

New submission from Yuwei Ba:

As we do not often use semicolons in Python world. I hope this historical semi 
would be cleaned in a future release.

Source: Lib/httplib.py:1117

--
components: Library (Lib)
files: mywork.patch
hgrepos: 361
keywords: patch
messages: 281378
nosy: ibigbug
priority: normal
severity: normal
status: open
title: Remove the semicolon in source code
type: enhancement
versions: Python 2.7
Added file: http://bugs.python.org/file45591/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

[Roundup Robot]

Roundup Robot added the comment:

New changeset 493359386360 by Ethan Furman in branch '3.6':
issue28082: actually include NEWS entry
https://hg.python.org/cpython/rev/493359386360

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

If make groupindex and indexgroup a dict and a tuple, we could use concrete 
dict and tuple API instead of generic mapping and sequence APIs.

Note that groups, groupindex and indexgroup are not independent. Actually 
indexgroup is derived from groups and groupindex (in Python code), but groups 
and groupindex could be derived from indexgroup. groups could be derived from 
code. The interface of _sre.compile() can be simplified by passing only 
groupindex or indexgroup. Current interface is only for backward compatibility. 
I don't know whether this still is needed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28764] test_mailbox fails when run as a non-root user on Android API 24

[R. David Murray]

R. David Murray added the comment:

LGTM.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

Steve Dower added the comment:

Whoops, that's what I get for renaming something. Easily fixed, but I'm happy 
to aim for 3.7.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28172] Upper-case all example enum members

[Roundup Robot]

Roundup Robot added the comment:

New changeset b9801dab214a by Ethan Furman in branch '3.6':
close issue28172: Change all example enum member names to uppercase, per Guido; 
patch by Chris Angelico.
https://hg.python.org/cpython/rev/b9801dab214a

New changeset 5ec8d4c51363 by Ethan Furman in branch 'default':
close issue28172: Change all example enum member names to uppercase, per Guido; 
patch by Chris Angelico.
https://hg.python.org/cpython/rev/5ec8d4c51363

--
nosy: +python-dev
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28172] Upper-case all example enum members

[Ethan Furman]

Changes by Ethan Furman :


--
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28767] Readd __index__ support on ipaddress objects

[Josh Rosenberg]

New submission from Josh Rosenberg:

It looks like, due to #16722, in #15559, __index__ was removed from ipaddress 
objects. #16722 was fixed a few months later, but the comments asking for it to 
be readded were put on a closed issue, so no one noticed.

Can __index__ support be readded now? Should be as simple as undoing 
https://hg.python.org/cpython/rev/5abea8a43f19 (probably manually, assuming the 
subsequent history would make a direct rollback nonfeasible).

Nosying the folks involved in fixing the original bugs.

--
messages: 281384
nosy: benjamin.peterson, josh.r, ncoghlan
priority: normal
severity: normal
status: open
title: Readd __index__ support on ipaddress objects
versions: Python 3.4, Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28767] Readd __index__ support on ipaddress objects

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Why __index__ support is needed?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28751] Fix comments in code.h

[Brett Cannon]

Brett Cannon added the comment:

Patch LGTM.

--
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4347] Circular dependency causes SystemError when adding new syntax

[Brett Cannon]

Brett Cannon added the comment:

So what does having the tokenizer not depend on pgen accomplish? Does it break 
a circular dependency where the tokenizer will get rebuilt with pgen before a 
full build starts?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
assignee:  -> belopolsky
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

The patch LGTM.  I'll commit it tonight unless Serhiy beats me to it.

--
nosy: +alexandre.vassalotti, haypo, tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Masayuki Yamamoto]

New submission from Masayuki Yamamoto:

Platform that appeared warning is Vista Cygwin x86. Interpreter execution 
doesn't crash because _setmode function is supplied from cygwin1.dll that 
always linked.
Warning reason is header io.h [*] doesn't include to source file. Therefore I 
wrote two patches for 3.7 and 2.7.

[*] https://msdn.microsoft.com/en-us/library/tw4k6df8.aspx (Cygwin also 
avaliable)

build log on 3.7:

gcc -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes-std=c99 -Wextra -Wno-unused-result 
-Wno-unused-parameter -Wno-missing-field-initializers   -I. -I./Include
-DPy_BUILD_CORE -o Modules/main.o Modules/main.c
Modules/main.c: In function 'Py_Main':
Modules/main.c:599:5: warning: implicit declaration of function '_setmode' 
[-Wimplicit-function-declaration]
 _setmode(fileno(stdin), O_BINARY);
 ^
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes-std=c99 -Wextra -Wno-unused-result 
-Wno-unused-parameter -Wno-missing-field-initializers   -I. -I./Include
-DPy_BUILD_CORE  -I./Modules/_io -c ./Modules/_io/fileio.c -o Modules/fileio.o
./Modules/_io/fileio.c: In function '_io_FileIO___init___impl':
./Modules/_io/fileio.c:478:5: warning: implicit declaration of function 
'_setmode' [-Wimplicit-function-declaration]
 _setmode(self->fd, O_BINARY);
 ^

--
components: Build
files: include-io.h.patch
keywords: patch
messages: 281389
nosy: benjamin.peterson, masamoto, stutzbach
priority: normal
severity: normal
status: open
title: Warning: implicit declaration of function '_setmode'
type: compile error
versions: Python 2.7, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45592/include-io.h.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28768] Warning: implicit declaration of function '_setmode'

[Masayuki Yamamoto]

Changes by Masayuki Yamamoto :


Added file: http://bugs.python.org/file45593/2.7-include-io.h.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28747] Expose SSL_CTX_set_cert_verify_callback

[Steve Dower]

Steve Dower added the comment:

For the sake of review, I fixed the patch and rebased it on default.

--
Added file: http://bugs.python.org/file45594/28747_3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28689] OpenSSL 1.1.0c test failures

[Charalampos Stratakis]

Charalampos Stratakis added the comment:

Fixed upstream:
https://github.com/openssl/openssl/commit/beacb0f0c1ae7b0542fe053b95307f515b578eb7

--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28532] Show sys.version when -V option is supplied twice.

[Martin Panter]

Martin Panter added the comment:

The text looks okay. I’m not sure about putting it in the “Porting to Python 
3.6” section, but there doesn’t seem to be a more appropriate existing heading. 
Perhaps we need a new heading, say “Other Improvement”, near “Optimizations” 
and “Build and C API Changes”. A previous What’s New had 
.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28751] Fix comments in code.h

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee:  -> rhettinger
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15851] Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the default.

[Mark Lawrence]

Changes by Mark Lawrence :


--
nosy:  -BreamoreBoy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28751] Fix comments in code.h

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0a916174 by Raymond Hettinger in branch '3.6':
Issue 28751: Fix comments in code.h.  (Contributed by Ned Batchelder).
https://hg.python.org/cpython/rev/0a916174

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28751] Fix comments in code.h

[Raymond Hettinger]

Raymond Hettinger added the comment:

Thanks Ned.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Ned Deily]

Ned Deily added the comment:

If you can push this in the next hour or two, it can still make b4.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

> If you can push this in the next hour or two ...

I'll do it now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0a2a0061e425 by Serhiy Storchaka in branch '3.6':
Issue #28752: Restored the __reduce__() methods of datetime objects.
https://hg.python.org/cpython/rev/0a2a0061e425

New changeset 23140bd66d86 by Serhiy Storchaka in branch 'default':
Issue #28752: Restored the __reduce__() methods of datetime objects.
https://hg.python.org/cpython/rev/23140bd66d86

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27414] http.server.BaseHTTPRequestHandler inconsistence with Content-Length value

[STINNER Victor]

STINNER Victor added the comment:

issue27414.patch is not good: see my review.

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28475] Misleading error on random.sample when k < 0

[Roundup Robot]

Roundup Robot added the comment:

New changeset 89f95c78e0ab by Raymond Hettinger in branch '3.6':
Issue 28475:  Improve error message for random.sample() with k < 0. 
(Contributed by Francisco Couzo).
https://hg.python.org/cpython/rev/89f95c78e0ab

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28752] datetime object fails to restore from reduction

[Alexander Belopolsky]

Alexander Belopolsky added the comment:

It looks like Serhiy has already committed it.  Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28475] Misleading error on random.sample when k < 0

[Raymond Hettinger]

Raymond Hettinger added the comment:

Thanks Franscisco.  

I ended-up not modifying the docs because I think it clutters that clarity with 
an irrelevant side issue.  The more important part was to make sure the error 
message wasn't misleading and the test that edge case.  I didn't backport to 
Python 2.7 because I don't think it meets the threshold of being interesting 
enough to warrant a backport to an old release.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28652] Make loop methods reject socket kinds they do not support.

[Roundup Robot]

Roundup Robot added the comment:

New changeset 0ee76f3afd70 by Yury Selivanov in branch '3.5':
Issue #28652: Partially rollback previous changes
https://hg.python.org/cpython/rev/0ee76f3afd70

New changeset a40159071359 by Yury Selivanov in branch '3.6':
Merge 3.5 (issue #28652)
https://hg.python.org/cpython/rev/a40159071359

New changeset a759fcba1866 by Yury Selivanov in branch 'default':
Merge 3.6 (issue #28652)
https://hg.python.org/cpython/rev/a759fcba1866

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Roundup Robot]

Roundup Robot added the comment:

New changeset 62c16fafa7d4 by Raymond Hettinger in branch '3.6':
Issue 28587:  list.index documentation missing start and stop arguments. 
(Contributed by Mariatta Wijaya.)
https://hg.python.org/cpython/rev/62c16fafa7d4

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Raymond Hettinger]

Raymond Hettinger added the comment:

Mariatta, thank you for the patch.  And Chris, thanks for the observant bug 
report.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Martin Panter]

Martin Panter added the comment:

Gareth, are you sure that fixes the main memory problem? Did you see Serhiy’s 
cum_weights list? Looking at the code, a list of every number from one to 13 
million will use more memory (to hold each unique integer) than the initial 
list of repeated ones.

I think the problem may also be causing buildbot failures:

Crash in test_random:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/5373/steps/test/logs/stdio
0:19:42 [368/404] test_random crashed -- running: test_zipfile (48 sec), 
test_tools (139 sec)
Traceback (most recent call last):
  [. . .]
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd9/build/Lib/test/libregrtest/runtest_mp.py",
 line 221, in run_tests_multiprocess
raise Exception(msg)
Exception: Child error on test_random: Exit code -9

Timeout in choices():
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/5464/steps/test/logs/stdio
0:17:05 [215/404] test_random crashed
Timeout (0:15:00)!
Thread 0x000802006400 (most recent call first):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/test_random.py", 
line 637 in test_choices_algorithms
  [. . .]
Traceback (most recent call last):
  [. . .]
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd10/build/Lib/test/libregrtest/runtest_mp.py",
 line 221, in run_tests_multiprocess
raise Exception(msg)
Exception: Child error on test_random: Exit code 1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee:  -> rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Raymond Hettinger]

Raymond Hettinger added the comment:

A smaller value suffices for this test.  It was trying to make sure the 
underlying algorithms are as in-sync as possible without going to extremes.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Roundup Robot]

Roundup Robot added the comment:

New changeset 3551fca2c6ae by Raymond Hettinger in branch '3.6':
Issue #28743:  Reduce memory consumption for random module tests
https://hg.python.org/cpython/rev/3551fca2c6ae

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15851] Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the default.

[Raymond Hettinger]

Changes by Raymond Hettinger :


--
assignee: rhettinger -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Martin Panter]

Martin Panter added the comment:

The committed change looks wrong in the new example. I think Mariatta’s patch 
was right; it the index found is 3, not 2:

>>> a
[66.25, 333, -1, 333, 1, 1234.5, 333]
>>> a.index(333)
1
>>> a.index(333, 2)  # search for 333 starting at index 2
3

--
nosy: +martin.panter
status: closed -> open
versions: +Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks, Raymond and Martin :)

Not sure what the procedure is for fixing this. Do I upload another patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Raymond Hettinger]

Raymond Hettinger added the comment:

Thanks for noticing.   I tested against the original list rather than the 
subsequently modified version.  I'm starting to think that this whole example 
section is annoyingly hard to follow and uninformative.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Raymond Hettinger]

Raymond Hettinger added the comment:

Attaching an improved list example:
* Replaced abstract and hard to follow numerical example with fruits
* Demonstrate the non-mutating methods first

--
Added file: http://bugs.python.org/file45595/new_list_example.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28587] list.index documentation missing start and stop arguments

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Thanks Raymond. The new set of examples is much better than the previous one.
+1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28743] test_choices_algorithms() in test_random uses lots of memory

[Martin Panter]

Martin Panter added the comment:

Thanks Raymond, now the test is noticeably faster and fine with my memory 
situation :)

--
stage:  -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com