[issue6815] UnicodeDecodeError in os.path.expandvars

[Roundup Robot]

Roundup Robot added the comment:

New changeset 08746e015c64 by Serhiy Storchaka in branch '3.3':
Issue #6815: os.path.expandvars() now supports non-ASCII environment
http://hg.python.org/cpython/rev/08746e015c64

New changeset f3c146036e7c by Serhiy Storchaka in branch 'default':
Issue #6815: os.path.expandvars() now supports non-ASCII environment
http://hg.python.org/cpython/rev/f3c146036e7c

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9694] argparse required arguments displayed under "optional arguments"

[paul j3]

paul j3 added the comment:

The attached file shows how the default argument groups could be redefined, 
using 'required' as the criteria.

I've implemented it as a method that is added to a subclass of ArgumentParser.  
This method is invoked after arguments are defined, prior to generating the 
help.

The help looks something like this:

usage: alt_grouping.py [-h] [-f FOO] -g GOO pos [baz]

required:
  posrequired positional
  -g GOO, --goo GOO  required optional

optional:
  -h, --help show this help message and exit
  -f FOO, --foo FOO  optional
  bazoptional positional

I was thinking of implementing this as a formatter subclass, but given the way 
the help is assembled, invoking this method from the parser is simpler.

--
Added file: http://bugs.python.org/file34065/alt_grouping.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6815] UnicodeDecodeError in os.path.expandvars

[Roundup Robot]

Roundup Robot added the comment:

New changeset b5ad525076eb by Serhiy Storchaka in branch '3.3':
Fixed typo in previous commit (issue #6815).
http://hg.python.org/cpython/rev/b5ad525076eb

New changeset 6825395e6107 by Serhiy Storchaka in branch 'default':
Fixed typo in previous commit (issue #6815).
http://hg.python.org/cpython/rev/6825395e6107

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20599] test_cleanup() of test_builtin failed

[STINNER Victor]

STINNER Victor added the comment:

Another failure:

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1724/steps/test/logs/stdio

==
FAIL: test_cleanup (test.test_builtin.ShutdownTest)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/test_builtin.py",
 line 1628, in test_cleanup
__cleanenv=True)
  File 
"/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/script_helper.py",
 line 69, in assert_python_ok
return _assert_python(True, *args, **env_vars)
  File 
"/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/script_helper.py",
 line 55, in _assert_python
"stderr follows:\n%s" % (rc, err.decode('ascii', 'ignore')))
AssertionError: Process return code is 1, stderr follows:
Shared object "libpython3.4dm.so.1" not found, required by "python"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20599] test_cleanup() of test_builtin failed

[Roundup Robot]

Roundup Robot added the comment:

New changeset 488ccbee6ee6 by Victor Stinner in branch 'default':
Issue #20599: Don't clear environment in test_cleanup() of test_builtin
http://hg.python.org/cpython/rev/488ccbee6ee6

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20599] test_cleanup() of test_builtin failed

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

And yet one failure on FreeBSD.

http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1724/steps/test/logs/stdio

==
FAIL: test_cleanup (test.test_builtin.ShutdownTest)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/test_builtin.py",
 line 1628, in test_cleanup
__cleanenv=True)
  File 
"/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/script_helper.py",
 line 69, in assert_python_ok
return _assert_python(True, *args, **env_vars)
  File 
"/usr/home/buildbot/koobs-freebsd10/3.x.koobs-freebsd10/build/Lib/test/script_helper.py",
 line 55, in _assert_python
"stderr follows:\n%s" % (rc, err.decode('ascii', 'ignore')))
AssertionError: Process return code is 1, stderr follows:
Shared object "libpython3.4dm.so.1" not found, required by "python"

--

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20599] test_cleanup() of test_builtin failed

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
Removed message: http://bugs.python.org/msg211136

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20599] test_cleanup() of test_builtin failed

[STINNER Victor]

STINNER Victor added the comment:

> Shared object "libpython3.4dm.so.1" not found, required by "python"

This is probably is missing LD_LIBRARY_PATH environment variable.

> Fatal Python error: Failed to initialize Windows random API (CryptoGen)

Oh, it remembers me that Windows requires some environment variables to start, 
otherwise it fails badly.

I modified the test to *not* start with an empty environment, it's not the 
purpose of the test.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20614] test.script_helper should copy SYSTEMROOT environment variable for __cleanenv=True

[STINNER Victor]

New submission from STINNER Victor:

On Windows, if Python is started with an empty environment (no environment 
variable at all), Python fails with:

"Fatal Python error: Failed to initialize Windows random API (CryptoGen)"

It's the Windows error 0x80090006 which is not displayed in the error message 
:-(

In fact, it's because Python 3 cannot be started without SYSTEMROOT environment 
variable. Otherwise, CryptAcquireContext() is unable to find some DLL.

IMO the script_helper should be fixed to copy the variable.

Recent example of this issue:
http://bugs.python.org/issue20599#msg21

--
components: Tests
messages: 211138
nosy: brian.curtin, haypo, serhiy.storchaka, tim.golden
priority: normal
severity: normal
status: open
title: test.script_helper should copy SYSTEMROOT environment variable for 
__cleanenv=True
versions: Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20614] test.script_helper should copy SYSTEMROOT environment variable for __cleanenv=True

[STINNER Victor]

STINNER Victor added the comment:

cleanenv.patch: untested test.

--
keywords: +patch
Added file: http://bugs.python.org/file34066/cleanenv.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6501] Fatal error on startup with invalid PYTHONIOENCODING

[STINNER Victor]

STINNER Victor added the comment:

> Is there anything to backport as referred to in msg136670 or can this be 
> closed?

The fix is present in Python 3.3 since Python 3.3.0 according to the changelog. 
Python 3.2 doesn't accept bugfixes anymore.

Python 2.7 doesn't have the function os.device_encoding(), I don't think that 
it is affected.

There is nothing more to do, I'm closing the bug. Thanks for the report.

--
resolution:  -> fixed
status: open -> closed
versions:  -Python 2.7, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20614] test.script_helper should copy SYSTEMROOT environment variable for __cleanenv=True

[STINNER Victor]

STINNER Victor added the comment:

When Python is executed in an empty environement, not only it displays "Fatal 
Python error: Failed to initialize Windows random API (CryptoGen)", but it 
opens also the fatal error popup on Windows.

The issue #19983 proposes a patch to not abort() at exit, but exit with an 
non-zero exit code instead. The same should be done for this error.

By the way, we can maybe help the use to fix this issue with a better error 
message. For example, add in the message " (check if SYSTEMROOT environment 
variable is correctly set)", maybe only if the environment variable is not set.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20615] Replace PyDict_GetItem() with PyDict_GetItemWithError()

[STINNER Victor]

New submission from STINNER Victor:

See this huge warning in the definition of PyDict_GetItem:

/* Note that, for historical reasons, PyDict_GetItem() suppresses all errors
 * that may occur (originally dicts supported only string keys, and exceptions
 * weren't possible).  So, while the original intent was that a NULL return
 * meant the key wasn't present, in reality it can mean that, or that an error
 * (suppressed) occurred while computing the key's hash, or that some error
 * (suppressed) occurred when comparing keys in the dict's internal probe
 * sequence.  A nasty example of the latter is when a Python-coded comparison
 * function hits a stack-depth error, which can cause this to return NULL
 * even if the key is present.
 */
PyObject *
PyDict_GetItem(PyObject *op, PyObject *key)
{ ... }

PyDict_GetItem() should avoided because it may hide important exceptions like 
KeyboardInterrupt or MemoryError.

See for example #14537 for a specific error.

By the way, the PyDict_GetItem() documentation should contain a big red warning 
and suggest to use PyDict_GetItemWithError() instead.

--
messages: 211142
nosy: haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Replace PyDict_GetItem() with PyDict_GetItemWithError()
versions: Python 3.3, Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19983] When interrupted during startup, Python should not call abort() but exit()

[STINNER Victor]

Changes by STINNER Victor :


--
title: Ctrl-C at startup can end in a Py_FatalError call -> When interrupted 
during startup, Python should not call abort() but exit()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20614] test.script_helper should copy SYSTEMROOT environment variable for __cleanenv=True

[STINNER Victor]

STINNER Victor added the comment:

Oh, another problem: if Python is compiled in shared module, libpython3.4.so 
cannot be found. LD_LIBRARY_PATH must also be copied if __cleanenv=True. 
Py_ENABLE_SHARED can be checked in sysconfig to decide if the environment 
variable should be copied or not.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20599] test_cleanup() of test_builtin failed

[STINNER Victor]

STINNER Victor added the comment:

> This is probably is missing LD_LIBRARY_PATH environment variable.
>> Fatal Python error: Failed to initialize Windows random API (CryptoGen)
>Oh, it remembers me that Windows requires some environment variables to start, 
>otherwise it fails badly.

Ok, I filled issue #20614 to track these bugs with __cleanenv=True.

Serhiy>print() can be used during Python exit in destructor if destructor 
called before cleaning up the builtins and sys modules and encoding module with 
the encoding of sys.stdout.
Serhiy>Cleaning up the builtins and sys modules are delayed after wiping other 
modules, this decreases the chance of print() failure.

Ah ok. I tested with a codec implemented in Python, it works well. So it is 
very specific to test_cleanup() which hack builtins and sys modules to keep a 
reference their.

I don't see anything else to do, I close the issue.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6815] UnicodeDecodeError in os.path.expandvars

[STINNER Victor]

STINNER Victor added the comment:

The changes on ntpath.py are a little bit weird: it uses os.environb, whereas 
Windows is the only OS where os.environb does not exist. It looks like ntpath 
is available and tested on UNIX so the change looks to be valid, even you are 
not supposed to have Windows variables in your UNIX environment :-)

As bytes filenames, we should maybe deprecated bytes environment variables on 
Windows in Python 3.5. On Windows, the environment is Unicode. The bytes API is 
just provided for backward compatibility, but it should not be used.

By the way, the initial bug report was on Python 2.

Using os.fsencode/fsdecode instead of the ASCII encoding looks correct.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20526] python: Modules/gcmodule.c:379: visit_decref: Assertion `((gc)->gc.gc_refs >> (1)) != 0' failed.

[Charles-François Natali]

Charles-François Natali added the comment:

Please revert.

To debug, since I guess it's due to a memory corruption because objects are
deallocated while they're still in use, you could try to use valgrind.
Unfortunately, since it's due to a race condition, the overhead will
probably make it really hard to reproduce :-(

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20616] Add tracemalloc.Traceback.format() method

[STINNER Victor]

New submission from STINNER Victor:

Attached patch adds a Traceback.format() to the new tracemalloc module.

Since the tracemalloc is new in Python 3.4 and my patch adds a new (simple and 
tested) method, I consider that it's not so late to add it :-)

I chose a different API than traceback.format_tb() because I would like to use 
directly print or use functions of the logging module (logging doesn't expect 
newlines).

I set the priority to release blocker because I want to know Larry's opinion on 
this issue.

@Larry: Change the priority if you consider that it's really too late for such 
change.

--
files: traceback_format.patch
keywords: patch
messages: 211147
nosy: gvanrossum, haypo, larry, neologix
priority: release blocker
severity: normal
status: open
title: Add tracemalloc.Traceback.format() method
versions: Python 3.4
Added file: http://bugs.python.org/file34067/traceback_format.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20617] test_ssl does not use mock

[Xavier de Gaye]

New submission from Xavier de Gaye:

The following line should be removed from test_ssl.py:

from unittest import mock

--
components: Library (Lib)
messages: 211148
nosy: xdegaye
priority: normal
severity: normal
status: open
title: test_ssl does not use mock
type: behavior
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19466] Clear state of threads earlier in Python shutdown

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1166b3321012 by Victor Stinner in branch 'default':
Issue #20526, #19466: Revert changes of issue #19466 which introduces a
http://hg.python.org/cpython/rev/1166b3321012

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20526] python: Modules/gcmodule.c:379: visit_decref: Assertion `((gc)->gc.gc_refs >> (1)) != 0' failed.

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1166b3321012 by Victor Stinner in branch 'default':
Issue #20526, #19466: Revert changes of issue #19466 which introduces a
http://hg.python.org/cpython/rev/1166b3321012

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20616] Add tracemalloc.Traceback.format() method

[Larry Hastings]

Larry Hastings added the comment:

Victor: at this point I'm cherry-picking all revisions that will go into rc2 / 
final.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20616] Add tracemalloc.Traceback.format() method

[STINNER Victor]

STINNER Victor added the comment:

> Victor: at this point I'm cherry-picking all revisions that will go into rc2 
> / final.

So would like to cherry-pick such addition?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20526] python: Modules/gcmodule.c:379: visit_decref: Assertion `((gc)->gc.gc_refs >> (1)) != 0' failed.

[STINNER Victor]

STINNER Victor added the comment:

> To debug, since I guess it's due to a memory corruption because
> objects are deallocated while they're still in use, you could try
> to use valgrind.
> Unfortunately, since it's due to a race condition, the overhead
> will probably make it really hard to reproduce :-(

I added assert(_Py_Finalizing == NULL || _Py_Finalizing == PyThreadState_GET()) 
almost everywhere, but the assertion didn't fail. It looks like only the main 
thread is running between the interrupted wait_for_thread_shutdown() and the 
final "python: Modules/gcmodule.c:379: visit_decref: ... failed" assertion in 
PyGC_Collect().

I tried to add directly assert(_PyGCHead_REFS(gc) != 0) in 
_PyGCHead_SET_REFS(), but the assertion didn't fail.

I also ran Python in Valgrind: no error neither.

Ok...

I close this issue as won't fix because it was occur with #19466 applied, but I 
just reverted this patch.

--
resolution:  -> wont fix
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19466] Clear state of threads earlier in Python shutdown

[STINNER Victor]

STINNER Victor added the comment:

I reverted the changes because it introduced regressions.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20320] select.select(timeout) and select.kqueue.control(timeout) must round the timeout to the upper bound

[STINNER Victor]

STINNER Victor added the comment:

Can I commit time_rouding-3.patch?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue4708] os.pipe should return inheritable descriptors (Windows)

[STINNER Victor]

STINNER Victor added the comment:

The PEP 446 has been implemented in Python 3.4 and all file descriptors and 
sockets are now created non-inheritable by default. Use os.set_inheritable() to 
make the pipe fds inheritable.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6815] UnicodeDecodeError in os.path.expandvars

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is patch for 2.7.

--
versions: +Python 2.7
Added file: http://bugs.python.org/file34068/expandvars_nonascii-2.7.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue18111] Add a default argument to min & max

[Éric Araujo]

Éric Araujo added the comment:

Note that the docs were changed, but versionchanged directives are missing.

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20601] tracing and tests that raise an exception in a SIGALRM handler

[Xavier de Gaye]

Xavier de Gaye added the comment:

> A signal should not remove the trace function.

And a signal should be traced.
The attached patch postpones all signals except SIGINT while the trace function 
is being invoked, and thus the signal is traced after returning from this 
function.
My previous test with a little improvement has been attached too and outputs 
now, with this patch:

tracing foo
tracing handler
Got ZeroDivisionError.
trace function: 

I did not test the patch against WITH_THREAD not being defined.

--
Added file: http://bugs.python.org/file34069/tracing_signals.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20601] tracing and tests that raise an exception in a SIGALRM handler

[Xavier de Gaye]

Changes by Xavier de Gaye :


Added file: http://bugs.python.org/file34070/signal_test.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20199] status of module_for_loader and utils._module_to_load

[Brett Cannon]

Brett Cannon added the comment:

set_loader and set_package are also deprecated (docs are accurate for that: 
http://docs.python.org/3.4/library/importlib.html#module-importlib.util . 
Everything else that is deprecated are methods are were deprecated in Python 
3.3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20199] status of module_for_loader and utils._module_to_load

[Brett Cannon]

Changes by Brett Cannon :


--
nosy: +larry
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20618] Unable to pip install pyjasperclient

[Tammy]

New submission from Tammy:

We used to be able to perform a "pip install pyjasperclient" with success.  The 
last time I did this was within the last couple months.
I tried this today and received an error,
...
Downloading/unpacking elementtree (from pyjasperclient)
  Could not find any downloads that satisfy the requirement elementtree (from 
pyjasperclient)
  Some externally hosted files were ignored (use --allow-external elementtree 
to allow).
Cleaning up...
No distributions at all found for elementtree (from pyjasperclient)
Storing debug log for failure in /home/belairlab/.pip/pip.log

--
components: Installation
messages: 211161
nosy: viel
priority: normal
severity: normal
status: open
title: Unable to pip install pyjasperclient
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20618] Unable to pip install pyjasperclient

[R. David Murray]

R. David Murray added the comment:

I'm afraid this isn't the appropriate tracker for either PIP issues or pypi 
issues, or issues with particular 3rd party packages (such as pyjasperclient).  
This tracker is for bugs in the CPython implementation of the language, and the 
standard library.

(While elementtree is part of the standard library, the requirement issue in 
pip is not an stdlib/CPython problem :)

--
nosy: +r.david.murray
resolution:  -> invalid
stage:  -> committed/rejected
status: open -> closed
versions: +3rd party -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20614] test.script_helper should copy SYSTEMROOT environment variable for __cleanenv=True

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue14537] "Fatal Python error: Cannot recover from stack overflow." with SymPy test suite

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

I didn't tested this patch with SymPy, but in general it LGTM.

--
assignee:  -> haypo
nosy: +serhiy.storchaka
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20615] Replace PyDict_GetItem() with PyDict_GetItemWithError()

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20416] Marshal: special case int and float, don't use references

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

> As a compromise, we could suppress the sharing for small int objects, since 
> they are singletons, anyway.

This is implementation detail.

But we can use more efficient way to memoizating small int objects.

I also suppose than efficient C implementation of IdentityDict will significant 
decrease an overhead (may be 2 times). As far as this is probably a first case 
for which IdentityDict give significant benefit, I'll provide an implementation 
for 3.5.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20619] tracemalloc changes col_offset attribute for _ast.arg objects

[Claudiu.Popa]

New submission from Claudiu.Popa:

Here's a strange bug. I don't know if this is legitimate or not, but it seems 
like there is some sort of overflow.

Given the following code:

  data = """
  def function(*, foot):
print(foot)
  """
  from ast import parse
  import tracemalloc
  tracemalloc.start()
  node = parse(data)
  tracemalloc.stop()
  arg = node.body[0].args.kwonlyargs[0]
  print(arg.lineno, arg.col_offset)

it yields on a freshly build the following, which is obviously wrong. It should 
have printed `1 1`.

  <_ast.arg object at 0x80103bcf8>
  1681660160 -2124152704

Also, there is no need to call tracemalloc.start, it has the same behaviour 
just by importing it.

--
components: Library (Lib)
messages: 211165
nosy: Claudiu.Popa
priority: normal
severity: normal
status: open
title: tracemalloc changes col_offset attribute for _ast.arg objects
type: behavior
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20619] tracemalloc changes col_offset attribute for _ast.arg objects

[Claudiu.Popa]

Claudiu.Popa added the comment:

The version of the interpreter is:

Python 3.4.0rc1+ (default:1166b3321012, Feb 13 2014, 21:49:27)
[GCC 4.2.1 20070831 patched [FreeBSD]] on freebsd8

--
nosy: +haypo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20615] Replace PyDict_GetItem() with PyDict_GetItemWithError()

[Raymond Hettinger]

Raymond Hettinger added the comment:

Please, no more big red warnings.

Keep the docs factual and straight-forward.  In the docs for PyDict_GetItem(), 
note that errors will get suppressed.  To
get error reporting use PyDict_GetItemWithError() instead.

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20620] Update the min()/max() docs for the new default argument

[Raymond Hettinger]

New submission from Raymond Hettinger:

There is a new "default" argument for min() and max():

>>> min([], default=10)
10

The new argument is not currently shown by help():

>>> help(min)
Help on built-in function min in module builtins:

min(...)
min(iterable[, key=func]) -> value
min(a, b, c, ...[, key=func]) -> value

With a single iterable argument, return its smallest item.
With two or more arguments, return the smallest argument.

--
assignee: docs@python
components: Documentation
messages: 211168
nosy: docs@python, rhettinger
priority: normal
severity: normal
status: open
title: Update the min()/max() docs for the new default argument
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20213] Change the install location of _sysconfigdata.py

[Thomas Petazzoni]

Thomas Petazzoni added the comment:

The patch is not working as it should be, so I withdraw it for the moment.

--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4

[Paul Moore]

New submission from Paul Moore:

There appears to be a significant issue with importing from zip files on Python 
3.3.4. I have tested this on Windows 7, 64-bit, using the MSI installer from 
python.org.

To reproduce, download virtualenv and extract the 
C:\Work\Scratch\virtualenv-pfm\virtualenv_support\pip-1.5.2-py2.py3-none-any.whl
 file. Set PYTHONPATH to the full path of that wheel.

python -c "import pip" should work without error, but I see

PS 20:44 C:\Work\Scratch\virtualenv-pfm
>$env:PYTHONPATH="C:\Work\Scratch\virtualenv-pfm\virtualenv_support\pip-1.5.2-py2.py3-none-any.whl"
PS 20:49 C:\Work\Scratch\virtualenv-pfm
>C:\Apps\Python33\python.exe -c "import pip"
Traceback (most recent call last):
  File "", line 1, in 
ImportError: No module named 'pip'

For comparison, the 32-bit version works perfectly:

PS 20:44 C:\Work\Scratch\virtualenv-pfm
>$env:PYTHONPATH="C:\Work\Scratch\virtualenv-pfm\virtualenv_support\pip-1.5.2-py2.py3-none-any.whl"
PS 20:49 C:\Work\Scratch\virtualenv-pfm
>C:\Apps\Python33\python.exe -c "import pip"
Traceback (most recent call last):
  File "", line 1, in 
ImportError: No module named 'pip'

--
keywords: 3.3regression
messages: 211170
nosy: georg.brandl, pmoore
priority: critical
severity: normal
status: open
title: Issue with zipimport in 3.3.4
type: behavior
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20139] Python installer does not install a "pip" command (just "pip3" and "pip3.4")

[Paul Moore]

Paul Moore added the comment:

This is still the case in the 3.4rc0 Windows installer. Could we get something 
definite for 3.4 final? It may be too late for that to be anything other than 
documenting that the command "pip" is not available, but given that most 3rd 
party documents use "pip" as the command, it probably is worth being explicit.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4

[Paul Moore]

Paul Moore added the comment:

Apologies, cut & paste error.

3.3.2 32-bit:

PS 20:49 C:\Work\Scratch\virtualenv-pfm
>py -3.3-32 -c "import pip"
PS 20:49 C:\Work\Scratch\virtualenv-pfm
>py -3.3-32 -V
Python 3.3.2

3.4rc0 is not affected either:

PS 20:54 C:\Work\Scratch\virtualenv-pfm
>py -3.4 -c "import pip"
PS 20:57 C:\Work\Scratch\virtualenv-pfm
>py -3.4 -V
Python 3.4.0rc1

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20416] Marshal: special case int and float, don't use references

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Here is a patch which special cases small integers. It decreases v3 and v4 dump 
time of bench.py by 10% without affecting load time. Of course in real cases 
the benefit will be much less.

--
Added file: http://bugs.python.org/file34071/marshal_small_ints_refs.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Stefan Behnel]

Stefan Behnel added the comment:

>>> inspect.isbuiltin() returns False
>> Are you absolutely sure about this?
> Yes.

Oh, well...

isbuiltin(cyfunction) *does* return False. However, 
ismethoddescriptor(cyfunction) returns True, because Cython's functions bind as 
methods and thus have a "__get__()" (but no __set__()). Therefore, 
_signature_is_builtin(cyfunction) returns True, and the 
Signature.from_builtin(cyfunction) code path is taken and fails.

So, once again:

If the intention is to test that a callable has a "__text_signature__", then 
the code should test for the existance of "__text_signature__". It should *not* 
try to test for types that may or may not have such an attribute, and then just 
fail if it surprisingly does not find it.

--
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20568] Pass --default-install to ensurepip in the Windows installers

[Nick Coghlan]

Changes by Nick Coghlan :


--
assignee:  -> ncoghlan
priority: deferred blocker -> release blocker
title: Pass --default-install to ensurepip in the Windows installers? -> Pass 
--default-install to ensurepip in the Windows installers

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20139] Python installer does not install a "pip" command (just "pip3" and "pip3.4")

[Nick Coghlan]

Nick Coghlan added the comment:

Oops, missed this already existed when I created issue 20568. I currently plan 
to have this fixed for rc2 on the 23rd.

--
resolution:  -> duplicate
status: open -> closed
superseder:  -> Pass --default-install to ensurepip in the Windows installers

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Stefan Behnel]

Stefan Behnel added the comment:

BTW, ismethoddescriptor() is an exceedingly broad test, IMHO. I wonder if it 
should even be relied upon for anything in inspect.py.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20619] tracemalloc changes col_offset attribute for _ast.arg objects

[STINNER Victor]

STINNER Victor added the comment:

I don't understand the link with tracemalloc. I get the same result if I 
comment all lines containing tracemalloc.

With Python 3.3, I get:

Traceback (most recent call last):
  File "x.py", line 9, in 
print(arg.lineno, arg.col_offset)
AttributeError: 'arg' object has no attribute 'lineno'

With Python 3.4, I get a number which looks random, but lineno and col_offset 
have the same value.

I'm not sure if it's a regression or not, so I set the priority to release 
blocker.

--
nosy: +benjamin.peterson, larry
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20363] BytesWarnings triggerred by test suite

[Éric Araujo]

Éric Araujo added the comment:

Thanks for applying the patch.  distutils tests don’t cover 100% of the 
codebase; did you test manually that the behavior of the changed code was still 
correct?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6650] sre_parse contains a confusing generic error message

[Éric Araujo]

Éric Araujo added the comment:

Serhiy: I meant that the patch looks right to me (“I would apply it”), not that 
I intended to do it (“I will apply it”)—I’m not set up right now to contribute 
to CPython again.  Would you mind committing it?

(Edited versions: exception messages are not part of a guaranteed API, but 
changing them can break things and we don’t do that needlessly in bugfix 
releases.)

--
assignee: eric.araujo -> 
nosy: +serhiy.storchaka
versions: +Python 3.5 -Python 2.6, Python 2.7, Python 3.1, Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue8876] distutils should not assume that hardlinks will work

[Éric Araujo]

Éric Araujo added the comment:

Sorry for the lax definition of “soon”; I’m back from a busy January and will 
try to make some time for CPython contributions.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Larry Hastings]

Larry Hastings added the comment:

Since this is a problem in Cython, not in CPython, maybe you can fix it in 
Cython?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Yury Selivanov]

Yury Selivanov added the comment:

Patch sig_cython_03.patch is still applicable (it probably won't apply to the 
current repo, but I can fix that). It should solve all these problems once and 
for all.

If Larry agrees, I can still merge it in.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Yury Selivanov]

Yury Selivanov added the comment:

> So, once again:

> If the intention is to test that a callable has a "__text_signature__", 
> then the code should test for the existance of "__text_signature__". 
> It should *not* try to test for types that may or may not have such 
> an attribute, and then just fail if it surprisingly does not find it.

Unfortunately this is something I do *not* want to change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Stefan Behnel]

Stefan Behnel added the comment:

> Since this is a problem in Cython, not in CPython, maybe you can fix it in 
> Cython?

I'm actually considering that. Now that Signature.from_function() allows
function-like types, it appears like it's the easiest solution to add a
"__signature__" property to cyfunctions that does the necessary "from
inspect import Signature, return Signature.from_function(self)" dance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20363] BytesWarnings triggerred by test suite

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

At least it wasn't changed.

As I see, affected line is used to output debugging message (disabled by 
default). It produces different result in 2.7 and 3.x 
("--xxx--" vs "--b'xxx'--") due to the 
difference between 2.x str and 3.x bytes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue747320] rfc2822 formatdate functionality duplication

[Éric Araujo]

Éric Araujo added the comment:

> what do you recommend to move forward with this bug and patches?

I would add tests to 3.4, to be sure that changing the code in 3.5 does not 
break compatibility.

> Do you have an example for "(A minor thing: I would use “attribute” instead 
> of “variable” in the docstrings.)"

“Deprecated weekdayname variable” → “Deprecated weekdayname attribute”

--
versions: +Python 3.5 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6650] sre_parse contains a confusing generic error message

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

May be. We should compare with regex and perhaps add a test.

--
assignee:  -> serhiy.storchaka
nosy: +ezio.melotti, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue6650] sre_parse contains a confusing generic error message

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

And of course we shouldn't use just %s. source.next can be non-printable 
character.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Yury Selivanov]

Yury Selivanov added the comment:

> I'm actually considering that. Now that Signature.from_function() allows
> function-like types, it appears like it's the easiest solution to add a
> "__signature__" property to cyfunctions that does the necessary "from
> inspect import Signature, return Signature.from_function(self)" dance.

Oh, sound like a big hack.

Stefan, Larry,

Please take a look at the new patch 'sig_cython_latest'

The change is really minimal, I think we can still push this in 3.4.

--
Added file: http://bugs.python.org/file34072/sig_cython_latest_01.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4

[Nick Coghlan]

Changes by Nick Coghlan :


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4

[Steve Dower]

Steve Dower added the comment:

It fails for me on 3.4.0rc1 and 3.3.4:

PS D:\> $env:PYTHONPATH
D:\Python33_x64\Lib\site-packages\virtualenv_support\pip-1.5.2-py2.py3-none-any.whl

PS D:\> py32 -V
Python 3.2.3
PS D:\> py32 -c "import pip; print(pip.__file__)"
D:\Python33_x64\Lib\site-packages\virtualenv_support\pip-1.5.2-py2.py3-none-any.whl\pip\__init__.py

PS D:\> py33 -V
Python 3.3.4
PS D:\> py33 -c "import pip; print(pip.__file__)"
D:\Python33\lib\site-packages\pip\__init__.py
(site-packages pip is after the wheel in sys.path)

PS D:\> py34 -V
Python 3.4.0rc1
PS D:\> py34 -c "import pip; print(pip.__file__)"
Traceback (most recent call last):
  File "", line 1, in 
ImportError: No module named 'pip'

Could it be because zipimporter is not a complete loader?

>>> import zipimport, importlib.abc
>>> issubclass(zipimport.zipimporter, importlib.abc.Loader)
False
>>> pprint(set(dir(importlib.abc.Loader)) - set(dir(zipimport.zipimporter)))
{'__abstractmethods__',
 '__dict__',
 '__module__',
 '__weakref__',
 '_abc_cache',
 '_abc_negative_cache',
 '_abc_negative_cache_version',
 '_abc_registry',
 'create_module',
 'module_repr'}

--
nosy: +steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue17159] Remove explicit type check from inspect.Signature.from_function()

[Stefan Behnel]

Stefan Behnel added the comment:

> Oh, sound like a big hack.

Well, it's certainly a bunch of overhead (even assuming that "inspect" will
most likely be imported already - just looked it up in import.c, there's
lots of useless generic code there), with a lot of potential for something
going wrong, but it should still be somewhat acceptable. Certainly not time
critical. Having to maintain our own function type isn't exactly the most
simple way of going about it in the first place.

I just tried it, it adds some 20 lines of C code but works ok.

> Please take a look at the new patch 'sig_cython_latest'
> The change is really minimal, I think we can still push this in 3.4.

I'm certainly ok with it, given that I had already asked for that a while ago.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20619] tracemalloc changes col_offset attribute for _ast.arg objects

[Roundup Robot]

Roundup Robot added the comment:

New changeset 2dd4922c9371 by Benjamin Peterson in branch 'default':
set line and column numbers for keyword-only arg nodes (closes #20619)
http://hg.python.org/cpython/rev/2dd4922c9371

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11406] There is no os.listdir() equivalent returning generator instead of list

[Ethan Furman]

Changes by Ethan Furman :


--
nosy: +ethan.furman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20622] Python3.3 venv pip fails to run if path contains spaces

[FeralBytes]

New submission from FeralBytes:

Well trying to test out venv on Python 3.3.2 on Linux Mint 16 x64 I was not 
able to get pip to execute correctly after it had been installed. The error 
from bash is:

(venv) wolfrage@wolfrage-KGP-M-E-D16 
/media/ShareDrives/HomePlus/Jordan/Projects/The Strategist $ pip install pysdl2
bash: /home/wolfrage/Projects/The Strategist/venv/bin/pip: 
/home/wolfrage/Projects/The: bad interpreter: No such file or directory

Same exact setup procedures in a path with out any spaces works as expected:

(venv) wolfrage@wolfrage-KGP-M-E-D16 
/media/ShareDrives/HomePlus/Jordan/Projects $ pip install pysdl2 
--allow-external pysdl2 --allow-unverified pysdl2
Downloading/unpacking pysdl2
  pysdl2 is potentially insecure and unverifiable.
  Downloading PySDL2-0.8.0.zip (1.1MB): 1.1MB downloaded
  Running setup.py 
(path:/media/ShareDrives/HomePlus/Jordan/Projects/venv/build/pysdl2/setup.py) 
egg_info for package pysdl2

Installing collected packages: pysdl2
  Running setup.py install for pysdl2

Successfully installed pysdl2
Cleaning up...
(venv) wolfrage@wolfrage-KGP-M-E-D16 
/media/ShareDrives/HomePlus/Jordan/Projects $ python3
Python 3.3.2+ (default, Oct  9 2013, 14:50:09) 
[GCC 4.8.1] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sdl2
>>> exit()

I hope that this can be fixed prior to 3.4 being released.
This not only affected pip but easy_install too.

--
components: Library (Lib)
messages: 211193
nosy: FeralBytes
priority: normal
severity: normal
status: open
title: Python3.3 venv pip fails to run if path contains spaces
type: behavior
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20620] Update the min()/max() docs for the new default argument

[Yury Selivanov]

Changes by Yury Selivanov :


--
nosy: +larry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4

[Gregory P. Smith]

Gregory P. Smith added the comment:

gah.  i was tracking this down because I saw some strange errors that made me 
suspect it might exist (in 2.7) when trying to use a zipped up standard library 
but had not had time to confirm it. :(

I really should have rolled back the CLs causing it before 3.3.4 given that 
investigation was ongoing.  :(

We need to fix this breakage before 3.4.0 release.  The best thing to do for 
3.4.0 is likely be to revert the following change:
 http://hg.python.org/cpython/rev/20b77ff040b6

For 3.3 the change that caused this is likely:
  http://hg.python.org/cpython/rev/2807a5f011e4

reverting that would restore the previous behavior.

Paul, are you in a position to try building 3.3.4 with that CL reverted to 
confirm?

We need better zipimport tests.
That test_zipimport passes while this problem exists is bad.

If you can come up with a reproducable test case for this, please go ahead and 
check it in to test_zipimport to highlight the brokenness.

--
nosy: +larry
priority: critical -> release blocker
versions: +Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

[Gregory P. Smith]

Changes by Gregory P. Smith :


--
title: Issue with zipimport in 3.3.4 -> Issue with zipimport in 3.3.4 and 
3.4.0rc1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20550] Use specific asserts in collections tests

[Raymond Hettinger]

Raymond Hettinger added the comment:

The patch is missing.

--
assignee:  -> rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20552] Use specific asserts in bytes tests

[Raymond Hettinger]

Raymond Hettinger added the comment:

None of these should be backported.

--
nosy: +rhettinger
versions: +Python 3.5 -Python 2.7, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20547] Use specific asserts in bigmem tests

[Raymond Hettinger]

Raymond Hettinger added the comment:

These should be backported.

And it probably shouldn't be done at all unless there is an actual failure with 
an uninformative error message.  Otherwise, you're just destabilizing the test 
suite and creating unnecessary code churn.

In the case of the collections tests, I used test-driven-development for parts 
of it and am very confident in the test as they stand.  If you start  switching 
the test methods, I become less confident in those tests (i.e. I haven't seen 
the new ones fail in the absence of the code they were meant to test).

Additionally, the "more specific tests" introduce some additional opacity that 
is harmful for knowing what methods and operators are specifically used 
internally in test method.  For end users of Python, they don't have to worry 
much about this, but we as developers of core types really care whether 
self.assertLessThan(x, y) really does x < y, or x.__lt__(y), or "not y >= x", 
etc.

IOW, I am of the strong opinion that your patches are not a good idea.  The 
"more specific tests" can be used in new tests or in tests that are failing, 
but going back and making blanket sweeps of the test suite isn't a good 
practice.

Please lookup Guido's comments on "holistic refactoring" being preferred to 
these kind of "sweeps".

--
nosy: +rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19081] zipimport behaves badly when the zip file changes while the process is running

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20621] Issue with zipimport in 3.3.4 and 3.4.0rc1

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19627] python open built-in function - "updating" is not defined

[Ezio Melotti]

Ezio Melotti added the comment:

This seems to be in 3.3 already, so only 2.7 is left.

--
keywords: +easy
stage:  -> needs patch
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19680] Help missing for exec and print

[Roundup Robot]

Roundup Robot added the comment:

New changeset cc62d856fc5f by Ezio Melotti in branch '2.7':
#19680: add back documentation for print and exec in the interactive help.
http://hg.python.org/cpython/rev/cc62d856fc5f

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue19680] Help missing for exec and print

[Ezio Melotti]

Ezio Melotti added the comment:

Fixed, thanks for the report!

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20623] Run test_htmlparser with unbuffered source

[Ezio Melotti]

Changes by Ezio Melotti :


--
dependencies: +Deprecate strict mode of HTMLParser

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20623] Run test_htmlparser with unbuffered source

[Ezio Melotti]

New submission from Ezio Melotti:

Currently test_htmlparser feeds the HTML source to the parser one char at the 
time (except a couple of buffering-specific tests that feed the parser with 
chunks of text).  This ensures that the parser doesn't break when the source is 
fed in smaller chunks (that might end in the middle of a tag).  However #20288 
revealed a bug that doesn't happen while feeding the parser char by char.

In order to avoid similar problems, all the tests should feed the source to the 
parser both char by char and as a single string.
So my plan is:
1) wait until #15114 is resolved and the strict mode and the strict tests are 
removed;
2) either change TestCaseBase._run_check() to run every test twice (possibly by 
using subTest), or use a subclass-based approach with a different _run_check in 
the two subclasses.

A few notes about this:
* a third kind of test that feeds the parser with chunk of arbitrary length 
(e.g. 5 chars) could be added as well;
* the increase in run-time shouldn't matter, since all the tests take very 
little time to run;
* I don't think it's necessary to backport this to 2.7/3.3/3.4 because it's a 
somewhat major refactoring, and if a bug is introduced by other changes the 
tests in 3.5 will find it (I expect all the bug fixes and new features to land 
in 3.5 too);

--
assignee: ezio.melotti
components: Tests
messages: 211201
nosy: ezio.melotti, r.david.murray
priority: normal
severity: normal
stage: needs patch
status: open
title: Run test_htmlparser with unbuffered source
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20288] HTMLParse handing of non-numeric charrefs broken

[Ezio Melotti]

Ezio Melotti added the comment:

This is now fixed, thanks for the report!

> This should be fixed, and the behavior of _run_check should probably be
> changed too -- maybe it could test both the char-by-char and the
> regular feeding.

I created #20623 to track this.

--
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20605] test_socket (testGetaddrinfo) failing on OS X 10.6.8 (32-bit)

[Roundup Robot]

Roundup Robot added the comment:

New changeset 6017d19669c3 by Ned Deily in branch '2.7':
Issue #20605: Make test_socket getaddrinfo OS X segfault test more robust.
http://hg.python.org/cpython/rev/6017d19669c3

New changeset 11a75f141cec by Ned Deily in branch '3.3':
Issue #20605: Make test_socket getaddrinfo OS X segfault test more robust.
http://hg.python.org/cpython/rev/11a75f141cec

New changeset 378bdb92e5b7 by Ned Deily in branch 'default':
Issue #20605: Make test_socket getaddrinfo OS X segfault test more robust.
http://hg.python.org/cpython/rev/378bdb92e5b7

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20605] test_socket (testGetaddrinfo) failing on OS X 10.6.8 (32-bit)

[Ned Deily]

Ned Deily added the comment:

The committed changes should prevent spurious test failures.  Thanks for the 
report.

--
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9694] argparse required arguments displayed under "optional arguments"

[paul j3]

paul j3 added the comment:

Here's another possible solution: add a `help_groups` parameter to 
ArgumentParser.  It is a list of base argument group names.  
`parser.add_argument(...)' places the action in one of those groups.

This is a generalization of the current code which creates two groups titled 
'positional arguments' and 'optional arguments', and assigns actions based on 
'optional strings' (e.g. '-f','--foo').

'help_groups' could have 1, 2, or 3 items.  

1 - just one argument group

2 - the current postional/optional split, but with user chosen names

3 - a 'positional', 'required', and 'optional' split.  

A 4 way split that distinguishes splits positionals between those that allow 0 
values and 1 or more, is possible, but probably not that useful.

The changes are in the ArgumentParser.__init__ and _add_action methods.

'subparsers' do not inherit this parameter.  I have not explored how it plays 
out with 'parents'. 'test_argparse.py' runs fine.

--
keywords: +patch
Added file: http://bugs.python.org/file34073/helpgroups.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue9694] argparse required arguments displayed under "optional arguments"

[paul j3]

Changes by paul j3 :


Added file: http://bugs.python.org/file34074/alt_grouping2.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com