[issue15661] OS X installer packages should be signed for OS X 10.8 Gatekeeper feature

[Ned Deily]

Ned Deily added the comment:

An additional point: the 3.3.0 Installer README and python.org web pages need 
to be updated to incorporate 10.8 installation information as necessary prior 
to final release. (in progress)

Also, s/singing/signing/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15649] subprocess.Popen.communicate: accept str for input parameter if universal_newlines is False

[Ramchandra Apte]

Ramchandra Apte added the comment:

Uhum.. Universal Newlines is being deprecated.

--
nosy: +ramchandra.apte

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15649] subprocess.Popen.communicate: accept str for input parameter if universal_newlines is False

[R. David Murray]

R. David Murray added the comment:

No it isn't.  There's some issue about a 'U' parameter somewhere that is being 
deprecated, but that has nothing to do with this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15390] PEP 3121, 384 refactoring applied to datetime module

[Robin Schreiber]

Robin Schreiber added the comment:

I have now included the changes that Antoine suggested. The _Get_State was used 
for debugging purposes and is, as I think, no longer necessary.

However we have yet to find a solution for the decref inside the dealloc 
methods.

--
Added file: 
http://bugs.python.org/file26817/_datetimemodule_pep3121-384_v2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15655] PEP 384 Refactoring applied to json module

[Robin Schreiber]

Robin Schreiber added the comment:

Removed C++ comment and corresponding codesnipped. Also changed bad-style macro 
definition.

--
Added file: http://bugs.python.org/file26818/_json_pep384_v1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15662] PEP 3121 refactoring applied to locale module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 have now been applied to the locale module!

--
components: Extension Modules
files: _locale_pep3121_v0.patch
keywords: patch
messages: 168268
nosy: Robin.Schreiber, loewis
priority: normal
severity: normal
status: open
title: PEP 3121 refactoring applied to locale module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26819/_locale_pep3121_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.5 with OS X installers

[Ned Deily]

New submission from Ned Deily:

The current situation with Tcl/Tk on OS X is less than ideal.  The 
Apple-supplied versions of the Cocoa-based Aqua Tk 8.5 on 10.6 was unusable 
with IDLE and most Tkinter applications.  The 10.7 and 10.8 versions are better 
but still have serious crashers that have been more recently fixed.  python.org 
installers currently also support using ActiveTcl release but that is also not 
ideal as there are license restrictions for some users and a separate download 
and install is required.  We should be able to provide a better out-of-the-box 
experience if python.org installers included its own copies of up-to-date 
Tcl/Tk libraries (as is the case with the Windows installers).  It would be 
good to still give users the option to use ActiveTcl for any of its additional 
features or to use system Python.  Also we could also look at providing Tcl/Tk 
8.5 for 10.5 users (possibly only Intel ones) which we currently do not.

--
assignee: ned.deily
components: Build, Installation, Macintosh
messages: 168269
nosy: ned.deily, ronaldoussoren
priority: normal
severity: normal
status: open
title: Investigate providing Tcl/Tk 8.5 with OS X installers
type: enhancement
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.5 with OS X installers

[Ronald Oussoren]

Ronald Oussoren added the comment:

A major reason for why the current installers don't install Tk as well is that 
this would significantly increase the size of the installer.

There's also the question of what bits of Tcl/Tk should be bundled, although I 
guess we should ship a minimal install of Tk that still supports everything 
that is wrapped by the python std lib. Alternatively we could ship the same 
subset as the Windows installer.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15663] Investigate providing Tcl/Tk 8.5 with OS X installers

[Ned Deily]

Ned Deily added the comment:

Yes, it would have to be a subset since some of the stuff in the ActiveTcl 
releases is unavailable anyway. But the current ActiveTcl installer dmgs are 
around 24Mb while the 3.3.0 installers are a little less than 20Mb.  Even if it 
were to double the size, 40Mb still seems pretty small by today's standards.  
And following the Windows installer lead would be a good starting point.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Ronald Oussoren]

New submission from Ronald Oussoren:

I noticed that 'test_curses' is not started when performing "make test" on an 
OSX box:

...
[ 42/369] test_curses
test_curses skipped -- sys.__stdout__ is not a tty
...

The host is a machine running OSX 10.8, fully up-to-date with patches and the 
current version of Xcode. 

The same thing happens when starting the testrunning in the same way as used by 
the test target in the Makefile:

$ ./python.exe -W default -bb -E -R -m test -r -w -j 0 -u 
all,-largefile,-audio,-gui test_curses
Using random seed 9471227
[1/1] test_curses
test_curses skipped -- sys.__stdout__ is not a tty
1 test skipped:
test_curses
Those skips are all expected on darwin.

--
components: Tests
messages: 168272
nosy: ronaldoussoren
priority: normal
severity: normal
status: open
title: test_curses not run with 'make test'
versions: Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15535] Fix pickling of named tuples in 2.7.3

[Thomas Miedema]

Thomas Miedema added the comment:

Attached is a script that shows the problem at hand.

Note that my remark that this bug could result in very large pickled files when 
using nested namedtuples seems not te be true.

--
Added file: http://bugs.python.org/file26820/show_namedtuple_pickle_fix.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Ned Deily]

Ned Deily added the comment:

This appears to be the same issue as raised in Issue12669.  Apparently it is 
not fixed.

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13370] test_ctypes fails when building python with clang

[Ronald Oussoren]

Ronald Oussoren added the comment:

The attached patch syncs libffi_osx with the copy of libffi that's included 
with PyObjC. 

With this patch test_ctypes passes for me when using clang to build on OSX 10.8.

I haven't run the tests with other python releases yet, and also not on a OSX 
10.5 system (where I can test if the patch works with GCC as well)

--
Added file: http://bugs.python.org/file26821/issue_13370.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Ronald Oussoren]

Ronald Oussoren added the comment:

the test does get run with 'make buildbottest', and then fails with a 
ValueError exception:


$ /Users/ronald/Projects/python/rw/default/tbuild/python.exe -W default -bb -E 
-R -m test -r -w -j 1 -u all -W --timeout=3600 test_curses
Using random seed 2242495
[1/1] test_curses
test test_curses crashed -- Traceback (most recent call last):
  File "/Users/ronald/Projects/python/rw/default/Lib/test/regrtest.py", line 
1221, in runtest_inner
test_runner()
  File "/Users/ronald/Projects/python/rw/default/Lib/test/test_curses.py", line 
338, in test_main
main(stdscr)
  File "/Users/ronald/Projects/python/rw/default/Lib/test/test_curses.py", line 
324, in main
test_unget_wch(stdscr)
  File "/Users/ronald/Projects/python/rw/default/Lib/test/test_curses.py", line 
283, in test_unget_wch
read = chr(read)
ValueError: chr() arg not in range(0x11)


That might be a bug in libcurses on OSX, I haven't tested with a separate 
install of libcurses yet.

BTW. The patch mentioned in Issue12669 looks slightly bogus: as buildbot is a 
daemon it might not even have a controlling tty. With some luck a proper fix 
will require the explicit use of a pseudo-tty.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11062] mailbox fails to round-trip a file to a Babyl mailbox

[Petri Lehtinen]

Petri Lehtinen added the comment:

This happens because of a bug in Babyl._install_message(). When adding a 
message from file, the "*** EOOH ***" line is written also after the second set 
of headers.

--
nosy: +petri.lehtinen

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Ned Deily]

Ned Deily added the comment:

The "chr() arg not in range(0x11)" from test_unget_wch is due to a bug in 
ncurses < 5.8; see Issue15037.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Ronald Oussoren]

Ronald Oussoren added the comment:

I knew the test failure looked familiar, but couldn't find the issue in the 
tracker.


This issue (test_curses not running with make test) is due to '-j0' in the 
arguments to the test runner: with -j0 the runner uses multiprocessing and the 
stdout and stderr of the child processes are pipes, hence both sys.stdout and 
sys.__stdout__ are not tty's and the test isn't started.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15586] Provide some examples for usage of ElementTree methods/attributes

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8d90fde35cc6 by Eli Bendersky in branch 'default':
Issue #15586: typo fix. This commit is accompanied by an apology for all 
Liechtensteiners out there, and a thanks to Eric Araujo for noticing.
http://hg.python.org/cpython/rev/8d90fde35cc6

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15586] Provide some examples for usage of ElementTree methods/attributes

[Eli Bendersky]

Eli Bendersky added the comment:

Daniel, this looks good except that the section numbering is different from 3.3 
where the object/function reference sections were nested under "Reference". 
Could you fix your patch to align the 2.7 doc to this structure?

P.S. Éric's comment also has to be fixed ;)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15656] "Extending Python with C" page needs update for 3.x

[Eli Bendersky]

Changes by Eli Bendersky :


--
nosy: +eli.bendersky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11062] mailbox fails to round-trip a file to a Babyl mailbox

[Roundup Robot]

Roundup Robot added the comment:

New changeset ad8c9725c041 by Petri Lehtinen in branch '2.7':
#11062: Fix adding a message from file to Babyl mailbox
http://hg.python.org/cpython/rev/ad8c9725c041

New changeset cbc1dc8cda06 by Petri Lehtinen in branch '3.2':
#11062: Fix adding a message from file to Babyl mailbox
http://hg.python.org/cpython/rev/cbc1dc8cda06

New changeset 7c8c6b905a18 by Petri Lehtinen in branch 'default':
#11062: Fix adding a message from file to Babyl mailbox
http://hg.python.org/cpython/rev/7c8c6b905a18

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11062] mailbox fails to round-trip a file to a Babyl mailbox

[Petri Lehtinen]

Changes by Petri Lehtinen :


--
resolution:  -> fixed
stage: needs patch -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11062] mailbox fails to round-trip a file to a Babyl mailbox

[Petri Lehtinen]

Changes by Petri Lehtinen :


--
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15656] "Extending Python with C" page needs update for 3.x

[Roundup Robot]

Roundup Robot added the comment:

New changeset 599376deeeac by Eli Bendersky in branch '3.2':
Issue #15656: fixing code sample in extending doc
http://hg.python.org/cpython/rev/599376deeeac

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15656] "Extending Python with C" page needs update for 3.x

[Eli Bendersky]

Eli Bendersky added the comment:

Fixed, thanks for the report.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15629] Run doctests in Doc/*.rst as part of regrtest

[Eli Bendersky]

Eli Bendersky added the comment:

I think implementing this is very important, and +1 to Georg's suggestion, 
because no one is suddenly going to convert KLOCs of code samples to be 
testable (many code samples are partial, and will need to be completed in one 
way or another to be actually runnable).

However, do I understand correctly that this is blocked on #10224?

--
nosy: +eli.bendersky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15629] Run doctests in Doc/*.rst as part of regrtest

[Chris Jerdonek]

Chris Jerdonek added the comment:

I would like the chance to try implementing this without depending on Sphinx 
and "make doctest".  I don't think it would take much work, and it would let us 
leverage and hook into regrtest's existing options (like test selection by 
name).  I am also okay with exposing this via an option rather than including 
the doctests by default, which seemed to be the main concern expressed by 
others.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[R. David Murray]

R. David Murray added the comment:

So this should be closed as a duplicate of issue 12669?

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Ronald Oussoren]

Ronald Oussoren added the comment:

Yes.

I'll add a message to that issue to note that is also affects 'make test'

--
resolution:  -> duplicate
stage:  -> committed/rejected
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12669] test_curses skipped on buildbots

[Ronald Oussoren]

Ronald Oussoren added the comment:

As noted in Issue15664 this issue also affects "make test".

--
nosy: +ronaldoussoren

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Chris Jerdonek]

Chris Jerdonek added the comment:

Here is the patch for 2.7.

--
Added file: http://bugs.python.org/file26822/issue-15543-6-py27.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12669] test_curses skipped on buildbots

[Ronald Oussoren]

Ronald Oussoren added the comment:

Nadeem: is the failure you show in msg141798 with a version of test_curses that 
uses pty.openpty? 

If it isn't: I'd expect more test failures on buildbot machines where the 
buildbot agent is started as a system daemon, in which case the process doesn't 
have a tty at all. Using pty.openpty it would be possible to ensure that there 
is a pty that can be used for the test.

I'll work on a patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15665] PEP 3121, 384 refactoring applied to lsprof module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the lsprof 
module!

--
components: Extension Modules
files: _lsprof_pep3121-384_v0.patch
keywords: patch
messages: 168292
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 refactoring applied to lsprof module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26823/_lsprof_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12669] test_curses skipped on buildbots

[Ronald Oussoren]

Ronald Oussoren added the comment:

BTW. the documentation for curses.setupterm says:

curses.setupterm([termstr, fd])

The first argument is actually named "term" in the C code.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15666] PEP 3121, 384 refactoring applied to lzma module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the lzma module!

--
components: Extension Modules
files: _lzma_pep3121-384_v0.patch
keywords: patch
messages: 168294
nosy: Robin.Schreiber, nadeem.vawda
priority: normal
severity: normal
status: open
title: PEP 3121, 384 refactoring applied to lzma module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26824/_lzma_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15667] PEP 3121, 384 refactoring applied to pickle module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the pickle 
module!

--
components: Extension Modules
files: _pickle_pep3121-384_v0.patch
keywords: patch
messages: 168295
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 refactoring applied to pickle module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26825/_pickle_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Chris Jerdonek]

Changes by Chris Jerdonek :


Added file: http://bugs.python.org/file26826/issue-15543-6-py32.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Chris Jerdonek]

Chris Jerdonek added the comment:

And here are the 3.2 patch and the 3.3 "delta" after forward-porting.  Note 
that to forward-port the 3.2 patch to the default 3.3 branch, you can simply 
drop the changes to the file Doc/library/bz2.rst.  I think that is the only 
conflict.

--
Added file: http://bugs.python.org/file26827/issue-15543-6-py33-delta.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15668] PEP 3121, 384 Refactoring applied to random module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the lsprof 
module!

--
components: Extension Modules
files: _random_pep3121-384_v0.patch
keywords: patch
messages: 168297
nosy: Robin.Schreiber, rhettinger
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to random module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26828/_random_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15669] PEP 3121, 384 Refactoring applied to sre module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the sre module!

--
components: Extension Modules
files: _sre_pep3121-384_v0.patch
keywords: patch
messages: 168298
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to sre module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26829/_sre_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15668] PEP 3121, 384 Refactoring applied to random module

[Raymond Hettinger]

Raymond Hettinger added the comment:

Martin, does this patch match your intent with PEP3121 and PEP384?

--
assignee:  -> loewis
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15643] Support OpenCSW in setup.py

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy: +loewis

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15670] PEP 3121, 384 Refactoring applied to ssl module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the ssl module!

--
components: Extension Modules
files: _ssl_pep3121-384_v0.patch
keywords: patch
messages: 168300
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to ssl module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26830/_ssl_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15573] Support unknown formats in memoryview comparisons

[Stefan Krah]

Stefan Krah added the comment:

Here is a new patch that hopefully addresses all comments.

--
Added file: http://bugs.python.org/file26831/issue15573-struct-2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15623] Init time relative imports no longer work from __init__.so modules

[Brett Cannon]

Brett Cannon added the comment:

I'm glad the work-around at least works, but I would still like to find out 
what the heck 3.2 is doing to see if it's reasonable to replicate in 3.3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15671] PEP 3121, 384 Refactoring applied to struct module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the struct 
module!

--
components: Extension Modules
files: _struct_pep3121-384_v0.patch
keywords: patch
messages: 168302
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to struct module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26832/_struct_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15672] PEP 3121, 384 Refactoring applied to testbuffer module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the testbuffer 
module!

--
components: Extension Modules
files: _testbuffer_pep3121-384_v0.patch
keywords: patch
messages: 168304
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to testbuffer module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26833/_testbuffer_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15672] PEP 3121, 384 Refactoring applied to testbuffer module

[Robin Schreiber]

Changes by Robin Schreiber :


--
nosy: +skrah -Robin.Schreiber

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15672] PEP 3121, 384 Refactoring applied to testbuffer module

[Robin Schreiber]

Changes by Robin Schreiber :


--
nosy: +Robin.Schreiber

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15673] PEP 3121, 384 Refactoring applied to testcapi module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the testcapi 
module!

--
components: Extension Modules
files: _testcapi_pep3121-384_v0.patch
keywords: patch
messages: 168305
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to testcapi module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26834/_testcapi_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15674] PEP 3121, 384 Refactoring applied to thread module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the thread 
module!

--
components: Extension Modules
files: _thread_pep3121-384_v0.patch
keywords: patch
messages: 168306
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to thread module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26835/_thread_pep3121-384_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15675] PEP 3121, 384 Refactoring applied to array module

[Robin Schreiber]

New submission from Robin Schreiber:

Changes proposed in PEP3121 and PEP384 have now been applied to the array 
module!

--
components: Extension Modules
files: array_pep3121-385_v0.patch
keywords: patch
messages: 168307
nosy: Robin.Schreiber
priority: normal
severity: normal
status: open
title: PEP 3121, 384 Refactoring applied to array module
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file26836/array_pep3121-385_v0.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Roundup Robot]

Roundup Robot added the comment:

New changeset 273df9789796 by R David Murray in branch '3.2':
#15543: glossary entry for and 'universal newlines', and links to it.
http://hg.python.org/cpython/rev/273df9789796

New changeset e67042b6ad02 by R David Murray in branch '3.2':
#15543: reflow paragraphs.
http://hg.python.org/cpython/rev/e67042b6ad02

New changeset 04a0255de9b8 by R David Murray in branch 'default':
Merge #15543: glossary entry for and 'universal newlines', and links to it.
http://hg.python.org/cpython/rev/04a0255de9b8

New changeset 37df50bc4ea0 by R David Murray in branch 'default':
#15543: additional link in subprocess docs.
http://hg.python.org/cpython/rev/37df50bc4ea0

New changeset a2efe5eeb876 by R David Murray in branch 'default':
#15543: reflow paragraph.
http://hg.python.org/cpython/rev/a2efe5eeb876

New changeset 8795cd3b4c8c by R David Murray in branch '2.7':
#15543: glossary entry for and 'universal newlines', and links to it.
http://hg.python.org/cpython/rev/8795cd3b4c8c

New changeset 35d8a638b0e2 by R David Murray in branch '2.7':
#15543: reflow paragraphs.
http://hg.python.org/cpython/rev/35d8a638b0e2

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[R. David Murray]

R. David Murray added the comment:

Thanks Chris.

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Andrew Svetlov]

Andrew Svetlov added the comment:

Good work.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Chris Jerdonek]

Chris Jerdonek added the comment:

Thanks, David!  Also, can/did you check that reflows like these still link to 
the glossary correctly?

+  :func:`input` function to allow opening files in binary or :term:`universal
+  newlines` mode.  Another new parameter, *openhook*, lets you use a function

I tried to avoid breaking role markups like these to be safe

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Andrew Svetlov]

Andrew Svetlov added the comment:

Yes, it is processed correctly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15625] Support u and w codes in memoryview

[Stefan Krah]

Stefan Krah added the comment:

Nick's comment in msg167963 got me thinking. Indeed, in Numpy the 'U'
specifier is similar to the struct module's 's' format code, only for
UCS4. So I'm questioning whether the current semantics of 'u' and 'w'
used by array.array were ever intended by the PEP authors:


import numpy

>>> nd = numpy.array(["A", "B"], dtype='U')
>>> nd
array(['A', 'B'],
  dtype='>> nd.tostring()
b'A\x00\x00\x00B\x00\x00\x00'
>>>
>>> nd = numpy.array(["ABC", "D"], dtype='U')
>>> nd
array(['ABC', 'D'],
  dtype='>> nd.tostring()
b'A\x00\x00\x00B\x00\x00\x00C\x00\x00\x00D\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00'
>>>


Internally, in NumPy 'U' is always UCS4, and the data type is a fixed
length string that has the length of the longest initializer element.


NumPy's use of 'U' seems vastly more useful for arrays than the behavior
of array.array:

>>> array.array('u', ['A', 'B'])
array('u', 'AB')
>>> array.array('u', ['ABC', 'D'])
Traceback (most recent call last):
  File "", line 1, in 
TypeError: array item must be unicode character


In Numpy, arrays of words are possible, with array.array they are not.

An additional thought: The convention in the struct module is to use
uppercase for unsigned types. So it would be a possibility to use
'C', 'U' and 'W', where '3C' would denote the same as '3s', except
for UCS1 instead of bytes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15676] mmap: add empty file check prior to offset check

[Steven Willis]

New submission from Steven Willis:

There are a number of issues dealing with the offset and length checks in 
offset, such as issue12556.

I'm running into this issue as well, but with a normal file that happens to be 
empty. I'm trying to access it with:

mmap.mmap(f.fileno(), length=0, access=mmap.ACCESS_READ)

So the length and offset should be calculated automatically. The man page for 
mmap says:

"SUSv3 specifies that mmap() should fail if length is 0.  However, in kernels 
before 2.6.12, mmap() succeeded in this case: no mapping was created and the 
call returned  addr.   Since  kernel  2.6.12, mmap() fails with the error 
EINVAL for this case."

So alright, mmapping an empty file is now allowed. But, could the check for an 
empty file be done prior to the check for the offset exceeding the size of the 
file? It would be much clearer in the cases where an empty (regular or 
otherwise) file was mmapped if the error message were something like "empty 
files cannot be mapped" insted of "offset is greater than file size" since I 
didn't even set the offset.

--
components: Library (Lib)
messages: 168314
nosy: Steven.Willis
priority: normal
severity: normal
status: open
title: mmap: add empty file check prior to offset check
type: behavior
versions: Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15643] Support OpenCSW in setup.py

[Martin v . Löwis]

Martin v. Löwis added the comment:

LGTM. In the usual case, it is harmless if the system is no Solaris, or OpenCSW 
is not installed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15346] Tkinter extention modules no documentation

[Daniel Swanson]

Daniel Swanson added the comment:

For that matter, none of the following have docs:
tkinter.colorchooser
tkinter.commondialog
tkinter.filedialog
tkinter.font
tkinter.messagebox
tkinter.simpledialog
tkinter.dnd
Perhaps this should be remidied? One sentence usualy does not describe the use 
of an entire module.

--
title: Tkinter dnd has no documentation -> Tkinter extention modules no 
documentation
type:  -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15346] Tkinter extention modules have no documentation

[Daniel Swanson]

Changes by Daniel Swanson :


--
title: Tkinter extention modules no documentation -> Tkinter extention modules 
have no documentation

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Andrew Svetlov]

Andrew Svetlov added the comment:

Antoine, can you explain why subprocess support for universal_newlines is 
broken?

As I can see tests for universal_newlines passed and these looks correct.

In general I like your idea to get rid of os.write, but maybe that patch should 
be landed in 3.4?

If not — I will prepare fix ASAP.

--
nosy: +r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15625] Support u and w codes in memoryview

[Martin v . Löwis]

Martin v. Löwis added the comment:

Travis: can you please comment on what the intended semantics of the 'u' and 
'w' specifiers is, in PEP 3118? More specifically:

- "an array/memoryview with format 'u' can support exactly one-character values 
(i.e. unicode strings of length 1)": true or false?
- "in a struct, an element of type 'u' will use up two bytes exactly (ignoring 
padding)": true or false?

--
nosy: +teoliphant

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15656] "Extending Python with C" page needs update for 3.x

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15656] "Extending Python with C" page needs update for 3.x

[Jesús Cea Avión]

Jesús Cea Avión added the comment:

Should this be applied to "default" (3.3) too?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Chris Jerdonek]

Chris Jerdonek added the comment:

Andrew, I'm not sure if this is the issue, but it seems like the only tests in 
which input is passed to communicate() with universal newlines is when stdin is 
the only PIPE, i.e.:

def test_universal_newlines_communicate_stdin(self):
# universal newlines through communicate(), with only stdin

IIRC, the select() and poll() implementations are only called when at least two 
of the streams are PIPE (like in the new input_none test I added recently).  
Have you tried passing input to communicate() with at least two pipes (e.g. 
stdin and stdout)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15656] "Extending Python with C" page needs update for 3.x

[Sandro Tosi]

Sandro Tosi added the comment:

It's fixed in default too: http://hg.python.org/cpython/rev/f46b4b7b817c

It was not shown because the commit message misses the issue reference.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15661] OS X installer packages should be signed for OS X 10.8 Gatekeeper feature

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Antoine Pitrou]

Antoine Pitrou added the comment:

As Chris said. Look at the POSIX version of _communicate(), nowhere is input 
given the newlines/encoding treatment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15676] mmap: add empty file check prior to offset check

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15676] mmap: add empty file check prior to offset check

[Jesús Cea Avión]

Jesús Cea Avión added the comment:

I do agree. Solaris also returns an error if len=0.

Could you please, provide patches for 2.7, 3.2 and 3.3?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11062] mailbox fails to round-trip a file to a Babyl mailbox

[Andrew Svetlov]

Andrew Svetlov added the comment:

Reopen the issue because Windows tests is failed.

Commits for this issue breaks Windows buildbot for 3.2 and 3.3.
Looks like problem is: Windows os.linesep different than Unix.

I don't know what format expected by protocol.

--
nosy: +asvetlov
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Andrew Svetlov]

Andrew Svetlov added the comment:

I've pushed test for piping stdin, stdout and and stderr: 4af2c0687970
What other test we should to add?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11062] mailbox fails to round-trip a file to a Babyl mailbox

[Petri Lehtinen]

Petri Lehtinen added the comment:

Yeah. Enabling the Babyl tests discovered yet another bug on a code path that 
wasn't excercised at all. I'll fix it.

--
assignee:  -> petri.lehtinen
resolution: fixed -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15666] PEP 3121, 384 refactoring applied to lzma module

[Nadeem Vawda]

Nadeem Vawda added the comment:

Thanks for the patch. Unfortunately I don't have much free time at the
moment, so it might be a few weeks before I get a chance to review it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15664] test_curses not run with 'make test'

[Nadeem Vawda]

Changes by Nadeem Vawda :


--
superseder:  -> test_curses skipped on buildbots

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Andrew Svetlov]

Andrew Svetlov added the comment:

Оор. I see. Pushing to communicate input with "\r" (see attached patch) 
produces the error.

Will work on fixing.

Thanks.

--
keywords: +patch
Added file: http://bugs.python.org/file26837/issue12623_failing_test.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Andrew Svetlov]

Andrew Svetlov added the comment:

I like to set status for the issue to "Release blocker" if Georg Brandl agree 
with that.

--
nosy: +georg.brandl
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Antoine Pitrou]

Antoine Pitrou added the comment:

> Оор. I see. Pushing to communicate input with "\r" (see attached patch) 
> produces the error.

Hmm, no, it's the reverse. Pushing input with "\n" should produce b"\r\n" on 
the other side, under Windows.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Antoine Pitrou]

Antoine Pitrou added the comment:

Well, it's not a regression and it may be slightly delicate, so I don't think 
it should be a release blocker.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15677] Gzip/zlib allows for compression level=0

[Sandro Tosi]

New submission from Sandro Tosi:

As reported at http://mail.python.org/pipermail/docs/2012-August/009837.html 
gzip/zlib allows for a compression level=0 (that's basically no compression) so 
the documentation should mention that possibility too.

--
assignee: docs@python
components: Documentation
messages: 168332
nosy: docs@python, sandro.tosi
priority: normal
severity: normal
stage: needs patch
status: open
title: Gzip/zlib allows for compression level=0
versions: Python 2.7, Python 3.2, Python 3.3

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Andrew Svetlov]

Andrew Svetlov added the comment:

The main question: can be fix applied to 3.3 or it can wait for 3.4?
3.2 has the same problem BTW.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15390] PEP 3121, 384 refactoring applied to datetime module

[Antoine Pitrou]

Antoine Pitrou added the comment:

> However we have yet to find a solution for the decref inside the dealloc 
> methods.

Perhaps ask for advice on python-dev?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Chris Jerdonek]

Chris Jerdonek added the comment:

> Pushing to communicate input with "\r" (see attached patch) produces the 
> error.

Is this a supported use case?  In universal newlines, stdin line endings are 
supposed to be "\n".  From the subprocess documentation: "For stdin, line 
ending characters '\n' in the input will be converted to the default line 
separator os.linesep."

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Andrew Svetlov]

Andrew Svetlov added the comment:

The real test should to put '\n' and subprocess should get '\r\n', right?
Looking the code this test will fail on Windows. 
I cannot check it just now but looks like this is the problem.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15604] PyObject_IsTrue failure checks

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Patches updated again.

--
Added file: http://bugs.python.org/file26838/istrue_check-3.3_3.patch
Added file: http://bugs.python.org/file26839/istrue_check-3.2_3.patch
Added file: http://bugs.python.org/file26840/istrue_check-2.7_3.patch

___
Python tracker 

___diff -r 5dc2b4a542f1 Modules/_csv.c
--- a/Modules/_csv.cWed Aug 15 22:53:56 2012 +0300
+++ b/Modules/_csv.cWed Aug 15 23:48:49 2012 +0300
@@ -196,8 +196,12 @@
 {
 if (src == NULL)
 *target = dflt;
-else
-*target = PyObject_IsTrue(src);
+else {
+int b = PyObject_IsTrue(src);
+if (b < 0)
+return -1;
+*target = b;
+}
 return 0;
 }
 
diff -r 5dc2b4a542f1 Modules/_io/textio.c
--- a/Modules/_io/textio.c  Wed Aug 15 22:53:56 2012 +0300
+++ b/Modules/_io/textio.c  Wed Aug 15 23:48:49 2012 +0300
@@ -1056,8 +1056,11 @@
 res = _PyObject_CallMethodId(buffer, &PyId_seekable, NULL);
 if (res == NULL)
 goto error;
-self->seekable = self->telling = PyObject_IsTrue(res);
+r = PyObject_IsTrue(res);
 Py_DECREF(res);
+if (r < 0)
+goto error;
+self->seekable = self->telling = r;
 
 self->has_read1 = _PyObject_HasAttrId(buffer, &PyId_read1);
 
diff -r 5dc2b4a542f1 Modules/_posixsubprocess.c
--- a/Modules/_posixsubprocess.cWed Aug 15 22:53:56 2012 +0300
+++ b/Modules/_posixsubprocess.cWed Aug 15 23:48:49 2012 +0300
@@ -503,7 +503,7 @@
 subprocess_fork_exec(PyObject* self, PyObject *args)
 {
 PyObject *gc_module = NULL;
-PyObject *executable_list, *py_close_fds, *py_fds_to_keep;
+PyObject *executable_list, *py_fds_to_keep;
 PyObject *env_list, *preexec_fn;
 PyObject *process_args, *converted_args = NULL, *fast_args = NULL;
 PyObject *preexec_fn_args_tuple = NULL;
@@ -518,15 +518,14 @@
 Py_ssize_t arg_num;
 
 if (!PyArg_ParseTuple(
-args, "OOiiO:fork_exec",
-&process_args, &executable_list, &py_close_fds, &py_fds_to_keep,
+args, "OOpOOOiiO:fork_exec",
+&process_args, &executable_list, &close_fds, &py_fds_to_keep,
 &cwd_obj, &env_list,
 &p2cread, &p2cwrite, &c2pread, &c2pwrite,
 &errread, &errwrite, &errpipe_read, &errpipe_write,
 &restore_signals, &call_setsid, &preexec_fn))
 return NULL;
 
-close_fds = PyObject_IsTrue(py_close_fds);
 if (close_fds && errpipe_write < 3) {  /* precondition */
 PyErr_SetString(PyExc_ValueError, "errpipe_write must be >= 3");
 return NULL;
diff -r 5dc2b4a542f1 Modules/_ssl.c
--- a/Modules/_ssl.cWed Aug 15 22:53:56 2012 +0300
+++ b/Modules/_ssl.cWed Aug 15 23:48:49 2012 +0300
@@ -1037,15 +1037,15 @@
 PyObject *retval = NULL;
 int len;
 int verification;
-PyObject *binary_mode = Py_None;
+int binary_mode = 0;
 
-if (!PyArg_ParseTuple(args, "|O:peer_certificate", &binary_mode))
+if (!PyArg_ParseTuple(args, "|p:peer_certificate", &binary_mode))
 return NULL;
 
 if (!self->peer_cert)
 Py_RETURN_NONE;
 
-if (PyObject_IsTrue(binary_mode)) {
+if (binary_mode) {
 /* return cert in DER-encoded format */
 
 unsigned char *bytes_buf = NULL;
diff -r 5dc2b4a542f1 Modules/itertoolsmodule.c
--- a/Modules/itertoolsmodule.c Wed Aug 15 22:53:56 2012 +0300
+++ b/Modules/itertoolsmodule.c Wed Aug 15 23:48:49 2012 +0300
@@ -1105,11 +1105,13 @@
 }
 ok = PyObject_IsTrue(good);
 Py_DECREF(good);
-if (!ok) {
+if (ok == 0) {
 lz->start = 1;
 return item;
 }
 Py_DECREF(item);
+if (ok < 0)
+return NULL;
 }
 }
 
@@ -1124,7 +1126,7 @@
 dropwhile_setstate(dropwhileobject *lz, PyObject *state)
 {
 int start = PyObject_IsTrue(state);
-if (start == -1)
+if (start < 0)
 return NULL;
 lz->start = start;
 Py_RETURN_NONE;
@@ -1270,10 +1272,11 @@
 }
 ok = PyObject_IsTrue(good);
 Py_DECREF(good);
-if (ok)
+if (ok == 1)
 return item;
 Py_DECREF(item);
-lz->stop = 1;
+if (ok == 0)
+lz->stop = 1;
 return NULL;
 }
 
@@ -1288,7 +1291,7 @@
 takewhile_reduce_setstate(takewhileobject *lz, PyObject *state)
 {
 int stop = PyObject_IsTrue(state);
-if (stop == -1)
+if (stop < 0)
 return NULL;
 lz->stop = stop;
 Py_RETURN_NONE;
@@ -3536,7 +3539,7 @@
 if (ok == 1)
 return datum;
 Py_DECREF(datum);
-if (ok == -1)
+if (ok < 0)
 return NULL;
 }
 }
@@ -3692,9 +3695,11 @@
 ok = PyObject_IsTrue(good);
 Py_DECREF(good);
 }
-if (!ok)
+if (ok == 0)
 return item;
 Py_DECREF(item);
+if (ok < 0)
+retur

[issue15490] Correct __sizeof__ support for StringIO

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
assignee: storchaka -> 
keywords: +needs review
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12669] test_curses skipped on buildbots

[Nadeem Vawda]

Nadeem Vawda added the comment:

> Nadeem: is the failure you show in msg141798 with a version of test_curses 
> that uses pty.openpty?

Yes, I tried the following change:

--- a/Lib/test/test_curses.py
+++ b/Lib/test/test_curses.py
@@ -328,11 +328,12 @@
 curses.resetty()

 def test_main():
-if not sys.__stdout__.isatty():
-raise unittest.SkipTest("sys.__stdout__ is not a tty")
 # testing setupterm() inside initscr/endwin
 # causes terminal breakage
-curses.setupterm(fd=sys.__stdout__.fileno())
+#curses.setupterm(fd=sys.__stdout__.fileno())
+import pty
+_, pty = pty.openpty()
+curses.setupterm(fd=pty)
 try:
 stdscr = curses.initscr()
 main(stdscr)

(I've never used openpty, either in Python or in C, so I can't vouch for
the correctness of this usage.)


> If it isn't: I'd expect more test failures on buildbot machines where the 
> buildbot agent is started as a system daemon, in which case the process 
> doesn't have a tty at all. Using pty.openpty it would be possible to ensure 
> that there is a pty that can be used for the test.

Looking at the actual buildbot results, most of the *nix bots I checked
are actually skipping this test; the only one I could find that wasn't is
the "x86 Ubuntu Shared" bot:
ttp://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/6640/steps/test/logs/stdio

So it looks like on most of the bots, buildbot is running without a tty.
Then, test_main() sees that sys.__stdout__ isn't suitable to run the
test, and bails out.

It'd be great if you can come up with a fix that gets the test running
in this environment, but it'll probably be more complicated than just
slotting in a call to openpty().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12669] test_curses skipped on buildbots

[Nadeem Vawda]

Changes by Nadeem Vawda :


--
stage:  -> needs patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15604] PyObject_IsTrue failure checks

[Roundup Robot]

Roundup Robot added the comment:

New changeset ba1c48f8b571 by Antoine Pitrou in branch '2.7':
Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors 
correctly.
http://hg.python.org/cpython/rev/ba1c48f8b571

New changeset 56dc7b09f390 by Antoine Pitrou in branch '3.2':
Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors 
correctly.
http://hg.python.org/cpython/rev/56dc7b09f390

New changeset b878df1d23b1 by Antoine Pitrou in branch 'default':
Issue #15604: Update uses of PyObject_IsTrue() to check for and handle errors 
correctly.
http://hg.python.org/cpython/rev/b878df1d23b1

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12623] "universal newlines" subprocess support broken with select- and poll-based communicate()

[Chris Jerdonek]

Chris Jerdonek added the comment:

> Looking the code this test will fail on Windows. I cannot check it just now 
> but looks like this is the problem.

Would it be possible to do something like the following to check this on a 
non-Windows machine (since the Python implementation of io respects the 
mutability of os.linesep but perhaps not the C version)?  It seems so.

>>> import _pyio, io, os
>>> io.TextIOWrapper = _pyio.TextIOWrapper
>>> os.linesep = "\r\n"
etc.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15604] PyObject_IsTrue failure checks

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Antoine.

--
resolution:  -> fixed
stage: patch review -> committed/rejected
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15661] OS X installer packages should be signed for OS X 10.8 Gatekeeper feature

[Florent Xicluna]

Changes by Florent Xicluna :


--
nosy: +flox

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15543] central documentation for 'universal newlines'

[Éric Araujo]

Éric Araujo added the comment:

Great patch!

--
nosy: +eric.araujo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue12436] Missing items in installation/setup instructions

[Éric Araujo]

Éric Araujo added the comment:

My computer currently doesn’t boot so I can’t check if I had started or not.  
You can propose a patch incorporating the various suggestions, or give me some 
days to read this again and make a summary of what I would have done.  Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7231] Windows installer does not add \Scripts folder to the path

[Éric Araujo]

Éric Araujo added the comment:

BTW, any reason to create python27.exe instead of python2.7.exe (so that the 
unix-centered docs about command lines would also apply to your Pythons)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15625] Support u and w codes in memoryview

[Nick Coghlan]

Nick Coghlan added the comment:

I admit that the main thing that bothers me with the proposal in PEP 3118 is 
the inconsistency between c -> bytes, while u, w -> str

This was less of an issue in 2.x (which was the main frame of reference when 
the PEP was written), with implicit str/unicode interoperability, but seems 
quite jarring in the 3.x world.

Status quo:
struct module: 'c' = individual bytes, 's' = multi-byte sequence
array module: 'u' typecode may be either 2 bytes or 4 bytes (Py_UNICODE) (the 
addition of the 'w' typecode has been reverted)

My current inclination is still to apply Victor's patch from #13072 (which 
changes array to export the appropriate integer typecodes for 'u' arrays) and 
otherwise punt on this for 3.3 and try to sort out the mess for 3.4.

For 3.4, I'm inclined to favour Stefan's proposal of C, U, W mapping to 
multi-point sequences of UCS-1, UCS-2, UCS-4 code points (with corresponding 
typecodes in the array module).

Support for lowercase 'u' would then never become an official part of the 
buffer API, existing only as an array typecode.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15604] PyObject_IsTrue failure checks

[Jesús Cea Avión]

Changes by Jesús Cea Avión :


--
nosy: +jcea

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue15678] IDLE menu customization is broken from OS X command lines

[Ned Deily]

New submission from Ned Deily:

With 3.3.0b2, when IDLE is started from a command line using
an OS X framework build (such as provided by the python.org
installers), the Aqua Tk menu customization is no longer being
performed, for example, no Preferences menu item, an extra Options
menu, etc.  It was broken as a side effect of the changes to
pythonw.c in b79d276041a8 for #15307.  Since sys.executable no
longer includes 'Python.app' in the path name, the attached patch
tests for a framework build instead.  This should give the previous
behavior in nearly all cases.  Whether the previous behavior is
sensible is left as an issue for later releases.  IDLE.app behavior was
not affected as it does its own manipulation of sys.executable;
that should probably also be changed in the future.

--
assignee: ned.deily
components: IDLE, Macintosh
files: X_bin_idle_menus.patch
keywords: patch
messages: 168346
nosy: ned.deily, ronaldoussoren
priority: release blocker
severity: normal
stage: commit review
status: open
title: IDLE menu customization is broken from OS X command lines
versions: Python 3.3
Added file: http://bugs.python.org/file26841/X_bin_idle_menus.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com