[issue2504] Add gettext.pgettext() and variants support

[Martin v. Löwis]

Martin v. Löwis <[EMAIL PROTECTED]> added the comment:

Would you like to work on a patch?

--
nosy: +loewis

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2503] Replace "== None/True/False" with "is"

[Wummel]

Wummel <[EMAIL PROTECTED]> added the comment:

Here is an updated patch, using "is False" to be consistent, and also
replacing the "!=" occurences.

Added file: 
http://bugs.python.org/file9886/0001-Replace-None-True-False-with-is.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2503] Replace "== None/True/False" with "is"

[Wummel]

Changes by Wummel <[EMAIL PROTECTED]>:


Removed file: 
http://bugs.python.org/file9882/0001-Replace-None-True-False-with-is.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2503] Replace "== None/True/False" with "is"

[Raymond Hettinger]

Raymond Hettinger <[EMAIL PROTECTED]> added the comment:

This patch is fine.

Before applying, check the code in PyShell to see if the "if response 
is False" line can be simplified to "if not response".

--
nosy: +rhettinger
resolution:  -> accepted

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2503] Replace "== None/True/False" with "is"

[Georg Brandl]

Georg Brandl <[EMAIL PROTECTED]> added the comment:

Benjamin, do you want to apply this? Add a Misc/NEWS item as well.

--
assignee:  -> benjamin.peterson
nosy: +benjamin.peterson

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2502] Add enum() example for named tuples

[Raymond Hettinger]

Raymond Hettinger <[EMAIL PROTECTED]> added the comment:

Thanks for asking. This should not go into the collections module.

The concept makes more sense in statically compiled languages.  In 
Python, we typically write something like "RED, ORANGE, YELLOW = range
(3)" at the module level.  That is faster and still allows prefixing 
using the module name (for example, re.MULTILINE).

--
resolution: accepted -> rejected

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2503] Replace "== None/True/False" with "is"

[Raymond Hettinger]

Raymond Hettinger <[EMAIL PROTECTED]> added the comment:

Don't think changes like this warrant a NEWS entry.  It's a code clean-
up, not a semantic change.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2505] Restrict attributes of _ast nodes

[Georg Brandl]

New submission from Georg Brandl <[EMAIL PROTECTED]>:

This patch adds two things to the _ast module:
* Nodes can be initialized with keyword arguments:
  m = _ast.Module(body=[...])

* Only attributes that are in _fields or _attributes can be set on nodes.

Martin, what do you think?

--
assignee: loewis
components: Extension Modules
files: ast-attrs.diff
keywords: patch
messages: 64691
nosy: georg.brandl, loewis
severity: normal
status: open
title: Restrict attributes of _ast nodes
type: behavior
versions: Python 2.6, Python 3.0
Added file: http://bugs.python.org/file9887/ast-attrs.diff

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Ned Batchelder]

New submission from Ned Batchelder <[EMAIL PROTECTED]>:

When tracing line execution with sys.settrace, a particular code
structure  fails to report an executed line.  The line is a continue
statement after an if condition in which the if condition is true every
time it is executed.

Attached is a file with two copies of the same code, except in the first
the if condition is always true, and in the second it is sometimes true.
 In the first, trace.py reports that the continue is never executed,
even though it is (as evidenced from the values of a, b, and c after
execution).

In the second code, the continue is properly reported.

This bug has been present since version 2.3.  2.2 does not exhibit it
(trace.py didn't exist in 2.2, but coverage.py shows the problem also).

To see the problem, execute "trace.py -c -m continue.py".  Then
continue.py.cover will show:

1: a = b = c = 0
  101: for n in range(100):
  100: if n % 2:
   50: if n % 4:
   50: a += 1
>> continue
   else:
   50: b += 1
   50: c += 1
1: assert a == 50 and b == 50 and c == 50

1: a = b = c = 0
  101: for n in range(100):
  100: if n % 2:
   50: if n % 3:
   33: a += 1
   17: continue
   else:
   50: b += 1
   50: c += 1
1: assert a == 33 and b == 50 and c == 50

--
components: Interpreter Core
files: continue.py
messages: 64692
nosy: nedbat
severity: normal
status: open
title: Line tracing of continue after always-taken if is incorrect
type: behavior
versions: Python 2.3, Python 2.4, Python 2.5, Python 2.6
Added file: http://bugs.python.org/file9888/continue.py

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2505] Restrict attributes of _ast nodes

[Georg Brandl]

Georg Brandl <[EMAIL PROTECTED]> added the comment:

On second thought, restricting node attributes may prevent custom AST
processing tools from adding useful information themselves...

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2152] make sqlite.Row hashable correctly

[Gerhard Häring]

Gerhard Häring <[EMAIL PROTECTED]> added the comment:

Thomas, could you do me a favour and create a patch for Python 3.0, too?
It seems that only tp_richcompare is supported there.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1579] logging documentation is unclear

[Kylotan]

Kylotan <[EMAIL PROTECTED]> added the comment:

I think I gave some pretty clear details in my original submission. A
better example on the front page is needed rather than one that could be
confused with output methods. The example in 14.5.3 needs to not be one
big code dump with no explanation other than comments.

I could go on: the front page talks about named logger instances, and
yet the basic example completely omits any mention of such instances,
instead using module-level calls. You have to dig into the middle of the
example in 14.5.3 to see what this means, and because that example isn't
well explained, it's still not clear. It seems to have 2 loggers
attached to the root, but I can't see what benefit that gives, since
there's no example showing that logging sent to the root goes to the
children (does it?), nor does the reverse happen. Examples should show
one or two things, not try to demonstrate every feature in a code dump
and expect you to guess which parts do what.

As for submitting a patch, the whole problem with documentation is that
if you don't understand it, you can't use the software, so how could
such a person possibly know exactly what should go in the patch? It
needs to be written from the perspective of someone who has never used
it before, which right now it plainly isn't.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2078] CSV Sniffer does not function properly on single column .csv files

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

> It works entirely based on chracter frequencies.

Does it make sense to restrict delimiters to a reasonable set of
characters? Usual punctuations, spaces, tabs... what else?

--
nosy: +amaury.forgeotdarc

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2507] Exception state lives too long in 3.0

[Antoine Pitrou]

New submission from Antoine Pitrou <[EMAIL PROTECTED]>:

See http://mail.python.org/pipermail/python-3000/2008-March/012830.html
: the exception state can survive across thread switches if the
enclosing frame is not destroyed immediately.

--
components: Interpreter Core
messages: 64697
nosy: jyasskin, pitrou
severity: normal
status: open
title: Exception state lives too long in 3.0
type: behavior
versions: Python 3.0

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2507] Exception state lives too long in 3.0

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

And this is a patch, together with a test.

--
keywords: +patch
Added file: http://bugs.python.org/file9889/exc_cleanup.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

This is because of a "peephole" optimization of the generated bytecode:
a jump instruction which target is another jump instruction can be
modified modified to target the final location.

You gain a few opcodes, but tracing is confusing...
Not sure how to fix this, though.

--
nosy: +amaury.forgeotdarc

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2505] Restrict attributes of _ast nodes

[Martin v. Löwis]

Martin v. Löwis <[EMAIL PROTECTED]> added the comment:

> On second thought, restricting node attributes may prevent custom AST
> processing tools from adding useful information themselves...

Indeed. If anything is to be checked, it should be whether the child
nodes or attributes have the right types. However, that should rather
be done in a recursive check function on _mod, which then would also
check whether all necessary fields have been set. Or, such checks
could be delayed until actual compilation of the tree is attempted
(i.e. conversion to the C AST structures).

As for being able to pass constructor arguments: I'd expect them
to be positional arguments, not keyword arguments - anybody creating
AST nodes would normally have Python.asdl open, no?

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2078] CSV Sniffer does not function properly on single column .csv files

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

>> It works entirely based on chracter frequencies.

Amaury> Does it make sense to restrict delimiters to a reasonable set of
Amaury> characters? Usual punctuations, spaces, tabs... what else?

There is an optional delimiters argument to the sniff() method which
defaults to None.  I would be happier if it was "the usual suspects"
(NeoOffice refuses to gues, but offers TAB, space, semicolon and comma as
the default separators when importing a CSV file - Excel seems to just
figure it out).  That would change the behavior though.  With no delimiter
set it's generally going to find something, just pick incorrectly.  With a
non-existent delimiter set it's going to raise an exception.  I'm not sure
this would be a good tradeoff and would just break existing code.

Skip

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2503] Replace "== None/True/False" with "is"

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Patch was committed in r62043. Wummel, thanks for the patch! Georg,
thanks for the practice.

--
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2508] When you create a file using file(path, "w") if the filename is illegal it throws an irrelevant error message

[kobi]

Changes by kobi <[EMAIL PROTECTED]>:


--
nosy: kobipe3
severity: normal
status: open
title: When you create a file using file(path, "w") if the filename is illegal 
it throws an irrelevant error message
type: resource usage
versions: Python 2.5

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2508] When you create a file using file(path, "w") if the filename is illegal it throws an irrelevant error message

[kobi]

New submission from kobi <[EMAIL PROTECTED]>:

It throws an IOError: ... No such file or directory: %path% instead of 
IOError: Invalid file name.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1054434] automatic XMLRPC boxcarring via multicall for xmlrpclib

[Martin v. Löwis]

Martin v. Löwis <[EMAIL PROTECTED]> added the comment:

As nobody has asked for this patch to be included, I think its probably
easiest just to reject it. Thanks for offering it in the first place,
though.

--
resolution:  -> rejected
status: open -> closed

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2508] When you create a file using file(path, "w") if the filename is illegal it throws an irrelevant error message

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

How do you know, in a cross platform way, that the name is illegal
instead that the file or directory does not exist?

--
nosy: +facundobatista

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2508] When you create a file using file(path, "w") if the filename is illegal it throws an irrelevant error message

[Martin v. Löwis]

Martin v. Löwis <[EMAIL PROTECTED]> added the comment:

This is not a bug in Python. The error that you get comes directly from
the operating system/C library, so please complain to your system vendor.

--
nosy: +loewis
resolution:  -> wont fix
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2509] Bazaar ignore file

[Benjamin Peterson]

New submission from Benjamin Peterson <[EMAIL PROTECTED]>:

I basically copied all the svn:ignore props into this file...

--
components: None
files: bzr-ignore.patch
keywords: easy, patch
messages: 64707
nosy: barry, benjamin.peterson, georg.brandl
severity: normal
status: open
title: Bazaar ignore file
type: feature request
Added file: http://bugs.python.org/file9890/bzr-ignore.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Benjamin Peterson]

New submission from Benjamin Peterson <[EMAIL PROTECTED]>:

I basically copied all the svn:ignore props into this file...

--
components: None
files: bzr-ignore.patch
keywords: easy, patch
messages: 64708
nosy: barry, benjamin.peterson, georg.brandl
severity: normal
status: open
title: Bazaar ignore file
type: feature request
versions: Python 2.6
Added file: http://bugs.python.org/file9891/bzr-ignore.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2509] Bazaar ignore file

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


--
resolution:  -> duplicate
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Georg Brandl]

Georg Brandl <[EMAIL PROTECTED]> added the comment:

I don't know if we should pollute the SVN tree with random VCS stuff.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Jeroen Ruigrok van der Werven]

Jeroen Ruigrok van der Werven <[EMAIL PROTECTED]> added the comment:

Given how Bazaar is not an official choice for the repository adding 
this kind of thing will lead to a road to add such information for Hg 
and other VCSes as well in order to be fair to all.

--
nosy: +asmodai

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2507] Exception state lives too long in 3.0

[Christian Heimes]

Changes by Christian Heimes <[EMAIL PROTECTED]>:


--
priority:  -> release blocker

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

I'd like to get Barry's opinion on this, since he added the experimental
Bazaar branches. I think it's reasonable as long as they're "offical"
VCS branches.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Jeroen Ruigrok van der Werven]

Jeroen Ruigrok van der Werven <[EMAIL PROTECTED]> added the comment:

But isn't that Bazaar thing totally stand-alone from the SVN 
repository? What experimental branches are you talking about?

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Alexander Belopolsky]

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment:

I think this is not a bug.  Here is a simpler way to illustrate the 
issue:

def f(x): 
for i in range(10): 
if x: 
pass 
continue 
f(True)
f(False)

If you run the code above under trace, you get the following coverage:

1: def f(x):
   22: for i in range(10):
   20: if x:
   10: pass
   10: continue   
1: f(True)
1: f(False)

Note that the 'continue' line is executed 10 instead of expected 20 
times.   This happens exactly as Amaury explained. If you disassemble f, 
you'll see

  2   0 SETUP_LOOP  34 (to 37)
  3 LOAD_GLOBAL  0 (range)
  6 LOAD_CONST   1 (10)
  9 CALL_FUNCTION1
 12 GET_ITER
>>   13 FOR_ITER20 (to 36)
 16 STORE_FAST   1 (i)

  3  19 LOAD_FAST0 (x)
 22 JUMP_IF_FALSE4 (to 29)
 25 POP_TOP 

  4  26 JUMP_ABSOLUTE   13
>>   29 POP_TOP 

  5  30 JUMP_ABSOLUTE   13
 33 JUMP_ABSOLUTE   13
>>   36 POP_BLOCK   
>>   37 LOAD_CONST   0 (None)
 40 RETURN_VALUE


Note how peephole optimizer replaced jump to the 'continue' line (5) 
from the 'pass' line (4) with a jump to the 'for' line by replacing

 4  26 JUMP_FORWARD 1 (to 30)

with

  4  26 JUMP_ABSOLUTE   13


I say this is not a bug because trace is correct in showing that the 
continue statement is never reached when executing f(True).

--
nosy: +belopolsky

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2511] Give AST's excepthandler proper attributes

[Georg Brandl]

New submission from Georg Brandl <[EMAIL PROTECTED]>:

The ASDL file has an XXX comment about excepthandler's lineno and
col_offset -- they are not attributes but fields which gets confusing
when this is exported to Python code. I think the only way to solve this
is to make it a "trivial" Sum with one element. This patch does that.

--
assignee: loewis
components: Interpreter Core
files: ast-except.diff
keywords: patch
messages: 64714
nosy: georg.brandl, loewis
severity: normal
status: open
title: Give AST's excepthandler proper attributes
versions: Python 2.6, Python 3.0
Added file: http://bugs.python.org/file9892/ast-except.diff

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2505] Easier creation of _ast nodes

[Georg Brandl]

Georg Brandl <[EMAIL PROTECTED]> added the comment:

Okay, I'm dropping the attribute restriction part.

Attaching new patch that allows creating nodes with fields (not
attributes) as positional arguments, and setting all keyword arguments
as attributes on self.

--
title: Restrict attributes of _ast nodes -> Easier creation of _ast nodes
Added file: http://bugs.python.org/file9893/ast-constructor-v2.diff

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2215] test_sqlite fails in 2.6a1 on MacOS X

[Gerhard Häring]

Changes by Gerhard Häring <[EMAIL PROTECTED]>:


--
resolution:  -> fixed
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Ned Batchelder]

Ned Batchelder <[EMAIL PROTECTED]> added the comment:

I see that the cause of the problem is the peephole optimizer.  That
doesn't mean this isn't a problem.

I am measuring the code coverage of a set of tests, and one of my lines
is being marked as not executed.  This is not the fault of the tests,
because in fact, without the optimization, the line would be executed. 
Conceptually, the line has been executed (the loop is restarted, rather
than execution continuing).

I don't know what the solution to this is.  Some options include fixing
the line tracing code to somehow indicate that the continue was
executed; or providing a way to disable peephole optimization for times
when accurate execution tracing is more important than speed.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2441] Mac build_install.py script fetches unavailable SQLite version

[Gerhard Häring]

Changes by Gerhard Häring <[EMAIL PROTECTED]>:


--
assignee:  -> ghaering
nosy: +ghaering

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2176] Undocumented lastrowid attribute i sqlite3 cursor class

[Gerhard Häring]

Changes by Gerhard Häring <[EMAIL PROTECTED]>:


--
assignee: georg.brandl -> ghaering
nosy: +ghaering

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

http://www.python.org/dev/bazaar/

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2176] Undocumented lastrowid attribute i sqlite3 cursor class

[Gerhard Häring]

Gerhard Häring <[EMAIL PROTECTED]> added the comment:

The lastrowid attribute is now documented in r62044. Thanks for bringing
this up.

--
resolution:  -> fixed
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue815646] thread unsafe file objects cause crash

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Actually, my approach was not 100% correct, it failed in some rare
cases. I've come to the conclusion that using an unlock count on the
PyFileObject is the correct way to proceed. I'm now attaching a working
and complete patch which protects all methods of the PyFileObject. The
original test suite runs fine, as well as the added test cases and Tim
Peters' crasher here:
http://mail.python.org/pipermail/python-dev/2003-June/036537.html

To sum up the changes brought by this patch:
- no supplementary locking
- but each time we release the GIL to do an operation on a FILE, we
increase a dedicated counter on the PyFileObject
- when close()ing a PyFileObject, if the aforementioned counter is
non-zero, we throw an IOError rather than risking calling fclose(). By
construction this cannot happen in the PyFileObject destructor, but if
ever it happens (for example if a C extension decides to put its hands
in the PyFileObject struct), we throw a SystemError instead.

Added file: http://bugs.python.org/file9894/filethread3.patch


Tracker <[EMAIL PROTECTED]>


___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Alexander Belopolsky]

Alexander Belopolsky <[EMAIL PROTECTED]> added the comment:

On Sat, Mar 29, 2008 at 2:51 PM, Ned Batchelder <[EMAIL PROTECTED]> wrote:
>
>  Ned Batchelder <[EMAIL PROTECTED]> added the comment:
>
>  I am measuring the code coverage of a set of tests, and one of my lines
>  is being marked as not executed.  This is not the fault of the tests,
>  because in fact, without the optimization, the line would be executed.
>  Conceptually, the line has been executed (the loop is restarted, rather
>  than execution continuing).
>

.. but the continue statement on line 5 is NOT executed in x == True
case.   Note that without optimization, the if statement + the
continue line translate to

  3  19 LOAD_FAST0 (x)
 22 JUMP_IF_FALSE4 (to 29)
 25 POP_TOP

  4  26 JUMP_FORWARD 1 (to 30)
>>   29 POP_TOP

  5 >>   30 JUMP_ABSOLUTE   13

where the second jump is to the continue statement.  Peephole
optimizer recognizes that the jump target is an unconditional jump and
changes the code to jump directly to the final target bypassing the
continue line.  The optimized code is

 3  19 LOAD_FAST0 (x)
 22 JUMP_IF_FALSE4 (to 29)
 25 POP_TOP

  4  26 JUMP_ABSOLUTE   13
>>   29 POP_TOP

  5  30 JUMP_ABSOLUTE   13

If x is true, line five is NOT executed.

>  I don't know what the solution to this is.  Some options include fixing
>  the line tracing code to somehow indicate that the continue was
>  executed; or providing a way to disable peephole optimization for times
>  when accurate execution tracing is more important than speed.
>

I think it is a good idea to provide a way to disable peephole
optimizer. In fact, I recently proposed exactly that in msg64638.   My
only problem is that I would like to follow gcc tradition and make -O
option take an optional  numeric  argument with 0 meaning no
optimization and increasingly aggressive optimization as the argument
increases.  Unfortunately -O0 will be confusingly similar to -OO.
Since -OO is not really optimization, but rather "strip" option, it
should probably migrate to -s or something.  In any case, such drastic
changes to command line options are not acceptable for 2.x, but maybe
possible for 3.0.

I can easily implement -N (No optimization) or -g  (debug) option that
will disable the peephole optimizer if there is support for such
feature.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2511] Give AST's excepthandler proper attributes

[Martin v. Löwis]

Martin v. Löwis <[EMAIL PROTECTED]> added the comment:

Sounds fine to me.

--
assignee: loewis -> georg.brandl
resolution:  -> accepted

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2505] Easier creation of _ast nodes

[Martin v. Löwis]

Martin v. Löwis <[EMAIL PROTECTED]> added the comment:

Looks fine to me. It might be reasonable to further restrict the
constructor to either 0 or len(_fields) arguments.

--
assignee: loewis -> georg.brandl
resolution:  -> accepted

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2473] logging.LogRecord should know how to handle dict-like args

[Vinay Sajip]

Vinay Sajip <[EMAIL PROTECTED]> added the comment:

You don't need to change the logging package for this. Simply generate a
bona-fide dict from your UserDict or DictMixin subclass as follows:

dict(userDict_or_mixIn_instance)

and pass that into the logging call instead of userDict_or_mixIn_instance.

--
assignee:  -> vsajip
nosy: +vsajip
resolution:  -> invalid
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue815646] thread unsafe file objects cause crash

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Ah, I had forgotten to protect the print statement as well. Here is a
new patch :-)

Added file: http://bugs.python.org/file9895/filethread4.patch


Tracker <[EMAIL PROTECTED]>


___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

> Unfortunately -O0 will be confusingly similar to -OO.
On my browser, both are shown identically at the pixel level.

Microsoft compilers use -Od to disable optimization...

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Raymond Hettinger]

Raymond Hettinger <[EMAIL PROTECTED]> added the comment:

This has basically almost never been a problem in the real world.  No 
need to complicate the world further by adding yet another option and 
the accompanying implementation-specific knowledge of why you would 
ever want to use it.

Also, when the peepholer is moved (after the AST is created, but before 
the opcodes), then little oddities like this will go away.

Recommend closing as "won't fix".

--
nosy: +rhettinger

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Ralf Schmitt]

Ralf Schmitt <[EMAIL PROTECTED]> added the comment:

it should be no problem to add this to the bzr repository. this is where
it belongs.

--
nosy: +schmir

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

I don't think that will work (at the moment.) The Bazaar repo is an
exact copy (on a cron job) of the Subversion one, so we can't add files.
Also, those using bzr-svn would miss out on the .bzrignore file.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[Ned Batchelder]

Ned Batchelder <[EMAIL PROTECTED]> added the comment:

I recognize that this is an unusual case, but it did come up in the real
world.  I found this while measuring test coverage, and the continue
line was marked as not executed, when it was.

I don't understand "when the peepholer is moved", so maybe you are right
that this will no longer be an issue.  But it seems to me to be endemic
to code optimization to lose the one-to-one correspondence between
source lines and ranges of bytecodes.  And as the compiler becomes more
complex and performs more optmizations, problems like this will likely
increase, no?

In any case, I'd like to know more about the changes planned for the AST
and compiler...

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Georg Brandl]

Georg Brandl <[EMAIL PROTECTED]> added the comment:

Wouldn't it be the job of the synchronisation job to automatically
create a .bzrignore file from the SVN ignore properties?

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Automation would be wonderful, but that still doesn't solve bzr-svn
problem. In the future, bzr-svn should be able to deal with svn:ignore
props, but it can't now. Should the Bazaar experiment fail, I'd just
like to remind you that "environmental cleanup" (aka pollution removal)
is only one "svn rm" away...

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2510] Bazaar ignore file

[Barry A. Warsaw]

Barry A. Warsaw <[EMAIL PROTECTED]> added the comment:

Personally, I think it would be fine to add one .bzrignore file at the
top of the tree.  I would also have no problem adding one for hg if some
Mercurial fan asks for it.  As you say, cleaning up afterward is a
simple 'rm' away.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2512] decide what to do with gettext API

[Benjamin Peterson]

New submission from Benjamin Peterson <[EMAIL PROTECTED]>:

The gettext module currently has functions and methods beginning with
"u" to designate functions which return unicode objects. The install
function/method also has a "unicode" parameter. These are obviously
useless in Py3k. The attached patch removes the u prefixed functions and
and unicode parameters. Docs updates are included.

PS. If you're interested, the Bazaar branch I developed this on is at
http://code.python.org/python/users/benjamin.peterson/py3k_gettext_api/.

--
components: Library (Lib)
keywords: patch
messages: 64733
nosy: barry, benjamin.peterson
priority: critical
severity: normal
status: open
title: decide what to do with gettext API
type: feature request
versions: Python 3.0

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2512] decide what to do with gettext API

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


Added file: http://bugs.python.org/file9896/gettext_api.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2507] Exception state lives too long in 3.0

[Jeffrey Yasskin]

Jeffrey Yasskin <[EMAIL PROTECTED]> added the comment:

Thanks for the patch. This isn't specific to threads at all, so the test
doesn't need to spawn a thread, just raise an exception from a nested
function with a parameter, catch it, delete the object the parameter
referred to, and then check that the object has been destroyed.

I don't know the exception handling code very well, so I'd like someone
more familiar with it to check that the patch is correct and efficient.
Collin, would you do the honors?

--
assignee:  -> collinwinter
nosy: +collinwinter

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue433030] SRE: Atomic Grouping (?>...) is not supported

[Jeffrey C. Jacobs]

Jeffrey C. Jacobs <[EMAIL PROTECTED]> added the comment:

I'm digging into the sre_parse.py at the moment and this I have all the 
changes I need for that now.  The rest of the changes I believe are in 
either sre_compile.py or more likely directly in _sre.c, so I will 
examine those files next.  I am attaching a single diff for 
expedience.  This is not an official patch, just a sample to see the 
progress I am making.  I forgot the correct format for patch files but 
I promise to get it right when I have made more progress.

--
components: +Library (Lib)
versions: +Python 2.6
Added file: http://bugs.python.org/file9897/PyLibDiffs.txt


Tracker <[EMAIL PROTECTED]>


___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2507] Exception state lives too long in 3.0

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

You are right, threads aren't needed. So, attaching an updated patch.

Added file: http://bugs.python.org/file9898/exc_cleanup2.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1731717] race condition in subprocess module

[Robert Siemer]

Robert Siemer <[EMAIL PROTECTED]> added the comment:

Update for my comment: python2.5.2 does not show that problem.
python2.4.5 did. I repeat, 2.5.2 does not clean up processes which are
still referenced, but it does clean unreferenced ones.

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1579] logging documentation is unclear

[Vinay Sajip]

Vinay Sajip <[EMAIL PROTECTED]> added the comment:

In your original submission, you said:

"... the front page has a rather confusing example of the named
hierarchy system, which might mislead the reader by making them think
it's about file types (perhaps for log output) rather than just
arbitrary naming conventions."

What the front page says is:

"Each [Logger] instance has a name, and they are conceptually arranged
in a name space hierarchy using dots (periods) as separators. For
example, a logger named "scan" is the parent of loggers "scan.text",
"scan.html" and "scan.pdf". Logger names can be anything you want, and
indicate the area of an application in which a logged message originates."

Notice the last sentence, which clearly (to me) states that logger names
can by anything you want, i.e. an arbitrary naming convention. Although
the examples given were "scan.text", "scan.html" and "scan.pdf", I don't
believe the average user would confuse this with file types for log
output, unless they skimmed the paragraph. The paragraph does  not
mention file types anywhere else, and nor do the next few paragraphs.

The example in section 14.5.3 is fairly well commented, so IMO it's
misrepresenting it a little to call it a "code dump". It's not the first
example, either - a number of shorter examples are shown earlier in the
documentation.

When the logging package was introduced into Python back in version 2.3,
there were some valid comments from people about lack of examples and
lack of clarity in the documentation. This was rectified over time, and
your comment is the first one for several months about documentation
clarity.

About documentation, it could always be argued that it could be clearer,
because there's bound to be someone who doesn't understand it. But
maintenance of this package (and Python) is a spare-time activity for
most of us, and a number of competing priorities have to be traded off
when deciding how to spend that time. I have spent a fair amount of time
over the months improving the documentation, as have others, to the
point where we don't get many comments about it; hence, it's time, from
my point of view, to scratch other itches. If people feel strongly
enough about it, they'll submit specific ideas or patches, which can be
easily incorporated into the documentation. (You can look at the history
of changes to the logging documentation in SVN to see that it updated
reasonably often.) Simply stating that it "is quite confusing" is so
open ended that an effort to make it less confusing could take a very
long time, and that's why I invited a patch: I got the impression that
you now understand how the hierarchy etc. works, even if you didn't
straight away. If you are still having difficulty understanding some
aspects of the package, please post on comp.lang.python: you will see
that queries are reasonably promptly answered, not always by core
developers but often by other users of the logging package.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

>From a quick glance: I may be wrong, but it looks like in
bytesio_writelines(), you'll have some reference leaks if the `while`
loop exits early because bytesio_write() returns NULL; `item` and `it`
should be decred'ed before returning.

--
nosy: +pitrou

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2506] Line tracing of continue after always-taken if is incorrect

[ajaksu]

Changes by ajaksu <[EMAIL PROTECTED]>:


--
nosy: +ajaksu2

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2275] urllib2 header capitalization

[Senthil]

Senthil <[EMAIL PROTECTED]> added the comment:

I understand your implementation of _cap_header_key function.
But should not this patch be handled in a way wherein.
key.capitalize() is just replaced by key.upper()?

Should not that suffice?
What is the difference between _cap_header_key and key.upper()?

Thank you,
Senthil

--
nosy: +orsenthil

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9084/_bytesio.c

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9085/add-bytesio-setup.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9087/test_memoryio.py

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9086/swap-initstdio-initsite.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9088/remove-old-stringio-test.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9089/truncate-semantic-change.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Changes by Alexandre Vassalotti <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file9090/io-misc-fixes.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1751] Fast BytesIO implementation + misc changes

[Alexandre Vassalotti]

Alexandre Vassalotti <[EMAIL PROTECTED]> added the comment:

Yes, that was a leak. It should be fixed now.

Merci Antoine!

Added file: http://bugs.python.org/file9899/bytesio+misc-fixes-4.patch

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2511] Give AST's excepthandler proper attributes

[Georg Brandl]

Georg Brandl <[EMAIL PROTECTED]> added the comment:

Committed in r62047.

--
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com