[issue2249] To document "assertTrue" in unittest

2008-03-08 Thread Georg Brandl

Georg Brandl added the comment:

I agree with Raymond. Having three names for a function is even more
un-Zen than two.

Also, I can't see wha'ts clearer in assertTrue in comparison with assert_.

--
resolution:  -> wont fix
status: open -> pending

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2257] typo in tutorial section 4.4 - final break statement is missing

2008-03-08 Thread Georg Brandl

Georg Brandl added the comment:

Sorry, but I don't see a mismatch between code and output.

--
resolution:  -> invalid
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2255] Change Mandrake by Mandriva for platform.dist()

2008-03-08 Thread Nicolas Lécureuil

Nicolas Lécureuil added the comment:

is there a fix applied on mandriva python :

--- (empty file)
+++ cooker/python/current/SOURCES/python-2.5.1-detect-mandriva.patch   
Sat Mar  8 03:22:50 2008
@@ -0,0 +1,10 @@
+--- Lib/platform.py.old2007-10-05 20:17:15.0 +0800
 Lib/platform.py2007-10-05 20:18:00.0 +0800
+@@ -225,7 +225,7 @@
+ 
+ def dist(distname='',version='',id='',
+ 
+- supported_dists=('SuSE', 'debian', 'fedora', 'redhat',
'mandrake')):
++ supported_dists=('SuSE', 'debian', 'fedora', 'mandriva',
'redhat', 'mandrake')):
+ 
+ """ Tries to determine the name of the Linux OS distribution name.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1095784] exclude CVS conflict files in sdist command

2008-03-08 Thread Georg Brandl

Georg Brandl added the comment:

Closing this as "won't fix" as per discussion in #1725737.
(Quote: "It's the job of the packager to clean the directory before
packaging.")

--
nosy: +georg.brandl
resolution:  -> wont fix
status: open -> closed

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2240] setitimer, getitimer wrapper

2008-03-08 Thread Georg Brandl

Georg Brandl added the comment:

Could you please put all changes in one complete patch? It's much easier
to review that way.

--
assignee:  -> loewis

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2249] To document "assertTrue" in unittest

2008-03-08 Thread Steve Purcell

Steve Purcell added the comment:

I could be convinced either way here, and Georg & Raymond always have 
excellent judgement.

My personal inclination would probably be to add the documentation for 
assertTrue() and also assertFalse(), since their naming is symmetrical 
with that of assertEqual() etc.  I think plenty of people are using 
those functions anyway, judging by emails I receive, and I'm not sure 
that leaving the function undocumented addresses the issue of the 
(admittedly) sprawling API.

(I think Fred Drake put together the documentation originally; I don't 
recall any particular discussion about which aliases to document and 
which to leave out.)

-Steve

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2255] Change Mandrake by Mandriva for platform.dist()

2008-03-08 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

I think it's better to add the new name rather than replace the existing
one.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1533486] long -> Py_ssize_t (C/API 1.2.1)

2008-03-08 Thread Georg Brandl

Georg Brandl added the comment:

Fixed in r61305.

--
resolution:  -> fixed
status: open -> closed

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2253] "continue" documentation internally inconsistent

2008-03-08 Thread Georg Brandl

Georg Brandl added the comment:

You're right, the footnote has to be removed. Fixed in r61303.

--
resolution:  -> fixed
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2255] Change Mandrake by Mandriva for platform.dist()

2008-03-08 Thread Marc-Andre Lemburg

Marc-Andre Lemburg added the comment:

Fixed in r61304.

Backport candidate.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2255] Change Mandrake by Mandriva for platform.dist()

2008-03-08 Thread Marc-Andre Lemburg

Changes by Marc-Andre Lemburg:


--
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1995] localeconv() does not encode returned strings

2008-03-08 Thread Martin v. Löwis

Martin v. Löwis added the comment:

I found now a way to fix this, by relying on wchar_t functions. It's
fixed in r61306

--
resolution:  -> fixed
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1618] locale.strxfrm can't handle non-ascii strings

2008-03-08 Thread Martin v. Löwis

Martin v. Löwis added the comment:

I found a way to fix this, using wchar_t functions. Fixed in r61307.

--
resolution:  -> fixed
status: open -> closed

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2240] setitimer, getitimer wrapper

2008-03-08 Thread Guilherme Polo

Guilherme Polo added the comment:

Complete patch attached

Added file: http://bugs.python.org/file9636/setitimer_getitimer.diff

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2240] setitimer, getitimer wrapper

2008-03-08 Thread Ralf Schmitt

Ralf Schmitt added the comment:

I'd like to also see this in 2.6. Should I update the patch (if it
doesn't apply) and test? (I guess the signal module hasn't changed that
much).

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2240] setitimer, getitimer wrapper

2008-03-08 Thread Guilherme Polo

Guilherme Polo added the comment:

If you are going to backport it to 2.6, then the C wrapper should be
adapted to match Python 2.x C coding style. If the other parts don't
apply correctly, then you should update it aswell.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1733184] slice type is unhashable

2008-03-08 Thread Jean-Paul Calderone

Jean-Paul Calderone added the comment:

I don't see the ability to use a slice as a dict key as particularly
more surprising than the ability to use ints as dict keys.  Someone who
doesn't understand how dicts work can use either of these features to
write broken programs.

I have thought about that example and it's precisely the kind of thing I
would like to work.  The behavior is consistent with that of using any
other immutable value as a key.  I don't have a use case right now (and
by admitting so may be dooming this change - but L. Peter Deutsch has
one, I think) but there's no way I would ever benefit from the current
behavior, whereas I _might_ be able to do something useful with the
proposed behavior.

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1733184] slice type is unhashable

2008-03-08 Thread Alexander Belopolsky

Alexander Belopolsky added the comment:

Note that L[:] and L[:] = [] are well-known idioms for making a copy of 
a list and emptying the list respectively. (For dictionaries we have 
D.copy() and D.clear().) Someone looking at x[:] or x[:] = [] should 
immediately recognize a list copy or clear operation.  Having to think 
of whether x may be a dictionary would make such code very confusing.

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1533486] long -> Py_ssize_t (C/API 1.2.1)

2008-03-08 Thread Alexander Belopolsky

Alexander Belopolsky added the comment:

Georg, did you miss the s/assuming/because/ part of my proposal?  Python 
guarantees that sizeof(Py_ssize_t) == sizeof(size_t) == sizeof(void*). (See PEP 
353.)

"Assuming" is therefore misleading because it suggests that it may not 
be always true.

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2241] Additional Flag For Unit-Test Module: There Can Be Only One (Error)

2008-03-08 Thread Brian White

Brian White added the comment:

I am somewhat new to mock objects.  I'm coding up my first one now (in
D) to simulate a "stream" for other objects I want to write.

Even within a single module, I typically have many tests for the methods
within that module.  And since a module's methods make use of each
other, there is again a case for the tests of the lower-level functions
to be executed first.

Anyway, this is something that works for me, but I understand that not
everybody operates this way.

All the best from this Canadian in Switzerland.  :-)

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1106316] slightly easier way to debug from the exception handler

2008-03-08 Thread Facundo Batista

Facundo Batista added the comment:

Added this functionality in r61312.

--
resolution:  -> accepted
status: open -> closed

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue705836] struct.pack of floats in non-native endian order

2008-03-08 Thread Mark Dickinson

Mark Dickinson added the comment:

Coming back to this, I think that it actually *is* clear what
struct(">f", large_float) should do:  it should raise OverflowError.
This fits in well with the general philosophy that Python (at least
tries to) follow for floating-point exceptions.

The attached patch (705836_v2.patch) fixes this.  All tests pass with 
this patch applied.

I'll leave this around for a few days in case anyone wants to comment on 
it;  then I plan to apply it to the trunk.

--
keywords: +patch
Added file: http://bugs.python.org/file9637/705836_v2.patch


Tracker <[EMAIL PROTECTED]>


___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1733184] slice type is unhashable

2008-03-08 Thread Raymond Hettinger

Changes by Raymond Hettinger:


--
resolution:  -> rejected
status: open -> closed

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2256] Install failure of 2.6a1 on Windows XP without VS8 installed

2008-03-08 Thread Jim Kleckner

Jim Kleckner added the comment:

I uninstalled and re-ran the install without the "compile all" selected.

The install didn't report errors.

running:
 python -c "import test.testall"
results in a traceback with the message:
  import _socket
   ImportError: DLL load failed: The system could not find the file
specified.

What sorts of things should I probe into?

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2218] Enhanced hotshot profiler with high-resolution timer

2008-03-08 Thread Jean Brouwers

Jean Brouwers added the comment:

There are 7 other, potentially serious issues in the original _hotshot.c 
file.  All those are being fixed for the next version of the enhanced 
hotshot files.

The 7 issues are:

1) functions flush_data and do_stop may create an infinite recursion on 
line 567.

2) The pack_string and pack_add_info functions do not check for string 
lengths exceeding BUFFERSIZE and may corrupt memory in that case.

3) In line 1182, linetimings should be frametimngs:
   {"frametimings", T_LONG, offsetof(ProfilerObject, linetimings), 
READONLY},

4) Coverage members frametimings, linetimings and lineevents are set on 
line 1562 ff. after different values may have been written into the log 
file header by function write_header on lines 1440 ff.

5) The coverage__doc__ on line 1546 is incomplete.

6) At several places, errors are detected but not reported and not sets.

7) An int value is passed where a long is specified or expected.  T_LONG 
should be T_INT on lines 1182-1184 and there are several calls to 
PyInt_FromLong with an int argument on line 487 ff. and other places.

__
Tracker <[EMAIL PROTECTED]>

__
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue812750] OSA support for properties broken

2008-03-08 Thread Mark Dickinson

Mark Dickinson added the comment:

The docs say that development for the MacPython OSA modules has stopped,
and that a replacement is expected for Python 2.5.

Can this issue now be closed, or at least have its priority downgraded?

--
nosy: +marketdickinson


Tracker <[EMAIL PROTECTED]>


___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1504333] sgmllib should allow angle brackets in quoted values

2008-03-08 Thread Paul Molodowitch

Paul Molodowitch added the comment:

Patch for sgmllib.py (and test_sgmllib.py)

Correctly parses quoted attribute - allowing for brackets, newlines, etc
within attributes - implemented by altering the loop which finds
attributes within parse_starttag so it checks for open-ended quotes, and
makes sure any closing brackets it finds are not within quotes

In test_sgmllib, added the test case from the original patch, as well as
re-enabling two other test cases, which both work now

--
keywords: +patch
nosy: +barnabas79
Added file: http://bugs.python.org/file9638/sgmllib_2008-03-08.patch

_
Tracker <[EMAIL PROTECTED]>

_
___
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com