FW: GSOC-2013 Proj- PMC rel. queries
Dear sir/mam,Please went through the below forwarded mail which is in continuation to what Sinny mam had presented her views on my earlier ideas. In my last email, I have mentioned 2 more improvements so I request you to please give your feedback to me. Also, I apologize for not sending my past e-mails to "plasma-devel@kde.org". Thanks and Regards,Saurabh Jain From: saurabh...@hotmail.com To: ksi...@gmail.com Subject: RE: GSOC-2013 Proj- PMC rel. queries Date: Sat, 20 Apr 2013 15:26:41 +0530 Thank you. All music, All pictures and All Videos are still not working on my system even after reinstalling the nepomuk packages. When restarting the nepomukindexer, I get the following error in the end- Error: "/var/tmp/kdecache-saurabh" is owned by uid 1001 instead of uid 0. I will try to resolve this issue with nepomuk community. Yes, shuffle mode is working well and mistakenly I pointed it out as missing. What I would like to point out is once you have created a playlist, you cannot rearrange the existing order of songs to the desired one. The only way, which I found, to do so is to create an another playlist from the beginning. One more improvement which I would like to mention in Pictures section is that in presence of proxy server, picasa is unable to connect to the google account or to load the pictures. Also, pressing the "tab" key after entering the email id in google account section does not move the cursor to next section, i.e., password textbox. Keyboard does not seem to produce any output in some other situations as well. Regards, Saurabh Jain Date: Fri, 19 Apr 2013 23:46:37 +0530 Subject: Re: GSOC-2013 Proj- PMC rel. queries From: ksi...@gmail.com To: saurabh...@hotmail.com CC: Plasma-devel@kde.org Doing CC to plasma-devel Thanks Saurabh for you effort. Nice start! On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote: Dear mam, Thanks for replying me back and presenting your views. Yes, you were right and I did deviate from the main point as I used the software and liked the idea of building such an application and therefore I thought more in enhancing and incorporating new features in it. I forgot to mention some of the improvements, which I think, can be done in this application. The "open with" menu option which I mentioned in my first mail also needs to be improved as the user can see this application in the above menu but due to lack of functionality provided on the back end, the user does not get the desired output response. +1 I like this idea, this need to be implemented. Improvements in following sections can be:- Music :- Search engine (in Songs, Album, etc.) does not seem to work at all. I tried searching for a music which is also there in the playlist but did not get any results (neither did it respond with search failure nor with song found). Improving the song search can have an alternative if sorting feature is introduced by virtue of which user can sort the albums, songs etc according to their names. Player can be enhanced with modes like repeat, shuffle, etc. and reordering of songs in the playlist is also not there. Ummm, For me search works fine for Artist, Album and songs works fine but yeah, it doesn't display message when search result is zero. Shuffle works in Playlist. Repeat option can be added. Sorting of media is needed on the basis of different field like size, date, name, length etc. Pictures:- Again, clicking on "All Picture" does not produce any results. Every time if the user has to view the pictures, he/she has to browse the pictures in the folders first and then load it. Further, just like we have the option to select some files and play them only, in a similar fashion, we can have option to select some pictures and then view them via slide show. I guess, your Nepomuk indexer is not running or maybe haven't indexed your picture directory. Check with that then All Picture will work fine. Yeah, we can think of viewing selected pictures in slideshow. Videos:- The full screen mode toggle button can be added into video section so that the user can directly watch the video in full screen mode. Also, many a times, it happens that the user downloads the subtitles of the movie which he/she wants to watch as the movie is not in his/her native language. For eg. if the movie's name is abc.avi, the subtitle's file is renamed to abc.en.srt in order to view the subtitle along with the movie in media player. The plasma media center is unable to show the subtitles when the movie is being played. Earlier Full screen Icon was in Media Player but it didn't fit well there so we moved it into configuration section in HomeScreen. Yeah, Video subtitle doesn't work for all possible subtitles file. Right now it works only for ffile with filename.srt file. It needs to be improved to work with all kinds
FW: Plasma-devel Digest, Vol 58, Issue 78
Hi Shantanu, Thanks for the feedback. I have mentioned a lot more ideas which were categorized by different sections like Music, etc. in my earlier mails to Sinny. I hope you went through them all. If not, please visit those mails and give me your feedback for that as well. For the convenience of reading those emails with ease, I have mentioned the word "IDEA" just before the idea is being explained. Thanks and Regards,Saurabh Jain > Message: 2 > Date: Wed, 24 Apr 2013 22:41:11 +0530 > From: Shantanu Tushar Jha > To: plasma-devel@kde.org > Subject: Re: FW: GSOC-2013 Proj- PMC rel. queries > Message-ID: > > Content-Type: text/plain; charset="iso-8859-1" > > Hi Saurabh, > > Nice to see your interest in Plasma Media Center, find my comments inline. > Also, you don't have to use sir/madam etc in your emails, just use people's > names to address them :) > > On Wed, Apr 24, 2013 at 3:53 PM, Saurabh Jain wrote: > > > Dear sir/mam, > > Please went through the below forwarded mail which is in continuation to > > what Sinny mam had presented her views on my earlier ideas. In my last > > email, I have mentioned 2 more improvements so I request you to please give > > your feedback to me. > > Also, I apologize for not sending my past e-mails to "plasma-devel@kde.org > > ". > > > > Thanks and Regards, > > Saurabh Jain > > > > -- > > From: saurabh...@hotmail.com > > To: ksi...@gmail.com > > Subject: RE: GSOC-2013 Proj- PMC rel. queries > > Date: Sat, 20 Apr 2013 15:26:41 +0530 > > > > Thank you. > > All music, All pictures and All Videos are still not working on my system > > even after reinstalling the nepomuk packages. When restarting the > > nepomukindexer, I get the following error in the end- Error: > > "/var/tmp/kdecache-saurabh" is owned by uid 1001 instead of uid 0. I will > > try to resolve this issue with nepomuk community. > > > > Yes, shuffle mode is working well and mistakenly I pointed it out as > > missing. What I would like to point out is once you have created a > > playlist, you cannot rearrange the existing order of songs to the desired > > one. The only way, which I found, to do so is to create an another playlist > > from the beginning. > > > > Yes, manual ordering will be a nice thing to implement. > > > > > One more improvement which I would like to mention in *Pictures* section > > is that in presence of *proxy server*, picasa is unable to connect to the > > google account or to load the pictures. > > > > PMC should pick up the proxy settings from your proxy settings in Network > Settings in KDE system settings. You should check that. > > > > Also, pressing the "tab" key after entering the email id in google account > > section does not move the cursor to next section, i.e., password textbox. > > Keyboard does not seem to produce any output in some other situations as > > well. > > > > Yep that sounds like a good idea :) > > > > > > > Regards, > > Saurabh Jain > > > > -- > > Date: Fri, 19 Apr 2013 23:46:37 +0530 > > > > Subject: Re: GSOC-2013 Proj- PMC rel. queries > > From: ksi...@gmail.com > > To: saurabh...@hotmail.com > > CC: Plasma-devel@kde.org > > > > > > > > Doing CC to plasma-devel > > > > > > Thanks Saurabh for you effort. Nice start! > > > > On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote: > > > > Dear mam, > > > > Thanks for replying me back and presenting your views. Yes, you were right > > and I did deviate from the main point as I used the software and liked the > > idea of building such an application and therefore I thought more in > > enhancing and incorporating new features in it. > > I forgot to mention some of the improvements, which I think, can be done IDEA - > > in this application. The "open with" menu option which I mentioned in my > > first mail also needs to be improved as the user can see this application > > in the above menu but due to lack of functionality provided on the back > > end, the user does not get the desired output response. > > > > > > +1 > > I like this idea, this need to be implemented. > > > > > > Improvements in following sections can be:- IDEA - > > *Music* *:- > > *Search engine (in Songs, Album, etc.) does not seem to work at all. I > > tried searching for a music which is also there in the playlist but did no
Re: GSOC- 2013 Proj.- PMC ideas
Hi Shantanu, Thanks for the feedback. I have mentioned a lot more ideas which were categorized by different sections like Music, etc. in my earlier mails to Sinny. I hope you went through them all. If not, please visit those mails and give me your feedback for that as well. For the convenience of reading those emails with ease, I have mentioned the word "IDEA" just before the idea is being explained. Thanks and Regards,Saurabh Jain > Message: 2 > Date: Wed, 24 Apr 2013 22:41:11 +0530 > From: Shantanu Tushar Jha > To: plasma-devel@kde.org > Subject: Re: FW: GSOC-2013 Proj- PMC rel. queries > Message-ID: > > Content-Type: text/plain; charset="iso-8859-1" > > Hi Saurabh, > > Nice to see your interest in Plasma Media Center, find my comments inline. > Also, you don't have to use sir/madam etc in your emails, just use people's > names to address them :) > > On Wed, Apr 24, 2013 at 3:53 PM, Saurabh Jain wrote: > > > Dear sir/mam, > > Please went through the below forwarded mail which is in continuation to > > what Sinny mam had presented her views on my earlier ideas. In my last > > email, I have mentioned 2 more improvements so I request you to please give > > your feedback to me. > > Also, I apologize for not sending my past e-mails to "plasma-devel@kde.org > > ". > > > > Thanks and Regards, > > Saurabh Jain > > > > -- > > From: saurabh...@hotmail.com > > To: ksi...@gmail.com > > Subject: RE: GSOC-2013 Proj- PMC rel. queries > > Date: Sat, 20 Apr 2013 15:26:41 +0530 > > > > Thank you. > > All music, All pictures and All Videos are still not working on my system > > even after reinstalling the nepomuk packages. When restarting the > > nepomukindexer, I get the following error in the end- Error: > > "/var/tmp/kdecache-saurabh" is owned by uid 1001 instead of uid 0. I will > > try to resolve this issue with nepomuk community. > > > > Yes, shuffle mode is working well and mistakenly I pointed it out as > > missing. What I would like to point out is once you have created a > > playlist, you cannot rearrange the existing order of songs to the desired > > one. The only way, which I found, to do so is to create an another playlist > > from the beginning. > > > > Yes, manual ordering will be a nice thing to implement. > > > > > One more improvement which I would like to mention in *Pictures* section > > is that in presence of *proxy server*, picasa is unable to connect to the > > google account or to load the pictures. > > > > PMC should pick up the proxy settings from your proxy settings in Network > Settings in KDE system settings. You should check that. > > > > Also, pressing the "tab" key after entering the email id in google account > > section does not move the cursor to next section, i.e., password textbox. > > Keyboard does not seem to produce any output in some other situations as > > well. > > > > Yep that sounds like a good idea :) > > > > > > > Regards, > > Saurabh Jain > > > > -- > > Date: Fri, 19 Apr 2013 23:46:37 +0530 > > > > Subject: Re: GSOC-2013 Proj- PMC rel. queries > > From: ksi...@gmail.com > > To: saurabh...@hotmail.com > > CC: Plasma-devel@kde.org > > > > > > > > Doing CC to plasma-devel > > > > > > Thanks Saurabh for you effort. Nice start! > > > > On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote: > > > > Dear mam, > > > > Thanks for replying me back and presenting your views. Yes, you were right > > and I did deviate from the main point as I used the software and liked the > > idea of building such an application and therefore I thought more in > > enhancing and incorporating new features in it. > > I forgot to mention some of the improvements, which I think, can be done IDEA - > > in this application. The "open with" menu option which I mentioned in my > > first mail also needs to be improved as the user can see this application > > in the above menu but due to lack of functionality provided on the back > > end, the user does not get the desired output response. > > > > > > +1 > > I like this idea, this need to be implemented. > > > > > > Improvements in following sections can be:- IDEA - > > *Music* *:- > > *Search engine (in Songs, Album, etc.) does not seem to work at all. I > > tried searching for a music which is also there in the playlist but did no
FW: GSOC-2013 Proj- PMC rel. queries
Dear sir/mam,Please went through the below forwarded mail which is in continuation to what Sinny mam had presented her views on my earlier ideas. In my last email, I have mentioned 2 more improvements so I request you to please give your feedback to me. Also, I apologize for not sending my past e-mails to "plasma-devel.org". Thanks and Regards,Saurabh Jain From: saurabh...@hotmail.com To: ksi...@gmail.com Subject: RE: GSOC-2013 Proj- PMC rel. queries Date: Sat, 20 Apr 2013 15:26:41 +0530 Thank you. All music, All pictures and All Videos are still not working on my system even after reinstalling the nepomuk packages. When restarting the nepomukindexer, I get the following error in the end- Error: "/var/tmp/kdecache-saurabh" is owned by uid 1001 instead of uid 0. I will try to resolve this issue with nepomuk community. Yes, shuffle mode is working well and mistakenly I pointed it out as missing. What I would like to point out is once you have created a playlist, you cannot rearrange the existing order of songs to the desired one. The only way, which I found, to do so is to create an another playlist from the beginning. One more improvement which I would like to mention in Pictures section is that in presence of proxy server, picasa is unable to connect to the google account or to load the pictures. Also, pressing the "tab" key after entering the email id in google account section does not move the cursor to next section, i.e., password textbox. Keyboard does not seem to produce any output in some other situations as well. Regards, Saurabh Jain Date: Fri, 19 Apr 2013 23:46:37 +0530 Subject: Re: GSOC-2013 Proj- PMC rel. queries From: ksi...@gmail.com To: saurabh...@hotmail.com CC: Plasma-devel@kde.org Doing CC to plasma-devel Thanks Saurabh for you effort. Nice start! On Fri, Apr 19, 2013 at 1:00 PM, Saurabh Jain wrote: Dear mam, Thanks for replying me back and presenting your views. Yes, you were right and I did deviate from the main point as I used the software and liked the idea of building such an application and therefore I thought more in enhancing and incorporating new features in it. I forgot to mention some of the improvements, which I think, can be done in this application. The "open with" menu option which I mentioned in my first mail also needs to be improved as the user can see this application in the above menu but due to lack of functionality provided on the back end, the user does not get the desired output response. +1 I like this idea, this need to be implemented. Improvements in following sections can be:- Music :- Search engine (in Songs, Album, etc.) does not seem to work at all. I tried searching for a music which is also there in the playlist but did not get any results (neither did it respond with search failure nor with song found). Improving the song search can have an alternative if sorting feature is introduced by virtue of which user can sort the albums, songs etc according to their names. Player can be enhanced with modes like repeat, shuffle, etc. and reordering of songs in the playlist is also not there. Ummm, For me search works fine for Artist, Album and songs works fine but yeah, it doesn't display message when search result is zero. Shuffle works in Playlist. Repeat option can be added. Sorting of media is needed on the basis of different field like size, date, name, length etc. Pictures:- Again, clicking on "All Picture" does not produce any results. Every time if the user has to view the pictures, he/she has to browse the pictures in the folders first and then load it. Further, just like we have the option to select some files and play them only, in a similar fashion, we can have option to select some pictures and then view them via slide show. I guess, your Nepomuk indexer is not running or maybe haven't indexed your picture directory. Check with that then All Picture will work fine. Yeah, we can think of viewing selected pictures in slideshow. Videos:- The full screen mode toggle button can be added into video section so that the user can directly watch the video in full screen mode. Also, many a times, it happens that the user downloads the subtitles of the movie which he/she wants to watch as the movie is not in his/her native language. For eg. if the movie's name is abc.avi, the subtitle's file is renamed to abc.en.srt in order to view the subtitle along with the movie in media player. The plasma media center is unable to show the subtitles when the movie is being played. Earlier Full screen Icon was in Media Player but it didn't fit well there so we moved it into configuration section in HomeScreen. Yeah, Video subtitle doesn't work for all possible subtitles file. Right now it works only for ffile with filename.srt file. It needs to be improved to work with all kinds of su
Improvements and Enhancements for Plasma Media Center Proposal Report reviews
Hi, I have submitted the proposal to work upon the project - "Improvements and Enhancements on Plasma Media Center" on melange. I kindly request all the mentors to review it and please let me know your suggestions for the same and if there are some changes/additions that need to be done in it. Looking for a positive response from your side. Thanks and Regards,Saurabh Jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110604: Drag and Drop feature to remove items from playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110604/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Drag and Drop feature to remove items from playlist in PMC directly without interrupting the current session of media being played. Diffs - libs/mediacenter/playlistmodel.h bedc26a mediaelements/playlist/Playlist.qml bbe97a7 mediaelements/playlist/PlaylistDelegate.qml 7dac484 Diff: http://git.reviewboard.kde.org/r/110604/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110604: Drag and Drop feature to remove items from playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110604/ --- (Updated May 23, 2013, 9:41 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Drag and Drop feature to remove items from playlist in PMC directly without interrupting the current session of media being played. Diffs (updated) - libs/mediacenter/playlistmodel.h bedc26a mediaelements/playlist/PlaylistDelegate.qml 7dac484 Diff: http://git.reviewboard.kde.org/r/110604/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110604: Drag and Drop feature to remove items from playlist added.
> On May 23, 2013, 8:59 a.m., Shantanu Tushar wrote: > > mediaelements/playlist/PlaylistDelegate.qml, line 104 > > <http://git.reviewboard.kde.org/r/110604/diff/1/?file=145972#file145972line104> > > > > can you derive the value 200 from the playlist width? You can get it > > using listViewItem.ListView.view.width * 0.4 > > Experiment with values other than 0.4 to see what feels natural. > > Also, remove the extra whitespace Initially I was using the comparitive value to be parent.width/3. I found this to be the best among other values as it allows the less tolerance for repositioning of item when the user might actually be trying to remove that item. If you say, should I finalize this value? - saurabh --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110604/#review33013 ------- On May 23, 2013, 9:41 a.m., saurabh jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110604/ > --- > > (Updated May 23, 2013, 9:41 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Description > --- > > Drag and Drop feature to remove items from playlist in PMC directly without > interrupting the current session of media being played. > > > Diffs > - > > libs/mediacenter/playlistmodel.h bedc26a > mediaelements/playlist/PlaylistDelegate.qml 7dac484 > > Diff: http://git.reviewboard.kde.org/r/110604/diff/ > > > Testing > --- > > > Thanks, > > saurabh jain > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110604: Drag and Drop feature to remove items from playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110604/ --- (Updated May 23, 2013, 9:59 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- The comparitive value, exceeding which the item will be removed from playlist, has been changed to parent.width/3. Description --- Drag and Drop feature to remove items from playlist in PMC directly without interrupting the current session of media being played. Diffs (updated) - libs/mediacenter/playlistmodel.h bedc26a mediaelements/playlist/PlaylistDelegate.qml 7dac484 Diff: http://git.reviewboard.kde.org/r/110604/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 23, 2013, 7:21 p.m.) Status -- This change has been discarded. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 23, 2013, 7:22 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 23, 2013, 7:22 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 23, 2013, 7:36 p.m.) Status -- This change has been discarded. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
> On May 24, 2013, 5:58 a.m., Shantanu Tushar wrote:
> > libs/mediacenter/playlistmodel.cpp, lines 134-136
> > <http://git.reviewboard.kde.org/r/110621/diff/2/?file=146071#file146071line134>
> >
> > resetting the whole model is an expensive operation. Its better to use
> > beginMoveRows for the source index.
> > http://qt-project.org/doc/qt-4.8/qabstractitemmodel.html#beginMoveRows
Using beginMoveRows(), we are able to play the media item though we can't swap
or drop the source row with or to the destination place. On contrary, the code
given in the patch is able to swap but could not play any media item.
I hope you were referring to the implementation mentioned below:
void PlaylistModel::swapItems(int firstIndex, int secondIndex)
{
//beginResetModel();
if(!beginMoveRows(QModelIndex(),firstIndex,firstIndex,QModelIndex(),secondIndex))
return;
endMoveRows();
//d->musicList.swap(secondIndex+1,firstIndex);
//endResetModel();
}
- saurabh
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110621/#review33070
-------
On May 23, 2013, 7:36 p.m., saurabh jain wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110621/
> ---
>
> (Updated May 23, 2013, 7:36 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Description
> ---
>
> Reordering of the songs in the playlist is now possible using this patch.
> Just drag and drop the item to the desired place (where you want to replace
> it with the item at desired location).
>
>
> Diffs
> -
>
> libs/mediacenter/playlistmodel.h 2c1dc6b
> libs/mediacenter/playlistmodel.cpp 40b490c
> mediaelements/playlist/PlaylistDelegate.qml b1e6f40
>
> Diff: http://git.reviewboard.kde.org/r/110621/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> saurabh jain
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 5:44 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h bedc26a libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml 7dac484 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 5:46 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - mediaelements/playlist/PlaylistDelegate.qml 7dac484 libs/mediacenter/playlistmodel.cpp 40b490c libs/mediacenter/playlistmodel.h bedc26a Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 5:48 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h bedc26a libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml 7dac484 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 7:09 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h bedc26a libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml 7dac484 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 7:20 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 7:30 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 7:34 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- movedx and movedy are also converted to camelcase format. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs (updated) - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 7:34 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- movedx and movedy are also converted to camelcase format. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110621/ --- (Updated May 24, 2013, 7:34 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Description --- Reordering of the songs in the playlist is now possible using this patch. Just drag and drop the item to the desired place (where you want to replace it with the item at desired location). Diffs - libs/mediacenter/playlistmodel.h 2c1dc6b libs/mediacenter/playlistmodel.cpp 40b490c mediaelements/playlist/PlaylistDelegate.qml b1e6f40 Diff: http://git.reviewboard.kde.org/r/110621/diff/ Testing --- Thanks, saurabh jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Reason for rejection of proposal to work upon plasma-mediacenter in GSOC'13
Hi, I, Saurabh Jain, had submitted the proposal to work upon the project - Improvements and Enhancements for plasma-mediacenter in google summer of code'13 program but it was rejected. I could not figure out the reason why it was rejected since I had really put in a lot of hard work in order to work on this project and in the process, I did successfully submit quite a few patches which were referred to me as the difficult ones to start with as a beginner. There were also quite a lot of other ideas/solutions which I did not mention in my proposal but discussed thoroughly with mentors - Shantanu and Sinny. Also, I mentioned a link in my proposal which directs you to the image in which I have created the mock up for this project. I hope everyone went through it. I am very disappointed at my rejection and I kindly request all the mentors to state the reason for the same so that I can come to know where was my proposal lagging behind? Did I miss something to write in it? I would be highly obliged if you can share your views about my proposal so that I can learn something new out of it and bring improvements to my proposals for any future projects. -- Regards, Saurabh Jain ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
