[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Pavel]

https://bugs.kde.org/show_bug.cgi?id=366299

Pavel  changed:

   What|Removed |Added

 CC||zol...@gmail.com

--- Comment #4 from Pavel  ---
I don't remember whether power management settings was fit to window height (in
case if we are talking about low screen resolution, for me it is 1366x768), but
as far as I remember, there was a scrollbar on the right side of the window, so
I was able to scroll the frame with settings controls by using this scrollbar
or using touch pad with multi-touch option. But I don't see this scrollbar at
the moment and area with controls is not scrollable at all. 
OpenSUSE Tumbleweed x64, Plasma 5.8.4

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 366299] System setting "Energy Saving" window is too large for a standard laptop screen

[Pavel]

https://bugs.kde.org/show_bug.cgi?id=366299

--- Comment #6 from Pavel  ---
(In reply to Wolfgang Bauer from comment #5)
> (In reply to Pavel from comment #4)
> > but as far as I remember, there was a scrollbar on the right side
> > of the window, so I was able to scroll the frame with settings controls by
> > using this scrollbar or using touch pad with multi-touch option. But I don't
> > see this scrollbar at the moment and area with controls is not scrollable at
> > all. 
> 
> I don't remember if this is true (as I personally never use this these
> settings, or run kcmshell5 manually), but it doesn't matter anyway.
> 
> For now, just open the settings in systemsettings5 ("Configure Desktop" in
> openSUSE), and they will have the scrollbar if the display is too small.
Main settings window has scrollbar, but Power Manager settings window - hasn't 

> Or use the previously mentioned workaround: Press and hold the 'Alt' key and
> click on the window (and hold the mouse button), this way you can move it
> wherever you want and be able to reach the buttons or other options.
Yes, I know about it and I'm using it. This feature one of the best in Linux
DEs :) Sometimes I need it in Windows, but unfortunately, it hasn't such
feature.

Thank you for the reply.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D14355: Fix: systemsettings with breeze-dark theme

[Pavel]

ppavel created this revision.
ppavel added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ppavel requested review of this revision.

REVISION SUMMARY
  Black category title text is displayed on black background in sidebar when 
theme is breeze-dark. See picture. F6137095: breezedark-fail.png 


TEST PLAN
  Select Breeze-dark theme.
  Open systemsettings.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D14355

AFFECTED FILES
  sidebar/package/contents/ui/CategoriesPage.qml

To: ppavel, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14355: Fix: systemsettings with breeze-dark theme

[Pavel]

ppavel added a comment.


  With `qqc2-desktop-style` installed all works fine. My fail.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D14355

To: ppavel, davidedmundson
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Upgrading Widgets from plasma-workspace

[Pavel]

Good day. Need your help.
 I am Upgrading Widgets from plasma-workspace and faced a number of 
problems.
 I will show the modernization goals using the example of the 
diskactivity widget, designed to visualize hard drive activity:


 1) At the moment when the widget is first loaded after installation, 
all the checkboxes are selected in the settings (checked = true).
  - It is necessary to make the widget display only real disk devices 
(not virtual, not loop or ram) by default.


 2) When the user tries to disable all checkboxes in the widget 
settings, this does not work. After the last checkbox is turned off, all 
checkboxes are turned on again (the default mode). I can’t disable all 
checkboxes at the same time.
  - I need to make sure that after disabling all settings the widget is 
empty.


  I decided to do this using the widget's initialization flag 
(widget_initialized). By default, widget_initialized = false.
When you first start the widget, when it has loaded all its settings, 
the value of the flag widget_initialized = true is set to 
Component.onCompleted.
And if the widget_initialized flag is set to true, then all subsequent 
changes are considered to be made by the user.
The widget_initialized flag allows to distinguish the first launch of 
the widget from the case when the user cleared all settings.


 Is there any other way to do this? Suppose using the API? Is there any 
specialized API that allows you to achieve a similar result? Preferably 
available from QML. Or maybe this API can be added somewhere?


 Thank you!


--
With best regards, Pavel Moseev

m...@basealt.ru
m...@altlinux.org

Re: Upgrading Widgets from plasma-workspace

[Pavel]

Any ideas would be greatly appreciated!


04.03.2019 15:55, Pavel:

Good day. Need your help.
 I am Upgrading Widgets from plasma-workspace and faced a number of 
problems.
 I will show the modernization goals using the example of the 
diskactivity widget, designed to visualize hard drive activity:


 1) At the moment when the widget is first loaded after installation, 
all the checkboxes are selected in the settings (checked = true).
  - It is necessary to make the widget display only real disk devices 
(not virtual, not loop or ram) by default.


 2) When the user tries to disable all checkboxes in the widget 
settings, this does not work. After the last checkbox is turned off, 
all checkboxes are turned on again (the default mode). I can’t disable 
all checkboxes at the same time.
  - I need to make sure that after disabling all settings the widget 
is empty.


  I decided to do this using the widget's initialization flag 
(widget_initialized). By default, widget_initialized = false.
When you first start the widget, when it has loaded all its settings, 
the value of the flag widget_initialized = true is set to 
Component.onCompleted.
And if the widget_initialized flag is set to true, then all subsequent 
changes are considered to be made by the user.
The widget_initialized flag allows to distinguish the first launch of 
the widget from the case when the user cleared all settings.


 Is there any other way to do this? Suppose using the API? Is there 
any specialized API that allows you to achieve a similar result? 
Preferably available from QML. Or maybe this API can be added somewhere?


 Thank you!



--
With best regards, Pavel Moseev

m...@basealt.ru
m...@altlinux.org

Re: Upgrading Widgets from plasma-workspace

[Pavel]

Hello,

Thanks for your response!

I tried to fix this once but unfortunately the systemactivity 
dataengine uses ksysguard which then probes kernel interfaces directly 
through some C code. It doesn't use Solid, where filtering out those 
interfaces would be easy. I'm not knowledgable enough in that codebase 
to comment on how that could be achieved there.


I'm working on a temporary solution to the problem - I implement 
filtering by device name (sd*, sr*, vd*,..). This should work until 
another solution is found.


I guess the sources is stored as a StringList and the widget assumes 
that when the list is empty, it uses the default set of all sources. 
Perhaps you can store a pseudo "EMPTY!" entry in the list to denote 
nothing is checked. However, I don't see why you would want to place a 
widget that then does not show anything?


Sometimes the user may try to disable the last checkbox and all 
checkboxes will turn on immediately in the settings.

It may be inconvenient for users to uncheck a large number of checkboxes.

There are two possible solutions:
1) Not allow to uncheck the last checkbox. There will always be at least 
one graph.
2) Allow to uncheck the last checkbox. In this case, the widget will be 
empty.


Now I have implemented the first option - I have forbidden to disable 
the last enabled checkbox.


--
Best regards, Pavel Moseev

m...@basealt.ru
m...@altlinux.org

D17094: Fixed comic widget context menu crash

[Pavel Mos]

pavelmos created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Crash happens on trying to use the context menu of widget with no active 
comics.
  The patch disables some items in this context menu to prevent crashes.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17094

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: pavelmos
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Crash happens on trying to load an unsupported format content such as video.
  To prevent a crash, the patch blocks the loading of unsupported content (such 
as video) instead of a picture when switching comic strip.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D17095

AFFECTED FILES
  applets/comic/comic.cpp

To: pavelmos
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos updated this revision to Diff 45996.
pavelmos marked an inline comment as done.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17095?vs=45995&id=45996

REVISION DETAIL
  https://phabricator.kde.org/D17095

AFFECTED FILES
  applets/comic/comic.cpp

To: pavelmos, jriddell, bshah, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in comic.cpp:196
> Just move this after brace.

Yes, I agree. Your remark is true

REVISION DETAIL
  https://phabricator.kde.org/D17095

To: pavelmos, jriddell, bshah, davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

[Pavel Mos]

pavelmos updated this revision to Diff 46064.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17094?vs=45994&id=46064

REVISION DETAIL
  https://phabricator.kde.org/D17094

AFFECTED FILES
  applets/comic/comic.cpp
  applets/comic/comic.h

To: pavelmos, jriddell, bshah, davidedmundson
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17094: Fixed comic widget context menu crash

[Pavel Mos]

pavelmos added a comment.


  I have no commit access.

REVISION DETAIL
  https://phabricator.kde.org/D17094

To: pavelmos, jriddell, bshah, davidedmundson, mart
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17095: Fixed comic widget crash

[Pavel Mos]

pavelmos added a comment.


  I have no commit access.

REVISION DETAIL
  https://phabricator.kde.org/D17095

To: pavelmos, jriddell, bshah, davidedmundson, #plasma, mart
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17796: Plasma Workspace. Fixed general settings of the widgets.

[Pavel Mos]

pavelmos created this revision.
pavelmos added projects: Plasma: Workspaces, Plasma (Plasma 5.14).
Herald edited projects, added Plasma; removed Plasma (Plasma 5.14), Plasma: 
Workspaces.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Fixed general settings of the widgets "Memory Status", "Hard Disk Space 
Usage", "Network Monitor", "Hard Disk Monitor".
  
  - correctly set checked/unchecked state on load.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17796

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: pavelmos
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17796: Plasma Workspace. Fixed general settings of the widgets.

[Pavel Mos]

pavelmos updated this revision to Diff 48278.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17796?vs=48186&id=48278

REVISION DETAIL
  https://phabricator.kde.org/D17796

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: pavelmos, jriddell, #plasma, ngraham
Cc: ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17796: Show accurate checked state for system monitor configuration pages

[Pavel Mos]

pavelmos added a comment.


  In D17796#382974 , @ngraham wrote:
  
  > There we go, it works now! Code change looks sane to me.
  >
  > Please change the title to something more descriptive, such as "Show 
accurate checked state for system monitor configuration pages". And then we'll 
wait for a review from a #plasma  
developer.
  
  
  Okay. Thank you!

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17796: Show accurate checked state for system monitor configuration pages

[Pavel Mos]

pavelmos added a comment.


  I have no commit access.

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Pavel Mos]

pavelmos created this revision.
pavelmos added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Added a ban on disabling the last checkbox in the widget settings.
  There will always be at least one graph.
  
  If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  It may be inconvenient for users to uncheck a large number of checkboxes.
  
  This fix is aimed at improving the usability of Plasma-Workspace widgets.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: pavelmos, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

[Pavel Mos]

pavelmos created this revision.
pavelmos added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
pavelmos requested review of this revision.

REVISION SUMMARY
  Made filtering the diskactivity widget settings upon first launch.
  Now, when the widget is first loaded, only checkboxes related to real devices 
in the system are enabled.
  When the widget is first loaded, only checkboxes related to real devices in 
the system are included.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20223

AFFECTED FILES
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: pavelmos, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20223: Plasma-Workspace. Filtering the diskactivity widget settings upon first launch.

[Pavel Mos]

pavelmos added a comment.


  In D20223#442762 , @davidedmundson 
wrote:
  
  > Can you explain not what the change is doing, but why we're making it?
  >
  > What happens if I'm trying to monitor a removable USB disk?
  
  
  Thanks for your responce!
  
  At the moment when the widget is first loaded after installation, all the 
checkboxes are selected in the settings (checked = true).
  Before using the diskactivity widget, the User must turn off all unnecessary 
settings. But such unnecessary settings may be too much. This will be 
inconvenient for the user.
  It is necessary to make the widget display only real disk devices (not 
virtual, not loop or ram) by default.
  
  The change only applies to HDD and SSD.
  
  I hope I answered your question?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20223

To: pavelmos, broulik, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17796: Show accurate checked state for system monitor configuration pages

[Pavel Mos]

pavelmos added a comment.


  It seems to me that everything is fine.
  Are there any other comments or questions?

REVISION DETAIL
  https://phabricator.kde.org/D17796

To: pavelmos, jriddell, #plasma, ngraham
Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D20223: Make disk monitor widget only show real devices by default

[Pavel Mos]

pavelmos added a comment.


  In D20223#442883 , @ngraham wrote:
  
  > I've edited the title and summary to be a bit more clear. Does that help 
and is it accurate?
  
  
  Yes that's right. Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20223

To: pavelmos, broulik, #plasma
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Pavel Mos]

pavelmos added a comment.


  Please skip this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20223: Make disk monitor widget only show real devices by default

[Pavel Mos]

pavelmos added a comment.


  Please skip this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20223

To: pavelmos, broulik, #plasma, davidre, ngraham, mart
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20222: Plasma-Workspace. The last checkbox in the widget settings

[Pavel Mos]

pavelmos added a comment.


  In D20222#466116 , @davidedmundson 
wrote:
  
  > Generally I don't like things being blocked for no discernable reason. It 
makes toggling between two things order dependent.
  >
  > > If the user disables the last checkbox, all other checkboxes will 
automatically get enabled in the settings.
  >
  > Yeah, that's weird behaviour.
  >
  > Lets do this.
  
  
  Thanks!
  I have no commit access.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20222

To: pavelmos, broulik, #plasma, davidre, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart