Review Request: Use the same code to draw animated hovers as normal icons

2010-05-07 Thread David Benjamin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3921/
---

Review request for Plasma.


Summary
---

QIcon::paint does some alignment work which we also do in iconRect, but because 
we also do size snapping and such, the resulting pixmap does not have the same 
size. This cause annoying bouncing icons because QIcon's default is to center 
the icon.


This addresses bug 233646.
https://bugs.kde.org/show_bug.cgi?id=233646


Diffs
-

  
/trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks/abstracttaskitem.cpp 
HEAD 

Diff: http://reviewboard.kde.org/r/3921/diff


Testing
---

Been running with this on my main KDE for a while. Tested with Pidgin's icon.


Screenshots
---

Screenshot of problem from bug report
  http://reviewboard.kde.org/r/3921/s/386/


Thanks,

David

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Don't show dictionary tooltip when not collapsed

2010-05-07 Thread David Benjamin

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3923/
---

Review request for Plasma.


Summary
---

Like the weather applet, the dictionary applet should not show a tooltip when 
placed on the desktop. It's distracting, particularly with the animation, and 
we already know it's a dictionary. :-)


This addresses bug 232763.
https://bugs.kde.org/show_bug.cgi?id=232763


Diffs
-

  /trunk/KDE/kdeplasma-addons/applets/dict/dict.cpp HEAD 

Diff: http://reviewboard.kde.org/r/3923/diff


Testing
---

Tested with dictionary applet in both panel and desktop. Been running for past 
couple of months.


Thanks,

David

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel