D27669: [kstyle] Tools area

[Abstract Software]

abstractdevelop added a comment.


  For me it only merges the menus with the window decoration, not the toolbar :/
  F8200218: QtAssistantToolbars.png 

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Abstract Software]

abstractdevelop added a comment.


  Also should we implement this for GTK apps?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre
Cc: abstractdevelop, IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, 
ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop created this revision.
abstractdevelop added reviewers: ngraham, niccolove.
abstractdevelop added projects: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
abstractdevelop requested review of this revision.

REVISION SUMMARY
  This is a new tab style for breeze.
  This is my first patch to KDE, so tell me if I did anything wrong. ;)

TEST PLAN
  F8269180: NewTabStyle.png 
  
  This is a new style with a top line which should look good with both mutable 
and nonmutable tabs.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: abstractdevelop, ngraham, niccolove
Cc: plasma-devel, dmenig, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, 
ndavis, ZrenBot, firef, ngraham, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart

D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop updated this revision to Diff 81459.
abstractdevelop added a comment.


  Address comments.
  (Those were just some things I was playing around with, but everybody was 
right and they weren't necessary)

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29264?vs=81454&id=81459

REVISION DETAIL
  https://phabricator.kde.org/D29264

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: abstractdevelop, #vdg, #breeze
Cc: ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop updated this revision to Diff 81460.
abstractdevelop added a comment.


  Oof silly me.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29264?vs=81459&id=81460

REVISION DETAIL
  https://phabricator.kde.org/D29264

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: abstractdevelop, #vdg, #breeze
Cc: ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, LeGast00n, 
The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, zachus, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop marked 5 inline comments as done.
abstractdevelop added a comment.


  If we want to do that, then the line will have to go on the bottom.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: filipf, ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop updated this revision to Diff 81461.
abstractdevelop marked 2 inline comments as done.
abstractdevelop added a comment.


  Fixed all messages. Sorry for all the emails. :/

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29264?vs=81460&id=81461

REVISION DETAIL
  https://phabricator.kde.org/D29264

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp

To: abstractdevelop, #vdg, #breeze
Cc: filipf, ngraham, cblack, plasma-devel, dmenig, manueljlin, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart

D29264: New tabs for Breeze

[Abstract Software]

abstractdevelop added a comment.


  Sorry everybody for not seeing all the new comments sooner! :D
  
  Ok, it seems like the some corners being rounded is a common complaint, so we 
should address it. I agree that it looks a little out of place in System 
Settings. The only trouble is doing this in a way which respects the line at 
the top.
  
  As for the inactive tab background, the problem is that I can't seem to find 
a QPalette color which is not too light/dark. The current one 
(QPalette::Disabled, QPalette::Window) is the best I could find, but we can go 
back to using the rather extreme dark one as is used in the current tabs, which 
IMO doesn't look good with this style. We could also make the current tab 
background *lighter* instead, as in manueljlins mockups where it is almost 
white. But that appears to be an issue left to colorshemes and not to the code. 
;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart